activejob-temporal 0.1.0 → 0.2.0

data/lib/activejob/temporal/workflows/workflow_dependencies.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "time"
+require "timeout"
 require "temporalio/error"
 
 require_relative "../activities/dependency_status_activity"
@@ -11,8 +13,11 @@ module ActiveJob
         DEPENDENCY_CHECK_ACTIVITY_TIMEOUT = 30.0
         DEPENDENCY_CHECK_RETRY_POLICY = Temporalio::RetryPolicy.new(max_attempts: 1)
         DEPENDENCY_WAIT_INTERVAL = 10.0
+        DEPENDENCY_WAIT_TIMEOUT = 86_400.0
+        DEPENDENCY_WAIT_MAX_INTERVAL = 60.0
+        DEPENDENCY_WAIT_BACKOFF = 2.0
         DEPENDENCY_NOT_FOUND_MAX_CHECKS = 6
-        COMPLETED_DEPENDENCY_STATES = %w[completed].freeze
+        COMPLETED_DEPENDENCY_STATES = %w[completed continued_as_new].freeze
         FAILED_DEPENDENCY_STATES = %w[failed canceled terminated timed_out unknown].freeze
         NOT_FOUND_DEPENDENCY_STATES = %w[not_found].freeze
 
@@ -23,16 +28,19 @@ module ActiveJob
           return if dependencies.empty?
 
           workflow_state["phase"] = "waiting_dependencies"
-          not_found_counts = Hash.new(0)
-          loop do
-            wait_while_paused
-            statuses = check_dependency_statuses(dependencies)
-            expired_not_found_statuses = expired_not_found_statuses(statuses, not_found_counts)
-            failed_statuses = failed_dependency_statuses(statuses) + expired_not_found_statuses
-            fail_for_dependencies!(failed_statuses) if fail_on_dependency_failure?(payload) && failed_statuses.any?
-            break if dependencies_satisfied?(statuses, expired_not_found_statuses)
-
-            Temporalio::Workflow.sleep(DEPENDENCY_WAIT_INTERVAL)
+          wait_options = dependency_wait_options(payload)
+          deadline = dependency_wait_deadline(wait_options)
+          begin
+            with_dependency_wait_timeout(wait_options, deadline) do
+              wait_for_dependency_statuses(payload, dependencies, wait_options)
+            end
+          rescue Timeout::Error
+            timed_out_statuses = dependency_timeout_statuses(dependencies)
+            if fail_on_dependency_failure?(payload)
+              fail_for_dependencies!(timed_out_statuses)
+            else
+              workflow_state.delete("dependency_wait")
+            end
           end
         end
 
@@ -50,6 +58,116 @@ module ActiveJob
           )
         end
 
+        def wait_for_dependency_statuses(payload, dependencies, wait_options)
+          not_found_counts = dependency_wait_not_found_counts
+          wait_interval = dependency_wait_current_interval(wait_options)
+          loop do
+            wait_while_paused
+            statuses = check_dependency_statuses(dependencies)
+            expired_not_found_statuses = expired_not_found_statuses(statuses, not_found_counts)
+            failed_statuses = failed_dependency_statuses(statuses) + expired_not_found_statuses
+            fail_for_dependencies!(failed_statuses) if fail_on_dependency_failure?(payload) && failed_statuses.any?
+            break if dependencies_satisfied?(statuses, expired_not_found_statuses)
+
+            persist_dependency_wait_state(not_found_counts, wait_interval)
+            continue_as_new_if_needed(payload)
+            Temporalio::Workflow.sleep(wait_interval)
+            wait_interval = next_dependency_wait_interval(wait_interval, wait_options)
+          end
+          workflow_state.delete("dependency_wait")
+        end
+
+        def with_dependency_wait_timeout(wait_options, deadline, &)
+          remaining_timeout = dependency_wait_remaining_timeout(deadline)
+          raise Timeout::Error, "dependency wait timed out" unless remaining_timeout.positive?
+
+          Temporalio::Workflow.timeout(
+            remaining_timeout,
+            Timeout::Error,
+            "dependency wait timed out after #{wait_options[:timeout]} seconds",
+            summary: "Dependency wait timeout",
+            &
+          )
+        end
+
+        def dependency_wait_options(payload)
+          configured_options = payload[:dependency_wait] || payload["dependency_wait"] || {}
+          initial_interval = positive_float_option(configured_options, :initial_interval, DEPENDENCY_WAIT_INTERVAL)
+          max_interval = positive_float_option(configured_options, :max_interval, DEPENDENCY_WAIT_MAX_INTERVAL)
+          {
+            timeout: positive_float_option(configured_options, :timeout, DEPENDENCY_WAIT_TIMEOUT),
+            initial_interval: initial_interval,
+            max_interval: [max_interval, initial_interval].max,
+            backoff: backoff_option(configured_options)
+          }
+        end
+
+        def positive_float_option(options, key, default)
+          value = options[key] || options[key.to_s]
+          return default unless value
+
+          number = Float(value)
+          number.positive? ? number : default
+        rescue ArgumentError, TypeError
+          default
+        end
+
+        def backoff_option(options)
+          value = options[:backoff] || options["backoff"]
+          return DEPENDENCY_WAIT_BACKOFF unless value
+
+          backoff = Float(value)
+          backoff >= 1.0 ? backoff : DEPENDENCY_WAIT_BACKOFF
+        rescue ArgumentError, TypeError
+          DEPENDENCY_WAIT_BACKOFF
+        end
+
+        def dependency_wait_not_found_counts
+          Hash.new(0).merge(dependency_wait_state["not_found_counts"] || {})
+        end
+
+        def dependency_wait_current_interval(wait_options)
+          current_interval = dependency_wait_state["current_interval"]
+          return wait_options[:initial_interval] unless current_interval
+
+          interval = Float(current_interval)
+          interval.positive? ? interval : wait_options[:initial_interval]
+        rescue ArgumentError, TypeError
+          wait_options[:initial_interval]
+        end
+
+        def dependency_wait_state
+          workflow_state["dependency_wait"] ||= {}
+        end
+
+        def dependency_wait_deadline(wait_options)
+          deadline_at = dependency_wait_state["deadline_at"]
+          return Time.iso8601(deadline_at) if deadline_at
+
+          persist_dependency_wait_deadline(wait_options)
+        rescue ArgumentError, TypeError
+          persist_dependency_wait_deadline(wait_options)
+        end
+
+        def persist_dependency_wait_deadline(wait_options)
+          deadline = Temporalio::Workflow.now + wait_options[:timeout]
+          dependency_wait_state["deadline_at"] = deadline.iso8601
+          deadline
+        end
+
+        def dependency_wait_remaining_timeout(deadline)
+          deadline - Temporalio::Workflow.now
+        end
+
+        def persist_dependency_wait_state(not_found_counts, wait_interval)
+          dependency_wait_state["not_found_counts"] = not_found_counts
+          dependency_wait_state["current_interval"] = wait_interval
+        end
+
+        def next_dependency_wait_interval(wait_interval, wait_options)
+          [wait_interval * wait_options[:backoff], wait_options[:max_interval]].min
+        end
+
         def dependencies_satisfied?(statuses, expired_not_found_statuses)
           expired_not_found_keys = expired_not_found_statuses.map { |status| dependency_status_key(status) }
           statuses.all? do |status|
@@ -79,16 +197,23 @@ module ActiveJob
         end
 
         def dependency_state(status)
-          status["state"] || status[:state]
+          status_value(status, :state)
         end
 
         def dependency_status_key(status)
-          job_class = status["job_class"] || status[:job_class]
-          job_id = status["job_id"] || status[:job_id]
+          job_class = status_value(status, :job_class)
+          job_id = status_value(status, :job_id)
+          workflow_id = status_value(status, :workflow_id)
+          run_id = status_value(status, :run_id)
           return "#{job_class}:#{job_id}" if job_class && job_id
           return job_id if job_id
+          return [workflow_id, run_id].compact.join(":") if workflow_id
+
+          status.hash
+        end
 
-          status["workflow_id"] || status[:workflow_id] || status.hash
+        def status_value(status, key)
+          status[key.to_s] || status[key]
         end
 
         def fail_on_dependency_failure?(payload)
@@ -109,6 +234,14 @@ module ActiveJob
             non_retryable: true
           )
         end
+
+        def dependency_timeout_statuses(dependencies)
+          dependencies.map do |dependency|
+            dependency.each_with_object({ "state" => "timed_out" }) do |(key, value), status|
+              status[key.to_s] = value
+            end
+          end
+        end
       end
     end
   end

data/lib/activejob/temporal.rb

@@ -9,17 +9,9 @@ require_relative "temporal/configurable"
 require_relative "temporal/client"
 require_relative "temporal/logger"
 require_relative "temporal/bind_policy"
-require_relative "temporal/rails_environment_loader"
 require_relative "temporal/tls_file"
-require_relative "temporal/certificate_watcher"
-require_relative "temporal/reload_signal_queue"
-require_relative "temporal/worker_client_reloader"
-require_relative "temporal/worker_pool"
 require_relative "temporal/audit_log"
-require_relative "temporal/metrics_server"
 require_relative "temporal/observability"
-require_relative "temporal/worker_health"
-require_relative "temporal/health_check_server"
 require_relative "temporal/middleware"
 require_relative "temporal/payload_serializers"
 require_relative "temporal/rate_limit_options"
@@ -36,6 +28,7 @@ require_relative "temporal/child_workflow_options"
 require_relative "temporal/chain_options"
 require_relative "temporal/dependency_options"
 require_relative "temporal/workflow_identity"
+require_relative "temporal/workflow_types"
 require_relative "temporal/job_payload_builder"
 require_relative "temporal/schedule_options"
 require_relative "temporal/conditional_enqueue"
@@ -44,17 +37,13 @@ require_relative "temporal/temporal_options"
 require_relative "temporal/schedule"
 require_relative "temporal/schedulable"
 require_relative "temporal/workflow_id_builder"
+require_relative "temporal/job_id_validation"
 require_relative "temporal/batch_enqueue_result"
 require_relative "temporal/batch_enqueuer"
 require_relative "temporal/workflow_enqueuer_batch"
 require_relative "temporal/workflow_enqueuer"
 require_relative "temporal/adapter"
 require_relative "temporal/transaction_safety"
-require_relative "temporal/workflows/aj_workflow"
-require_relative "temporal/workflows/dead_letter_workflow"
-require_relative "temporal/activities/rate_limit_activity"
-require_relative "temporal/activities/dependency_status_activity"
-require_relative "temporal/activities/aj_runner_activity"
 require_relative "temporal/cancel"
 require_relative "temporal/inspect"
 require_relative "temporal/signal_query"

data/test/mutant_unit_test.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require "mutant/minitest/coverage"
+require_relative "../spec/spec_helper"
+
+# mutant-minitest discovers test/**/*_test.rb, while the migrated suite keeps
+# the existing spec/ split for CI and developer workflows.
+Minitest::Spec.cover "ActiveJob::Temporal::WorkflowIdBuilder#build"
+Minitest::Spec.cover "ActiveJob::Temporal::WorkflowIdBuilder.default_for"
+
+Dir[File.expand_path("../spec/unit/**/*_spec.rb", __dir__)].each do |path|
+  require path
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activejob-temporal
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Temporal Technologies
@@ -16,7 +16,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '8.1'
+        version: '7.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: '9'
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '8.1'
+        version: '7.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: '9'
@@ -36,7 +36,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '8.1'
+        version: '7.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: '9'
@@ -46,7 +46,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '8.1'
+        version: '7.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: '9'
@@ -78,20 +78,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0.3'
-- !ruby/object:Gem::Dependency
-  name: listen
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.9'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.9'
 - !ruby/object:Gem::Dependency
   name: temporalio
   requirement: !ruby/object:Gem::Requirement
@@ -127,33 +113,53 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2.14'
 - !ruby/object:Gem::Dependency
-  name: bundler-audit
+  name: github_changelog_generator
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '1.18'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '1.18'
 - !ruby/object:Gem::Dependency
-  name: github_changelog_generator
+  name: listen
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.18'
+        version: '3.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.18'
+        version: '3.9'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.11'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.11'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7'
 - !ruby/object:Gem::Dependency
   name: msgpack
   requirement: !ruby/object:Gem::Requirement
@@ -169,7 +175,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.8'
 - !ruby/object:Gem::Dependency
-  name: mutant-rspec
+  name: mutant-minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -210,20 +216,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '13.2'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.12'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.12'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -273,9 +265,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.9'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.9.42
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -283,9 +272,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.9'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.9.42
 description: |
   activejob-temporal bridges Rails ActiveJob with Temporal's durable execution engine.
   It provides a drop-in ActiveJob adapter, Temporal workflows, and supporting tooling
@@ -297,12 +283,17 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- AGENTS.md
 - CHANGELOG.md
+- CLAUDE.md
+- CONTRIBUTING.md
 - LICENSE
 - README.md
 - activejob-temporal.gemspec
 - api/job_payload_schema.json
 - bin/temporal-worker
+- gemfiles/activejob_contract.gemfile
+- gemfiles/temporalio_contract.gemfile
 - lib/activejob-temporal.rb
 - lib/activejob/temporal.rb
 - lib/activejob/temporal/active_job_handler_source.rb
@@ -333,8 +324,10 @@ files:
 - lib/activejob/temporal/external_operation.rb
 - lib/activejob/temporal/health_check_server.rb
 - lib/activejob/temporal/http_line_reader.rb
+- lib/activejob/temporal/http_request_failure_handling.rb
 - lib/activejob/temporal/inspect.rb
 - lib/activejob/temporal/job_descriptor.rb
+- lib/activejob/temporal/job_id_validation.rb
 - lib/activejob/temporal/job_payload_builder.rb
 - lib/activejob/temporal/job_payload_chain_builder.rb
 - lib/activejob/temporal/job_payload_child_workflows.rb
@@ -378,10 +371,12 @@ files:
 - lib/activejob/temporal/worker_client_reloader.rb
 - lib/activejob/temporal/worker_health.rb
 - lib/activejob/temporal/worker_pool.rb
+- lib/activejob/temporal/worker_runtime.rb
 - lib/activejob/temporal/workflow_enqueuer.rb
 - lib/activejob/temporal/workflow_enqueuer_batch.rb
 - lib/activejob/temporal/workflow_id_builder.rb
 - lib/activejob/temporal/workflow_identity.rb
+- lib/activejob/temporal/workflow_types.rb
 - lib/activejob/temporal/workflows/aj_workflow.rb
 - lib/activejob/temporal/workflows/dead_letter_support.rb
 - lib/activejob/temporal/workflows/dead_letter_workflow.rb
@@ -394,13 +389,13 @@ files:
 - lib/activejob/temporal/workflows/workflow_local_activities.rb
 - lib/activejob/temporal/workflows/workflow_nexus.rb
 - lib/activejob/temporal/workflows/workflow_versioning.rb
+- test/mutant_unit_test.rb
 homepage: https://github.com/schovi/activejob-temporal
 licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/schovi/activejob-temporal
-  source_code_uri: https://github.com/schovi/activejob-temporal/tree/main
-  documentation_uri: https://github.com/schovi/activejob-temporal/blob/main/docs/README.md
+  source_code_uri: https://github.com/schovi/activejob-temporal
   changelog_uri: https://github.com/schovi/activejob-temporal/blob/main/CHANGELOG.md
   rubygems_mfa_required: 'true'
 rdoc_options: []