activejob-google_cloud_tasks-http 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1f75ab5b15c876b764b2a30837307a55179e4b158845237b1c46867331728f0e
-  data.tar.gz: 8c367bb1dc438647af0a164fdbe9bc7fb89055e83ce4b1a26d845f1fce9ab0a7
+  metadata.gz: d51fc09c046c3a0aac710f1155498a72c72018086fdd24167e4249c1b5d03f61
+  data.tar.gz: afd118c002dcc743118a3e1c87fbab5f064b3144ac6bc87fd0196d9551c3710c
 SHA512:
-  metadata.gz: e75a8f803782889055e447ccb0dd13dd57978a63d7adeb33a5f59da8052965db1621bb3aa432087c6d36196170be3f323068fac3a173893bb9756c05798ef8ec
-  data.tar.gz: 23ad68ee012868e82b8baf6ae0a28fc63c8a36e061cb0fe24308a6e544fe9ab0d04e04a170e22da555720b213bedc4a2713f22128cdd6de17c38cdbdb1de8c27
+  metadata.gz: de14461acec2013a347cc8f654adc1d4a55c4c4575a6258daa0e5ebab3e198ebd76ec2c8de34a65c18acc42065ce1eba195747cdcf668da42b0603ab39fc8a76
+  data.tar.gz: 50d947d1a3585ebd393b152bb9855b3b43de220591ef69871234a82292883d913c36c3c2c194518f5793bcdf4d42d4f90c690962fbc4256a503d8b7c3fc6d5da

data/.github/workflows/ci.yml

@@ -0,0 +1,31 @@
+name: CI
+on:
+ - push
+
+jobs:
+  test:
+    name: Test
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby_image:
+          - ruby:latest
+          - ruby:3.0
+          - ruby:2.7
+          - ruby:2.6
+        bundle:
+          - latest
+          - activejob-6.1
+          - activejob-6.0
+          - activejob-5.2
+    container:
+      image: ${{ matrix.ruby_image }}
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Install dependencies and run tests
+        run: |
+          bundle
+          bundle exec appraisal install
+          bundle exec appraisal "${{ matrix.bundle }}" rake spec

data/.gitignore

@@ -11,3 +11,6 @@
 .rspec_status
 
 Gemfile.lock
+
+# Appraisal
+/gemfiles

data/Appraisals

@@ -0,0 +1,15 @@
+appraise 'latest' do
+  gem 'activejob'
+end
+
+appraise 'activejob-6.1' do
+  gem 'activejob', '~> 6.1.4'
+end
+
+appraise 'activejob-6.0' do
+  gem 'activejob', '~> 6.0.4'
+end
+
+appraise 'activejob-5.2' do
+  gem 'activejob', '~> 5.2.6'
+end

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.3.0
+
+- [Support for enqueue_after_transaction_commit setting introduced in Rails 7.2](https://github.com/esminc/activejob-google_cloud_tasks-http/pull/14) by @bluerabbit
+- [Update readme example to use new config format](https://github.com/esminc/activejob-google_cloud_tasks-http/pull/14) by @jaredlt
+
 ## 0.2.0
 
 This version depends on google-cloud-tasks 2.0 or later. Since google-cloud-tasks 2.0 has API changes, upgrading to this version may affect to existing adapter initialization code. If you are initializing Google::Cloud::Tasks client manually, you will have to change `Google::Cloud::Tasks.new` to `Google::Cloud::Tasks.cloud_tasks` as follows:

data/Gemfile

@@ -4,3 +4,5 @@ git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in activejob-google_cloud_tasks-http.gemspec
 gemspec
+
+gem 'appraisal'

data/README.md

@@ -75,10 +75,10 @@ unless ARGV.include?("assets:precompile") # prevents running on assets:precompil
     project: 'my-project',
     location: 'europe-west2',
     url: 'https://www.example.com/jobs',
-    client: Google::Cloud::Tasks.cloud_tasks(
-      version: :v2beta3,
-      credentials: JSON.parse(ENV["GOOGLE_CLOUD_PRODUCTION_KEYFILE"]) # this will cause an error if the environment variable does not exist
-    )
+    client: Google::Cloud::Tasks.cloud_tasks(version: :v2beta3) { |config|
+      # this will cause an error if the environment variable does not exist
+      config.credentials = JSON.parse(ENV["GOOGLE_CLOUD_PRODUCTION_KEYFILE"])
+    }
   )
 end
 ```

data/lib/active_job/google_cloud_tasks/http/adapter.rb

@@ -6,12 +6,18 @@ module ActiveJob
   module GoogleCloudTasks
     module HTTP
       class Adapter
-        def initialize(project:, location:, url:, task_options: {}, client: nil)
+        def initialize(project:, location:, url:, task_options: {}, client: nil, enqueue_after_transaction_commit: false)
           @project = project
           @location = location
           @url = url
           @task_options = task_options
           @client = client
+          @enqueue_after_transaction_commit = enqueue_after_transaction_commit
+        end
+
+        # Method expected in Rails 7.2 and later
+        def enqueue_after_transaction_commit?
+          @enqueue_after_transaction_commit
         end
 
         def enqueue(job, attributes = {})

data/lib/active_job/google_cloud_tasks/http/inline.rb

@@ -4,6 +4,11 @@ module ActiveJob
   module GoogleCloudTasks
     module HTTP
       module Inlining
+        # Method expected in Rails 7.2 and later
+        def enqueue_after_transaction_commit?
+          false
+        end
+
         def enqueue(job, *)
           ActiveJob::Base.execute job.serialize
         end

data/lib/active_job/google_cloud_tasks/http/version.rb

@@ -1,7 +1,7 @@
 module ActiveJob
   module GoogleCloudTasks
     module HTTP
-      VERSION = "0.2.0"
+      VERSION = "0.3.0"
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activejob-google_cloud_tasks-http
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - hibariya
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-05-31 00:00:00.000000000 Z
+date: 2024-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob
@@ -101,10 +101,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".github/workflows/verify.yml"
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- Appraisals
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -139,7 +140,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.5.11
 signing_key: 
 specification_version: 4
 summary: ActiveJob adapter for Google Cloud Tasks HTTP targets.

data/.github/workflows/verify.yml

@@ -1,18 +0,0 @@
-name: Verify
-on:
- - push
-
-jobs:
-  tests:
-    name: Tests
-    runs-on: ubuntu-latest
-    container:
-      image: ruby
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v2
-
-      - name: Install dependencies and run tests
-        run: |
-          bundle
-          rake spec