activejob-google_cloud_tasks-http 0.1.3 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 06b5da976d41cd61619702524da58f0dea6226b3f6b5510455d5556afb5a5910
-  data.tar.gz: 567bdda0e0b4e4f6e279c3bfce9508ba795035366c279d9e45cde6b9d638e47d
+  metadata.gz: 1f75ab5b15c876b764b2a30837307a55179e4b158845237b1c46867331728f0e
+  data.tar.gz: 8c367bb1dc438647af0a164fdbe9bc7fb89055e83ce4b1a26d845f1fce9ab0a7
 SHA512:
-  metadata.gz: b9c65beebd8426e212fae8b5266f5ae911c1ff28f343be83d4e8003af23e7690a0a7c20c4c1cf16ebfbdee52c88436dacee3fb4db00d17a45e1de50549757b6a
-  data.tar.gz: ea19d25710b97c8b38afbb258da990e338457f38c88da277ef3dd1bcf41ff1931eca60d158c90378d2ac2178a9886af11e95dcbb8e4f4268754a8034f7dfd797
+  metadata.gz: e75a8f803782889055e447ccb0dd13dd57978a63d7adeb33a5f59da8052965db1621bb3aa432087c6d36196170be3f323068fac3a173893bb9756c05798ef8ec
+  data.tar.gz: 23ad68ee012868e82b8baf6ae0a28fc63c8a36e061cb0fe24308a6e544fe9ab0d04e04a170e22da555720b213bedc4a2713f22128cdd6de17c38cdbdb1de8c27

data/.github/workflows/verify.yml

@@ -0,0 +1,18 @@
+name: Verify
+on:
+ - push
+
+jobs:
+  tests:
+    name: Tests
+    runs-on: ubuntu-latest
+    container:
+      image: ruby
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Install dependencies and run tests
+        run: |
+          bundle
+          rake spec

data/.rspec

@@ -0,0 +1 @@
+--require spec_helper

data/CHANGELOG.md

@@ -0,0 +1,23 @@
+## 0.2.0
+
+This version depends on google-cloud-tasks 2.0 or later. Since google-cloud-tasks 2.0 has API changes, upgrading to this version may affect to existing adapter initialization code. If you are initializing Google::Cloud::Tasks client manually, you will have to change `Google::Cloud::Tasks.new` to `Google::Cloud::Tasks.cloud_tasks` as follows:
+
+from:
+
+    Rails.application.config.active_job.queue_adapter = ActiveJob::GoogleCloudTasks::HTTP::Adapter.new(
+      client: Google::Cloud::Tasks.new(version: :v2beta3),
+      # ...
+    )
+
+to:
+
+    Rails.application.config.active_job.queue_adapter = ActiveJob::GoogleCloudTasks::HTTP::Adapter.new(
+      client: Google::Cloud::Tasks.cloud_tasks(version: :v2beta3),
+      # ...
+    )
+
+For more information, see this migration guide: https://github.com/googleapis/google-cloud-ruby/blob/master/google-cloud-tasks/MIGRATING.md
+
+## 0.1.0
+
+:tada:

data/README.md

@@ -29,7 +29,7 @@ Rails.application.config.active_job.queue_adapter = ActiveJob::GoogleCloudTasks:
   project: 'a-gcp-project-name',
   location: 'asia-northeast1',
   url: 'https://an-endpoint-to-perform-jobs.a.run.app/_jobs',
-  client: Google::Cloud::Tasks.new(version: :v2beta3), # optional
+  client: Google::Cloud::Tasks.cloud_tasks(version: :v2beta3), # optional
   task_options: { # optional
     oidc_token: {
       service_account_email: 'cloudrun-invoker@a-gcp-project-name.iam.gserviceaccount.com'
@@ -65,6 +65,24 @@ Requiring `active_job/google_cloud_tasks/http/inline` makes the adapter skip enq
 require 'active_job/google_cloud_tasks/http/inline' unless Rails.env.production?
 ```
 
+#### Error when calling assets:precompile?
+
+When you call assets:precompile, all configs and initializers are loaded. If you load your credentials via environment variables they may not be available and the adapter initialization will cause errors. To solve this, wrap the `queue_adapter` config in a `unless ARGV.include?("assets:precompile")` condition. e.g.:
+
+```ruby
+unless ARGV.include?("assets:precompile") # prevents running on assets:precompile
+  Rails.application.config.active_job.queue_adapter = ActiveJob::GoogleCloudTasks::HTTP::Adapter.new(
+    project: 'my-project',
+    location: 'europe-west2',
+    url: 'https://www.example.com/jobs',
+    client: Google::Cloud::Tasks.cloud_tasks(
+      version: :v2beta3,
+      credentials: JSON.parse(ENV["GOOGLE_CLOUD_PRODUCTION_KEYFILE"]) # this will cause an error if the environment variable does not exist
+    )
+  )
+end
+```
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.

data/activejob-google_cloud_tasks-http.gemspec

@@ -17,16 +17,16 @@ Gem::Specification.new do |spec|
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
   spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
-    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features|example-app)/}) }
   end
   spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
   spec.add_runtime_dependency "activejob"
-  spec.add_runtime_dependency "google-cloud-tasks"
+  spec.add_runtime_dependency "google-cloud-tasks", ">= 2.0.0"
   spec.add_runtime_dependency "rack"
-  spec.add_development_dependency "bundler", "~> 1.17"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "bundler"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rspec"
 end

data/lib/active_job/google_cloud_tasks/http/adapter.rb

@@ -1,5 +1,6 @@
 require 'json'
 require 'google/cloud/tasks'
+require 'gapic/grpc' # to use Google::Protobuf::Timestamp which is used by Google::Cloud::Tasks::Vxx
 
 module ActiveJob
   module GoogleCloudTasks
@@ -14,10 +15,10 @@ module ActiveJob
         end
 
         def enqueue(job, attributes = {})
-          path = client.queue_path(@project, @location, job.queue_name)
+          path = client.queue_path(project: @project, location: @location, queue: job.queue_name)
           task = build_task(job, attributes)
 
-          client.create_task path, task
+          client.create_task parent: path, task: task
         end
 
         def enqueue_at(job, scheduled_at)
@@ -27,7 +28,7 @@ module ActiveJob
         private
 
         def client
-          @client ||= Google::Cloud::Tasks.new(version: :v2beta3)
+          @client ||= Google::Cloud::Tasks.cloud_tasks(version: :v2beta3)
         end
 
         def build_task(job, attributes)

data/lib/active_job/google_cloud_tasks/http/version.rb

@@ -1,7 +1,7 @@
 module ActiveJob
   module GoogleCloudTasks
     module HTTP
-      VERSION = "0.1.3"
+      VERSION = "0.2.0"
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activejob-google_cloud_tasks-http
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.2.0
 platform: ruby
 authors:
 - hibariya
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-10-04 00:00:00.000000000 Z
+date: 2020-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.0.0
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
@@ -56,44 +56,44 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.17'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.17'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 description: ActiveJob adapter for Google Cloud Tasks HTTP targets.
 email:
 - hibariya@gmail.com
@@ -101,8 +101,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/verify.yml"
 - ".gitignore"
+- ".rspec"
 - ".travis.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
@@ -136,7 +139,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: ActiveJob adapter for Google Cloud Tasks HTTP targets.