activeinteractor 1.0.1 → 1.1.0

data/spec/integration/an_organizer_with_failing_nested_organizer_spec.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe 'An organizer with failing nested organizer', type: :integration do
+  let!(:parent_interactor1) { build_interactor('TestParentInteractor1') }
+  let!(:parent_interactor2) { build_interactor('TestParentInteractor2') }
+  let!(:child_interactor1) { build_interactor('TestChildInteractor1') }
+  let!(:child_interactor2) do
+    build_interactor('TestChildInteractor2') do
+      def perform
+        context.fail!
+      end
+    end
+  end
+
+  let!(:child_interactor_class) do
+    build_organizer('TestChildOrganizer') do
+      organize TestChildInteractor1, TestChildInteractor2
+    end
+  end
+
+  let(:parent_interactor_class) do
+    build_organizer('TestParentOrganizer') do
+      organize TestParentInteractor1, TestChildOrganizer, TestParentInteractor2
+    end
+  end
+
+  describe '.perform' do
+    subject { parent_interactor_class.perform }
+
+    before do
+      expect_any_instance_of(child_interactor_class).to receive(:perform).exactly(:once).and_call_original
+      expect_any_instance_of(child_interactor1).to receive(:perform).exactly(:once).and_call_original
+      expect_any_instance_of(child_interactor2).to receive(:perform).exactly(:once).and_call_original
+      expect_any_instance_of(child_interactor2).to receive(:rollback).exactly(:once).and_call_original
+      expect_any_instance_of(child_interactor1).to receive(:rollback).exactly(:once).and_call_original
+      expect_any_instance_of(parent_interactor1).to receive(:rollback).exactly(:once).and_call_original
+      expect_any_instance_of(parent_interactor2).not_to receive(:perform).exactly(:once).and_call_original
+      expect_any_instance_of(parent_interactor2).not_to receive(:rollback).exactly(:once).and_call_original
+    end
+
+    it { is_expected.to be_a parent_interactor_class.context_class }
+
+    it { is_expected.to be_failure }
+  end
+end

data/spec/integration/an_organizer_with_options_callbacks_spec.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe 'An organizer with options callbacks', type: :integration do
+  let!(:interactor1) do
+    build_interactor('TestInteractor1') do
+      def perform
+        context.step = 3 if context.step == 2
+        context.step = 6 if context.step == 5
+      end
+    end
+  end
+
+  let(:interactor_class) do
+    build_organizer do
+      organize do
+        add TestInteractor1, before: :test_before_method, after: :test_after_method
+        add TestInteractor1, before: lambda {
+          context.step = 5 if context.step == 4
+        }, after: lambda {
+          context.step = 7 if context.step == 6
+        }
+      end
+
+      private
+
+      def test_before_method
+        context.step = 2 if context.step == 1
+      end
+
+      def test_after_method
+        context.step = 4 if context.step == 3
+      end
+    end
+  end
+
+  include_examples 'a class with interactor methods'
+  include_examples 'a class with interactor callback methods'
+  include_examples 'a class with interactor context methods'
+  include_examples 'a class with organizer callback methods'
+
+  describe '.perform' do
+    subject { interactor_class.perform(step: 1) }
+
+    it { is_expected.to be_a interactor_class.context_class }
+    it 'is expected to receive #test_before_method once' do
+      expect_any_instance_of(interactor_class).to receive(:test_before_method)
+        .exactly(:once)
+      subject
+    end
+
+    it 'is expected to receive #test_after_method once' do
+      expect_any_instance_of(interactor_class).to receive(:test_after_method)
+        .exactly(:once)
+      subject
+    end
+
+    it 'runs callbacks in sequence' do
+      expect(subject.step).to eq(7)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,13 +1,23 @@
 # frozen_string_literal: true
 
-require_relative 'support/coverage'
-
-Spec::Coverage::Runner.start do
-  add_formatter :simple_cov_html
-  add_formatter :codacy
-  track '/lib/**/*.rb'
-  filter '/spec/'
-  filter '/lib/rails/**'
+begin
+  require 'simplecov'
+  require 'simplecov-lcov'
+
+  SimpleCov::Formatter::LcovFormatter.config.report_with_single_file = true
+
+  SimpleCov.start do
+    enable_coverage :branch
+    add_filter '/spec/'
+    add_filter '/lib/rails/**/*.rb'
+    track_files '/lib/**/*.rb'
+    formatter SimpleCov::Formatter::MultiFormatter.new([
+                                                         SimpleCov::Formatter::HTMLFormatter,
+                                                         SimpleCov::Formatter::LcovFormatter
+                                                       ])
+  end
+rescue LoadError
+  puts 'Skipping coverage...'
 end
 
 require 'bundler/setup'

data/spec/support/shared_examples/a_class_that_extends_active_interactor_models_example.rb

@@ -0,0 +1,81 @@
+# frozen_string_literal: true
+
+RSpec.shared_examples 'A class that extends ActiveInteractor::Models' do
+  it { expect(model_class).to respond_to :attribute }
+  it { expect(model_class).to respond_to :attributes }
+
+  describe 'as an instance' do
+    subject { model_class.new }
+
+    it { is_expected.to respond_to :attributes }
+    it { is_expected.to respond_to :called! }
+    it { is_expected.to respond_to :fail! }
+    it { is_expected.to respond_to :fail? }
+    it { is_expected.to respond_to :failure? }
+    it { is_expected.to respond_to :merge! }
+    it { is_expected.to respond_to :rollback! }
+    it { is_expected.to respond_to :success? }
+    it { is_expected.to respond_to :successful? }
+  end
+
+  describe '.new' do
+    subject { model_class.new(attributes) }
+
+    describe 'with arguments {:foo => "foo"}' do
+      let(:attributes) { { foo: 'foo' } }
+
+      it { is_expected.to have_attributes(foo: 'foo') }
+    end
+
+    describe 'with arguments {:bar => "bar"}' do
+      let(:attributes) { model_class.new(bar: 'bar') }
+
+      it { expect { subject }.to raise_error(ActiveModel::UnknownAttributeError) }
+    end
+
+    describe 'with arguments <#ModelClass foo="foo">' do
+      let(:other_instance) { model_class.new(foo: 'foo') }
+      let(:attributes) { other_instance }
+
+      it { is_expected.to have_attributes(foo: 'foo') }
+
+      context 'with argument instance having @_failed eq to true' do
+        before { other_instance.instance_variable_set('@_failed', true) }
+
+        it { is_expected.to be_failure }
+      end
+
+      context 'with argument instance having @_called eq to ["foo"]' do
+        before { other_instance.instance_variable_set('@_called', %w[foo]) }
+
+        it 'is expected to have instance variable @_called eq to ["foo"]' do
+          expect(subject.instance_variable_get('@_called')).to eq %w[foo]
+        end
+      end
+
+      context 'with argument instance having @_rolled_back eq to true' do
+        before { other_instance.instance_variable_set('@_rolled_back', true) }
+
+        it 'is expected to have instance variable @_rolled_back eq to true' do
+          expect(subject.instance_variable_get('@_rolled_back')).to eq true
+        end
+      end
+    end
+
+    describe 'with arguments <#OtherClass bar="bar">' do
+      let(:attributes) { model_class.new(other_instance) }
+      let!(:other_class) do
+        build_class('OtherClass') do
+          include ActiveModel::Attributes
+          include ActiveModel::Model
+          extend ActiveInteractor::Models
+          acts_as_context
+          attribute :bar
+        end
+      end
+      let(:other_instance) { other_class.new(bar: 'bar') }
+
+      it { expect { subject }.to raise_error(ActiveModel::UnknownAttributeError) }
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activeinteractor
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Aaron Allen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-28 00:00:00.000000000 Z
+date: 2020-10-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -111,6 +111,7 @@ files:
 - lib/active_interactor/configurable.rb
 - lib/active_interactor/context/attributes.rb
 - lib/active_interactor/context/base.rb
+- lib/active_interactor/context/errors.rb
 - lib/active_interactor/context/loader.rb
 - lib/active_interactor/context/status.rb
 - lib/active_interactor/error.rb
@@ -127,6 +128,8 @@ files:
 - lib/active_interactor/organizer/perform.rb
 - lib/active_interactor/rails.rb
 - lib/active_interactor/rails/orm/active_record.rb
+- lib/active_interactor/rails/orm/dynamoid.rb
+- lib/active_interactor/rails/orm/mongoid.rb
 - lib/active_interactor/rails/railtie.rb
 - lib/active_interactor/version.rb
 - lib/rails/generators/active_interactor.rb
@@ -185,13 +188,11 @@ files:
 - spec/integration/an_organizer_with_around_each_callbacks_spec.rb
 - spec/integration/an_organizer_with_before_each_callbacks_spec.rb
 - spec/integration/an_organizer_with_conditionally_organized_interactors_spec.rb
+- spec/integration/an_organizer_with_failing_nested_organizer_spec.rb
+- spec/integration/an_organizer_with_options_callbacks_spec.rb
 - spec/spec_helper.rb
-- spec/support/coverage.rb
-- spec/support/coverage/reporters.rb
-- spec/support/coverage/reporters/codacy.rb
-- spec/support/coverage/reporters/simple_cov.rb
-- spec/support/coverage/runner.rb
 - spec/support/helpers/factories.rb
+- spec/support/shared_examples/a_class_that_extends_active_interactor_models_example.rb
 - spec/support/shared_examples/a_class_with_interactor_callback_methods_example.rb
 - spec/support/shared_examples/a_class_with_interactor_context_methods_example.rb
 - spec/support/shared_examples/a_class_with_interactor_methods_example.rb
@@ -202,10 +203,10 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/aaronmallen/activeinteractor/issues
-  changelog_uri: https://github.com/aaronmallen/activeinteractor/blob/v1.0.1/CHANGELOG.md
-  documentation_uri: https://www.rubydoc.info/gems/activeinteractor/1.0.1
+  changelog_uri: https://github.com/aaronmallen/activeinteractor/blob/v1.1.0/CHANGELOG.md
+  documentation_uri: https://www.rubydoc.info/gems/activeinteractor/1.1.0
   hompage_uri: https://github.com/aaronmallen/activeinteractor
-  source_code_uri: https://github.com/aaronmallen/activeinteractor/tree/v1.0.1
+  source_code_uri: https://github.com/aaronmallen/activeinteractor/tree/v1.1.0
   wiki_uri: https://github.com/aaronmallen/activeinteractor/wiki
 post_install_message: 
 rdoc_options: []
@@ -227,45 +228,43 @@ signing_key:
 specification_version: 4
 summary: Ruby interactors with ActiveModel::Validations
 test_files:
-- spec/active_interactor_spec.rb
-- spec/integration/a_failing_interactor_spec.rb
-- spec/integration/active_record_integration_spec.rb
+- spec/support/shared_examples/a_class_that_extends_active_interactor_models_example.rb
+- spec/support/shared_examples/a_class_with_interactor_methods_example.rb
+- spec/support/shared_examples/a_class_with_interactor_context_methods_example.rb
+- spec/support/shared_examples/a_class_with_organizer_callback_methods_example.rb
+- spec/support/shared_examples/a_class_with_interactor_callback_methods_example.rb
+- spec/support/spec_helpers.rb
+- spec/support/helpers/factories.rb
+- spec/integration/an_organizer_with_options_callbacks_spec.rb
+- spec/integration/an_interactor_with_validations_on_calling_spec.rb
+- spec/integration/an_organizer_with_failing_nested_organizer_spec.rb
+- spec/integration/a_basic_interactor_spec.rb
+- spec/integration/a_basic_organizer_spec.rb
+- spec/integration/an_organizer_with_conditionally_organized_interactors_spec.rb
+- spec/integration/an_interactor_with_validations_spec.rb
+- spec/integration/an_interactor_with_an_existing_context_class_spec.rb
+- spec/integration/an_organizer_with_around_each_callbacks_spec.rb
 - spec/integration/an_interactor_with_validations_on_called_spec.rb
 - spec/integration/an_interactor_with_around_perform_callbacks_spec.rb
 - spec/integration/an_interactor_with_before_rollback_callbacks_spec.rb
-- spec/integration/a_basic_organizer_spec.rb
+- spec/integration/an_interactor_with_before_perform_callbacks_spec.rb
 - spec/integration/an_interactor_with_around_rollback_callbacks_spec.rb
+- spec/integration/an_interactor_with_after_perform_callbacks_spec.rb
+- spec/integration/an_interactor_with_after_context_validation_callbacks_spec.rb
 - spec/integration/an_organizer_with_after_each_callbacks_spec.rb
+- spec/integration/active_record_integration_spec.rb
+- spec/integration/a_failing_interactor_spec.rb
+- spec/integration/an_organizer_with_before_each_callbacks_spec.rb
 - spec/integration/an_organizer_performing_in_parallel_spec.rb
-- spec/integration/an_interactor_with_an_existing_context_class_spec.rb
 - spec/integration/an_interactor_with_after_rollback_callbacks_spec.rb
-- spec/integration/an_interactor_with_validations_spec.rb
-- spec/integration/a_basic_interactor_spec.rb
-- spec/integration/an_interactor_with_validations_on_calling_spec.rb
-- spec/integration/an_interactor_with_before_perform_callbacks_spec.rb
-- spec/integration/an_organizer_with_before_each_callbacks_spec.rb
-- spec/integration/an_organizer_with_conditionally_organized_interactors_spec.rb
-- spec/integration/an_organizer_with_around_each_callbacks_spec.rb
-- spec/integration/an_interactor_with_after_context_validation_callbacks_spec.rb
-- spec/integration/an_interactor_with_after_perform_callbacks_spec.rb
-- spec/support/spec_helpers.rb
-- spec/support/coverage/reporters.rb
-- spec/support/coverage/reporters/codacy.rb
-- spec/support/coverage/reporters/simple_cov.rb
-- spec/support/coverage/runner.rb
-- spec/support/shared_examples/a_class_with_organizer_callback_methods_example.rb
-- spec/support/shared_examples/a_class_with_interactor_callback_methods_example.rb
-- spec/support/shared_examples/a_class_with_interactor_methods_example.rb
-- spec/support/shared_examples/a_class_with_interactor_context_methods_example.rb
-- spec/support/helpers/factories.rb
-- spec/support/coverage.rb
-- spec/spec_helper.rb
+- spec/active_interactor/interactor/worker_spec.rb
+- spec/active_interactor/interactor/perform/options_spec.rb
 - spec/active_interactor/context/base_spec.rb
-- spec/active_interactor/base_spec.rb
 - spec/active_interactor/config_spec.rb
+- spec/active_interactor/error_spec.rb
+- spec/active_interactor/base_spec.rb
+- spec/active_interactor/organizer/interactor_interface_collection_spec.rb
 - spec/active_interactor/organizer/base_spec.rb
 - spec/active_interactor/organizer/interactor_interface_spec.rb
-- spec/active_interactor/organizer/interactor_interface_collection_spec.rb
-- spec/active_interactor/interactor/worker_spec.rb
-- spec/active_interactor/interactor/perform/options_spec.rb
-- spec/active_interactor/error_spec.rb
+- spec/spec_helper.rb
+- spec/active_interactor_spec.rb

data/spec/support/coverage.rb

@@ -1,4 +0,0 @@
-# frozen_string_literal: true
-
-require_relative 'coverage/reporters'
-require_relative 'coverage/runner'

data/spec/support/coverage/reporters.rb

@@ -1,11 +0,0 @@
-# frozen_string_literal: true
-
-module Spec
-  module Coverage
-    module Reporters
-      EMPTY_LOAD_RESULT = [{}, [], []].freeze
-    end
-  end
-end
-
-Dir[File.expand_path('reporters/*.rb', __dir__)].sort.each { |file| require file }

data/spec/support/coverage/reporters/codacy.rb

@@ -1,39 +0,0 @@
-# frozen_string_literal: true
-
-module Spec
-  module Coverage
-    module Reporters
-      module Codacy
-        class << self
-          def load
-            return EMPTY_LOAD_RESULT unless load_dependencies
-
-            [formatters, initialize_steps, run_steps]
-          end
-
-          private
-
-          def load_dependencies
-            require 'codacy-coverage'
-            true
-          rescue LoadError
-            puts 'Skipping Codacy Coverage reporting...'
-            false
-          end
-
-          def formatters
-            { codacy: ::Codacy::Formatter }
-          end
-
-          def initialize_steps
-            []
-          end
-
-          def run_steps
-            []
-          end
-        end
-      end
-    end
-  end
-end

data/spec/support/coverage/reporters/simple_cov.rb

@@ -1,54 +0,0 @@
-# frozen_string_literal: true
-
-module Spec
-  module Coverage
-    module Reporters
-      module SimpleCov
-        class << self
-          def load
-            return EMPTY_LOAD_RESULT unless load_dependencies
-
-            [formatters, initialize_steps, run_steps]
-          end
-
-          private
-
-          def load_dependencies
-            require 'simplecov'
-            true
-          rescue LoadError
-            puts 'Skipping SimpleCov reporting...'
-            false
-          end
-
-          def formatters
-            { simple_cov_html: ::SimpleCov::Formatter::HTMLFormatter }
-          end
-
-          def initialize_steps
-            [setup_formatters]
-          end
-
-          def run_steps
-            [start_simplecov]
-          end
-
-          def setup_formatters
-            lambda do |runner|
-              ::SimpleCov.formatter = ::SimpleCov::Formatter::MultiFormatter.new(runner.formatters)
-            end
-          end
-
-          def start_simplecov
-            lambda do |runner|
-              ::SimpleCov.start do
-                runner.tracked_files.each { |f| track_files f }
-                runner.filtered_files.each { |f| add_filter f }
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end