activeinteractor 1.0.0 → 1.0.5

data/spec/integration/a_basic_interactor_spec.rb

@@ -103,4 +103,52 @@ RSpec.describe 'A basic interactor', type: :integration do
       end
     end
   end
+
+  context 'having default context attributes {:foo => "foo"}' do
+    let(:interactor_class) do
+      build_interactor do
+        context_attribute :foo, default: -> { 'foo' }
+      end
+    end
+
+    describe '.perform' do
+      subject { interactor_class.perform(context_attributes) }
+
+      context 'when no context is passed' do
+        let(:context_attributes) { {} }
+
+        it { is_expected.to have_attributes(foo: 'foo') }
+      end
+
+      context 'when context {:foo => "bar"} is passed' do
+        let(:context_attributes) { { foo: 'bar' } }
+
+        it { is_expected.to have_attributes(foo: 'bar') }
+      end
+    end
+  end
+
+  context 'having default context attributes {:foo => "foo", :bar => "bar"} using the #context_attributes method' do
+    let(:interactor_class) do
+      build_interactor do
+        context_attributes foo: { default: -> { 'foo' } }, bar: { default: -> { 'bar' } }
+      end
+
+      describe '.perform' do
+        subject { interactor_class.perform(context_attributes) }
+
+        context 'when no context is passed' do
+          let(:context_attributes) { {} }
+
+          it { is_expected.to have_attributes(foo: 'foo', bar: 'bar') }
+        end
+
+        context 'when context {:foo => "bar"} is passed' do
+          let(:context_attributes) { { foo: 'bar' } }
+
+          it { is_expected.to have_attributes(foo: 'bar', bar: 'bar') }
+        end
+      end
+    end
+  end
 end

data/spec/integration/a_basic_organizer_spec.rb

@@ -69,6 +69,26 @@ RSpec.describe 'A basic organizer', type: :integration do
         expect_any_instance_of(test_interactor_2).not_to receive(:perform!)
         subject
       end
+
+      # https://github.com/aaronmallen/activeinteractor/issues/169
+      context 'with error message "something went wrong"' do
+        let!(:test_interactor_1) do
+          build_interactor('TestInteractor1') do
+            def perform
+              context.fail!('something went wrong')
+            end
+          end
+        end
+
+        it { expect { subject }.not_to raise_error }
+        it { is_expected.to be_a interactor_class.context_class }
+        it { is_expected.to be_failure }
+        it { expect(subject.errors.count).to eq 1 }
+        it 'is expected to have errors "something went wrong" on :context' do
+          expect(subject.errors[:context]).not_to be_empty
+          expect(subject.errors[:context]).to include 'something went wrong'
+        end
+      end
     end
   end
 
@@ -92,6 +112,105 @@ RSpec.describe 'A basic organizer', type: :integration do
         expect_any_instance_of(test_interactor_1).to receive(:rollback)
         subject
       end
+
+      # https://github.com/aaronmallen/activeinteractor/issues/169
+      context 'with error message "something went wrong"' do
+        let!(:test_interactor_2) do
+          build_interactor('TestInteractor2') do
+            def perform
+              context.fail!('something went wrong')
+            end
+          end
+        end
+
+        it { expect { subject }.not_to raise_error }
+        it { is_expected.to be_a interactor_class.context_class }
+        it { is_expected.to be_failure }
+        it { expect(subject.errors.count).to eq 1 }
+        it 'is expected to have errors "something went wrong" on :context' do
+          expect(subject.errors[:context]).not_to be_empty
+          expect(subject.errors[:context]).to include 'something went wrong'
+        end
+      end
+    end
+  end
+
+  # https://github.com/aaronmallen/activeinteractor/issues/151
+  context 'with an interactor class having a predefined context class with attributes [:foo]' do
+    let!(:test_context_class) do
+      build_context('TestInteractor1Context') do
+        attributes :foo
+      end
+    end
+
+    # rubocop:disable Metrics/AbcSize
+    let!(:test_interactor_1) do
+      build_interactor('TestInteractor1') do
+        def perform
+          context.has_foo_as_method = context.foo.present?
+          context.has_foo_as_element = context[:foo].present?
+          context.has_bar_as_method = context.bar.present?
+          context.has_bar_as_element = context[:bar].present?
+        end
+      end
+    end
+    # rubocop:enable Metrics/AbcSize
+
+    let(:interactor_class) do
+      build_organizer do
+        organize :test_interactor_1
+      end
+    end
+
+    context 'when passing a context argument { :foo => "foo", :bar => "bar" }' do
+      let(:context_attributes) { { foo: 'foo', bar: 'bar' } }
+
+      describe '.perform' do
+        subject(:result) { interactor_class.perform(context_attributes) }
+        it { is_expected.to have_attributes(foo: 'foo', bar: 'bar') }
+
+        it 'is expected to copy all attributes in the contexts to each interactor' do
+          expect(subject.has_foo_as_method).to be true
+          expect(subject.has_foo_as_element).to be true
+          expect(subject.has_bar_as_method).to be true
+          expect(subject.has_bar_as_element).to be true
+        end
+
+        describe '#attributes' do
+          subject { result.attributes }
+
+          it { is_expected.to be_a Hash }
+          it { is_expected.to be_empty }
+        end
+      end
+
+      context 'with attributes [:foo] on the organizer context class' do
+        let!(:interactor_class) do
+          build_organizer do
+            context_attributes :foo
+            organize :test_interactor_1
+          end
+        end
+
+        describe '.perform' do
+          subject(:result) { interactor_class.perform(context_attributes) }
+          it { is_expected.to have_attributes(foo: 'foo', bar: 'bar') }
+
+          it 'is expected to copy all attributes in the contexts to each interactor' do
+            expect(subject.has_foo_as_method).to be true
+            expect(subject.has_foo_as_element).to be true
+            expect(subject.has_bar_as_method).to be true
+            expect(subject.has_bar_as_element).to be true
+          end
+
+          describe '#attributes' do
+            subject { result.attributes }
+
+            it { is_expected.to be_a Hash }
+            it { is_expected.to eq(foo: 'foo') }
+          end
+        end
+      end
     end
   end
 end

data/spec/integration/active_record_integration_spec.rb

@@ -6,356 +6,22 @@ begin
   require 'active_interactor/rails/orm/active_record'
 
   RSpec.describe 'ActiveRecord integration', type: :integration do
-    let!(:active_record_base_mock) do
-      build_class('ActiveRecordBaseMock') do
-        def self.attr_accessor(*attributes)
-          attribute_keys.concat(attributes.map(&:to_sym))
-          super
-        end
-
-        def self.attribute_keys
-          @attribute_keys ||= []
-        end
-
-        def initialize(attributes = nil, _options = {})
-          (attributes || {}).each do |key, value|
-            instance_variable_set("@#{key}", value)
-          end
-        end
-
-        def [](name)
-          instance_variable_get("@#{name}")
-        end
-
-        def []=(name, value)
-          instance_variable_set("@#{name}", value)
-        end
-
-        def attributes
-          self.class.attribute_keys.each_with_object({}) do |key, hash|
-            hash[key] = instance_variable_get("@#{key}")
-          end
-        end
-
-        def to_h
-          attributes.to_h
-        end
-      end
-    end
+    let!(:active_record_base_mock) { build_class('ActiveRecordBaseMock') }
 
     context 'after ActiveSupport.run_load_hooks has been received with :active_record' do
       before { ActiveSupport.run_load_hooks(:active_record, active_record_base_mock) }
 
-      describe 'an ActiveRecord model class with .acts_as_context' do
-        let(:model_mock) do
-          build_class('ModelMock', active_record_base_mock) do
-            attr_accessor :foo
+      describe 'an ActiveRecord model class with .acts_as_context and attribute :foo' do
+        let(:model_class) do
+          build_class('ModelClass', active_record_base_mock) do
+            include ActiveModel::Attributes
+            include ActiveModel::Model
             acts_as_context
+            attribute :foo
           end
         end
 
-        describe 'as an instance' do
-          subject { model_mock.new }
-
-          it { is_expected.to respond_to :called! }
-          it { is_expected.to respond_to :fail! }
-          it { is_expected.to respond_to :fail? }
-          it { is_expected.to respond_to :failure? }
-          it { is_expected.to respond_to :merge! }
-          it { is_expected.to respond_to :rollback! }
-          it { is_expected.to respond_to :success? }
-          it { is_expected.to respond_to :successful? }
-        end
-
-        describe '.new' do
-          subject { model_mock.new(attributes) }
-          let(:attributes) { nil }
-
-          it 'is expected not to receive #copy_flags!' do
-            expect_any_instance_of(model_mock).not_to receive(:copy_flags!)
-            subject
-          end
-
-          it 'is expected not to receive #copy_called!' do
-            expect_any_instance_of(model_mock).not_to receive(:copy_called!)
-            subject
-          end
-
-          it 'is expected to receive super on parent class with nil attributes' do
-            expect(active_record_base_mock).to receive(:new).with(nil)
-            subject
-          end
-
-          context 'with attributes { :foo => "foo" }' do
-            let(:attributes) { { foo: 'foo' } }
-
-            it { expect { subject }.not_to raise_error }
-
-            it 'is expected to receive #copy_flags!' do
-              expect_any_instance_of(model_mock).to receive(:copy_flags!).with(foo: 'foo')
-              subject
-            end
-
-            it 'is expected to receive #copy_called!' do
-              expect_any_instance_of(model_mock).to receive(:copy_called!).with(foo: 'foo')
-              subject
-            end
-
-            it 'is expected to receive super on parent class with { :foo => "foo" }' do
-              expect(active_record_base_mock).to receive(:new).with(foo: 'foo')
-              subject
-            end
-          end
-
-          context 'with attributes being an instance of ModelMock having attributes { :foo => "foo" }' do
-            let(:previous_instance) { model_mock.new(foo: 'foo') }
-            let(:attributes) { previous_instance }
-
-            it { is_expected.to have_attributes(foo: 'foo') }
-
-            context 'with _failed equal to true on previous instance' do
-              before { previous_instance.instance_variable_set('@_failed', true) }
-
-              it { is_expected.to be_failure }
-            end
-
-            context 'with _rolled_back equal to true on previous instance' do
-              before { previous_instance.instance_variable_set('@_rolled_back', true) }
-
-              it 'is expected to have instance variable @_rolled_back eq to true' do
-                expect(subject.instance_variable_get('@_rolled_back')).to eq true
-              end
-            end
-
-            context 'with _called eq to ["foo"] on previous instance' do
-              before { previous_instance.instance_variable_set('@_called', %w[foo]) }
-
-              it 'is expected to have instance variable @_called eq to ["foo"]' do
-                expect(subject.instance_variable_get('@_called')).to eq %w[foo]
-              end
-            end
-          end
-        end
-
-        describe '#merge!' do
-          subject { model_mock.new(attributes).merge!(merge_instance) }
-          context 'having attributes { :foo => nil }' do
-            let(:attributes) { { foo: nil } }
-
-            context 'with merging instance having attributes { :foo => "foo" }' do
-              let(:merge_instance) { model_mock.new(foo: 'foo') }
-
-              it { is_expected.to have_attributes(foo: 'foo') }
-
-              context 'with _failed equal to true on merging instance' do
-                before { merge_instance.instance_variable_set('@_failed', true) }
-
-                it { is_expected.to be_failure }
-              end
-
-              context 'with _rolled_back equal to true on merging instance' do
-                before { merge_instance.instance_variable_set('@_rolled_back', true) }
-
-                it 'is expected to have instance variable @_rolled_back eq to true' do
-                  expect(subject.instance_variable_get('@_rolled_back')).to eq true
-                end
-              end
-            end
-          end
-
-          context 'having attributes { :foo => "foo"}' do
-            let(:attributes) { { foo: 'foo' } }
-
-            context 'with merging instance having attributes { :foo => "bar" }' do
-              let(:merge_instance) { model_mock.new(foo: 'bar') }
-
-              it { is_expected.to have_attributes(foo: 'bar') }
-
-              context 'with _failed equal to true on merging instance' do
-                before { merge_instance.instance_variable_set('@_failed', true) }
-
-                it { is_expected.to be_failure }
-              end
-
-              context 'with _rolled_back equal to true on merging instance' do
-                before { merge_instance.instance_variable_set('@_rolled_back', true) }
-
-                it 'is expected to have instance variable @_rolled_back eq to true' do
-                  expect(subject.instance_variable_get('@_rolled_back')).to eq true
-                end
-              end
-            end
-          end
-        end
-      end
-
-      describe 'a basic interactor using an ActiveRecord model class as context' do
-        let!(:model_mock) do
-          require 'active_model'
-          build_class('ModelMock', active_record_base_mock) do
-            include ActiveModel::Validations
-            attr_accessor :foo
-            acts_as_context
-          end
-        end
-
-        let(:interactor_class) do
-          build_interactor do
-            contextualize_with :model_mock
-
-            def perform
-              context.foo = 'foo'
-            end
-          end
-        end
-
-        include_examples 'a class with interactor methods'
-        include_examples 'a class with interactor callback methods'
-        include_examples 'a class with interactor context methods'
-
-        describe '.context_class' do
-          subject { interactor_class.context_class }
-
-          it { is_expected.to eq model_mock }
-        end
-
-        describe '.perform' do
-          subject { interactor_class.perform }
-
-          it { is_expected.to be_a model_mock }
-          it { is_expected.to be_successful }
-          it { is_expected.to have_attributes(foo: 'foo') }
-        end
-
-        describe '.perform!' do
-          subject { interactor_class.perform! }
-
-          it { expect { subject }.not_to raise_error }
-          it { is_expected.to be_a model_mock }
-          it { is_expected.to be_successful }
-          it { is_expected.to have_attributes(foo: 'foo') }
-        end
-
-        context 'failing the context on #perform' do
-          let(:interactor_class) do
-            build_interactor do
-              contextualize_with :model_mock
-
-              def perform
-                context.fail!
-              end
-            end
-          end
-
-          describe '.perform' do
-            subject { interactor_class.perform }
-
-            it { expect { subject }.not_to raise_error }
-            it { is_expected.to be_a model_mock }
-            it { is_expected.to be_failure }
-            it 'is expected to receive #rollback' do
-              expect_any_instance_of(interactor_class).to receive(:rollback)
-              subject
-            end
-          end
-
-          describe '.perform!' do
-            subject { interactor_class.perform! }
-
-            it { expect { subject }.to raise_error(ActiveInteractor::Error::ContextFailure) }
-          end
-        end
-      end
-
-      describe 'a basic organizer using an ActiveRecord model class as context' do
-        let!(:model_mock) do
-          require 'active_model'
-          build_class('ModelMock', active_record_base_mock) do
-            include ActiveModel::Validations
-            attr_accessor :first_name, :last_name
-            acts_as_context
-          end
-        end
-
-        context 'with each organized interactor using the model' do
-          let!(:test_interactor_1) do
-            build_interactor('TestInteractor1') do
-              contextualize_with :model_mock
-
-              def perform
-                context.first_name = 'Test'
-              end
-            end
-          end
-
-          let!(:test_interactor_2) do
-            build_interactor('TestInteractor2') do
-              contextualize_with :model_mock
-
-              def perform
-                context.last_name = 'User'
-              end
-            end
-          end
-
-          let(:interactor_class) do
-            build_organizer do
-              contextualize_with :model_mock
-              organize :test_interactor_1, :test_interactor_2
-            end
-          end
-
-          include_examples 'a class with interactor methods'
-          include_examples 'a class with interactor callback methods'
-          include_examples 'a class with interactor context methods'
-          include_examples 'a class with organizer callback methods'
-
-          describe '.perform' do
-            subject { interactor_class.perform }
-
-            it { is_expected.to be_a model_mock }
-            it { is_expected.to be_successful }
-            it { is_expected.to have_attributes(first_name: 'Test', last_name: 'User') }
-          end
-        end
-
-        context 'with each organized interactor using their default context' do
-          let!(:test_interactor_1) do
-            build_interactor('TestInteractor1') do
-              def perform
-                context.first_name = 'Test'
-              end
-            end
-          end
-
-          let!(:test_interactor_2) do
-            build_interactor('TestInteractor2') do
-              def perform
-                context.last_name = 'User'
-              end
-            end
-          end
-
-          let(:interactor_class) do
-            build_organizer do
-              contextualize_with :model_mock
-              organize :test_interactor_1, :test_interactor_2
-            end
-          end
-
-          include_examples 'a class with interactor methods'
-          include_examples 'a class with interactor callback methods'
-          include_examples 'a class with interactor context methods'
-          include_examples 'a class with organizer callback methods'
-
-          describe '.perform' do
-            subject { interactor_class.perform }
-
-            it { is_expected.to be_a model_mock }
-            it { is_expected.to be_successful }
-            it { is_expected.to have_attributes(first_name: 'Test', last_name: 'User') }
-          end
-        end
+        include_examples 'A class that extends ActiveInteractor::Models'
       end
     end
   end