activeinsights 0.1.3 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 224f2e05720b4f7ed167aef5cb469c741f38092d6151b6654087ad8b2f9d1c97
-  data.tar.gz: 4c78b34bfd30da47e0583752f814211a6bc0d26aa6715312a726a9b9b36b1e58
+  metadata.gz: dadcb3ff31dcb9021bea6a79dbbe8c2e9de03a268a0c82f6a36158bd513c9f2a
+  data.tar.gz: 6c99fafe1e426fbd8de6fbe53c889e5bd780a4d5b37fdc110665e0eddff0ae0a
 SHA512:
-  metadata.gz: c6718d87d6db17476c8ecc4c9738bc3069064a0a842afbc01d6279993515607a67cf6d41535b32a93bebd7097869871fd19f28662093df3851aae2b11e88ef51
-  data.tar.gz: fdf1d55c14ed9d7ec9c98e7f98c71aa9e9e5bcf6520ff4c728412ea3199cb9f9e95c06f5733c7fb3c84b8e554f1d2576895fc63ebad8387dfb624a902d972091
+  metadata.gz: 732e3356cdcb0d23798fc0a5c3f6414b3f1f7e1fa5226b1d27b100f58a7081190fdb5dec27ae71b836beee660cd0dfe3e26ed9c1d9d2cb8d089e22787a4ef649
+  data.tar.gz: 03a8cd017f4fa4b5da97825a2ad2414a4e18b4ec771f14ff38e9bf90d9afa6f40e50f9ea262c90e354fea3baf0d4184bde4aeea15eae77ab7e93dd98666c1a1a

data/README.md

@@ -48,6 +48,12 @@ options for the `Request` model.
 ActiveInsights.connects_to = { database: { writing: :requests, reading: :requests } }
 ```
 
+You can supply an array of ignored endpoints
+
+```ruby
+ActiveInsights.ignored_endpoints = ["Rails::HealthController#show"]
+```
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run

data/app/controllers/active_insights/application_controller.rb

@@ -24,5 +24,14 @@ module ActiveInsights
         Date.current
       end.beginning_of_day
     end
+
+    def base_scope
+      scope = ActiveInsights::Request.where(started_at: @date)
+      if ActiveInsights.ignored_endpoints.present?
+        scope = scope.where.
+                not(formatted_controller: ActiveInsights.ignored_endpoints)
+      end
+      scope
+    end
   end
 end

data/app/controllers/active_insights/controller_p_values_controller.rb

@@ -17,8 +17,7 @@ module ActiveInsights
 
     def minutes
       @minutes ||=
-        ActiveInsights::Request.where(started_at: @date).
-        where(formatted_controller: params[:formatted_controller]).
+        base_scope.where(formatted_controller: params[:formatted_controller]).
         minute_by_minute.with_durations.select_started_at
     end
   end

data/app/controllers/active_insights/p_values_controller.rb

@@ -15,9 +15,7 @@ module ActiveInsights
     private
 
     def minutes
-      @minutes ||=
-        ActiveInsights::Request.where(started_at: @date).
-        minute_by_minute.with_durations.select_started_at
+      @minutes ||= base_scope.minute_by_minute.with_durations.select_started_at
     end
   end
 end

data/app/controllers/active_insights/requests_controller.rb

@@ -4,10 +4,8 @@ module ActiveInsights
   class RequestsController < ApplicationController
     def index
       @requests =
-        ActiveInsights::Request.where(started_at: @date).
-        with_durations.select(:formatted_controller).
-        group(:formatted_controller).
-        sort_by { |model| model.durations.count(",") + 1 }.reverse
+        base_scope.with_durations.select(:formatted_controller).
+        group(:formatted_controller).sort_by(&:agony).reverse
     end
   end
 end

data/app/controllers/active_insights/rpm_controller.rb

@@ -4,9 +4,10 @@ module ActiveInsights
   class RpmController < ApplicationController
     def index
       @minutes =
-        ActiveInsights::Request.where(started_at: @date).
-        minute_by_minute.select("COUNT(id) AS rpm").select_started_at.
-        map { |minute| [minute.started_at.strftime("%-l:%M%P"), minute.rpm] }
+        base_scope.minute_by_minute.select("COUNT(id) AS rpm").
+        select_started_at.map do |minute|
+          [minute.started_at.strftime("%-l:%M%P"), minute.rpm]
+        end
     end
 
     def redirection

data/app/helpers/active_insights/application_helper.rb

@@ -39,7 +39,7 @@ module ActiveInsights
     private
 
     def percentile_value(data, percentile)
-      value = data[(percentile * data.size).ceil - 1]
+      value = data.sort[(percentile * data.size).ceil - 1]
 
       value&.round(1) || "N/A"
     end

data/app/models/active_insights/request.rb

@@ -4,10 +4,12 @@ module ActiveInsights
   class Request < ::ActiveInsights::Record
     scope :with_durations, lambda {
       case connection.adapter_name
-      when "SQLite", "Mysql2", "Mysql2Spatial", "Mysql2Rgeo", "Trilogy"
-        select("GROUP_CONCAT(duration) AS durations")
+      when "SQLite"
+        select("JSON_GROUP_ARRAY(duration) AS durations")
+      when "Mysql2", "Mysql2Spatial", "Mysql2Rgeo", "Trilogy"
+        select("JSON_ARRAYAGG(duration) AS durations")
       when "PostgreSQL"
-        select("STRING_AGG(CAST(duration AS varchar), ',') AS durations")
+        select("JSON_AGG(duration) AS durations")
       end
     }
     scope :minute_by_minute, lambda {
@@ -42,7 +44,11 @@ module ActiveInsights
     def parsed_durations
       return unless respond_to?(:durations)
 
-      @parsed_durations ||= durations.split(",").map(&:to_f).sort
+      @parsed_durations ||=
+        if durations.is_a?(Array) then durations
+        else
+          JSON.parse(durations)
+        end.sort
     end
 
     def pretty_started_at

data/app/views/active_insights/requests/index.html.erb

@@ -41,7 +41,7 @@
     </tr>
   </thead>
   <tbody>
-    <% @requests.sort_by(&:agony).reverse.each do |model| %>
+    <% @requests.each do |model| %>
       <tr>
         <td><%= link_to model.formatted_controller, controller_p_values_path(@date.first.to_date, model.formatted_controller) %></td>
         <td><%= per_minute(model.parsed_durations.size, (@date.last - @date.first).seconds) %></td>

data/lib/active_insights/engine.rb

@@ -20,7 +20,8 @@ module ActiveInsights
       ActiveSupport::Notifications.
         subscribe("process_action.action_controller") do |_name,
           started, finished, unique_id, payload|
-        next if Rails.env.development?
+        next if Rails.env.development? ||
+          ActiveInsights.ignored_endpoint?(payload)
 
         Thread.new do
           ActiveRecord::Base.connection_pool.with_connection do

data/lib/active_insights/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveInsights
-  VERSION = "0.1.3"
+  VERSION = "0.2.0"
 end

data/lib/active_insights.rb

@@ -7,5 +7,11 @@ require "active_insights/version"
 require "active_insights/engine"
 
 module ActiveInsights
-  mattr_accessor :connects_to
+  mattr_accessor :connects_to, :ignored_endpoints
+
+  def self.ignored_endpoint?(payload)
+    ignored_endpoints.to_a.include?(
+      "#{payload[:controller]}##{payload[:action]}"
+    )
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activeinsights
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.2.0
 platform: ruby
 authors:
 - Nick Pezza