activeinsights 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 224f2e05720b4f7ed167aef5cb469c741f38092d6151b6654087ad8b2f9d1c97
-  data.tar.gz: 4c78b34bfd30da47e0583752f814211a6bc0d26aa6715312a726a9b9b36b1e58
+  metadata.gz: 357a2bfdbba595c8b40f5a63b2417d49bc6f4288c688e0d75ab77ba378cd078e
+  data.tar.gz: 52e2ad59d758b76ad46aa01cf592a3365dfe3baa407556196acbc027cbec121a
 SHA512:
-  metadata.gz: c6718d87d6db17476c8ecc4c9738bc3069064a0a842afbc01d6279993515607a67cf6d41535b32a93bebd7097869871fd19f28662093df3851aae2b11e88ef51
-  data.tar.gz: fdf1d55c14ed9d7ec9c98e7f98c71aa9e9e5bcf6520ff4c728412ea3199cb9f9e95c06f5733c7fb3c84b8e554f1d2576895fc63ebad8387dfb624a902d972091
+  metadata.gz: fc8e3e23c6d340f047392bf9f21cd8e1bc1b255d9d072e7f30f4b2494d639522e3f1276021461ff87649c48bc0c61854ba234422ad2e508e0efbced367a28ab0
+  data.tar.gz: 1f184e727faf3f5a50ecc017158ee97058b5de3dacb4d8e0b8d3ba9d4725f62f245a4220d47a9221fb6dbfcbe700943c92f213ca4c58e2ef15586f22238d60b0

data/app/controllers/active_insights/requests_controller.rb

@@ -7,7 +7,7 @@ module ActiveInsights
         ActiveInsights::Request.where(started_at: @date).
         with_durations.select(:formatted_controller).
         group(:formatted_controller).
-        sort_by { |model| model.durations.count(",") + 1 }.reverse
+        sort_by(&:agony).reverse
     end
   end
 end

data/app/helpers/active_insights/application_helper.rb

@@ -39,7 +39,7 @@ module ActiveInsights
     private
 
     def percentile_value(data, percentile)
-      value = data[(percentile * data.size).ceil - 1]
+      value = data.sort[(percentile * data.size).ceil - 1]
 
       value&.round(1) || "N/A"
     end

data/app/models/active_insights/request.rb

@@ -4,10 +4,12 @@ module ActiveInsights
   class Request < ::ActiveInsights::Record
     scope :with_durations, lambda {
       case connection.adapter_name
-      when "SQLite", "Mysql2", "Mysql2Spatial", "Mysql2Rgeo", "Trilogy"
-        select("GROUP_CONCAT(duration) AS durations")
+      when "SQLite"
+        select("JSON_GROUP_ARRAY(duration) AS durations")
+      when "Mysql2", "Mysql2Spatial", "Mysql2Rgeo", "Trilogy"
+        select("JSON_ARRAYAGG(duration) AS durations")
       when "PostgreSQL"
-        select("STRING_AGG(CAST(duration AS varchar), ',') AS durations")
+        select("JSON_AGG(duration) AS durations")
       end
     }
     scope :minute_by_minute, lambda {
@@ -42,7 +44,11 @@ module ActiveInsights
     def parsed_durations
       return unless respond_to?(:durations)
 
-      @parsed_durations ||= durations.split(",").map(&:to_f).sort
+      @parsed_durations ||=
+        if durations.is_a?(Array) then durations
+        else
+          JSON.parse(durations)
+        end.sort
     end
 
     def pretty_started_at

data/app/views/active_insights/requests/index.html.erb

@@ -41,7 +41,7 @@
     </tr>
   </thead>
   <tbody>
-    <% @requests.sort_by(&:agony).reverse.each do |model| %>
+    <% @requests.each do |model| %>
       <tr>
         <td><%= link_to model.formatted_controller, controller_p_values_path(@date.first.to_date, model.formatted_controller) %></td>
         <td><%= per_minute(model.parsed_durations.size, (@date.last - @date.first).seconds) %></td>

data/lib/active_insights/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveInsights
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activeinsights
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Nick Pezza