activehook 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f3a59808084220469fb34637c67bf5e9f262e631
-  data.tar.gz: 791adea3103be50f0b47ae4a1bcc85456271279b
+  metadata.gz: a9bdd9c58667318f072b3bb500d48e3595927593
+  data.tar.gz: f715fdbb3226983ab489aa310166c58b8e922481
 SHA512:
-  metadata.gz: 40f0470b5c5239cc3f7ea56cb20c458239d72ada5180327ac45356ab32357ee0770d66a8c23691619ba4d2eeca3dff0df0e133154384803ed90189b0f450a2a9
-  data.tar.gz: e9cd328d156e39b4d9478fb3aa8740d5999404629ac0adae3a8c0c67b8e55071168a98ba8c7c843b6e46a34b8c9d47ac95b5d0e1dae3b920f831e605342c1524
+  metadata.gz: dfa8fe137d40397d8f25ea78d86a48b9041fb24374aec759112efdc48eae8b27e4fccc459efca48c9b27db9a3b4767e8de28aa345e398beae4b58ba437cc2393
+  data.tar.gz: 31772720c13d69ad9a4bb9445283eecab98af8294d1c487e8d74fdf31b757975a5ba80788c552b590dce004beb7ceff7d23f50de7ca7471de84a34dc066d5284

data/README.md

@@ -1,12 +1,12 @@
 # ActiveHook
 ---
 
-Fast and simple webhook microservice for Ruby. **Please consider it under development at the moment.**
+Fast and simple webhook delivery microservice for Ruby. **Please consider it under development at the moment.**
 
 ActiveHook provides a scalable solution to your applications webhook sending needs. Its Redis-backed, with support for forking and threading - letting it send an enormous amount of webhooks in short order. Basically a much more focused version of a job processor such as Sidekiq, DelayedJob, Resque, etc. It includes the following:
 
-- A server for the purpose of sending webhooks.
-- A mixin module for the purpose of recieving and validating webhooks.
+- A server for the purpose of sending webhooks. With support for retry attempts.
+- A client-side mixin module for the purpose of recieving and validating webhooks.
 - A piece of Rack middleware for the purpose of performing validation.
 
 ## Installation
@@ -155,13 +155,19 @@ end
 
 Sending webhooks is one thing - ensuring they are from who we want is another.
 
-ActiveHook includes a piece of Rack middleware for the purpose of validation. When a client attempts to validate a webhook, they are sending a message back to your server. The message includes the hooks ID as well as key. These are are then cross-referenced. If they match, we provide the AOK.
+ActiveHook includes a piece of Rack middleware for the purpose of validation. When a client attempts to validate a webhook, they are sending a message back to your server. The message includes the hooks ID as well as key. These are are then cross-referenced with the server records. If they match, we provide the AOK.
+
+We set the address that the middleware uses from our config file (App mode config described above):
+
+```ruby
+config.validation_path = '/hooks/validate'
+```
 
 In Rails, we would add the middleware like this:
 
 ```ruby
 # In config/application.rb
-config.middleware.use ActiveHook::App::Middleware
+config.middleware.use('ActiveHook::App::Middleware')
 ```
 
 Or with Rackup files:

data/lib/activehook/app/middleware.rb

@@ -1,15 +1,6 @@
 module ActiveHook
   module App
     class Middleware
-      class << self
-        attr_accessor :valid, :invalid, :not_created, :created
-      end
-
-      @invalid      = ->(_env) { [400, { "Content-Type" => "application/json" }, [{ valid: false }.to_json]] }
-      @valid        = ->(_env) { [200, { "Content-Type" => "application/json" }, [{ valid: true }.to_json]] }
-      @not_created  = ->(_env) { [400, { "Content-Type" => "application/json" }, [{ status: false }.to_json]] }
-      @created      = ->(_env) { [200, { "Content-Type" => "application/json" }, [{ status: true }.to_json]] }
-
       def initialize(app)
         @app = app
       end
@@ -18,8 +9,9 @@ module ActiveHook
         @env = env
         @req = Rack::Request.new(env)
 
-        if validation_request? then valid?
-        elsif creation_request? then create?
+        if validation_request? then response(Validation)
+        #Not enabling webhook creation yet.
+        #elsif creation_request? then response(Creation)
         else @app.call(@env)
         end
       end
@@ -32,35 +24,27 @@ module ActiveHook
         @req.path == ActiveHook.config.creation_path && @req.post?
       end
 
-      def valid?
-        if Validation.new(@req.params).start
-          self.class.valid.call(@env)
-        else
-          self.class.invalid.call(@env)
-        end
-      end
-
-      def create?
-        if Creation.new(@req.params).start
-          self.class.created.call(@env)
-        else
-          self.class.not_created.call(@env)
-        end
+      def response(klass)
+        response =
+          if klass.new(@req).start then { code: 200, status: true }
+          else { code: 400, status: false }
+          end
+        [response[:code], { "Content-Type" => "application/json" }, [{ status: response[:status] }.to_json]]
       end
     end
 
-    Validation = Struct.new(:params) do
+    Validation = Struct.new(:req) do
       def start
-        hook = { id: params['id'].to_i, key: params['key'] }
+        hook = { id: req.params['id'].to_i, key: req.params['key'] }
         ActiveHook::Validate.new(hook).perform
       rescue
         false
       end
     end
 
-    Creation = Struct.new(:params) do
+    Creation = Struct.new(:req) do
       def start
-        hook = { uri: params['uri'], payload: JSON.parse(params['payload']) }
+        hook = JSON.parse(req.body.read)
         ActiveHook::Hook.new(hook).perform
       rescue
         false

data/lib/activehook/version.rb

@@ -1,4 +1,4 @@
 module ActiveHook
-  VERSION = '0.1.3'
+  VERSION = '0.1.4'
   CODENAME = 'Fat Sparrow'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activehook
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Nicholas Sweeting
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-23 00:00:00.000000000 Z
+date: 2016-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis