activegraph 10.0.0 → 10.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 66259444a09dbe560ec1a284b7c1988b24eaf4b29386efb63664cef081edf520
-  data.tar.gz: ec43759b43c92f62a93589225207e0d37ef1d18ee4b61d5f4f204b89b8985787
+  metadata.gz: e434fda5c1ab2cf1ad9d3d859cec6fc31d7b076fefcf3ead00dd5890849436a1
+  data.tar.gz: 1d0827473f9f6c0e6000fd0da3175f6721c1e11d146734b58d9a3c216502b973
 SHA512:
-  metadata.gz: ec40cecc16c133c065672a3aa37360c304bba5cf24fe430dda7a789885262a7b239b798a7998b6d96b34ba8d05d5d0376c134dc829d6db0800e392fb740c0ec7
-  data.tar.gz: 9f7fc129cf6916cdf69373ebb789ff7bc5f6c38c675d3e51403c4b0e6e7135a9649cfb2f3f754634507979a371de2a6a16f8670c765e38a016627c21f04e8535
+  metadata.gz: d260e538a8121c313d08a51893a773ba2e7e6d7c6f0cf9e1a99f2f28da656c5192779e408f02cb7c8f399e9dbe427ed67ff6df5cf2f406a727ebb2259549c113
+  data.tar.gz: 40b4a2bbdc71d888447f9b2c057cdb3d0c5b5f75f783e6a61fa04defc8916908e7dc3aee2f09c8261bd9e851c67c270b1eef920fff1039cdaa68d4a023291dff

data/CHANGELOG.md

@@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file.
 This file should follow the standards specified on [http://keepachangelog.com/]
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## [10.0.1] 2020-07-26
+
+## Fixed
+
+- fixed incorrect id comparison, which could result in lost relationships (https://github.com/neo4jrb/activegraph/issues/1611)
+- brought back BigDecimalConverter
+- fixed rails template (Thanks @ekampp)
+
 ## [10.0.0] 2020-07-06
 
 - neo4j 4.0 support (default database only)

data/lib/active_graph/node/query/query_proxy_methods_of_mass_updating.rb

@@ -49,31 +49,20 @@ module ActiveGraph
         # Deletes the relationships between all nodes for the last step in the QueryProxy chain and replaces them with relationships to the given nodes.
         # Executed in the database, callbacks will not be run.
         def replace_with(node_or_nodes)
-          node_hash = idify_hash(node_or_nodes)
+          node_or_nodes = Array(node_or_nodes).map { |arg| arg.is_a?(ActiveGraph::Node) ? arg : @model.find(arg) }
           original_ids = self.pluck(:id)
-          new_nodes = add_rels(node_hash, original_ids)
-          delete_rels_for_nodes(original_ids - node_hash.keys)
-          new_nodes | node_hash.values
+          delete_rels_for_nodes(original_ids, node_or_nodes.collect(&:id))
+          add_rels(node_or_nodes, original_ids)
         end
 
-        def idify_hash(args)
-          Array(args).reject(&:blank?).flatten.each_with_object({}).with_index do |(arg, hash), inx|
-            if arg.is_a?(Integer) || arg.is_a?(String)
-              hash[arg.to_i] = @model.find(arg)
-            else
-              key = arg.persisted? ? arg.id : "tmp_#{inx}"
-              hash[key] = arg
-            end
-          end
-        end
-
-        def add_rels(node_hash, original_ids)
-          (node_hash.keys - original_ids).map do |id|
-            node_hash[id] if _create_relation_or_defer(node_hash[id])
+        def add_rels(node_or_nodes, original_ids)
+          node_or_nodes.map do |obj|
+            obj if original_ids.include?(obj.id) || _create_relation_or_defer(obj)
           end.compact
         end
 
-        def delete_rels_for_nodes(ids)
+        def delete_rels_for_nodes(original_ids, new_ids)
+          ids = original_ids.select { |id| !new_ids.include?(id) }
           return unless ids.present?
           if association.dependent
             start_object.public_send("dependent_#{association.dependent}_callback", association, ids)

data/lib/active_graph/shared/type_converters.rb

@@ -69,6 +69,33 @@ module ActiveGraph::Shared
       end
     end
 
+    class BigDecimalConverter < BaseConverter
+      class << self
+        def convert_type
+          BigDecimal
+        end
+
+        def db_type
+          String
+        end
+
+        def to_db(value)
+          case value
+          when Rational
+            value.to_f.to_d
+          when respond_to?(:to_d)
+            value.to_d
+          else
+            BigDecimal(value.to_s)
+          end.to_s
+        end
+
+        def to_ruby(value)
+          value.to_d
+        end
+      end
+    end
+
     class StringConverter < BaseConverter
       class << self
         def convert_type

data/lib/active_graph/version.rb

@@ -1,3 +1,3 @@
 module ActiveGraph
-  VERSION = '10.0.0'
+  VERSION = '10.0.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activegraph
 version: !ruby/object:Gem::Version
-  version: 10.0.0
+  version: 10.0.1
 platform: ruby
 authors:
 - Andreas Ronge, Brian Underwood, Chris Grigg, Heinrich Klobuczek
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-07-07 00:00:00.000000000 Z
+date: 2020-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -394,7 +394,7 @@ metadata:
   changelog_uri: https://github.com/neo4jrb/activegraph/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/neo4jrb/activegraph/
   bug_tracker_uri: https://github.com/neo4jrb/activegraph/issues
-post_install_message: 
+post_install_message:
 rdoc_options:
 - "--quiet"
 - "--title"
@@ -417,7 +417,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.2
-signing_key: 
+signing_key:
 specification_version: 4
 summary: A graph database for Ruby
 test_files: []