activefacts-cql 1.7.1

data/lib/activefacts/cql/compiler/expression.rb

@@ -0,0 +1,443 @@
+module ActiveFacts
+  module CQL
+    class Compiler
+
+      # An Operation is a binary or ternary fact type involving an operator,
+      # a result, and one or two operands.
+      # Viewed as a result, it behaves like a Reference with a nested Clause.
+      # Viewed as a fact type, it behaves like a Clause.
+      #
+      # The only exception here is an equality comparison, where it may
+      # turn out that the equality is merely a projection. In this case
+      # the Operation is dropped from the clauses and is replaced by the
+      # projected operand.
+      #
+      # Each operand may be a Literal, a Reference, or another Operation,
+      # so we need to recurse down the tree to build the query.
+      #
+      class Operation
+        # Reference (in)compatibility:
+        [ :term, :leading_adjective, :trailing_adjective, :role_name, :quantifier,
+          :value_constraint, :embedded_presence_constraint, :literal
+        ].each do |s|
+          define_method(s) { raise "Unexpected call to Operation\##{s}" }
+          define_method(:"#{s}=") { raise "Unexpected call to Operation\##{s}=" }
+        end
+        def role_name; nil; end
+        def leading_adjective; nil; end
+        def trailing_adjective; nil; end
+        def value_constraint; nil; end
+        def literal; nil; end
+	def side_effects; nil; end
+        attr_accessor :player     # What ObjectType does the Binding denote
+        attr_accessor :binding    # What Binding for that ObjectType
+        attr_accessor :clause     # What clause does the result participate in?
+        attr_accessor :role       # Which Role of this ObjectType
+        attr_accessor :role_ref   # Which RoleRef to that Role
+        attr_accessor :certainty  # nil, true, false -> maybe, definitely, not
+        def nested_clauses; @nested_clauses ||= [self]; end
+        def clause; self; end
+        def objectification_of; @fact_type; end
+        # Clause (in)compatibility:
+        [ :phrases, :qualifiers, :context_note, :reading, :role_sequence, :fact
+        ].each do |s|
+          define_method(s) { raise "Unexpected call to Operation\##{s}" }
+          define_method(:"#{s}=") { raise "Unexpected call to Operation\##{s}=" }
+        end
+        def conjunction; nil; end
+        attr_reader :fact_type
+        def objectified_as; self; end   # The Reference which objectified this fact type
+
+	def initialize
+	  @certainty = true	  # Assume it's definite
+	end
+
+        def operands context = nil
+          raise "REVISIT: Implement operand enumeration in the operator subclass #{self.class.name}"
+        end
+
+        def identify_players_with_role_name context
+          # Just recurse, there's no way (yet: REVISIT?) to add a role name to the result of an expression
+          refs.each { |o|
+            o.identify_players_with_role_name(context)
+          }
+          # As yet, an operation cannot have a role name:
+          # identify_player context if role_name
+        end
+
+        def identify_other_players context
+          # Just recurse, there's no way (yet: REVISIT?) to add a role name to the result of an expression
+          refs.each { |o|
+            o.identify_other_players(context)
+          }
+          identify_player context
+        end
+
+        def bind context
+          refs.each do |o|
+            o.bind context
+          end
+          name = result_type_name(context)
+          @player = result_value_type(context, name)
+          key = "#{name} #{object_id}"  # Every Operation result is a unique Binding
+          @binding = (context.bindings[key] ||= Binding.new(@player))
+          @binding.refs << self
+          @binding
+        end
+
+        def result_type_name(context)
+          raise "REVISIT: Implement result_type_name in the #{self.class.name} subclass"
+        end
+
+        def result_value_type(context, name)
+          vocabulary = context.vocabulary
+          constellation = vocabulary.constellation
+	  vocabulary.valid_value_type_name(name) ||
+	    constellation.ValueType(vocabulary, name, :concept => :new)
+        end
+
+        def is_naked_object_type
+          false # All Operations are non-naked
+        end
+
+        def match_existing_fact_type context
+          opnds = refs
+          result_ref = Reference.new(@binding.player.name)
+          result_ref.player = @binding.player
+          result_ref.binding = @binding
+          @binding.refs << result_ref
+          clause_ast = Clause.new(
+            [result_ref, '='] +
+              (opnds.size > 1 ? [opnds[0]] : []) +
+              [operator, opnds[-1]]
+          )
+
+          # REVISIT: All operands must be value-types or simply-identified Entity Types.
+
+          # REVISIT: We should auto-create steps from Entity Types to an identifying ValueType
+          # REVISIT: We should traverse up the supertype of ValueTypes to find a DataType
+          @fact_type = clause_ast.match_existing_fact_type(context, :exact_type => true)
+	  if clause.certainty == false
+	    raise "Negated fact types in expressions are not yet supported: #{clause.inspect}"
+	  end
+          return @fact_type if @fact_type
+
+          @fact_type = clause_ast.make_fact_type context.vocabulary
+          reading = clause_ast.make_reading context.vocabulary, @fact_type
+          rrs = reading.role_sequence.all_role_ref_in_order
+          opnds[0].role_ref = rrs[0]
+          opnds[-1].role_ref = rrs[-1]
+          opnds.each do |opnd|
+            next unless opnd.is_a?(Operation)
+            opnd.match_existing_fact_type context
+	    if opnd.certainty == false
+	      raise "Negated fact types in expressions are not yet supported: #{opnd.inspect}"
+	    end
+          end
+          @fact_type
+        end
+
+        def is_equality_comparison
+          false
+        end
+
+        def operator
+          raise "REVISIT: Implement operator access in the operator subclass #{self.class.name}"
+        end
+
+      end
+
+      class Comparison < Operation
+        attr_accessor :operator, :e1, :e2, :qualifiers, :conjunction
+
+        def initialize operator, e1, e2, certainty = true
+          @operator, @e1, @e2, @certainty, @qualifiers = operator, e1, e2, certainty, []
+        end
+
+        def refs
+          [@e1, @e2]
+        end
+
+        def bind context
+          refs.each do |o|
+            o.bind context
+          end
+
+          # REVISIT: Return the projected binding instead:
+          return @result = nil if @projection
+
+          name = 'Boolean'
+          @player = result_value_type(context, name)
+          key = "#{name} #{object_id}"  # Every Comparison result is a unique Binding
+          @binding = (context.bindings[key] ||= Binding.new(@player))
+          @binding.refs << self
+          @binding
+        end
+
+        def result_type_name(context)
+          "COMPARE#{operator}<#{[@e1,@e2].map{|e| e.player.name}*' WITH '})>"
+        end
+
+        def is_equality_comparison
+          @operator == '='
+        end
+
+        def identify_player context
+          @player || begin
+            if @projection
+              raise "REVISIT: The player is the projected expression"
+            end
+            v = context.vocabulary
+            @boolean ||=
+	      v.constellation.ValueType[[[v.name], 'Boolean']] ||
+	      v.constellation.ValueType(v, 'Boolean', :concept => :new)
+            @player = @boolean
+          end
+        end
+
+=begin
+        def project lr
+          @projection = lr
+          projected_rr = lr == :left ? @e2 : @e1
+          true
+        end
+=end
+
+        def inspect; to_s; end
+
+        def to_s
+          "COMPARE#{
+	    operator
+	  }(#{
+	    case @certainty
+	    when nil; 'maybe '
+	    when false; 'negated '
+	    # else 'definitely '
+	    end
+          }#{
+	    e1.to_s
+	  } WITH #{
+	    e2.to_s
+	  }#{
+	    @qualifiers.empty? ? '' : ', ['+@qualifiers*', '+']'
+	  })"
+        end
+      end
+
+      class Sum < Operation
+        attr_accessor :terms
+        def initialize *terms
+          @terms = terms
+        end
+
+        def refs
+          @terms
+        end
+
+        def operator
+          '+'
+        end
+
+        def identify_player context
+          @player || begin
+            # The players in the @terms have already been identified
+            # REVISIT: Check compliance of all units in @terms, and apply conversions where necessary
+            # REVISIT: The type of this result should be derived from type promotion rules. Here, we take the left-most.
+            # REVISIT: We should define a subtype of the result type here, and apply the units to it.
+            v = context.vocabulary
+            @player = @terms[0].player
+            @player
+          end
+        end
+
+        def result_type_name(context)
+          "SUM_OF<#{ @terms.map{|f| f.player.name}*', ' }>"
+        end
+
+=begin
+        def result_value_type(context, name)
+          # REVISIT: If there are units involved, check compatibility
+          vt = super
+          vt
+        end
+=end
+
+        def inspect; to_s; end
+
+        def to_s
+          'SUM(' + @terms.map{|term| "#{term.to_s}" } * ' PLUS ' + ')'
+        end
+      end
+
+      class Product < Operation
+        attr_accessor :factors
+        def initialize *factors
+          @factors = factors
+        end
+
+        def refs
+          @factors
+        end
+
+        def operator
+          '*'
+        end
+
+        def identify_player context
+          @player || begin
+            # The players in the @factors have already been identified
+            # REVISIT: Calculate the units of the result from the units in @factors
+            # REVISIT: The type of this result should be derived from type promotion rules. Here, we take the left-most.
+            # REVISIT: We should define a subtype of the result type here, and apply the units to it.
+            v = context.vocabulary
+            @player = @factors[0].player
+          end
+        end
+
+        def result_type_name(context)
+          "PRODUCT_OF<#{ @factors.map{|f| f.player.name}*' ' }>"
+        end
+
+=begin
+        def result_value_type(context, name)
+          vt = super
+          # REVISIT: If there are units involved, create the result units
+          vt
+        end
+=end
+
+        def inspect; to_s; end
+
+        def to_s
+          'PRODUCT(' + @factors.map{|factor| "#{factor.to_s}" } * ' TIMES ' + ')'
+        end
+      end
+
+      class Reciprocal < Operation
+        attr_accessor :divisor
+        def initialize divisor
+          @divisor = divisor
+        end
+
+        def operator
+          '1/'
+        end
+
+        def refs
+          [@divisor]
+        end
+
+        def identify_player context
+          @player || begin
+            # The player in @divisor has already been identified
+            # REVISIT: Calculate the units of the result from the units in @divisor
+            # REVISIT: Do we want integer division?
+            v = context.vocabulary
+            @player = v.constellation.ValueType(v, 'Real', :concept => :new)
+          end
+        end
+
+=begin
+        def result_type_name(context)
+          raise hell
+        end
+=end
+
+        def inspect; to_s; end
+
+        def to_s
+          "RECIPROCAL(#{factor.to_s})"
+        end
+      end
+
+      class Negate
+        attr_accessor :term
+        def initialize term
+          @term = term
+        end
+
+        def operator
+          '0-'
+        end
+
+        def identify_player context
+          @player || begin
+            # The player in @term have already been identified
+            v = context.vocabulary
+            @player = @term.player
+          end
+        end
+
+=begin
+        def result_type_name(context)
+          raise hell
+        end
+=end
+
+        def inspect; to_s; end
+
+        def to_s
+          "NEGATIVE(#{term.to_s})"
+        end
+      end
+
+      class Literal
+        attr_accessor :literal, :unit, :role, :role_ref, :clause
+        attr_reader :objectification_of, :leading_adjective, :trailing_adjective, :value_constraint
+
+        def initialize literal, unit
+          @literal, @unit = literal, unit
+        end
+
+        # Stubs:
+        def role_name; nil; end
+        def nested_clauses; nil; end
+
+        def inspect; to_s; end
+
+        def to_s
+          unit ? "(#{@literal.to_s} in #{unit.to_s})" : @literal.to_s
+        end
+
+        def player
+          @player
+        end
+
+        def identify_players_with_role_name(context)
+          # Nothing to do here, move along
+        end
+
+        def identify_other_players(context)
+          identify_player context
+        end
+
+        def identify_player context
+          @player || begin
+            player_name =
+              case @literal
+              when String; 'String'
+              when Float; 'Real'
+              when Numeric; 'Integer'
+              when TrueClass, FalseClass; 'Boolean'
+              end
+            v = context.vocabulary
+            @player = v.constellation.ValueType(v, player_name)
+          end
+        end
+
+        def bind context
+          @binding || begin
+            key = "#{@player.name} #{@literal}"
+            @binding = (context.bindings[key] ||= Binding.new(@player))
+            @binding.refs << self
+          end
+        end
+
+        def binding
+          @binding
+        end
+      end
+
+    end
+  end
+end

data/lib/activefacts/cql/compiler/fact.rb

@@ -0,0 +1,390 @@
+module ActiveFacts
+  module CQL
+    class Compiler < ActiveFacts::CQL::Parser
+
+      class Fact < Definition
+        def initialize clauses, population_name = ''
+          @clauses = clauses
+          @population_name = population_name
+        end
+
+        def compile
+          @population = @constellation.Population[[@vocabulary.identifying_role_values, @population_name]] ||
+	      @constellation.Population(@vocabulary, @population_name, :concept => :new)
+
+          @context = CompilationContext.new(@vocabulary)
+          @context.bind @clauses
+          @context.left_contraction_allowed = true
+          @clauses.each do |clause|
+	    ft = clause.match_existing_fact_type @context
+	    if clause.certainty == false
+	      raise "Negated fact #{clause.inspect} is not supported"
+	    end
+	  end
+
+          # Figure out the simple existential facts and find fact types:
+          @bound_facts = []
+          @unbound_clauses = all_clauses(@clauses).
+            map do |clause|
+              bind_literal_or_fact_type clause
+            end.
+            compact
+
+          # Because the fact types may include forward references, we must
+          # process the list repeatedly until we make no further progress.
+          @pass = 0 # Repeat until we make no more progress:
+          true while bind_more_facts
+
+          # Any remaining unbound facts are a problem we can bitch about:
+          complain_incomplete unless @unbound_clauses.empty?
+
+          @bound_facts.uniq # N.B. this includes Instance objects (existential facts)
+        end
+
+        def bind_literal_or_fact_type clause
+          # Every bound word (term) in the phrases must have a literal
+          # OR be bound to an entity type identified by the phrases
+
+          # Any clause that has one binding and no other word is
+          # either a value instance or a simply-identified entity.
+          clause.refs.each do |ref|
+            next unless l = ref.literal    # No literal
+            next if ref.binding.instance   # Already bound
+            player = ref.binding.player
+            # raise "A literal may not be an objectification" if ref.role_ref.nested_clauses
+            # raise "Not processing facts involving nested clauses yet" if ref.role_ref
+            trace :instance_detail, "Making #{player.class.basename} #{player.name} using #{l.inspect}" do
+              ref.binding.instance = instance_identified_by_literal(player, l)
+            end
+            ref
+          end
+
+          if clause.phrases.size == 1 and (ref = clause.phrases[0]).is_a?(Compiler::Reference)
+            if ref.nested_clauses
+              # Assign the objectified fact type as this clause's fact type?
+              clause.fact_type = ref.player.fact_type
+              clause
+            else
+              # This is an existential fact (like "Name 'foo'", or "Company 'Microsoft'")
+              nil # Nothing to see here, move along
+            end
+          else
+            raise "Fact Type not found: '#{clause.display}'" unless clause.fact_type
+            # This instance will be associated with its binding by our caller
+            clause
+          end
+        end
+
+        #
+        # Try to bind this clause, and return true if it can be completed
+        #
+        def bind_clause clause
+          return true if clause.fact
+
+          # Find the roles of this clause that do not yet have an instance
+          bare_roles = clause.refs.
+            select do |ref|
+	      if !ref.binding.instance and ref.literal
+                ref.binding.instance = instance_identified_by_literal(ref.binding.player, ref.literal)
+	      end
+
+              next false if ref.binding.instance
+              true
+            end
+
+	  trace :instance_detail, "Considering '#{clause.display}' with "+
+	    (bare_roles.empty? ? "no bare roles" : "bare roles: #{bare_roles.map{|ref| ref.player.name}*", "}") do
+
+            # If all the roles are in place, we can bind the rest of this clause:
+            return true if bare_roles.size == 0 && bind_complete_fact(clause)
+
+            progress = false
+            if bare_roles.size == 1 &&
+                (binding = bare_roles[0].binding) &&
+                (et = binding.player).is_a?(ActiveFacts::Metamodel::EntityType)
+              if et.preferred_identifier.role_sequence.all_role_ref.detect{|rr| rr.role.fact_type == clause.fact_type} &&
+                bind_entity_if_identifier_ready(clause, et, binding)
+                progress = true
+              end
+            end
+
+            return true if progress
+            trace :instance_detail, "Delaying until all role players are asserted: #{clause.fact_type.default_reading.inspect}"
+            nil
+          end
+        end
+
+        # Take one pass through the @unbound_clauses, processing (and removing) any that have all pre-requisites
+        def bind_more_facts
+          return false unless @unbound_clauses.size > 0
+          @pass += 1
+
+          progress = false
+          trace :instance_detail, "Pass #{@pass} with #{@unbound_clauses.size} clauses to consider" do
+            @unbound_clauses =
+              @unbound_clauses.select do |clause|
+                action = bind_clause(clause)
+                progress = true if action
+                !action
+              end
+            trace :instance_detail, "end of pass, unbound clauses are #{@unbound_clauses.map(&:display)*', '}"
+          end # debug
+          progress
+        end
+
+        # Occasionally we need to search through all the clauses. This builds a flat list
+        def all_clauses clauses
+          clauses.map do |clause|
+            [clause] + clause.refs.map{|vr| vr.nested_clauses ? all_clauses(vr.nested_clauses) : []}
+          end.flatten.compact
+        end
+
+        def bind_complete_fact clause
+          return true unless clause.fact_type  # An bare objectification
+          instances = clause.refs.map{|vr| vr.binding.instance }
+          trace :instance_detail, "All role players exist for #{clause.display.inspect} exist: #{instances.map{|i| "#{i.verbalise}"}*", "}"
+
+          if e = clause.fact_type.entity_type and
+            clause.refs[0].binding.instance.object_type == e
+            fact = clause.refs[0].binding.instance.fact
+          else
+            # Check that this fact doesn't already exist
+	    trace :instance_detail, "Searching for existing fact instance"
+
+            fact = clause.fact_type.all_fact.detect do |f|
+
+              # Get the role values of this fact in the order of the clause we just bound
+              role_values_in_clause_order = f.all_role_value.sort_by do |rv|
+                clause.reading.role_sequence.all_role_ref.detect{|rr| rr.role == rv.role}.ordinal
+              end
+
+              # If all this fact's role values are played by the bound instances, it's the same fact
+              !role_values_in_clause_order.zip(instances).detect{|rv, i| rv.instance != i }
+            end
+          end
+          if fact
+            clause.fact = fact
+            trace :instance, "Already known: #{fact.verbalise.inspect}"
+          else
+            trace :instance_detail, "Asserting fact of type #{clause.fact_type.default_reading.inspect}"
+            fact =
+              clause.fact =
+              @constellation.Fact(:new, :fact_type => clause.fact_type, :population => @population)
+            @bound_facts << fact
+            clause.reading.role_sequence.all_role_ref_in_order.zip(instances).each do |rr, instance|
+              trace :instance_detail, "Assigning fact role #{instance.object_type.name} to #{instance.value ? instance.value.inspect : instance.verbalise}"
+              # REVISIT: Any residual adjectives after the fact type matching are lost here.
+              @constellation.RoleValue(:fact => fact, :instance => instance, :role => rr.role, :population => @population)
+            end
+            trace :instance, "Assert #{fact.verbalise.inspect} #{@population.name.size>0 ? " in "+@population.name.inspect : ''}" unless clause.fact_type.entity_type
+          end
+
+          if !fact.instance && clause.fact_type.entity_type
+            # Objectified fact type; create the instance
+            # Create the instance that objectifies this fact. We don't have the binding to assign it to though; that'll happen in our caller
+            instance =
+              @constellation.Instance(:new, :object_type => clause.fact_type.entity_type, :fact => fact, :population => @population)
+            trace :instance, "Assert #{instance.verbalise.inspect}"
+            @bound_facts << instance
+          end
+
+          if clause.fact and
+            clause.objectified_as and
+            instance = clause.fact.instance and
+            instance.object_type == clause.objectified_as.binding.player
+            clause.objectified_as.binding.instance = instance
+          end
+
+          true
+        end
+
+        # If we have one bare role (no literal or instance) played by an entity type,
+        # and the bound fact type participates in the identifier, we might now be able
+        # to create the entity instance.
+        def bind_entity_if_identifier_ready clause, entity_type, binding
+          # Check this instance doesn't already exist already:
+          identifying_binding = (clause.refs.map{|vr| vr.binding}-[binding])[0]
+          return false unless identifying_binding # This happens when we have a bare objectification
+          identifying_instance = identifying_binding.instance
+          preferred_identifier = entity_type.preferred_identifier
+	  role_count = preferred_identifier.role_sequence.all_role_ref.size 
+
+          trace :instance, "A #{binding.player.name} is #{role_count > 1 ? 'partly ':''}identified in #{clause.inspect}"
+
+          identifying_role_ref = preferred_identifier.role_sequence.all_role_ref.detect { |rr|
+              rr.role.fact_type == clause.fact_type && rr.role.object_type == identifying_binding.player
+            }
+          unless identifying_role_ref
+            # This should never happen; we already bound all refs
+            trace :instance, "Failed to find a #{identifying_instance.object_type.name}"
+            return false # We can't do this yet
+          end
+          role_value = identifying_instance.all_role_value.detect do |rv|
+            rv.fact.fact_type == identifying_role_ref.role.fact_type
+          end
+          if role_value && role_count == 1
+            instance = (role_value.fact.all_role_value.to_a-[role_value])[0].instance
+            trace :instance, "Existential fact already known: #{instance.verbalise.inspect}"
+            binding.instance = instance
+            return true  # Done with this clause
+          end
+
+          pi_role_refs = preferred_identifier.role_sequence.all_role_ref
+          # For each pi role, we have to find the fact clause, which contains the binding we need.
+          # Then we have to create an instance of each fact
+          identifiers =
+            pi_role_refs.map do |rr|
+              # Find a clause that provides the identifying_ref for this player:
+              identifying_clause = all_clauses(@clauses).detect do |clause|
+                rr.role.fact_type == clause.fact_type &&
+                  clause.refs.detect{|vr| vr.binding == binding}
+              end
+              return false unless identifying_clause
+              identifying_ref = identifying_clause.refs.select{|ref| ref.binding != binding}[0]
+              identifying_binding = identifying_ref ? identifying_ref.binding : nil
+              identifying_instance = identifying_binding.instance
+
+              [rr, identifying_clause, identifying_binding, identifying_instance]
+            end
+          if identifiers.detect{ |i| !i[3] }  # Not all required facts are bound yet
+            trace :instance, "Can't go through with creating #{binding.player.name}; not all the identifying facts are in"
+            return false
+          end
+
+	  instance = @constellation.Instance(:new, :object_type => entity_type, :population => @population)
+	  binding.instance = instance
+	  @bound_facts << instance
+	  identifiers.each do |rr, identifying_clause, identifying_binding, identifying_instance|
+	    # This clause provides the identifying literal for the entity_type
+	    id_fact =
+	      identifying_clause.fact =
+	      @constellation.Fact(:new, :fact_type => rr.role.fact_type, :population => @population)
+	    @bound_facts << id_fact
+	    role = (rr.role.fact_type.all_role.to_a-[rr.role])[0]
+	    @constellation.RoleValue(:instance => instance, :fact => id_fact, :population => @population, :role => role)
+	    @constellation.RoleValue(:instance => identifying_instance, :fact => id_fact, :role => rr.role, :population => @population)
+	    trace :instance, "Assert #{id_fact.verbalise.inspect} (existential) #{@population.name.size>0 ? " in "+@population.name.inspect : ''}"
+	  end
+	  trace :instance, "Assert #{instance.verbalise.inspect} #{@population.name.size>0 ? " in "+@population.name.inspect : ''}"
+
+          true  # Done with this clause
+        end
+
+        def instance_identified_by_literal object_type, literal
+          if object_type.is_a?(ActiveFacts::Metamodel::EntityType)
+            entity_identified_by_literal object_type, literal
+          else
+            trace :instance_detail, "Assert Value #{object_type.name} #{literal.inspect}" do
+              is_literal_string = literal.literal.is_a?(String)
+	      # REVISIT: Check for subtypes and supertypes also, and promote type if necessary
+	      instance = object_type.all_instance.detect do |i|
+              #instance = @constellation.Instance.detect do |key, i|
+                  # REVISIT: And same unit
+		  trace :instance_detail2, "Comparing #{i.value.literal.inspect} to #{literal.literal.to_s.inspect}"
+                  i.population == @population &&
+                    i.value &&
+                    i.value.literal.inspect == literal.literal.to_s.inspect &&
+                    i.value.is_literal_string == is_literal_string
+                end
+              #instance = object_type.all_instance.detect { |instance|
+              #  instance.population == @population && instance.value == literal
+              #}
+	      if instance
+		trace :instance, "Instance already known: #{instance.verbalise.inspect}"
+              else
+                instance = @constellation.Instance(:new)
+                instance.object_type = object_type
+                instance.population = @population
+                instance.value = [literal.to_s, is_literal_string, nil]
+		trace :instance, "Assert #{instance.verbalise.inspect} #{@population.name.size>0 ? " in "+@population.name.inspect : ''}"
+                @bound_facts << instance
+              end
+              instance
+            end
+          end
+        end
+
+        def entity_identified_by_literal object_type, literal
+          # A literal that identifies an entity type means the entity type has only one identifying role
+          # That role is played either by a value type, or by another similarly single-identified entity type
+          trace :instance_detail, "Assert Entity #{object_type.name} identified by '#{literal}'" do
+            identifying_role_refs = object_type.preferred_identifier.role_sequence.all_role_ref
+            raise "Single literal cannot satisfy multiple identifying roles for #{object_type.name}" if identifying_role_refs.size > 1
+            role = identifying_role_refs.single.role
+            # This instance has no binding; the binding is of the entity type not the identifying value type
+            identifying_instance = instance_identified_by_literal role.object_type, literal
+            existing_instance = nil
+            instance_rv = identifying_instance.all_role_value.detect { |rv|
+              next false unless rv.population == @population         # Not this population
+              next false unless rv.fact.fact_type == role.fact_type # Not this fact type
+              other_role_value = (rv.fact.all_role_value-[rv])[0]
+              existing_instance = other_role_value.instance
+              other_role_value.instance.object_type == object_type          # Is it this object_type?
+            }
+            if instance_rv
+              instance = existing_instance
+	      trace :instance, "Already known: #{instance.verbalise.inspect}"
+            else
+              # This fact has no clause.
+	      trace :instance_detail, "Creating implicit existential fact #{role.fact_type.default_reading}"
+              fact = @constellation.Fact(:new, :fact_type => role.fact_type, :population => @population)
+              @bound_facts << fact
+              # This instance will be associated with its binding by our caller
+              instance = @constellation.Instance(:new, :object_type => object_type, :population => @population)
+	      trace :instance_detail, "Creating Entity #{object_type.name} identified by '#{literal}' #{@population.name.size>0 ? " in "+@population.name.inspect : ''}"
+              @bound_facts << instance
+              # The identifying fact type has two roles; create both role instances:
+              @constellation.RoleValue(:instance => identifying_instance, :fact => fact, :population => @population, :role => role)
+              @constellation.RoleValue(:instance => instance, :fact => fact, :population => @population, :role => (role.fact_type.all_role-[role])[0])
+	      trace :instance, "Assert #{instance.verbalise.inspect}"
+            end
+            instance
+          end
+        end
+
+        def complain_incomplete
+          if @unbound_clauses.size > 0
+            # Provide a readable description of the problem here, by showing each binding with no instance
+            missing_bindings = @unbound_clauses.
+              map do |clause|
+                clause.refs.
+                  select do |refs|
+                    !refs.binding.instance
+                  end.
+                  map do |ref|
+                    ref.binding
+                  end
+              end.
+              flatten.
+              uniq
+
+            raise "Not enough facts are given to identify #{
+                missing_bindings.
+                  sort_by{|b| b.key}.
+                  map do |b|
+                    player_identifier =
+                      if b.player.is_a?(ActiveFacts::Metamodel::EntityType)
+                        "lacking " +
+                          b.player.preferred_identifier.role_sequence.all_role_ref.map do |rr|
+                            [ rr.leading_adjective, rr.role.role_name || rr.role.object_type.name, rr.trailing_adjective ].compact*" "
+                          end*", "
+                      else
+                        "needs a value"
+                      end
+                    [
+                      b.refs[0].leading_adjective, b.player.name, b.refs[0].trailing_adjective
+                    ].compact*" " +
+                      " (#{player_identifier})"
+                  end*" or "
+              }"
+          end
+        end
+
+        def to_s
+          super+@clauses.map(&:to_s)*', '
+        end
+
+      end
+    end
+  end
+end