activefacts-api 0.8.12 → 0.9.1

data/spec/{identification_spec.rb → identification_scheme/identification_spec.rb}

@@ -1,5 +1,7 @@
-require 'rspec'
-require 'activefacts/api'
+#
+# ActiveFacts tests: Value instances in the Runtime API
+# Copyright (c) 2008 Clifford Heath. Read the LICENSE file.
+#
 
 describe "An Entity Type" do
   before :all do
@@ -28,16 +30,14 @@ describe "An Entity Type" do
     end
 
     it "should fail if the role isn't one-to-one" do
-      pending "Lacks a check for one-to-one identifying role" do
-        proc do
-          module Mod
-            class Cat
-              identified_by :name
-              has_one :name
-            end
+      proc do
+        module Mod
+          class Cat
+            identified_by :name
+            has_one :name
           end
-        end.should raise_error
-      end
+        end
+      end.should raise_error
     end
 
     describe "when asserted" do
@@ -81,11 +81,13 @@ describe "An Entity Type" do
       end
 
       it "should fail if the new value already exists" do
-        pending "Doesn't check validity of rename" do
-          proc do
-            @bus.name = 'Acme'
-          end.should raise_error
-        end
+        proc do
+          @fly.name = 'Acme'
+        end.should raise_error
+      end
+
+      it "should not fail if the new value is self" do
+        lambda { @bus.name = 'Acme' }.should_not raise_error
       end
 
       describe "to a previously-nonexistent value" do
@@ -103,15 +105,11 @@ describe "An Entity Type" do
         end
 
         it "should be found under the new identifier" do
-          pending "entities are not re-indexed on identifier assignment" do
-            @c.Business['Bloggs'].should == @bus
-          end
+          @c.Business[['Bloggs']].should == @bus
         end
 
         it "should be in the constellation's index under the new identifier" do
-          pending "entities are not re-indexed on identifier assignment" do
-            @c.Business.keys[0].should == ['Bloggs']
-          end
+          @c.Business.keys.should include ['Bloggs']
         end
 
         it "should be the counterpart of the new identifier" do
@@ -119,24 +117,23 @@ describe "An Entity Type" do
         end
 
         it "should not be found in the constellation using the old value" do
-          pending "entities are not de-indexed on identifier assignment" do
-            @c.Business[['Acme']].should be_nil
-          end
+          @c.Business[['Acme']].should be_nil
         end
 
         it "the old value's back-reference is set to nil" do
           @acme.business.should be_nil
         end
 
-        describe "and the old identifying value plays no other roles" do
-          describe "and the player of the identifying role is not independent" do
-            it "should retract the previous value" do
-              pending "All value types default to independent" do
-                @c.Name['Acme'].should be_nil
-              end
-            end
-          end
-        end
+        #describe "and the old identifying value plays no other roles" do
+        #  describe "and the player of the identifying role is not independent" do
+        #    it "should retract the previous value" do
+        #      pending "All value types default to independent" do
+        #        @c.Name['Acme'].should be_nil
+        #      end
+        #    end
+        #  end
+        #end
+
       end
     end
 
@@ -157,11 +154,11 @@ describe "An Entity Type" do
             @bus.retract
           end
 
-          it "should retract the identifying value also" do
-            pending "All value types default to independent" do
-              @c.Name['Acme'].should be_nil
-            end
-          end
+          #it "should retract the identifying value also" do
+          #  pending "All value types default to independent" do
+          #    @c.Name['Acme'].should be_nil
+          #  end
+          #end
 
           it "should not appear as the value's counterpart role" do
             @acme.business.should be_nil
@@ -204,24 +201,39 @@ describe "An Entity Type" do
           has_one :building
           has_one :number
         end
+
+        class OwnershipId < Int
+          value_type
+        end
+
+        class Owner
+          identified_by :ownership_id, :building
+          has_one :ownership_id
+          has_one :building
+        end
+
+        class OwnerRoom
+          identified_by :owner, :room
+          has_one :owner
+          has_one :room
+        end
       end
     end
+
     before :each do
       @c = ActiveFacts::API::Constellation.new(Mod)
     end
 
     it "should fail if any role is one-to-one" do
-      pending "Lacks a check for one-to-one identifying role" do
-        proc do
-          module Mod
-            class Floor
-              identified_by :building, :number
-              has_one :building
-              one_to_one :number    # Error, invalid identifier
-            end
+      proc do
+        module Mod
+          class Floor
+            identified_by :building, :number
+            has_one :building
+            one_to_one :number    # Error, invalid identifier
           end
-        end.should raise_error
-      end
+        end
+      end.should raise_error
     end
 
     describe "when asserted" do
@@ -230,6 +242,9 @@ describe "An Entity Type" do
         @mackay = @c.Name['Mackay']
         @r = @c.Room(@b, 101)
         @rn = @r.number
+
+        @o = @c.Owner(1_001, @b)
+        @or = @c.OwnerRoom(@o, @r)
       end
 
       it "should return a new instance if not previously present" do
@@ -271,15 +286,14 @@ describe "An Entity Type" do
         @mackay = @c.Name['Mackay']
         @r = @c.Room(@b, 101)
         @rn = @r.number
+
+        @o = @c.Owner(1_001, @b)
+        @or = @c.OwnerRoom(@o, @r)
       end
 
       it "should fail if the new value already exists" do
         @c.Room(@b, 102)
-        pending "Doesn't check validity of rename" do
-          proc {
-            @r.number = 102
-          }.should raise_error
-        end
+        lambda { @r.number = 102 }.should raise_error
       end
 
       describe "to a previously-nonexistent value" do
@@ -298,16 +312,18 @@ describe "An Entity Type" do
         end
 
         it "should be found under the new identifier" do
-          pending "entities are not re-indexed on identifier assignment" do
-            @c.Room[[@b.identifying_role_values, 103]].should == @r
-            @c.Room[[['Mackay'], 101]].should be_nil
-          end
+          @c.Room[[@b.identifying_role_values, 103]].should == @r
+          @c.Room[[['Mackay'], 101]].should be_nil
+        end
+
+        it "should be found under the new identifier even on deep associations" do
+          @c.OwnerRoom[[@o.identifying_role_values, @r.identifying_role_values]].should == @or
+          @c.OwnerRoom[[[1_001, ['Mackay']], [['Mackay'], 103]]].should == @or
+          @c.OwnerRoom[[[1_001, ['Mackay']], [['Mackay'], 101]]].should be_nil
         end
 
         it "should be in the constellation's index under the new identifier" do
-          pending "entities are not de-indexed on identifier assignment" do
-            @c.Room.keys[0].should == [['Mackay'], @r.number]
-          end
+          @c.Room.keys[0].should == [['Mackay'], @r.number]
         end
 
         it "should be included in the counterparts of the new identifier roles" do
@@ -316,24 +332,22 @@ describe "An Entity Type" do
         end
 
         it "should not be found in the constellation using the old value" do
-          pending "entities are not de-indexed on identifier assignment" do
-            @c.Room.keys[0].should_not == [['Mackay'],101]
-          end
+          @c.Room.keys[0].should_not == [['Mackay'],101]
         end
 
         it "the old value's back-reference is set to nil" do
-          @rn.all_room.to_a.should_not be_include(@r)
+          @rn.all_room.to_a.should_not include @r
         end
 
-        describe "and the old identifying value plays no other roles" do
-          describe "and the player of the identifying role is not independent" do
-            it "should retract the previous value" do
-              pending "All value types default to independent" do
-                @c.Number[101].should be_nil
-              end
-            end
-          end
-        end
+        #describe "and the old identifying value plays no other roles" do
+        #  describe "and the player of the identifying role is not independent" do
+        #    it "should retract the previous value" do
+        #      pending "All value types default to independent" do
+        #        @c.Number[101].should be_nil
+        #      end
+        #    end
+        #  end
+        #end
       end
     end
 

data/spec/identification_scheme/identity_change_spec.rb

@@ -0,0 +1,118 @@
+#
+# ActiveFacts tests: Value instances in the Runtime API
+# Copyright (c) 2008 Clifford Heath. Read the LICENSE file.
+#
+
+require 'fixtures/tax'
+include ActiveFacts::API
+
+describe "identity" do
+  before :each do
+    @c1 = Constellation.new(Tax)
+    @juliar = "Juliar Gillard"
+
+    @p1 = @c1.Australian(@juliar)
+  end
+
+  it "should be indexed" do
+    @c1.Name.keys.should == [@juliar]
+    @c1.Name.values.should == [@juliar]
+    @c1.Person.keys.should == [[@juliar]]
+    @c1.Person.values.should == [@p1]
+    @c1.Australian.keys.should == [[@juliar]]
+    @c1.Australian.values.should == [@p1]
+  end
+
+  describe "change" do
+    before :each do
+      @tony = "Tony Abbot"
+      @p3 = @c1.AustralianTaxPayer(:tfn => 123, :name => @tony)
+
+      @r1 = @c1.AustralianTaxReturn(@p3, 2010)
+      @c1.AustralianTaxReturn.keys.should == [[[123], [2010]]]
+      @c1.AustralianTaxReturn.values.should == [@r1]
+
+      @c1.Name.keys.should =~ [@juliar, @tony]
+      @c1.Name.values.should =~ [@juliar, @tony]
+      @c1.Person.keys.should =~ [[@juliar], [@tony]]
+      @c1.Person.values.should =~ [@p1, @p3]
+      @c1.Australian.keys.should =~ [[@juliar], [@tony]]
+      @c1.Australian.values.should =~ [@p1, @p3]
+      @c1.AustralianTaxPayer.keys.should =~ [[123]]
+      @c1.AustralianTaxPayer.values.should =~ [@p3]
+    end
+
+    describe "that implies change of subtype" do
+      before :each do
+        @p2 = nil
+        @change = proc {
+          @p2 = @c1.AustralianTaxPayer(:tfn => 789, :name => "Juliar Gillard")
+        }
+      end
+
+      it "should be denied" do
+        @change.should raise_error(DuplicateIdentifyingValueException)
+      end
+
+      it "should not change instance subtype" do
+        @p1.class.should == Tax::Australian
+      end
+
+      it "should have no side-effects" do
+        begin
+          @change.call
+        rescue DuplicateIdentifyingValueException => e
+        end
+
+        @p2.should be_nil
+        @c1.Name.values.should =~ [@juliar, @tony]
+        @c1.Name.keys.should =~ [@juliar, @tony]
+        @c1.TFN.keys.should =~ [123]
+        @c1.Person.values.should =~ [@p1, @p3]
+        @c1.Person.keys.should =~ [[@juliar],[@tony]]
+        @c1.Australian.values.should =~ [@p1, @p3]
+      end
+
+      it "should have no side-effects (retracting values which shouldn't)" do
+        @p2_tfn = @c1.TFN(789)
+        begin
+          @change.call
+        rescue DuplicateIdentifyingValueException => e
+        end
+
+        @c1.TFN.keys.should =~ [123, 789]
+      end
+    end
+
+    describe "causing conflict" do
+      it "should fail and make no change" do
+        proc {
+          @p3.name = "Juliar Gillard"    # Must fail; must leave @p3 untouched.
+        }.should raise_error # (ActiveFacts::API::AmbiguousIdentityChange)
+
+        @p3.name.should == @tony
+      end
+    end
+
+    describe "without conflict" do
+      before :each do
+        @p3.tfn = 456
+      end
+
+      it "should be allowed" do
+        @p3.identifying_role_values.should == [456]
+      end
+
+      it "should be re-indexed" do
+        @c1.AustralianTaxPayer.keys.should == [[456]]
+      end
+
+      it "should be propagated" do
+        key = [[456], [2010]]
+        @r1.identifying_role_values.should == key
+        @c1.AustralianTaxReturn.keys.should == [key]
+        @c1.AustralianTaxReturn.values.should == [@r1]
+      end
+    end
+  end
+end

data/spec/identification_scheme/identity_supertype_change_spec.rb

@@ -0,0 +1,63 @@
+#
+# ActiveFacts tests: Value instances in the Runtime API
+# Copyright (c) 2008 Clifford Heath. Read the LICENSE file.
+#
+
+describe 'identity change on subtype' do
+  before :all do
+    module Mod
+      class EntityA
+        identified_by :value_a
+        one_to_one :value_a
+        has_one :value_b
+      end
+
+      class ValueA < Int
+        value_type
+      end
+
+      class ValueB < String
+        value_type
+      end
+
+      class EntityB < EntityA
+        identified_by :value_b
+      end
+    end
+
+    @constellation = ActiveFacts::API::Constellation.new(Mod)
+    @a = @constellation.EntityA(123)
+  end
+
+  it "should fail if the value is the same" do
+    lambda { @b = @constellation.EntityB(123, 'abc') }.should raise_error
+  end
+
+  context "on a deep-subtype" do
+    before :all do
+      module Mod
+        class EntityC < EntityB
+        end
+      end
+
+      @c = @constellation.EntityC(:value_a => 1, :value_b => 'abc')
+    end
+
+    it "should fail if the value already exist" do
+      @a.value_a.should == 123
+      @c.value_a.should == 1
+      lambda { @a.value_a = 1 }.should raise_error(ActiveFacts::API::DuplicateIdentifyingValueException)
+      lambda { @c.value_a = 123 }.should raise_error(ActiveFacts::API::DuplicateIdentifyingValueException)
+    end
+
+    it "should keep the previous value intact" do
+      @a.value_a.should == 123
+      @c.value_a.should == 1
+    end
+
+    it "should allow the change when the value doesn't exist" do
+      @c.value_a = 987
+      @c.value_a.should == 987
+    end
+  end
+end

data/spec/{entity_type_spec.rb → object_type/entity_type/entity_type_spec.rb}

@@ -2,8 +2,6 @@
 # ActiveFacts tests: Entity classes in the Runtime API
 # Copyright (c) 2008 Clifford Heath. Read the LICENSE file.
 #
-require 'rspec'
-require 'activefacts/api'
 
 describe "Entity Type class definitions" do
   before :each do
@@ -16,7 +14,7 @@ describe "Entity Type class definitions" do
       end
       class Person < LegalEntity
         identified_by :name
-        has_one :name, :class => Name
+        one_to_one :name, :class => Name
       end
     end
   end
@@ -77,7 +75,7 @@ describe "Entity Type class definitions" do
     Mod::Person.roles.include?(:name).should be_true
   end
 
-  it "should fail on a ValueClass" do
+  it "should fail on a ValClass" do
     lambda{
       class SomeClass < String
         identified_by