activecommand 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6539a80be081d5bb2ca07a4c214fd505456bf9b9
-  data.tar.gz: 13c3d3d4554c819a8373961ba7b3a881532503af
+  metadata.gz: a0bff99477fe2be1ec3d4ac7c189110141d37c1a
+  data.tar.gz: f5fee12ef76e5b5af11ee14356b48a5786c1eecb
 SHA512:
-  metadata.gz: f81fae5b5fe169483413092a52549b4b0340ef0d9ed9680c5e3acf6d00fcb04daafc80bdda1996f5e109cb2d1d0e14d3a4524d3c1132705d9c4a1f4bb50eac82
-  data.tar.gz: 01e987eccf9471dc91d2463b4572027128c41c63e33d55381230ed713cd3439e3566c03e644b2a41b5b2ba4cd37c65a39a8219f7b8ce71d3bc048a8e7030d163
+  metadata.gz: efb9b97ed8b2f8d6837cdc12ddca0808266de59db91979113430fb20d56ceefcf46cffde5ef8ae21ef8aad7cccc6aff4fffdb4c436a5fb744ae763e8e53b899f
+  data.tar.gz: 0323cee104f88f74b1c177abcf35e222e7f26cff2c80c953c2f97b9fd708e81a0fcccce788f48bf4747c4bab34dcd54e11fefb69eac72e52400d4b77f1e1f3fd

data/.ruby-version

@@ -0,0 +1 @@
+2.3.0

data/.travis.yml

@@ -1,11 +1,22 @@
 language: ruby
 rvm:
+  - 2.3.0
   - 2.2.3
-  - jruby
+  - jruby-9.1.2.0
 before_install: gem install bundler -v 1.10.6
 
+env:
+  - JAVA_TOOL_OPTIONS="-Dfile.encoding=UTF8"
+
 script: 'bundle exec rake'
 
+branches:
+  only:
+    - master
+    - develop
+    - /^feature\/.*$/
+    - /^release\/.*$/
+
 notifications:
   email:
     recipients:

data/README.md

@@ -1,5 +1,7 @@
 # ActiveCommand
 
+[![Build Status](https://travis-ci.org/jcarley/activecommand.svg?branch=master)](https://travis-ci.org/jcarley/activecommand)
+
 ActiveCommand adds the ability to use the command pattern commonly seen in CQRS.
 
 ## Installation
@@ -28,11 +30,23 @@ First create your command.  Perhaps adding it to a commands folder under app, if
       - commands
         - SubmitOrderCommand.rb
 
-Then inherit from the base command class and implement an execute method.
+Then inherit from the base command class and implement an execute method.  The following example
+is assuming the Order is an ActiveRecord model and has a submit? method.
 
 ```ruby
 class SubmitOrderCommand < ActiveCommand::Command
+
+  attribute :order_id, String
+
+  validates :order_id, presence: true
+
   def execute
+    order = Order.find(order_id)
+    if order.submit?
+      Emailer.send_order_submitted_notification_for(order)
+    else
+      raise OrderSubmitError, "Something went wrong submitting the order '#{order_id}'"
+    end
   end
 end
 ```
@@ -42,12 +56,12 @@ execute the command, instantiate it and execute it using the CommandBus.  The re
 is a CommandResult object.  The CommandResult will tell you if the command was successful or not.
 
 ```ruby
-submit_order_command = SubmitOrderCommand.new
+submit_order_command = SubmitOrderCommand.new(:order_id => "ABC123")
 cr = ActiveCommand::CommandBus.execute(submit_order_command)
 if cr.success?
   redirect "/"
 else
-  render "submit_path"
+  render :submit
 end
 ```
 
@@ -59,7 +73,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/activecommand. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome on GitHub at https://github.com/jcarley/activecommand. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](contributor-covenant.org) code of conduct.
 
 
 ## License

data/activecommand.gemspec

@@ -17,6 +17,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'middleware'
   spec.add_dependency 'activesupport'
   spec.add_dependency 'activemodel'
+  spec.add_dependency 'sidekiq'
 
   # Prevent pushing this gem to RubyGems.org by setting 'allowed_push_host', or
   # delete this section to allow pushing this gem to any host.

data/lib/active_command.rb

@@ -3,11 +3,14 @@ require 'middleware'
 require 'active_support'
 require 'active_support/hash_with_indifferent_access'
 require 'active_model'
+require 'sidekiq'
 
 module ActiveCommand
   extend ActiveSupport::Autoload
 
+  autoload :Core
   autoload :Command
+  autoload :BackgroundCommand
   autoload :CommandBus
   autoload :CommandResult
   autoload :CommandNotValidError

data/lib/active_command/command.rb

@@ -1,9 +1,13 @@
 module ActiveCommand
   class Command
+    include Core
+    include Sidekiq::Worker
     include Virtus.model
     include ActiveModel::Validations
     include ActiveModel::Serializers::JSON
 
+    attribute :job_id, String
+
     def self.from_json(json)
       klass = self.new
       klass.from_json(json)
@@ -16,6 +20,15 @@ module ActiveCommand
     alias_method :to_hash, :to_params
 
     def run
+      self.class.perform_async self.to_params.to_json
+    end
+
+    def perform(job_data)
+      self.from_json(job_data)
+      self.perform_now
+    end
+
+    def perform_now
       if self.valid?
         self.execute
       else

data/lib/active_command/command_bus.rb

@@ -8,7 +8,18 @@ module ActiveCommand
     end
 
     def execute(command)
-      env = {:command => command}
+      env = {:command => command, :at => :later}
+      default_middleware.call(env)
+      env[:command_result]
+    end
+
+    def self.execute_now(command)
+      bus = self.instance
+      bus.execute_now(command)
+    end
+
+    def execute_now(command)
+      env = {:command => command, :at => :now}
       default_middleware.call(env)
       env[:command_result]
     end

data/lib/active_command/core.rb

@@ -0,0 +1,9 @@
+module ActiveCommand
+  module Core
+    extend ActiveSupport::Concern
+
+    module ClassMethods
+    end
+
+  end
+end

data/lib/active_command/middleware/command_runner.rb

@@ -8,12 +8,15 @@ module ActiveCommand
     end
 
     def call(env)
+
+      at = env.fetch(:at, :later)
       cmd = env.fetch(:command, nil)
 
       result = CommandResult.new(cmd).tap do |cr|
         begin
           raise MissingCommandError if cr.command.nil?
-          cr.command.run
+          cr.command.run if at == :later
+          cr.command.perform_now if at == :now
         rescue StandardError => e
           cr.error = e
         end

data/lib/active_command/version.rb

@@ -1,3 +1,3 @@
 module ActiveCommand
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/todo.md

@@ -0,0 +1,12 @@
+
+TODO
+------
+* Add generators
+* Add background command using ActiveJob
+* Add more middleware
+   - logging
+   - benchmarking
+   - job recording
+* Example project
+* Description/Example code using command validations
+* Add callbacks

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activecommand
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Jefferson Carley
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-11-14 00:00:00.000000000 Z
+date: 2016-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: sidekiq
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -118,6 +132,7 @@ files:
 - ".gitignore"
 - ".rbenv-gemsets"
 - ".rspec"
+- ".ruby-version"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -132,9 +147,11 @@ files:
 - lib/active_command/command_bus.rb
 - lib/active_command/command_not_valid_error.rb
 - lib/active_command/command_result.rb
+- lib/active_command/core.rb
 - lib/active_command/middleware/command_runner.rb
 - lib/active_command/version.rb
 - lib/activecommand.rb
+- todo.md
 homepage: https://github.com/jcarley/activecommand
 licenses:
 - MIT
@@ -156,7 +173,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: ActiveCommand adds the ability to use the command pattern commonly seen in