activeagent 1.6.3 → 1.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1611f71e0ff6a30b864e797b01cd20242a46acad9df3888c836799f0d297e3d1
-  data.tar.gz: 5f93c9a8c43a98cf7eb599d9efb37f2915c1d2e5ef6f4138464c33cd1f4d3af1
+  metadata.gz: a0332669c4ffee1ccbea3e1645e126acac6b4e957b980000e5d96baedc908638
+  data.tar.gz: 1d6062b56a6e7fc0e76b965d308df706c3be563292344cdf68b500046e838784
 SHA512:
-  metadata.gz: 7e27caea807dc1d32744260bf157086160d73935fba48aea9c4c59e3234c26a5aee707eb650104a76f2fdf2e59497b0408b6a80392b83ceeab2770b4c8eef3c0
-  data.tar.gz: e44dc91193d40a6fafa9bc79c3cfc3a8c4f2acc215fc0fae0229424218a8c1bc6ca5b96c5803553bb610f89b86eb519b2f0c6061018117b65a38d77eba61100b
+  metadata.gz: c0a940227737d94497c19e8760cf1241ea02f6078987f8cd27f78b0b1a1fb22ac90c8b924dff87e85a4bf8f13c952f6a36eec388dd806f56d230f5b38c9fe59b
+  data.tar.gz: df01fdb757be0bcfa549086dfe0082db0ada892fc552600087d07fe9c1299a4aa4d4c897987cbda897832d11df50f19368261413647f63db4e636a4bb5bb98e5

data/CHANGELOG.md

@@ -7,6 +7,27 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.6.4] - 2026-09-22
+
+Releases `activeagent` and `actionagent` 1.6.4 from one tag. A patch on 1.6.3
+carrying one fix to `SchemaTools`, for a filter that answered confidently and
+wrongly instead of failing.
+
+### Fixed
+
+- A Rails enum is offered to the model as its names (`{type: "string", enum:
+  [...]}`) instead of the integer backing it. `SchemaGenerator` reads enums from
+  inclusion validators and never consulted `defined_enums`, so a `status` column
+  reached the model as a bare integer with no labels.
+- A filter value outside an enum — alone or inside an IN list — is rejected,
+  naming the valid values, instead of matching no rows. `status: "pending"`
+  returned `{count: 0}`, which an agent reports as a fact, indistinguishable
+  from "none match". Same reasoning as the unknown-operator rejection in
+  `range_predicates!`.
+- An enum is no longer offered the range form. Its integer backing is a
+  declaration-order artefact, so `status: {gt: 1}` was a meaningless filter that
+  still returned a confident count.
+
 ## [1.6.3] - 2026-09-18
 
 Releases `activeagent` and `actionagent` 1.6.3 from one tag.

data/lib/active_agent/schema_tools.rb

@@ -332,6 +332,8 @@ module ActiveAgent
               "`#{key}` is not a filterable attribute. Allowed filters: #{filterable.join(", ")}"
           end
 
+          validate_enum_value!(column, value)
+
           memo[column] = value
         end
 
@@ -386,6 +388,40 @@ module ActiveAgent
         end
       end
 
+      # A value outside a Rails enum reaches `where` as an unmatched name and
+      # returns zero rows — the same silent-nothing that {.range_predicates!}
+      # rejects for an unknown operator, and just as bad here: an agent reads
+      # "0 tickets under review" as a fact rather than a mistyped filter.
+      #
+      # The range form is not offered on an enum (see {.range_filterable?}), so
+      # a Hash here is a filter that cannot mean anything.
+      #
+      # @api private
+      # @raise [UnpermittedAttribute] on a value the enum does not define
+      def validate_enum_value!(column, value)
+        values = enum_values_for(column)
+        return if values.blank?
+
+        if value.is_a?(Hash)
+          raise UnpermittedAttribute,
+            "`#{column}` is an enum and cannot be compared as a range. " \
+            "Allowed values: #{values.keys.join(", ")}"
+        end
+
+        # An Array is an IN filter, which `where` silently narrows to its
+        # defined members just as it drops a lone undefined one.
+        Array(value).each do |member|
+          # The schema offers names only, so an integer here came from a
+          # model ignoring it. Accepted anyway: it is unambiguous, and a host
+          # calling the tool directly in Ruby reasonably passes the backing
+          # value.
+          next if values.key?(member.to_s) || values.value?(member)
+
+          raise UnpermittedAttribute,
+            "`#{member}` is not a valid `#{column}`. Allowed values: #{values.keys.join(", ")}"
+        end
+      end
+
       # Projects a record down to the declared return columns.
       #
       # The projection happens in SQL (+select+) as well as here, but the Ruby
@@ -455,14 +491,44 @@ module ActiveAgent
         properties = schema[:schema][:properties]
 
         filterable.index_with do |column|
+          next enum_property(column) if enum_column?(column)
+
           scalar = (properties[column] || { type: "string" }).deep_dup
           range_filterable?(column) ? with_range_form(column, scalar) : scalar
         end
       end
 
+      # A Rails enum is declared on the model, not through the inclusion
+      # validator SchemaGenerator reads, so without this a `status` column
+      # reaches the model as a bare integer: no labels, no constraint. The
+      # names are the model's own API (`Ticket.open`, `status: "open"`), so
+      # they are what the tool offers.
+      #
+      # @api private
+      def enum_property(column)
+        { type: "string", enum: enum_values_for(column).keys, description: "#{column.to_s.humanize} field" }
+      end
+
+      # @api private
+      def enum_column?(column)
+        enum_values_for(column).present?
+      end
+
+      # @api private
+      def enum_values_for(column)
+        @model.defined_enums[column.to_s] || {}
+      end
+
       # Dates, times and numbers are the columns a question like "overdue" or
       # "more than 10" actually needs a comparison on.
+      #
+      # An enum is backed by an integer but is not ordered in any sense a
+      # question can use: `status > 1` is an artefact of declaration order, so
+      # offering the range form on one invites a meaningless filter that still
+      # returns a confident count.
       def range_filterable?(column)
+        return false if enum_column?(column)
+
         RANGE_FILTERABLE_TYPES.include?(@model.type_for_attribute(column).type)
       end
 

data/lib/active_agent/version.rb

@@ -1,3 +1,3 @@
 module ActiveAgent
-  VERSION = "1.6.3"
+  VERSION = "1.6.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activeagent
 version: !ruby/object:Gem::Version
-  version: 1.6.3
+  version: 1.6.4
 platform: ruby
 authors:
 - Justin Bowen
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-09-18 00:00:00.000000000 Z
+date: 2026-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack