activeadmin_sortable_table 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bad6787846d549ac47bef5f8c6b56431f5bef5dd
-  data.tar.gz: c8c9be5b01fd966f8807f2c5645157100050f698
+  metadata.gz: c2bd5bd104786dfa4fced4ec016c5217d0d56a43
+  data.tar.gz: 5118bbb2416edb0a4abe6fff9cc8dbf425b9ce3b
 SHA512:
-  metadata.gz: ca386a268b779c503a074f5c3e1eee2da272b342c4716628ae7b957c1a5ed8f742434b14454ed87d986c0465f7c929e2c7abea1e364accb1fbb3f97eea4e1185
-  data.tar.gz: b5ae41b61014415bdb5fb47619901a6429b19a4b19a805f4c86c35982950e5eab3f0904b72a6ac7865ad693deb6f7469e63d8545c2b1d6c251572326b3ff88fc
+  metadata.gz: 33e203c5d4994ff406c19dfbf97eadd0554c4277eefd0503cee167ebf545611dbd7c9d9f1a50bd73f87ccaf1dc801b7d2f7f318915a5316a3b81ceb59a9e2893
+  data.tar.gz: 2f1d841f544a349e8e13db18a6415fc56735647aa2ea516f237b9a6e23a62a6f254e530f17f9235a49e4d4892079bee31210cff12cc6ae8add5c448a4878fcfe

data/.gitignore

@@ -19,3 +19,4 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+Gemfile.lock

data/.travis.yml

@@ -2,9 +2,14 @@ sudo: false
 language: ruby
 
 rvm:
-  - 2.1.5
-  - 2.2.2
-  - ruby-head
+  - 2.3.7
+  - 2.4.4
+  - 2.5.1
+
+env:
+  matrix:
+    - RAILS_VERSION=4.2.10
+    - RAILS_VERSION=5.2.1
 
 matrix:
   allow_failures:

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+1.3.0
+
+  * Test against latest supported ruby versions: 2.3.7, 2.4.4, 2.5.1 and rails versions: 4.2.10, 5.2.1.
+  * Add Rails 5 support
+
 1.2.0
 
   * **Feature**. Now it is possible to specify an acts_as_list column other than position @faucct 

data/Gemfile

@@ -2,7 +2,10 @@ source 'https://rubygems.org'
 
 gemspec
 
-gem 'activeadmin', github: 'activeadmin/activeadmin'
+gem 'activeadmin'
+gem 'coffee-script'
+gem 'puma'
+gem 'rails', *ENV['RAILS_VERSION']
 gem 'sqlite3'
 gem 'acts_as_list'
-gem 'rubocop'
+gem 'rubocop', '0.34.2'

data/lib/active_admin/sortable_table.rb

@@ -25,7 +25,7 @@ module ActiveAdmin
       # @param [ActiveAdmin::DSL] dsl
       # @return [void]
       #
-      def included(dsl)
+      def included(dsl) # rubocop:disable Metrics/AbcSize
         dsl.instance_eval do
           member_action :sort, method: :post do
             resource.insert_at params[:position].to_i
@@ -34,7 +34,7 @@ module ActiveAdmin
 
           member_action :move_to_top, method: :post do
             resource.move_to_top
-            redirect_to :back
+            redirect_to request.headers['HTTP_REFERER'] || collection_path
           end
         end
       end

data/lib/active_admin/sortable_table/version.rb

@@ -1,6 +1,6 @@
 module ActiveAdmin
   #
   module SortableTable
-    VERSION = '1.2.0'
+    VERSION = '1.3.0'
   end
 end

data/spec/dummy/app/assets/javascripts/active_admin.js

@@ -0,0 +1,3 @@
+//= require active_admin/base
+//= require jquery.simulate.drag-sortable
+//= require activeadmin_sortable_table

data/spec/dummy/app/assets/stylesheets/active_admin.scss

@@ -10,7 +10,7 @@
 // Active Admin's got SASS!
 @import "active_admin/mixins";
 @import "active_admin/base";
-@import "activeadmin_sortable_table";
+@import "activeadmin_sortable_table.css";
 // Overriding any non-variable SASS must be done after the fact.
 // For example, to change the default status-tag color:
 //

data/spec/dummy/config/application.rb

@@ -21,7 +21,9 @@ module Dummy
     # config.i18n.default_locale = :de
 
     # Do not swallow errors in after_commit/after_rollback callbacks.
-    config.active_record.raise_in_transactional_callbacks = true
+    if Rails.gem_version < Gem::Version.new('5')
+      config.active_record.raise_in_transactional_callbacks = true
+    end
   end
 end
 

data/spec/features/drag_and_drop_spec.rb

@@ -55,7 +55,7 @@ RSpec.describe ActiveAdmin::SortableTable, 'Drag-and-Drop', type: :feature, js:
       end
     end
 
-    it 'can not drug not by handle' do
+    it 'can not drag not by handle' do
       move_up(3, by: 2, use_handle: false)
 
       expect(visible_ids).to eq([1, 2, 3])
@@ -116,7 +116,7 @@ RSpec.describe ActiveAdmin::SortableTable, 'Drag-and-Drop', type: :feature, js:
       end
     end
 
-    it 'can not drug not by handle' do
+    it 'can not drag not by handle' do
       move_down(6, by: 2, use_handle: false)
 
       expect(visible_ids).to eq([4, 5, 6])
@@ -153,6 +153,6 @@ RSpec.describe ActiveAdmin::SortableTable, 'Drag-and-Drop', type: :feature, js:
         $("#category_#{element_id}").simulateDragSortable({ move: #{by} })
       JS
     end
-    sleep 0.5
+    sleep 0.7
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activeadmin_sortable_table
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Adam McCrea
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-16 00:00:00.000000000 Z
+date: 2018-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeadmin
@@ -153,7 +153,6 @@ files:
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
-- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -170,7 +169,7 @@ files:
 - spec/dummy/app/admin/categories.rb
 - spec/dummy/app/admin/dashboard.rb
 - spec/dummy/app/assets/images/.keep
-- spec/dummy/app/assets/javascripts/active_admin.js.coffee
+- spec/dummy/app/assets/javascripts/active_admin.js
 - spec/dummy/app/assets/javascripts/application.js
 - spec/dummy/app/assets/javascripts/jquery.simulate.drag-sortable.js
 - spec/dummy/app/assets/stylesheets/active_admin.scss
@@ -242,7 +241,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.14.1
 signing_key: 
 specification_version: 4
 summary: Drag and drop reordering interface for ActiveAdmin tables
@@ -252,7 +251,7 @@ test_files:
 - spec/dummy/app/admin/categories.rb
 - spec/dummy/app/admin/dashboard.rb
 - spec/dummy/app/assets/images/.keep
-- spec/dummy/app/assets/javascripts/active_admin.js.coffee
+- spec/dummy/app/assets/javascripts/active_admin.js
 - spec/dummy/app/assets/javascripts/application.js
 - spec/dummy/app/assets/javascripts/jquery.simulate.drag-sortable.js
 - spec/dummy/app/assets/stylesheets/active_admin.scss

data/Gemfile.lock

@@ -1,247 +0,0 @@
-GIT
-  remote: git://github.com/activeadmin/activeadmin.git
-  revision: a5a53c3f2b8fdfd2605575b62b158318f7651f46
-  specs:
-    activeadmin (1.0.0.pre1)
-      arbre (~> 1.0, >= 1.0.2)
-      bourbon
-      coffee-rails
-      formtastic (~> 3.1)
-      formtastic_i18n
-      inherited_resources (~> 1.6)
-      jquery-rails
-      jquery-ui-rails (~> 5.0)
-      kaminari (~> 0.15)
-      rails (>= 3.2, < 5.0)
-      ransack (~> 1.3)
-      sass-rails
-
-PATH
-  remote: .
-  specs:
-    activeadmin_sortable_table (1.2.0)
-      activeadmin (>= 1.0.0.pre1)
-      uber (= 0.0.15)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    actionmailer (4.2.4)
-      actionpack (= 4.2.4)
-      actionview (= 4.2.4)
-      activejob (= 4.2.4)
-      mail (~> 2.5, >= 2.5.4)
-      rails-dom-testing (~> 1.0, >= 1.0.5)
-    actionpack (4.2.4)
-      actionview (= 4.2.4)
-      activesupport (= 4.2.4)
-      rack (~> 1.6)
-      rack-test (~> 0.6.2)
-      rails-dom-testing (~> 1.0, >= 1.0.5)
-      rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (4.2.4)
-      activesupport (= 4.2.4)
-      builder (~> 3.1)
-      erubis (~> 2.7.0)
-      rails-dom-testing (~> 1.0, >= 1.0.5)
-      rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    activejob (4.2.4)
-      activesupport (= 4.2.4)
-      globalid (>= 0.3.0)
-    activemodel (4.2.4)
-      activesupport (= 4.2.4)
-      builder (~> 3.1)
-    activerecord (4.2.4)
-      activemodel (= 4.2.4)
-      activesupport (= 4.2.4)
-      arel (~> 6.0)
-    activesupport (4.2.4)
-      i18n (~> 0.7)
-      json (~> 1.7, >= 1.7.7)
-      minitest (~> 5.1)
-      thread_safe (~> 0.3, >= 0.3.4)
-      tzinfo (~> 1.1)
-    acts_as_list (0.7.2)
-      activerecord (>= 3.0)
-    addressable (2.3.8)
-    arbre (1.0.3)
-      activesupport (>= 3.0.0)
-    arel (6.0.3)
-    ast (2.1.0)
-    astrolabe (1.3.1)
-      parser (~> 2.2)
-    bourbon (4.2.4)
-      sass (~> 3.4)
-      thor (~> 0.19)
-    builder (3.2.2)
-    capybara (2.5.0)
-      mime-types (>= 1.16)
-      nokogiri (>= 1.3.3)
-      rack (>= 1.0.0)
-      rack-test (>= 0.5.4)
-      xpath (~> 2.0)
-    cliver (0.3.2)
-    coffee-rails (4.1.0)
-      coffee-script (>= 2.2.0)
-      railties (>= 4.0.0, < 5.0)
-    coffee-script (2.4.1)
-      coffee-script-source
-      execjs
-    coffee-script-source (1.9.1.1)
-    database_cleaner (1.5.0)
-    diff-lcs (1.2.5)
-    erubis (2.7.0)
-    execjs (2.6.0)
-    formtastic (3.1.3)
-      actionpack (>= 3.2.13)
-    formtastic_i18n (0.4.1)
-    globalid (0.3.6)
-      activesupport (>= 4.1.0)
-    has_scope (0.6.0)
-      actionpack (>= 3.2, < 5)
-      activesupport (>= 3.2, < 5)
-    i18n (0.7.0)
-    inherited_resources (1.6.0)
-      actionpack (>= 3.2, < 5)
-      has_scope (~> 0.6.0.rc)
-      railties (>= 3.2, < 5)
-      responders
-    jquery-rails (4.0.5)
-      rails-dom-testing (~> 1.0)
-      railties (>= 4.2.0)
-      thor (>= 0.14, < 2.0)
-    jquery-ui-rails (5.0.5)
-      railties (>= 3.2.16)
-    json (1.8.3)
-    kaminari (0.16.3)
-      actionpack (>= 3.0.0)
-      activesupport (>= 3.0.0)
-    launchy (2.4.3)
-      addressable (~> 2.3)
-    loofah (2.0.3)
-      nokogiri (>= 1.5.9)
-    mail (2.6.3)
-      mime-types (>= 1.16, < 3)
-    mime-types (2.6.1)
-    mini_portile (0.6.2)
-    minitest (5.8.0)
-    multi_json (1.11.2)
-    nokogiri (1.6.6.2)
-      mini_portile (~> 0.6.0)
-    parser (2.2.2.6)
-      ast (>= 1.1, < 3.0)
-    phantomjs (2.1.1.0)
-    poltergeist (1.6.0)
-      capybara (~> 2.1)
-      cliver (~> 0.3.1)
-      multi_json (~> 1.0)
-      websocket-driver (>= 0.2.0)
-    polyamorous (1.2.0)
-      activerecord (>= 3.0)
-    powerpack (0.1.1)
-    rack (1.6.4)
-    rack-test (0.6.3)
-      rack (>= 1.0)
-    rails (4.2.4)
-      actionmailer (= 4.2.4)
-      actionpack (= 4.2.4)
-      actionview (= 4.2.4)
-      activejob (= 4.2.4)
-      activemodel (= 4.2.4)
-      activerecord (= 4.2.4)
-      activesupport (= 4.2.4)
-      bundler (>= 1.3.0, < 2.0)
-      railties (= 4.2.4)
-      sprockets-rails
-    rails-deprecated_sanitizer (1.0.3)
-      activesupport (>= 4.2.0.alpha)
-    rails-dom-testing (1.0.7)
-      activesupport (>= 4.2.0.beta, < 5.0)
-      nokogiri (~> 1.6.0)
-      rails-deprecated_sanitizer (>= 1.0.1)
-    rails-html-sanitizer (1.0.2)
-      loofah (~> 2.0)
-    railties (4.2.4)
-      actionpack (= 4.2.4)
-      activesupport (= 4.2.4)
-      rake (>= 0.8.7)
-      thor (>= 0.18.1, < 2.0)
-    rainbow (2.0.0)
-    rake (10.4.2)
-    ransack (1.7.0)
-      actionpack (>= 3.0)
-      activerecord (>= 3.0)
-      activesupport (>= 3.0)
-      i18n
-      polyamorous (~> 1.2)
-    responders (2.1.0)
-      railties (>= 4.2.0, < 5)
-    rspec-core (3.3.2)
-      rspec-support (~> 3.3.0)
-    rspec-expectations (3.3.1)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.3.0)
-    rspec-mocks (3.3.2)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.3.0)
-    rspec-rails (3.3.3)
-      actionpack (>= 3.0, < 4.3)
-      activesupport (>= 3.0, < 4.3)
-      railties (>= 3.0, < 4.3)
-      rspec-core (~> 3.3.0)
-      rspec-expectations (~> 3.3.0)
-      rspec-mocks (~> 3.3.0)
-      rspec-support (~> 3.3.0)
-    rspec-support (3.3.0)
-    rubocop (0.34.2)
-      astrolabe (~> 1.3)
-      parser (>= 2.2.2.5, < 3.0)
-      powerpack (~> 0.1)
-      rainbow (>= 1.99.1, < 3.0)
-      ruby-progressbar (~> 1.4)
-    ruby-progressbar (1.7.5)
-    sass (3.4.18)
-    sass-rails (5.0.4)
-      railties (>= 4.0.0, < 5.0)
-      sass (~> 3.1)
-      sprockets (>= 2.8, < 4.0)
-      sprockets-rails (>= 2.0, < 4.0)
-      tilt (>= 1.1, < 3)
-    sprockets (3.3.4)
-      rack (~> 1.0)
-    sprockets-rails (2.3.3)
-      actionpack (>= 3.0)
-      activesupport (>= 3.0)
-      sprockets (>= 2.8, < 4.0)
-    sqlite3 (1.3.10)
-    thor (0.19.1)
-    thread_safe (0.3.5)
-    tilt (2.0.1)
-    tzinfo (1.2.2)
-      thread_safe (~> 0.1)
-    uber (0.0.15)
-    websocket-driver (0.6.2)
-      websocket-extensions (>= 0.1.0)
-    websocket-extensions (0.1.2)
-    xpath (2.0.0)
-      nokogiri (~> 1.3)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  activeadmin!
-  activeadmin_sortable_table!
-  acts_as_list
-  capybara
-  database_cleaner
-  launchy
-  phantomjs
-  poltergeist
-  rails (~> 4.2)
-  rspec-rails (~> 3.3)
-  rubocop
-  sqlite3
-
-BUNDLED WITH
-   1.14.3

data/spec/dummy/app/assets/javascripts/active_admin.js.coffee

@@ -1,3 +0,0 @@
-#= require active_admin/base
-#= require jquery.simulate.drag-sortable
-#= require activeadmin_sortable_table