activeadmin_reorderable 0.0.1 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: e310f082a9ea3570f41763b70f87913ea42d9fe0
-  data.tar.gz: 5190b5b7255acfde21b7961a2ba54028319ecb42
+SHA256:
+  metadata.gz: a3444cc5455393598880575853ae90a3fa3c96ad70db05266319ca3f11175321
+  data.tar.gz: 4f61654aee46f935210df56e3ff98702538a0bd455937b57d3ad19f766d4e92b
 SHA512:
-  metadata.gz: b1d34bd9eaea1df4cf8dc937591ccd8d4c160a05f1bae9c57fb537bd5747cf8482b9e1c3452281d6605c28946f90ce04d72787912132c953038d35205b8a5f03
-  data.tar.gz: a11e92314ae39121376cdb899f0f6c96d7da846339754e83a66b9a0dcd15cafc0897591dd6ce2a269717a047eaf2d1ed4c283e80e86fe7bc9fbcef9f603a890a
+  metadata.gz: e8b5032d8e89cd76d8649656e240509296b9dd4b150c9a5ac5fa4e5c84bd1f6753ed2a400dc2cc4954b0ecaae5fd776885747f97973e1ca701a2bbc225f2d4c1
+  data.tar.gz: 9e68c6debce31865ba13d2ed203ae2317ad06cb42040b6308590ab8db4b3ea921de6b2e0e61b11448f9b869fa8b568ed2e477c98878370d14fa26a489070b515

data/.gitignore

@@ -0,0 +1 @@
+builds/*

data/CHANGELOG.md

@@ -0,0 +1,9 @@
+# Changelog
+
+## 0.1.0
+
+- Replace deprecated `render :nothing` with `head :ok` (thanks @zharikovpro)
+
+## 0.0.3
+
+- Removed a console.log within the reordering JavaScript.

data/CONTRIBUTING.md

@@ -0,0 +1,27 @@
+# Contributing
+
+Thank you for considering a contribution to this project!
+
+## Deployment
+
+`activeadmin_reorderable` is published on http://rubygems.org. The
+following steps are necessary to push a new version:
+
+### Build the gem
+
+`gem build activeadmin_reorderable.gemspec`
+
+This will produce an artifact named roughly
+`activeadmin_reorderable-<version>.gem`.
+
+### Publish the gem
+
+`gem push activeadmin_reorderable-<version>.gem`
+
+You may bump into permissions issues if you have not been added as an
+owner on the gem. Consult the Viget development team for acess.
+
+## Reviews
+
+All changes should be submitted through pull request. Ideally, at
+least two :+1:s should be given before a pull request is merge.

data/README.md

@@ -52,3 +52,15 @@ ActiveAdmin.register Widget do
   end
 end
 ```
+
+## Contributing
+
+1. Fork it ( https://github.com/[my-github-username]/activeadmin_reorderable/fork )
+2. Create your feature branch (`git checkout -b my-new-feature`)
+3. Commit your changes (`git commit -am "Add some feature"`)
+4. Push to the branch (`git push origin my-new-feature`)
+5. Create a new Pull Request
+
+### Issue and PR reviews
+
+Another way you can help is by reviewing issues, trying to reproduce bugs, and providing feedback on PRs.

data/app/assets/javascripts/activeadmin_reorderable.js

@@ -1,8 +1,7 @@
-$.fn.reorderable = function(opts) {
+$.fn.reorderable = function (opts) {
   // This helper fixes the table row width collapsing when being dragged
   function reorderableTableHelper(e, ui) {
-    console.log(ui);
-    ui.children().each(function() {
+    ui.children().each(function () {
       var $cell = $(this);
 
       $cell.width($cell.width());
@@ -19,16 +18,17 @@ $.fn.reorderable = function(opts) {
   }
 
   function reorderableTableStop(e, ui) {
-    var $row    = ui.item,
-        $rows   = $row.parent().children('tr'),
-        $table  = $row.closest('table'),
-        $handle = $row.find('.reorder-handle'),
-        url     = $handle.data('reorder-url'),
-        index   = function(i) { return $rows.index(i) + 1; };
+    var $row = ui.item,
+      $rows = $row.parent().children('tr'),
+      $table = $row.closest('table'),
+      $handle = $row.find('.reorder-handle'),
+      url = $handle.data('reorder-url'),
 
-    $table.find('tbody tr').each(function(index) {
-      var $row     = $(this),
-          newClass = ''
+      index = function (i) { return $rows.index(i) + 1; };
+
+    $table.find('tbody tr').each(function (index) {
+      var $row = $(this),
+        newClass = ''
 
       $row.removeClass('odd').removeClass('even');
 
@@ -41,27 +41,33 @@ $.fn.reorderable = function(opts) {
       $row.addClass(newClass);
     });
 
-    $rows.each(function() {
+    $rows.each(function () {
       $(this).find('.position').text(index($(this)));
     });
+    var top_id = $row.prev().find('.reorder-handle').data("reorderId")
+    var bottom_id = $row.next().find('.reorder-handle').data("reorderId")
 
-    $.post(url, { position: index($row) });
+    $.post(url, {
+      position: index($row),
+      top_id: top_id,
+      bottom_id: bottom_id 
+    });
   }
 
-  return this.each(function() {
+  return this.each(function () {
     var opts = $.extend({
-      items:  'tbody tr',
+      items: 'tbody tr',
       handle: '.reorder-handle',
-      axis:   'y',
+      axis: 'y',
       helper: reorderableTableHelper,
-      start:  reorderableTableStart,
-      stop:   reorderableTableStop,
+      start: reorderableTableStart,
+      stop: reorderableTableStop,
     }, opts || {});
 
     $(this).sortable(opts);
   });
 };
 
-$(function() {
+$(function () {
   $('.aa-reorderable').reorderable();
 });

data/lib/active_admin/reorderable/dsl.rb

@@ -6,7 +6,7 @@ module ActiveAdmin
       def reorderable(&block)
         body = proc do
           resource.insert_at(params[:position].to_i)
-          render :nothing => true
+          head :ok
         end
 
         member_action(:reorder, :method => :post, &block || body)

data/lib/active_admin/reorderable/table_methods.rb

@@ -11,8 +11,12 @@ module ActiveAdmin
       private
 
       def reorder_handle_for(resource)
-        url = url_for([:reorder, :admin, resource])
-        span(reorder_handle_content, :class => 'reorder-handle', 'data-reorder-url' => url)
+        aa_resource   = active_admin_namespace.resource_for(resource.class)
+        instance_name = aa_resource.resources_configuration[:self][:route_instance_name]
+
+        url = send([:reorder, aa_resource.route_prefix, instance_name, :path].join('_'), resource)
+
+        span(reorder_handle_content, :class => 'reorder-handle', 'data-reorder-url' => url, 'data-reorder-id' => resource.id)
       end
 
       def reorder_handle_content

data/lib/activeadmin_reorderable/version.rb

@@ -1,3 +1,3 @@
 module ActiveadminReorderable
-  VERSION = "0.0.1"
+  VERSION = "0.1.5"
 end

metadata

@@ -1,28 +1,28 @@
 --- !ruby/object:Gem::Specification
 name: activeadmin_reorderable
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.5
 platform: ruby
 authors:
 - Chris Jones
 - Lawson Kurtz
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2014-04-24 00:00:00.000000000 Z
+date: 2021-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeadmin
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.6'
 description: Add drag and drop reordering to ActiveAdmin tables.
@@ -32,6 +32,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".gitignore"
+- CHANGELOG.md
+- CONTRIBUTING.md
 - Gemfile
 - MIT-LICENSE
 - README.md
@@ -49,25 +52,23 @@ homepage: http://www.github.com/vigetlabs/activeadmin_reorderable
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.1
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: Drag and drop reordering for ActiveAdmin tables
 test_files: []
-has_rdoc: