activeadmin_polymorphic 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 806875f4dc043b24f94549838a81c5ad6d180e4b
-  data.tar.gz: 786835f0298f3ce1e08870a9bede6f9ab036d9e6
+  metadata.gz: ea40004a0a7bb3aef319d8e0b0d233b3f3321436
+  data.tar.gz: a51f08e75f8e5bdc1cfe67d66d9b747668e6859c
 SHA512:
-  metadata.gz: 8a5da9426cf627abefc48134e70fc9bea72ebd90de1f8c1e28094e6dc693037609120a1ed514a26a1d5b417ed64a6d558623f8a47ffcab26b0585eee6b60b2e5
-  data.tar.gz: d8f296a37a267d68ccccf8d9cfea1b8449f7ebe66b3a889e1791ad29126093191a68bde27f27c8834cb093d4aa64a03bd8eff151f36b3c0e2a65bede0e26e666
+  metadata.gz: 4b3cb0a0b38df959b3dcd5b26b6508a8b2cf7f3d2984c0f98073a41f4f7b88a5de7cc7c61523a3269ab993bb9035d935754aea040a8e8d2a80762a9cc346840f
+  data.tar.gz: c10e8cfd50e7caae2ded2bf30dfa68b1c8914d170ad7bef1a6503f6682b4512802338f09c52bf3e9fc0358f459671ccc4a3ff8d20dbce6335011bed7921411cd

data/README.md

@@ -21,20 +21,25 @@ gem "activeadmin_polymorphic"
 
 and run `bundle install`.
 
-Include assets in js and css manifests
+Include assets in JS and CSS manifests
 
+JS:
 ```
 #= require activeadmin_polymorphic
+```
+
+CSS:
+```
 @import "activeadmin_polymorphic";
 ```
 
 # Usage
 
-To use gem, your model should have related model, which works as a proxy to polymorphic relations.
+To use the gem, your model should have a related model, which works as a proxy to polymorphic relations.
 
 ![](https://s3.amazonaws.com/f.cl.ly/items/2Z3M2V0b3Z342L2Z2R0N/Screen%20Shot%202015-02-05%20at%2013.37.36.png)
 
-Gem extrands activeadmin's form builder, so to enable `has_many_polymorphic` method you need to override form builder using `builder` option:
+The gem extends activeadmin's form builder, so to enable the `has_many_polymorphic` method you need to override form builder using the `builder` option:
 
 ```
 ...
@@ -47,38 +52,38 @@ end
 ```
 
 There are few options available:
-* first option is a name of polymorphic has_many association
-* second option referes to polymorphied version of association name (sectionable_id and sectaionable_type for example)
+* first option, the name of polymorphic has_many association
+* second option, referes to polymorphied version of an association name (sectionable_id and sectaionable_type for example)
 * `types` - list of related models you want to use
-* `allow_destroy` - weather or not to allow to destroy related objects
+* `allow_destroy` - whether or not to allow destroying related objects
 * `sortable` - enables drag'n'drop for nested forms, accepts sortable column name, for example `sortable: :priority`
 
-Subforms for polymorphic relations are forms which you define in your ActiveAdmin. Gem fetches and submits them using some ajax magic.
+Subforms for polymorphic relations are forms which you define in your ActiveAdmin. The gem fetches and submits them using some ajax magic.
 
 # Under the hood
 
-This gem is a set of dirty hacks and tricks. Calling `polymorphic_has_many` makes it to do the following things:
+This gem is a set of dirty hacks and tricks. Calling `polymorphic_has_many` makes it do the following things:
 
-* for new records it generates dropdown with polymorphic types
-* for exising records it generates two hidden fields with id and type
-* then the real javascript starts, it extracts whole forms from polymorphic models new or edit pages, strips form actions, and inserts that forms right into parent form
-* when you try to submit forms, javascripts submit subforms first; if subforms are invalid, it reloads them with erros and interupts  main form submission process
-* after all sub forms successfully saved, it strips them (because forms nested into other forms are simantically invalid, right?) and submits parent form
+* for new records it generates a dropdown with polymorphic types
+* for exising records it generates two hidden fields with `id` and `type`
+* then the real JavaScript starts, it extracts whole forms from polymorphic models new or edit pages, strips form actions, and inserts those forms right into the parent form
+* when you try to submit forms, JavaScript submits subforms first; if subforms are invalid, it reloads them with erros and interupts the main form's submission process
+* after all subforms have been successfully saved, it strips them (because forms nested into other forms are simantically invalid, right?) and submits the parent form
 
 # File uploads in subforms
 
-Gem relies on [rails ajax](https://github.com/rails/jquery-rails) form submissions, which doesn't allow to submit files directly. Workaround for it is asynchronous file submission using for example [remotipart](https://github.com/JangoSteve/remotipart) for CarrierWave or [refile](https://github.com/elabs/refile) with [refile-input](https://github.com/hyperoslo/refile-input). Note: before subforms submissions javascript strips all file inputs from forms.
+The gem relies on [rails ajax](https://github.com/rails/jquery-rails)'s form submissions, which doesn't allow to submit files directly. Workaround for this is asynchronous file submission using, for example [remotipart](https://github.com/JangoSteve/remotipart) for CarrierWave, or [refile](https://github.com/elabs/refile) with [refile-input](https://github.com/hyperoslo/refile-input). Note: before subforms submissions JavaScript strips all file inputs from the forms.
 
 # Testing
 
-Tests stucture is mostly copied from original ActiveAdmin.
+Test's stucture is mostly copied from the original ActiveAdmin.
 
-Install development dependencies with `bundle install`. To setup test suit run `rake test`. Run tests with `bundle exec guard`. There aren't many of them, let's say there are quite a few.
+Install development dependencies with `bundle install`. To setup the test suit run `rake test`. Run tests with `bundle exec guard`. There aren't many of them, let's say there are quite a few.
 
 # In plan
 
 * allow to reuse existing polymorphic objects
-* check who it works with  models under sertain namespace
+* check who it works with: models under a certain namespace
 * improve tests
 
 # License

data/lib/activeadmin_polymorphic/form_builder.rb

@@ -51,7 +51,11 @@ module ActiveadminPolymorphic
         contents << has_many_form.input(builder_options[:sortable], as: :hidden)
 
         contents << template.content_tag(:li, class: 'handle') do
-          ::ActiveAdmin::Iconic.icon :move_vertical
+          '''
+          <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" id="Layer_1" x="0px" y="0px" width="30px" height="25px" viewBox="0 0 550 550" enable-background="new 0 0 550 550" xml:space="preserve">
+            <path d="M418.909,456.728h-93.091v-288l-93.091,93.091V139.637L372.363,0L512,139.637v122.182l-93.091-93.091V456.728z   M93.091,84.363h93.091v288l93.091-93.091v122.182L139.637,541.091L0,401.454V279.272l93.091,93.091V84.363z"></path>
+          </svg>
+          '''.html_safe
         end
       end
 

data/lib/activeadmin_polymorphic/version.rb

@@ -1,3 +1,3 @@
 module ActiveadminPolymorphic
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activeadmin_polymorphic
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Petr Sergeev
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-05 00:00:00.000000000 Z
+date: 2015-04-20 00:00:00.000000000 Z
 dependencies: []
 description: This gem extends formtastic's form builder to support polymoprhic has
   many relations in your forms
@@ -74,7 +74,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: HasMany polymoprhic support for active admin.