activeadmin_favorites 0.1.5 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ff5b3c593b66aca8d7ebe1bdf1997d8eef0241f5a959aaeb2df486069c220d75
-  data.tar.gz: b2f7a9c06c263889b6949c51eb03c4fb6f8257685c4f2eb7430e2268fcb28125
+  metadata.gz: 87ee6c5a7e74841630d69de986dcc7dfef4f799e094f696529b3fe51b6c53552
+  data.tar.gz: b9381534a09f71b745c9d3a317d4890c0a21391c27be544e421be5b76cda43c2
 SHA512:
-  metadata.gz: d65424d28f1f81b94602c44b2f0fd0051c7bd38e9887fcb66beb63295b64ad25a72b2ccf0e45bd18991c4ce1ce8561ef7b5908ddb428e66beb04f5accf308ace
-  data.tar.gz: 8f5b9d04b0f105e46c4fb7d88b520472d26fbe699bebd4d38a4c663d839e9545ea3cd6599e4085b663b03142740a964fd89b3ea689010d65a5b576930ad6dd16
+  metadata.gz: 422903c24269839ed1142a83e6c8fcc1f5aff493eba16a6d91574869eaaf8c64dcdde3b650c8ce4a90a29f56c4bdc2f656881204e44bb6a60b135eb7ece956e7
+  data.tar.gz: f9bf4dabb5f05f413a031b90694af82929117f14c5b3855c05be0c057f39d66441a83e68d755826ef4ff180a3e367f4f04d18a66a9e57c8d23c29f5965a8e893

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # CHANGELOG
 
+## 0.1.7 (2026-10-29)
+
+- Fix engine view path order so favorites sits immediately before ActiveAdmin and host `app/views` stays ahead of the gem `_html_head`. Rails engines prepend view paths; the previous reorder left favorites first whenever it was already ahead of ActiveAdmin.
+
+## 0.1.6 (2026-10-27)
+
+- Link the personalization menu stylesheet from Active Admin's HTML head so hosts no longer need a Tailwind `@import` of the Propshaft path.
+- Document `ActiveAdmin::Favorites.personalization_menu_stylesheet_path` for hosts that concatenate the plain CSS into a Tailwind CLI entry.
+
 ## 0.1.5 (2026-10-26)
 
 - Keep personalization menu actions in view while a long catalog scrolls.

data/README.md

@@ -61,10 +61,18 @@ When using ActionPolicy, add `save_lens_favorite?` and `reset?` to `ActiveAdmin:
 
 ### Stylesheet
 
-Import the personalization menu stylesheet into the ActiveAdmin CSS entrypoint so the cogwheel dropdown can scroll the catalog while keeping action buttons in view:
+The engine ships an `active_admin/_html_head` that links `activeadmin_favorites/personalization_menu` so the cogwheel dropdown can scroll the catalog while keeping action buttons in view. The file is plain CSS served through Propshaft; it does not need Tailwind processing. Engine view paths sit immediately before ActiveAdmin's, so a host `app/views/active_admin/_html_head` still wins.
 
-```css
-@import "activeadmin_favorites/personalization_menu.css";
+If the host overrides that partial, add the link there:
+
+```erb
+<%= stylesheet_link_tag "activeadmin_favorites/personalization_menu" %>
+```
+
+Do not bare-`@import` that Propshaft logical path into an Active Admin CSS entry that Tailwind CLI compiles from a generated `tmp` file. Tailwind resolves imports from the input file directory, not through Propshaft. Hosts that must fold the rules into one built stylesheet can concatenate the absolute file instead:
+
+```ruby
+File.read(ActiveAdmin::Favorites.personalization_menu_stylesheet_path)
 ```
 
 ### Locales

data/app/views/active_admin/_html_head.html.erb

@@ -0,0 +1,14 @@
+<%= stylesheet_link_tag "active_admin" %>
+<%= stylesheet_link_tag ActiveAdmin::Favorites::PERSONALIZATION_MENU_STYLESHEET %>
+<meta name="viewport" content="width=device-width,initial-scale=1">
+<%= csrf_meta_tags %>
+<%= csp_meta_tag %>
+<% # On page load or when changing themes, best to add inline in `head` to avoid FOUC %>
+<%= javascript_tag nonce: true do %>
+  if (localStorage.theme === 'dark' || (!('theme' in localStorage) && window.matchMedia('(prefers-color-scheme: dark)').matches)) {
+    document.documentElement.classList.add('dark')
+  } else {
+    document.documentElement.classList.remove('dark')
+  }
+<% end %>
+<%= javascript_importmap_tags "active_admin", importmap: ActiveAdmin.importmap %>

data/lib/activeadmin/favorites/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveAdmin
   module Favorites
-    VERSION = "0.1.5"
+    VERSION = "0.1.7"
   end
 end

data/lib/activeadmin/favorites/view_paths.rb

@@ -2,15 +2,17 @@
 
 module ActiveAdmin
   module Favorites
-    # Place this engine's views ahead of ActiveAdmin's so resource index/show
-    # overrides (catalog injection) win, while the host app/views path stays first.
+    # Place this engine's views immediately before ActiveAdmin's so resource
+    # index/show overrides (catalog injection) win. Rails engines prepend their
+    # view paths, so favorites can otherwise sit ahead of the host app/views and
+    # shadow customized templates such as active_admin/_html_head.
     module ViewPaths
       module_function
 
       def prefer_over_active_admin!(view_paths)
         path_strings = view_paths.to_a.map { |path| path.to_s }
         reordered = reorder_path_strings(path_strings)
-        return view_paths if reordered.equal?(path_strings)
+        return view_paths if reordered == path_strings
 
         ActionView::PathSet.new(reordered)
       end
@@ -25,24 +27,32 @@ module ActiveAdmin
 
       def reorder_path_strings(path_strings)
         favorites_root = Engine.root.join("app/views").to_s
-        return path_strings unless path_strings.include?(favorites_root)
+        active_admin_root = active_admin_views_root(path_strings)
+        return path_strings unless path_strings.include?(favorites_root) && active_admin_root
+        return path_strings if already_before_active_admin?(path_strings, favorites_root, active_admin_root)
 
-        active_admin_root = path_strings.find do |path|
-          path.match?(%r{/gems/activeadmin-[^/]+/app/views\z})
-        end
-        return path_strings unless active_admin_root
+        place_before_active_admin(path_strings, favorites_root, active_admin_root)
+      end
 
-        favorites_index = path_strings.index(favorites_root)
-        active_admin_index = path_strings.index(active_admin_root)
-        return path_strings if favorites_index < active_admin_index
+      def active_admin_views_root(path_strings)
+        path_strings.find { |path| path.match?(%r{/gems/activeadmin-[^/]+/app/views\z}) }
+      end
 
+      def already_before_active_admin?(path_strings, favorites_root, active_admin_root)
+        path_strings.index(favorites_root) == path_strings.index(active_admin_root) - 1
+      end
+
+      def place_before_active_admin(path_strings, favorites_root, active_admin_root)
         moved = path_strings.dup
-        moved.delete_at(favorites_index)
+        moved.delete(favorites_root)
         moved.insert(moved.index(active_admin_root), favorites_root)
         moved
       end
-      module_function :reorder_path_strings
-      private_class_method :reorder_path_strings
+
+      module_function :reorder_path_strings, :active_admin_views_root,
+        :already_before_active_admin?, :place_before_active_admin
+      private_class_method :reorder_path_strings, :active_admin_views_root,
+        :already_before_active_admin?, :place_before_active_admin
     end
   end
 end

data/lib/activeadmin/favorites.rb

@@ -5,6 +5,8 @@ require "activeadmin/favorites/configuration"
 
 module ActiveAdmin
   module Favorites
+    PERSONALIZATION_MENU_STYLESHEET = "activeadmin_favorites/personalization_menu"
+
     class << self
       def config
         @config ||= Configuration.new
@@ -14,6 +16,13 @@ module ActiveAdmin
         yield config
       end
 
+      # Absolute path to the plain CSS file Propshaft serves. Hosts that
+      # concatenate into a Tailwind CLI entry can File.read this path; do not
+      # bare-@import the Propshaft logical path from a tmp Tailwind input.
+      def personalization_menu_stylesheet_path
+        Engine.root.join("app/assets/stylesheets/#{PERSONALIZATION_MENU_STYLESHEET}.css")
+      end
+
       def install!
         require "activeadmin/favorites/install"
         Install.call

data/sig/activeadmin/favorites.rbs

@@ -1,5 +1,8 @@
 module ActiveAdmin
   module Favorites
     VERSION: String
+    PERSONALIZATION_MENU_STYLESHEET: String
+
+    def self.personalization_menu_stylesheet_path: () -> Pathname
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activeadmin_favorites
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.7
 platform: ruby
 authors:
 - Andrei Makarov
@@ -355,6 +355,7 @@ files:
 - app/models/active_admin/favorites/lens_favorite.rb
 - app/models/active_admin/favorites/view_lens/layout.rb
 - app/models/active_admin/favorites/view_lens_default.rb
+- app/views/active_admin/_html_head.html.erb
 - app/views/active_admin/favorites/_lens_catalog_data.html.erb
 - app/views/active_admin/favorites/_macro_fields.html.erb
 - app/views/active_admin/favorites/_personalization_trigger.html.erb