activeadmin_dynamic_fields 0.5.0 → 0.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '019f2b81ed1552f13f57b73141860957f4869b10de1f018a289aa8724cc23ec1'
-  data.tar.gz: 4ed1bb60f5b1ddef1a3d870296d8548faa18cc36db5adadb8271f0c655c769f6
+  metadata.gz: 1a0aa1741561ea938be8cfdfb7d75df0b85ba24dcdf303639ac3824ffc6ddd4f
+  data.tar.gz: 208287487042b2ef3de93b20f9a733383e470e44473c40b398b3600ec18f11bc
 SHA512:
-  metadata.gz: b07cc4e73b801ef79ee52b52a6c82117d7e966a2f1eadb0e415e00c608456c02f2c14694c2fc41037ad381c9c0c3bfbf1c0ed96c0c6d13bd0ce3335c38dc1e11
-  data.tar.gz: c0aa33df12ef6ed16927a49bb9b93d0fcffeffc6f20b661f11edb350544f12e550f90fd5fa5870a43154c0097995bbb02f2f80f24e1ff821eddc2d0fa60e613d
+  metadata.gz: 6817a8dccfb3691bf61cfe2f8a30d0dd51fb45b40becc20fab9b36fe9b8c573e9f78f68dc12e6c8a0e91c34d2416d773f5f3a1d62359b32e2888e68b2d19113a
+  data.tar.gz: 0f15dcb8b29b7cbf73ba0e6932b6a0dd42a91ca883357ea0024da13b5b65867c2cf22bcae0458967ec37f70a7667607c0cb65be8aa43b17319b83595c2ee8cbd

data/README.md

@@ -1,8 +1,10 @@
-# ActiveAdmin Dynamic Fields [![Gem Version](https://badge.fury.io/rb/activeadmin_dynamic_fields.svg)](https://badge.fury.io/rb/activeadmin_dynamic_fields) [![CircleCI](https://circleci.com/gh/blocknotes/activeadmin_dynamic_fields.svg?style=svg)](https://circleci.com/gh/blocknotes/activeadmin_dynamic_fields)
+# ActiveAdmin Dynamic Fields
+[![gem version](https://badge.fury.io/rb/activeadmin_dynamic_fields.svg)](https://badge.fury.io/rb/activeadmin_dynamic_fields) [![gem downloads](https://badgen.net/rubygems/dt/activeadmin_dynamic_fields)](https://rubygems.org/gems/activeadmin_dynamic_fields) [![linters](https://github.com/blocknotes/activeadmin_dynamic_fields/actions/workflows/linters.yml/badge.svg)](https://github.com/blocknotes/activeadmin_dynamic_fields/actions/workflows/linters.yml) [![specs](https://github.com/blocknotes/activeadmin_dynamic_fields/actions/workflows/specs.yml/badge.svg)](https://github.com/blocknotes/activeadmin_dynamic_fields/actions/workflows/specs.yml)
 
 An Active Admin plugin to add dynamic behaviors to some fields.
 
 Features:
+
 - set conditional checks on fields
 - trigger actions on target elements
 - inline field editing
@@ -10,19 +12,39 @@ Features:
 
 The easiest way to show how this plugin works is looking the examples [below](#examples).
 
+Please :star: if you like it.
+
 ## Install
-- Add to your Gemfile: `gem 'activeadmin_dynamic_fields'`
-- Execute bundle
-- Add at the end of your ActiveAdmin javascripts (_app/assets/javascripts/active_admin.js_):
+
+First, add the gem to your ActiveAdmin project: `gem 'activeadmin_dynamic_fields'` (and execute `bundle`)
+
+If you installed Active Admin **without Webpacker** support:
+- add at the end of your ActiveAdmin javascripts (_app/assets/javascripts/active_admin.js_):
 
 ```js
 //= require activeadmin/dynamic_fields
 ```
 
+Otherwise **with Webpacker**:
+
+- Execute in your project root:
+
+```sh
+yarn add blocknotes/activeadmin_dynamic_fields
+```
+
+- Add to your *app/javascript/packs/active_admin.js*:
+
+```js
+require('activeadmin_dynamic_fields')
+```
+
 ## Options
+
 Options are passed to fields using *input_html* parameter as *data* attributes.
 
 Conditions:
+
 - **data-if**: check a condition, values:
   + **checked**: check if a checkbox is checked (ex. `"data-if": "checked"`)
   + **not_checked**: check if a checkbox is not checked
@@ -36,6 +58,7 @@ Conditions:
 - **data-function**: check the return value of a custom function (ex. `"data-function": "my_check"`)
 
 Actions:
+
 - **data-then**: action to trigger (alias **data-action**), values:
   + **hide**: hides elements (ex. `"data-then": "hide", "data-target": ".errors"`)
   + **slide**: hides elements (using sliding)
@@ -49,6 +72,7 @@ Actions:
 - **data-args**: arguments passed to the callback function
 
 Targets:
+
 - **data-target**: target css selector (from parent fieldset, look for the closest match)
 - **data-gtarget**: target css selector globally
 
@@ -57,6 +81,7 @@ A check condition or a custom check function are required. A trigger action is r
 ## Examples
 
 ### Dynamic fields examples
+
 - A checkbox that hides other fields if is checked (ex. model *Article*):
 
 ```rb
@@ -128,6 +153,7 @@ function on_change_category(el) {
 ```
 
 ### Inline editing examples
+
 - Prepare a custom member action to save data, an *update* helper function is available (third parameter is optional, allow to filter using strong parameters):
 
 ```rb
@@ -165,6 +191,7 @@ end
 ```
 
 ### Dialog example
+
 Example with 2 models: *Author* and *Article*
 
 Prepare the content dialog - in Active Admin Author config:
@@ -208,13 +235,16 @@ end
 The link url is loaded via AJAX before opening the dialog.
 
 ## Do you like it? Star it!
-If you use this component just star it. A developer is more motivated to improve a project when there is some interest.
 
-Take a look at [other ActiveAdmin components](https://github.com/blocknotes?utf8=✓&tab=repositories&q=activeadmin&type=source) that I made if you are curious.
+If you use this component just star it. A developer is more motivated to improve a project when there is some interest. My other [Active Admin components](https://github.com/blocknotes?utf8=✓&tab=repositories&q=activeadmin&type=source).
+
+Or consider offering me a coffee, it's a small thing but it is greatly appreciated: [about me](https://www.blocknot.es/about-me).
 
 ## Contributors
+
 - [Mattia Roccoberton](http://blocknot.es): author
 - The good guys that opened issues and pull requests from time to time
 
 ## License
+
 The gem is available as open-source under the terms of the [MIT](LICENSE.txt).

data/Rakefile

@@ -1,3 +1,16 @@
 # frozen_string_literal: true
 
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
+
+begin
+  require 'rspec/core/rake_task'
+
+  RSpec::Core::RakeTask.new(:spec) do |t|
+    # t.ruby_opts = %w[-w]
+    t.rspec_opts = ['--color', '--format documentation']
+  end
+
+  task default: :spec
+rescue LoadError
+  puts '! LoadError: no RSpec available'
+end

data/app/assets/javascripts/activeadmin/dynamic_fields.js

@@ -1,6 +1,7 @@
 (function () {
   'use strict'
 
+  // noinspection JSUnusedGlobalSymbols
   const ACTIONS = {
     addClass: (el, name) => el.addClass(name),
     addStyle: (el, extra_style) => {
@@ -11,7 +12,8 @@
       }
     },
     callback: (el, name) => {
-      if (window[name]) window[name](el.data('args'))
+      const cb_function = window.hasOwnProperty(name) ? window[name] : null
+      if (typeof cb_function === 'function') cb_function(el.data('args'))
       else {
         el.attr('data-df-errors', 'callback function not found')
         console.warn(`activeadmin_dynamic_fields callback function not found: ${name}`)
@@ -21,13 +23,14 @@
     hide: el => el.hide(),
     setText: (el, text) => el.text(text),
     setValue: (el, value) => {
-      if (el.attr('type') == 'checkbox') el.prop('checked', value == '1')
+      if (el.attr('type') === 'checkbox') el.prop('checked', value === '1')
       else el.val(value)
       el.trigger('change')
     },
     slide: el => el.slideUp()
   }
 
+  // noinspection EqualityComparisonWithCoercionJS, JSUnusedGlobalSymbols
   const CONDITIONS = {
     blank: el => el.val().length === 0 || !el.val().trim(),
     changed: _el => true,
@@ -88,12 +91,21 @@
     }
 
     evaluateCondition() {
-      let value = CONDITIONS[this.el.data('if')?.trim()]
+      let data_if = this.el.data('if')
+      let value = data_if ? CONDITIONS[data_if.trim()] : null
       if (value) return { condition: value }
-      if (value = this.el.data('eq')) return { condition: CONDITIONS['eq'], condition_arg: value }
-      if (value = this.el.data('not')) return { condition: CONDITIONS['not'], condition_arg: value }
-      if (value = this.el.data('match')) return { condition: CONDITIONS['match'], condition_arg: new RegExp(value) }
-      if (value = this.el.data('mismatch')) return { condition: CONDITIONS['mismatch'], condition_arg: new RegExp(value) }
+
+      value = this.el.data('eq')
+      if (value) return { condition: CONDITIONS['eq'], condition_arg: value }
+
+      value = this.el.data('not')
+      if (value) return { condition: CONDITIONS['not'], condition_arg: value }
+
+      value = this.el.data('match')
+      if (value) return { condition: CONDITIONS['match'], condition_arg: new RegExp(value) }
+
+      value = this.el.data('mismatch')
+      if (value) return { condition: CONDITIONS['mismatch'], condition_arg: new RegExp(value) }
 
       this.custom_function = this.el.data('function')
       if (this.custom_function) {
@@ -112,32 +124,30 @@
       // closest find for has many associations
       if (this.el.data('target')) this.target = this.el.closest('fieldset').find(this.el.data('target'))
       else if (this.el.data('gtarget')) this.target = $(this.el.data('gtarget'))
-      if (action_name == 'callback') this.target = this.el
+      if (action_name === 'callback') this.target = this.el
     }
 
     isValid() {
       if (!this.condition) return false
-      if (!this.action && !this.custom_function) return false
-
-      return true
+      return (this.action || this.custom_function)
     }
 
     setup() {
       if (!this.isValid()) return
-      if (this.el.data('if') != 'changed') this.apply()
+      if (this.el.data('if') !== 'changed') this.apply()
       this.el.on('change', () => this.apply())  
     }
   }
 
-  // Inline update - must be called binded on the editing element
+  // Inline update - must be called bound on the editing element
   function dfUpdateField() {
-    if ($(this).data('loading') != '1') {
+    if ($(this).data('loading') !== '1') {
       $(this).data('loading', '1');
       let _this = $(this);
       let type = $(this).data('field-type');
       let new_value;
-      if (type == 'boolean') new_value = !$(this).data('field-value');
-      else if (type == 'select') new_value = $(this).val();
+      if (type === 'boolean') new_value = !$(this).data('field-value');
+      else if (type === 'select') new_value = $(this).val();
       else new_value = $(this).text();
       let data = {};
       data[$(this).data('field')] = new_value;
@@ -146,16 +156,16 @@
         data: { data: data },
         method: 'POST',
         url: $(this).data('save-url'),
-        complete: function (req, status) {
+        complete: function (_req, _status) {
           $(this).data('loading', '0');
         },
-        success: function (data, status, req) {
-          if (data.status == 'error') {
+        success: function (data, _status, _req) {
+          if (data.status === 'error') {
             if ($(this).data('show-errors')) {
               let result = '';
               let message = data.message;
               for (let key in message) {
-                if (typeof (message[key]) === 'object') {
+                if (message.hasOwnProperty(key) && typeof (message[key]) === 'object') {
                   if (result) result += ' - ';
                   result += key + ': ' + message[key].join('; ');
                 }
@@ -181,8 +191,7 @@
     }
   }
 
-  // Init
-  $(document).ready(function () {
+  function dfInit() {
     // Setup dynamic fields
     const selectors = '.active_admin .input [data-if], .active_admin .input [data-eq], .active_admin .input [data-not], .active_admin .input [data-match], .active_admin .input [data-mismatch], .active_admin .input [data-function]'
     $(selectors).each(function () {
@@ -205,20 +214,23 @@
     $('.active_admin [data-df-dialog]').on('click', function (event) {
       event.preventDefault()
       $(this).blur()
-      if ($('#df-dialog').data('loading') != '1') {
-        $('#df-dialog').data('loading', '1')
-        if ($('#df-dialog').length == 0) $('body').append('<div id="df-dialog"></div>')
+      const df_dialog = $('#df-dialog')
+
+      if (df_dialog.data('loading') !== '1') {
+        df_dialog.data('loading', '1')
+        if (df_dialog.length === 0) $('body').append('<div id="df-dialog"></div>')
         let title = $(this).attr('title')
         $.ajax({
           url: $(this).attr('href'),
-          complete: function (req, status) {
+          complete: function (_req, _status) {
             $('#df-dialog').data('loading', '0')
           },
-          success: function (data, status, req) {
-            if (title) $('#df-dialog').attr('title', title)
-            $('#df-dialog').html(data)
-            $('#df-dialog').dialog({ modal: true })
-          },
+          success: function (data, _status, _req) {
+            const dialog = $('#df-dialog')
+            if (title) dialog.attr('title', title)
+            dialog.html(data)
+            dialog.dialog({ modal: true })
+          }
         })
       }
     })
@@ -231,11 +243,14 @@
       $(this).data('field-value', $(this).text())
       let fnUpdate = $.proxy(dfUpdateField, $(this))
       $(this).on('blur', function () {
-        if ($(this).data('field-value') != $(this).text()) fnUpdate()
+        if ($(this).data('field-value') !== $(this).text()) fnUpdate()
       })
     })
     $('[data-field][data-field-type="select"][data-save-url]').each(function () {
       $(this).on('change', $.proxy(dfUpdateField, $(this)))
     })
-  })
+  }
+
+  $(document).ready(dfInit)
+  $(document).on('turbolinks:load', dfInit)
 })()

data/lib/activeadmin/dynamic_fields/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveAdmin
   module DynamicFields
-    VERSION = '0.5.0'
+    VERSION = '0.6.4'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activeadmin_dynamic_fields
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.4
 platform: ruby
 authors:
 - Mattia Roccoberton
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-10-04 00:00:00.000000000 Z
+date: 2022-03-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeadmin
@@ -25,131 +25,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: activestorage
+  name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 6.0.3.2
+        version: '2.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 6.0.3.2
-- !ruby/object:Gem::Dependency
-  name: capybara
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 3.33.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 3.33.0
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.13.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.13.1
-- !ruby/object:Gem::Dependency
-  name: puma
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 4.3.5
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 4.3.5
-- !ruby/object:Gem::Dependency
-  name: rspec_junit_formatter
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.4.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.4.1
-- !ruby/object:Gem::Dependency
-  name: rspec-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 4.0.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 4.0.1
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.90.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.90.0
-- !ruby/object:Gem::Dependency
-  name: selenium-webdriver
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 3.142.7
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 3.142.7
-- !ruby/object:Gem::Dependency
-  name: sqlite3
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.4.2
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.4.2
+        version: '2.4'
 description: An Active Admin plugin to add dynamic behaviors to fields
 email: mat@blocknot.es
 executables: []
@@ -167,7 +55,10 @@ files:
 homepage: https://github.com/blocknotes/activeadmin_dynamic_fields
 licenses:
 - MIT
-metadata: {}
+metadata:
+  homepage_uri: https://github.com/blocknotes/activeadmin_dynamic_fields
+  source_code_uri: https://github.com/blocknotes/activeadmin_dynamic_fields
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -183,7 +74,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: Dynamic fields for ActiveAdmin