activeadmin_dynamic_fields 0.2.2 → 0.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: a41854a61414d8eb8f8c35556fd0cbfdfa8364ed
-  data.tar.gz: 85340ca45697226edb75f74a5189c812400e19cd
+SHA256:
+  metadata.gz: a0ed5077c7c98c62def46fd92bc4e832c97239af6c5549feb26c9c0190dd9f4c
+  data.tar.gz: 6c874a1265046e090b1e1528de0f030a06fc4cf916d1f1625b174323c90be756
 SHA512:
-  metadata.gz: 72f93305d28ba3134437e19d062cc03a654113776d8aecfceb78f06d0939caeb8a3e01e4bca0f273db11be3b4358d2a7d72a57fbd838248c4af6108c54a44d42
-  data.tar.gz: 45231b55baf2d328e05e83d843285858487067f7798859c8b0d5fbfee11663e282c9230a41a8a5efed1a71082f68e1892c31e06fbc09893f9d12f69f6986ddec
+  metadata.gz: abb89d40dd388777bad8ec10264358993e3d70c07d45b5ab4720a7ac4bab0caa9ff0032bc312eb9a744e84cb0923dead550a9e9e61dc822846dce5a998ae3c62
+  data.tar.gz: adfea763fa7d6ab978a3048d55e0f6a9ab14c5fc2ac743603176512f477fc822524126ca936d816aa3285a87c3c1ec46aae0076f7513e669552bf51cbd2a4a98

data/.rubocop.yml

@@ -0,0 +1,73 @@
+require:
+  - rubocop-rspec
+
+Rails:
+  Enabled: true
+
+AllCops:
+  TargetRubyVersion: 2.3.8
+  TargetRailsVersion: 5.2
+  Exclude:
+    - db/schema.rb
+    - bin/*
+    - node_modules/**/*
+    # Temporary files
+    - tmp/**/*
+
+Rails/InverseOf:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Metrics/ClassLength:
+  # Default value is 100
+  Max: 150
+
+Metrics/LineLength:
+  # Default is 80
+  Max: 120
+
+Metrics/ModuleLength:
+  # Default is 100
+  Max: 150
+
+Metrics/ParameterLists:
+  # Default is 5
+  Max: 6
+
+RSpec/ExampleLength:
+  # Default is 10
+  Max: 20
+
+Style/FrozenStringLiteralComment:
+  # Deface DOES edit strings in place
+  Exclude:
+    - 'app/overrides/**/*'
+
+RSpec/MultipleExpectations:
+  # Default is 3
+  Max: 5
+
+RSpec/NestedGroups:
+  # Default is 3
+  Max: 6
+
+Metrics/AbcSize:
+  Max: 25
+
+Metrics/BlockLength:
+  # This value double the rubocop default
+  Max: 50
+
+Metrics/CyclomaticComplexity:
+  # This value double the rubocop default
+  Max: 12
+
+Metrics/MethodLength:
+  # This value double the rubocop default
+  Max: 20
+
+Metrics/PerceivedComplexity:
+  # Default is 7
+  Max: 10

data/README.md

@@ -9,7 +9,7 @@ Features:
 - inline field editing
 - create links to load some content in a dialog
 
-The easiest way to show how this plugin works is looking the examples [below](#examples-of-dynamic-fields).
+The easiest way to show how this plugin works is looking the examples [below](#examples).
 
 ## Install
 
@@ -46,22 +46,22 @@ Options are passed to fields using *input_html* parameter as *data* attributes:
 
 ### Dynamic fields examples
 
-- A checkbox that hides other fields if false (ex. model *Article*):
+- A checkbox that hides other fields if is checked (ex. model *Article*):
 
 ```rb
 form do |f|
   f.inputs 'Article' do
-    f.input :published, input_html: { data: { if: 'not_checked', action: 'hide', target: '.grp1' } }
+    f.input :published, input_html: { data: { if: 'checked', action: 'hide', target: '.grp1' } }
     f.input :online_date, wrapper_html: { class: 'grp1' }
-    f.input :position, wrapper_html: { class: 'grp1' }
+    f.input :draft_notes, wrapper_html: { class: 'grp1' }
   end
   f.actions
 end
 ```
 
-- Add 3 classes (*first*, *second*, *third*) if a checkbox is true:
+- Add 3 classes (*first*, *second*, *third*) if a checkbox is not checked:
 
-`f.input :published, input_html: { data: { if: 'checked', action: 'addClass first second third', target: '.grp1' } }`
+`f.input :published, input_html: { data: { if: 'not_checked', action: 'addClass first second third', target: '.grp1' } }`
 
 - Set another field value if a string field is blank:
 
@@ -184,6 +184,8 @@ The link url is loaded via AJAX before opening the dialog.
 
 If you use this component just star it. A developer is more motivated to improve a project when there is some interest.
 
+Take a look at [other ActiveAdmin components](https://github.com/blocknotes?utf8=✓&tab=repositories&q=activeadmin&type=source) that I made if you are curious.
+
 ## Contributors
 
 - [Mattia Roccoberton](http://blocknot.es) - creator, maintainer

data/Rakefile

@@ -1,3 +1,3 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'

data/activeadmin_dynamic_fields.gemspec

@@ -1,4 +1,6 @@
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'activeadmin/dynamic_fields/version'
 
@@ -15,5 +17,5 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0")
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'activeadmin', '~> 1.0'
+  spec.add_runtime_dependency 'activeadmin', '>= 1.0'
 end

data/app/assets/javascripts/activeadmin/dynamic_fields.js

@@ -1,117 +1,117 @@
 // Evaluate a condition
-function dfEvalCondition( el, args, on_change ) {
-  if( args.fn ) {
-    if( args.fn && window[args.fn] ) return !window[args.fn]( el );
-    else console.log( 'Warning - activeadmin_dynamic_fields: ' + args.fn + '() not available [1]' );
+function dfEvalCondition(el, args, on_change) {
+  if(args.fn) {
+    if(args.fn && window[args.fn]) return !window[args.fn](el);
+    else console.log('Warning - activeadmin_dynamic_fields: ' + args.fn + '() not available [1]');
   }
-  else if( args.if == 'checked' ) {
+  else if(args.if == 'checked') {
     return el.is(':checked');
   }
-  else if( args.if == 'not_checked' ) {
+  else if(args.if == 'not_checked') {
     return !el.is(':checked');
   }
-  else if( args.if == 'blank' ) {
+  else if(args.if == 'blank') {
     return el.val().length === 0 || !el.val().trim();
   }
-  else if( args.if == 'not_blank' ) {
+  else if(args.if == 'not_blank') {
     return el.val().length !== 0 && el.val().trim();
   }
-  else if( args.if == 'changed' ) {
+  else if(args.if == 'changed') {
     return on_change;
   }
-  else if( args.eq ) {
+  else if(args.eq) {
     return el.val() == args.eq;
   }
-  else if( args.not ) {
+  else if(args.not) {
     return el.val() != args.not;
   }
   return undefined;
 }
 
 // Prepare a field
-function dfSetupField( el ) {
-  var action = el.data( 'action' );
+function dfSetupField(el) {
+  var action = el.data('action');
   var target, args = {};
-  args.if = el.data( 'if' );
-  args.eq = el.data( 'eq' );
-  args.not = el.data( 'not' );
-  args.fn = el.data( 'function' );
-  if( el.data( 'target' ) ) target = el.closest( 'fieldset' ).find( el.data( 'target' ) );  // closest find for has many associations
-  else if( el.data( 'gtarget' ) ) target = $( el.data( 'gtarget' ) );
-  if( action == 'hide' ) {
-    if( dfEvalCondition( el, args, false ) ) target.hide();
+  args.if = el.data('if');
+  args.eq = el.data('eq');
+  args.not = el.data('not');
+  args.fn = el.data('function');
+  if(el.data('target')) target = el.closest('fieldset').find(el.data('target'));  // closest find for has many associations
+  else if(el.data('gtarget')) target = $(el.data('gtarget'));
+  if(action == 'hide') {
+    if(dfEvalCondition(el, args, false)) target.hide();
     else target.show();
-    el.on( 'change', function( event ) {
-      if( dfEvalCondition( $(this), args, true ) ) target.hide();
+    el.on('change', function(event) {
+      if(dfEvalCondition($(this), args, true)) target.hide();
       else target.show();
     });
   }
-  else if( action == 'slide' ) {
-    if( dfEvalCondition( el, args, false ) ) target.slideDown();
+  else if(action == 'slide') {
+    if(dfEvalCondition(el, args, false)) target.slideDown();
     else target.slideUp();
-    el.on( 'change', function( event ) {
-      if( dfEvalCondition( $(this), args, true ) ) target.slideDown();
+    el.on('change', function(event) {
+      if(dfEvalCondition($(this), args, true)) target.slideDown();
       else target.slideUp();
     });
   }
-  else if( action == 'fade' ) {
-    if( dfEvalCondition( el, args, false ) ) target.fadeIn();
+  else if(action == 'fade') {
+    if(dfEvalCondition(el, args, false)) target.fadeIn();
     else target.fadeOut();
-    el.on( 'change', function( event ) {
-      if( dfEvalCondition( $(this), args, true ) ) target.fadeIn();
+    el.on('change', function(event) {
+      if(dfEvalCondition($(this), args, true)) target.fadeIn();
       else target.fadeOut();
     });
   }
-  else if( action.substr( 0, 8 ) == 'setValue' ) {
-    var val = action.substr( 8 ).trim();
-    if( dfEvalCondition( el, args, false ) ) dfSetValue( target, val );
-    el.on( 'change', function( event ) {
-      if( dfEvalCondition( $(this), args, true ) ) dfSetValue( target, val );
+  else if(action.substr(0, 8) == 'setValue') {
+    var val = action.substr(8).trim();
+    if(dfEvalCondition(el, args, false)) dfSetValue(target, val);
+    el.on('change', function(event) {
+      if(dfEvalCondition($(this), args, true)) dfSetValue(target, val);
     });
   }
-  else if( action.substr( 0, 8 ) == 'callback' ) {
-    var cb = action.substr( 8 ).trim();
-    if( cb && window[cb] ) {
-      if( dfEvalCondition( el, args, false ) ) window[cb]( el.data( 'args' ) );
-      el.on( 'change', function( event ) {
-        if( dfEvalCondition( $(this), args, true ) ) window[cb]( el.data( 'args' ) );
+  else if(action.substr(0, 8) == 'callback') {
+    var cb = action.substr(8).trim();
+    if(cb && window[cb]) {
+      if(dfEvalCondition(el, args, false)) window[cb](el.data('args'));
+      el.on('change', function(event) {
+        if(dfEvalCondition($(this), args, true)) window[cb](el.data('args'));
       });
     }
-    else console.log( 'Warning - activeadmin_dynamic_fields: ' + cb + '() not available [2]' );
-  }
-  else if( action.substr( 0, 8 ) == 'addClass' ) {
-    var classes = action.substr( 8 ).trim();
-    if( dfEvalCondition( el, args, false ) ) target.removeClass( classes );
-    else target.addClass( classes );
-    el.on( 'change', function( event ) {
-      if( dfEvalCondition( $(this), args, true ) ) target.removeClass( classes );
-      else target.addClass( classes );
+    else console.log('Warning - activeadmin_dynamic_fields: ' + cb + '() not available [2]');
+  }
+  else if(action.substr(0, 8) == 'addClass') {
+    var classes = action.substr(8).trim();
+    if(dfEvalCondition(el, args, false)) target.removeClass(classes);
+    else target.addClass(classes);
+    el.on('change', function(event) {
+      if(dfEvalCondition($(this), args, true)) target.removeClass(classes);
+      else target.addClass(classes);
     });
   }
-  else if( args.fn ) {  // function without action
-    dfEvalCondition( el, args, false );
-    el.on( 'change', function( event ) {
-      dfEvalCondition( el, args, true );
+  else if(args.fn) {  // function without action
+    dfEvalCondition(el, args, false);
+    el.on('change', function(event) {
+      dfEvalCondition(el, args, true);
     });
   }
 }
 
 // Set the value of an element
-function dfSetValue( el, val ) {
-  if( el.attr('type') != 'checkbox' ) el.val( val );
+function dfSetValue(el, val) {
+  if(el.attr('type') != 'checkbox') el.val(val);
   else el.prop('checked', val == '1');
-  el.trigger( 'change' );
+  el.trigger('change');
 }
 
 // Inline update - must be called binded on the editing element
 function dfUpdateField() {
-  if( $(this).data( 'loading' ) != '1' ) {
-    $(this).data( 'loading', '1' );
+  if($(this).data('loading') != '1') {
+    $(this).data('loading', '1');
     var _this = $(this);
-    var type = $(this).data( 'field-type' );
+    var type = $(this).data('field-type');
     var new_value;
-    if( type == 'boolean' ) new_value = !$(this).data( 'field-value' );
-    else if( type == 'select' ) new_value = $(this).val();
+    if(type == 'boolean') new_value = !$(this).data('field-value');
+    else if(type == 'select') new_value = $(this).val();
     else new_value = $(this).text();
     var data = {};
     data[$(this).data('field')] = new_value;
@@ -119,94 +119,91 @@ function dfUpdateField() {
       context: _this,
       data: { data: data },
       method: 'POST',
-      url: $(this).data( 'save-url' ),
-      complete: function( req, status ) {
-        $(this).data( 'loading', '0' );
+      url: $(this).data('save-url'),
+      complete: function(req, status) {
+        $(this).data('loading', '0');
       },
-      success: function( data, status, req ) {
-        if( data.status == 'error' ) {
-          if( $(this).data( 'show-errors' ) ) {
+      success: function(data, status, req) {
+        if(data.status == 'error') {
+          if($(this).data('show-errors')) {
             var result = '';
             var message = data.message;
-            for( var key in message ) {
-              if( typeof( message[key] ) === 'object' ) {
-                if( result ) result += ' - ';
-                result += key + ': ' + message[key].join( '; ' );
+            for(var key in message) {
+              if(typeof(message[key]) === 'object') {
+                if(result) result += ' - ';
+                result += key + ': ' + message[key].join('; ');
               }
             }
-            if( result ) alert( result );
+            if(result) alert(result);
           }
         }
         else {
-          $(this).data( 'field-value', new_value );
-          if( $(this).data('content') ) {
+          $(this).data('field-value', new_value);
+          if($(this).data('content')) {
             var old_text = $(this).text();
-            var old_class = $(this).attr( 'class' );
+            var old_class = $(this).attr('class');
             var content = $($(this).data('content'));
-            $(this).text( content.text() );
-            $(this).attr( 'class', content.attr( 'class' ) );
-            content.text( old_text );
-            content.attr( 'class', old_class );
-            $(this).data( 'content', content );
+            $(this).text(content.text());
+            $(this).attr('class', content.attr('class'));
+            content.text(old_text);
+            content.attr('class', old_class);
+            $(this).data('content', content);
           }
         }
-      },
-      // error: function( req, status, error ) {
-      //   // if( $(this).data( 'show-errors' ) && req.responseJSON.message ) { }
-      // },
+      }
     });
   }
 }
 
 // Init
-$(document).ready( function() {
+$(document).ready(function() {
   // Setup dynamic fields
-  $('.active_admin .input [data-if], .active_admin .input [data-function], .active_admin .input [data-eq], .active_admin .input [data-not]').each( function() {
-    dfSetupField( $(this) );
+  $('.active_admin .input [data-if], .active_admin .input [data-function], .active_admin .input [data-eq], .active_admin .input [data-not]').each(function() {
+    dfSetupField($(this));
   });
   // Setup dynamic fields for has many associations
-  $('.active_admin .has_many_container').on( 'has_many_add:after', function( e, fieldset, container ) {
-    $('.active_admin .input [data-if], .active_admin .input [data-function], .active_admin .input [data-eq], .active_admin .input [data-not]').each( function() {
-      dfSetupField( $(this) );
+  $('.active_admin .has_many_container').on('has_many_add:after', function(e, fieldset, container) {
+    $('.active_admin .input [data-if], .active_admin .input [data-function], .active_admin .input [data-eq], .active_admin .input [data-not]').each(function() {
+      dfSetupField($(this));
     });
   });
   // Set dialog icon link
-  $('.active_admin [data-df-icon]').each( function() {
-    $(this).append( ' »' );  // ' •'
+  $('.active_admin [data-df-icon]').each(function() {
+    $(this).append(' »');  // ' •'
   });
   // Open content in dialog
-  $('.active_admin [data-df-dialog]').on( 'click', function( event ) {
+  $('.active_admin [data-df-dialog]').on('click', function(event) {
     event.preventDefault();
     $(this).blur();
-    if( $('#df-dialog').data( 'loading' ) != '1' ) {
-      $('#df-dialog').data( 'loading', '1' );
-      if( $('#df-dialog').length == 0 ) $('body').append( '<div id="df-dialog"></div>' );
-      var title = $(this).attr( 'title' );
+    if($('#df-dialog').data('loading') != '1') {
+      $('#df-dialog').data('loading', '1');
+      if($('#df-dialog').length == 0) $('body').append('<div id="df-dialog"></div>');
+      var title = $(this).attr('title');
       $.ajax({
-        url: $(this).attr( 'href' ),
-        complete: function( req, status ) {
-          $('#df-dialog').data( 'loading', '0' );
+        url: $(this).attr('href'),
+        complete: function(req, status) {
+          $('#df-dialog').data('loading', '0');
         },
-        success: function( data, status, req ) {
-          if( title ) $('#df-dialog').attr( 'title', title );
-          $('#df-dialog').html( data );
+        success: function(data, status, req) {
+          if(title) $('#df-dialog').attr('title', title);
+          $('#df-dialog').html(data);
           $('#df-dialog').dialog({ modal: true });
         },
       });
     }
   });
   // Inline editing
-  $('[data-field][data-field-type="boolean"][data-save-url]').each( function() {
-    $(this).on( 'click', $.proxy( dfUpdateField, $(this) ) );
+  $('[data-field][data-field-type="boolean"][data-save-url]').each(function() {
+    $(this).on('click', $.proxy(dfUpdateField, $(this)));
   });
-  $('[data-field][data-field-type="string"][data-save-url]' ).each( function() {
-    $(this).data( 'field-value', $(this).text() );
-    var fnUpdate = $.proxy( dfUpdateField, $(this) );
-    $(this).on( 'blur', function() {
-      if( $(this).data( 'field-value' ) != $(this).text() ) fnUpdate();
+  $('[data-field][data-field-type="string"][data-save-url]').each(function() {
+    $(this).data('field-value', $(this).text());
+    var fnUpdate = $.proxy(dfUpdateField, $(this));
+    $(this).on('blur', function() {
+      if($(this).data('field-value') != $(this).text()) fnUpdate();
     });
   });
-  $('[data-field][data-field-type="select"][data-save-url]').each( function() {
-    $(this).on( 'change', $.proxy( dfUpdateField, $(this) ) );
+  $('[data-field][data-field-type="select"][data-save-url]').each(function() {
+    $(this).on('change', $.proxy(dfUpdateField, $(this)));
   });
 });

data/lib/activeadmin/dynamic_fields.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'activeadmin/dynamic_fields/engine'

data/lib/activeadmin/dynamic_fields/engine.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_admin'
 
 module ActiveAdmin
@@ -6,21 +8,39 @@ module ActiveAdmin
       engine_name 'activeadmin_dynamic_fields'
     end
 
-    def self.edit_boolean( field, url, value )
-      { 'data-field': field, 'data-field-type': 'boolean', 'data-field-value': value, 'data-content': "<span class=\"status_tag changed\">#{value ? 'no' : 'yes'}</span>", 'data-save-url': url, 'data-show-errors': '1' }
+    def self.edit_boolean(field, url, value)
+      {
+        'data-field': field,
+        'data-field-type': 'boolean',
+        'data-field-value': value,
+        'data-content': "<span class=\"status_tag changed\">#{value ? 'no' : 'yes'}</span>",
+        'data-save-url': url,
+        'data-show-errors': '1'
+      }
     end
 
-    def self.edit_select( field, url )
-      { 'data-field': field, 'data-field-type': 'select', 'data-save-url': url, 'data-show-errors': '1' }
+    def self.edit_select(field, url)
+      {
+        'data-field': field,
+        'data-field-type': 'select',
+        'data-save-url': url,
+        'data-show-errors': '1'
+      }
     end
 
-    def self.edit_string( field, url )
-      { contenteditable: true, 'data-field': field, 'data-field-type': 'string', 'data-save-url': url, 'data-show-errors': '1' }
+    def self.edit_string(field, url)
+      {
+        contenteditable: true,
+        'data-field': field,
+        'data-field-type': 'string',
+        'data-save-url': url,
+        'data-show-errors': '1'
+      }
     end
 
-    def self.update( resource, params, permit_params = nil )
+    def self.update(resource, params, permit_params = nil)
       if params[:data]
-        if resource.update( permit_params ? params[:data].permit( permit_params ) : params[:data].permit! )
+        if resource.update(permit_params ? params[:data].permit(permit_params) : params[:data].permit!)
           { json: { status: 'ok' } }
         else
           { json: { status: 'error', message: resource.errors } }

data/lib/activeadmin/dynamic_fields/version.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module ActiveAdmin
   module DynamicFields
-    VERSION = '0.2.2'
+    VERSION = '0.2.6'
   end
 end

data/lib/activeadmin_dynamic_fields.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'activeadmin/dynamic_fields'

metadata

@@ -1,27 +1,27 @@
 --- !ruby/object:Gem::Specification
 name: activeadmin_dynamic_fields
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.6
 platform: ruby
 authors:
 - Mattia Roccoberton
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-24 00:00:00.000000000 Z
+date: 2019-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeadmin
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.0'
 description: An Active Admin plugin to add dynamic behaviors to fields
@@ -31,6 +31,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -60,8 +61,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 3.0.2
 signing_key: 
 specification_version: 4
 summary: Dynamic fields for ActiveAdmin