activeadmin_batched_export 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e93f12265a281843049efbf5266abaa1a097f9d49b642734cf9457c93ce6dd86
-  data.tar.gz: 9fd765cfb434f66e14ee4a3bcdc76726b0fe45409b0fec04904b435b5949395f
+  metadata.gz: 66bcf48aae48932a2dd49a6f494ef82e8ef405e857e0faef6ee9f0df24d2208d
+  data.tar.gz: 404850d208cb0339b9a3cc1bc78ceb8acc0bff449f23ed0e1413869cdfa66483
 SHA512:
-  metadata.gz: ab8f3476d7eec0a5fba80b7170a116b9a13df06efff0f865d4aa7933593557ecacd056a4fd7ec229f70f66c053779169b6cb6328d3f4a62e0a24ad93f0699eea
-  data.tar.gz: b7f01fd4e7af21b8c69c0b67bb7380b8b8b0c9fd874e7e155dba65e8bc4197677590c2cc49dade46f2d79c6afca16b08f59edd30e5b87554332e9d6256941c43
+  metadata.gz: e3db51c40f02ad9130fd9af283d1d44e45064eb49467046422a4639c24cc5f27bee73b808ff7e5cae4ac436e984ff086556588d0d408a8e52db09b4031bda7a3
+  data.tar.gz: c875062f769f3d529ae443cab3de7e46ee8a547e23f8a8a7ad9723a675c153dbcf3c75bb734bdb0cc6fb147535983736da9f0b9f9674b4ec4995b4dd950b7afb

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # CHANGELOG
 
+## 0.3.3 (2026-11-03)
+
+- Refuse `max_export_rows` on live batch requests even when `export_cursor` is set.
+- Fail closed when release confirmation input reaches EOF; accept empty Enter or case-insensitive `y`.
+- Require a matching `CHANGELOG.md` version heading before `gem push`.
+- Run the test workflow on pull requests.
+
 ## 0.3.2 (2026-09-07)
 
 - Serve the workspace export assembly as JavaScript from `ActiveAdmin.importmap`.

data/README.md

@@ -53,7 +53,7 @@ add_index :active_admin_batched_export_snapshot_rows, [:token, :position], uniqu
 add_index :active_admin_batched_export_snapshot_rows, :created_at
 ```
 
-Without that table, batches walk a live keyset cursor. With it, the first batch stores filtered primary keys and later batches join live rows in freeze order. The token is not an access grant: rows still load through `find_collection`.
+Without that table, batches walk a live keyset cursor. With it, the first batch stores filtered primary keys and later batches join live rows in freeze order. The token is not an access grant: rows still load through `find_collection`. Freeze mode expects integer primary keys (`bigint record_id`); UUID or string keys are not supported yet.
 
 Enable download formats per resource:
 
@@ -153,12 +153,12 @@ Available keys: `workspace`, `card`, `card_title`, `table`, `table_body`, `table
 
 Copy any partial from the gem into `app/views/active_admin/batched_export/` in the host app:
 
-- `workspace.html.erb` — page shell; start here for layout changes
+- `workspace.html.erb`: page shell; start here for layout changes
 - `_summary.html.erb`
 - `_columns.html.erb`
 - `_filters.html.erb`
 - `_progress.html.erb`
-- `_actions.html.erb` — load, cancel, save, and back buttons
+- `_actions.html.erb`: load, cancel, save, and back buttons
 
 ### Stimulus controller
 
@@ -185,7 +185,7 @@ The engine pins `controllers/activeadmin_batched_export/batched_export_controlle
 3. Load export always refetches `export_meta` JSON for a progress estimate, then walks chunks with `export_cursor` / `X-Batched-Export-Next` until that header is absent. When the freeze table exists, the first batch also returns `X-Batched-Export-Snapshot` and later chunks send `export_snapshot` with the cursor.
 4. User saves the assembled Blob locally. Cancel keeps an incomplete file when any chunks already arrived.
 
-Batched requests limit server memory per request; the browser still holds the full assembled file before save. Very large exports can exhaust tab memory. Tune `batch_size`, `max_batch_size`, and `large_export_row_threshold` for your data width and row counts. The workspace shows a warning when row count reaches the threshold. Set `max_export_rows` to refuse a collection larger than that count (`over_max` on meta, 400 on the first batch).
+Batched requests limit server memory per request; the browser still holds the full assembled file before save. Very large exports can exhaust tab memory. Tune `batch_size`, `max_batch_size`, and `large_export_row_threshold` for your data width and row counts. The workspace shows a warning when row count reaches the threshold. Set `max_export_rows` to refuse a collection larger than that count (`over_max` on meta, 400 on live batches, including requests that already carry `export_cursor`).
 
 When the freeze table exists, the first batch stores filtered primary keys in NULL-safe order (RFC-0003). Later batches walk those positions and join live cells. Inserts after freeze are omitted. Updates after freeze appear. Deleted freeze ids are skipped. Without the table, each chunk continues after the last returned sort key and primary key (RFC-0002) and is not a point-in-time snapshot. Custom `order_by` expressions fall back to primary key descending. NULL sort keys sort last in both directions.
 
@@ -230,7 +230,7 @@ See [CONTRIBUTING.md](CONTRIBUTING.md). Bug reports and pull requests are welcom
 
 ## License
 
-MIT — see [LICENSE.md](LICENSE.md).
+MIT. See [LICENSE.md](LICENSE.md).
 
 ## Sponsors
 

data/activeadmin_batched_export.gemspec

@@ -48,7 +48,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "appraisal", "~> 2"
   spec.add_development_dependency "bundler", ">= 2"
-  spec.add_development_dependency "polyrun", ">= 2.2.0"
+  spec.add_development_dependency "polyrun", ">= 2.2.9"
   spec.add_development_dependency "prosopite", "~> 2.0"
   spec.add_development_dependency "rake", "~> 13"
   spec.add_development_dependency "rspec", "~> 3"

data/app/views/active_admin/batched_export/_summary.html.erb

@@ -9,7 +9,7 @@
       </tr>
       <tr class="<%= styles[:table_row] %>">
         <th scope="row" class="<%= styles[:table_header] %>"><%= t("active_admin.batched_export_page.scope_label") %></th>
-        <td class="<%= styles[:table_cell] %>"><%= current_scope ? scope_name(current_scope) : "—" %></td>
+        <td class="<%= styles[:table_cell] %>"><%= current_scope ? scope_name(current_scope) : "-" %></td>
       </tr>
       <tr class="<%= styles[:table_row] %>">
         <th scope="row" class="<%= styles[:table_header] %>"><%= t("active_admin.batched_export_page.sort_label") %></th>

data/lib/activeadmin/batched_export/controller_methods.rb

@@ -48,7 +48,9 @@ module ActiveAdmin
 
       def render_export_batch(export_format)
         ensure_batch_download_format_allowed!(export_format)
-        refuse_over_max_export_rows! if starting_export_walk?
+        # Live walks (no snapshot token) always admit against max_export_rows.
+        # export_cursor is client-supplied Base64 JSON, so presence alone must not skip the cap.
+        refuse_over_max_export_rows! if params[:export_snapshot].blank?
         field, direction = batched_export_sort_pair
         cursor = decode_export_cursor(field: field, direction: direction)
         page = snapshot_export_page(field: field, direction: direction, cursor: cursor)
@@ -139,10 +141,6 @@ module ActiveAdmin
         paginate(find_collection(except: [:pagination]), 1, effective_batch_size).total_count
       end
 
-      def starting_export_walk?
-        params[:export_snapshot].blank? && params[:export_cursor].blank?
-      end
-
       def refuse_over_max_export_rows!
         cap = BatchedExport.config.max_export_rows
         return if cap.blank?
@@ -238,7 +236,7 @@ module ActiveAdmin
       def batched_export_sort_description
         order_param = params[:order].presence || active_admin_config.sort_order
         clause = ActiveAdmin::OrderClause.new(active_admin_config, order_param)
-        return order_param.to_s.tr("_", " ").strip.presence || "—" unless clause.valid?
+        return order_param.to_s.tr("_", " ").strip.presence || "-" unless clause.valid?
 
         attribute = active_admin_config.resource_class.human_attribute_name(clause.field)
         direction =
@@ -247,7 +245,7 @@ module ActiveAdmin
           else
             I18n.t("active_admin.batched_export_page.sort_ascending")
           end
-        "#{attribute} — #{direction}"
+        "#{attribute} - #{direction}"
       end
 
       def batched_export_csv_column_metadata

data/lib/activeadmin/batched_export/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveAdmin
   module BatchedExport
-    VERSION = "0.3.2"
+    VERSION = "0.3.3"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activeadmin_batched_export
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Andrei Makarov
@@ -91,14 +91,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.2.0
+        version: 2.2.9
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.2.0
+        version: 2.2.9
 - !ruby/object:Gem::Dependency
   name: prosopite
   requirement: !ruby/object:Gem::Requirement