activeadmin 2.9.0 → 2.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3a79fadc45ea60de060d130d9ce18ca04b0becd14baae2e46b3749b76cb7bd20
-  data.tar.gz: 59ecfb3dba085bd66b2534991dcba8e14dae2f76a07baae37f8b8daaa4063917
+  metadata.gz: 2475b735a56270b5b9421b1caaf3a29309db304fa4cb8d177e81feaddd4c8ce3
+  data.tar.gz: a54450d0ceee48a534ac77886151f4c089d89b9d56d3f3429f8eea110a11ee09
 SHA512:
-  metadata.gz: 2d26b7fb0ffbd1da98ca7b4f685a7c386dcab3f25079f5e16e7926cb1c9ce2060db7ecc27d158608091a178590c9604b33850d5f44009401bee467c6f84811a0
-  data.tar.gz: 1273181e98620f7af30434e4fb669d95eddfa7633d3e5fb5b51fbb31bf8d8b7615e07c413590cba13b86b5fc1e087dc589f7f4f227c6ff62c4ea25925faf07f8
+  metadata.gz: df19f0ebb54934855aaa741b836ecfe6298f696b7f522d116c5f5f30a6585804c88eb361d546f4515f36881638481cd644a63b5e1e8d9c848d8b9b2974acbf7f
+  data.tar.gz: ead38adf2aaf33eddef91a863518ba3ad67b2d9cb3cd32573e65d3538f4d3140d5ee44697a4e3d2578aaf1fc20571b7a4da01d00ea3a1c4888a8f4599b7f2c9d

data/CHANGELOG.md

@@ -2,6 +2,41 @@
 
 ## Unreleased
 
+## 2.10.0 [☰](https://github.com/activeadmin/activeadmin/compare/v2.9.0..v2.10.0)
+
+### Enhancements
+
+* Load favicon from Webpacker assets when use_webpacker is set to true. [#6954] by [@Fs00]
+* Don't apply sorting to collection until after scoping. [#7205] by [@agrobbin]
+* Resolve dart sass deprecation warning for division. [#7095] by [@tordans]
+* Use `instrument` from the Notifications API instead of low level `publish`. [#7262] by [@sprql]
+* Avoid mutating string literals. [#6936] by [@tomgilligan]
+* Include print styles in main stylesheet. [#6922] by [@deivid-rodriguez]
+* Use `POST` for OmniAuth links. [#6916] by [@deivid-rodriguez]
+* Scope new record instantiation by authorization scope. [#6884] by [@ngouy]
+* Make `permit_params` and `belongs_to` order independent. [#6906] by [@deivid-rodriguez]
+* Use collection length instead of running COUNTs for limited collections. [#5660] by [@MmKolodziej]
+
+### Bug Fixes
+
+* Show ransackable_scopes filters in search results. [#7127] by [@vlad-psh]
+
+### Translation Improvements
+
+* Fix Dutch translation for password reset button. [#7181] by [@mvz]
+* Add few key to RO pagination.entry. [#6915] by [@lubosch]
+* Change misleading Korean translation. [#6873] by [@1000ship]
+
+### Documentation
+
+* Replace deprecated update_attributes! with update!. [#6959] by [@sergey-alekseev]
+* Clarify docs on user setup. [#6872] by [@javawizard]
+
+### Dependency Changes
+
+* Drop rails 5.2 support. [#7293] by [@deivid-rodriguez]
+* Drop support for Ruby 2.5. [#7236] by [@alejandroperea]
+
 ## 2.9.0 [☰](https://github.com/activeadmin/activeadmin/compare/v2.8.1..v2.9.0)
 
 ### Enhancements
@@ -587,6 +622,7 @@ Please check [0-6-stable] for previous changes.
 [#5631]: https://github.com/activeadmin/activeadmin/pull/5631
 [#5632]: https://github.com/activeadmin/activeadmin/pull/5632
 [#5650]: https://github.com/activeadmin/activeadmin/pull/5650
+[#5660]: https://github.com/activeadmin/activeadmin/pull/5660
 [#5662]: https://github.com/activeadmin/activeadmin/pull/5662
 [#5710]: https://github.com/activeadmin/activeadmin/pull/5710
 [#5726]: https://github.com/activeadmin/activeadmin/pull/5726
@@ -650,11 +686,31 @@ Please check [0-6-stable] for previous changes.
 [#6548]: https://github.com/activeadmin/activeadmin/pull/6548
 [#6583]: https://github.com/activeadmin/activeadmin/pull/6583
 [#6584]: https://github.com/activeadmin/activeadmin/pull/6584
-
+[#6872]: https://github.com/activeadmin/activeadmin/pull/6872
+[#6873]: https://github.com/activeadmin/activeadmin/pull/6873
+[#6884]: https://github.com/activeadmin/activeadmin/pull/6884
+[#6906]: https://github.com/activeadmin/activeadmin/pull/6906
+[#6915]: https://github.com/activeadmin/activeadmin/pull/6915
+[#6916]: https://github.com/activeadmin/activeadmin/pull/6916
+[#6922]: https://github.com/activeadmin/activeadmin/pull/6922
+[#6936]: https://github.com/activeadmin/activeadmin/pull/6936
+[#6954]: https://github.com/activeadmin/activeadmin/pull/6954
+[#6959]: https://github.com/activeadmin/activeadmin/pull/6959
+[#7095]: https://github.com/activeadmin/activeadmin/pull/7095
+[#7127]: https://github.com/activeadmin/activeadmin/pull/7127
+[#7181]: https://github.com/activeadmin/activeadmin/pull/7181
+[#7205]: https://github.com/activeadmin/activeadmin/pull/7205
+[#7236]: https://github.com/activeadmin/activeadmin/pull/7236
+[#7262]: https://github.com/activeadmin/activeadmin/pull/7262
+[#7293]: https://github.com/activeadmin/activeadmin/pull/7293
+
+[@1000ship]: https://github.com/1000ship
 [@5t111111]: https://github.com/5t111111
 [@aarek]: https://github.com/aarek
 [@adler99]: https://github.com/adler99
+[@agrobbin]: https://github.com/agrobbin
 [@ajw725]: https://github.com/ajw725
+[@alejandroperea]: https://github.com/alejandroperea
 [@alex-bogomolov]: https://github.com/alex-bogomolov
 [@amiel]: https://github.com/amiel
 [@amiuhle]: https://github.com/amiuhle
@@ -681,6 +737,7 @@ Please check [0-6-stable] for previous changes.
 [@FabioRos]: https://github.com/FabioRos
 [@faucct]: https://github.com/faucct
 [@Fivell]: https://github.com/Fivell
+[@Fs00]: https://github.com/Fs00
 [@fuzziness]: https://github.com/fuzziness
 [@giapnhdev]: https://github.com/giapnhdev
 [@glebtv]: https://github.com/glebtv
@@ -693,6 +750,7 @@ Please check [0-6-stable] for previous changes.
 [@irmela]: https://github.com/irmela
 [@Ivanov-Anton]: https://github.com/Ivanov-Anton
 [@jasl]: https://github.com/jasl
+[@javawizard]: https://github.com/javawizard
 [@javierjulio]: https://github.com/javierjulio
 [@jawa]: https://github.com/jawa
 [@JiiHu]: https://github.com/JiiHu
@@ -710,14 +768,18 @@ Please check [0-6-stable] for previous changes.
 [@leio10]: https://github.com/leio10
 [@littleforest]: https://github.com/littleforest
 [@Looooong]: https://github.com/Looooong
+[@lubosch]: https://github.com/lubosch
 [@markstory]: https://github.com/markstory
 [@mauriciopasquier]: https://github.com/mauriciopasquier
 [@mconiglio]: https://github.com/mconiglio
 [@micred]: https://github.com/micred
 [@mirelon]: https://github.com/mirelon
+[@MmKolodziej]: https://github.com/MmKolodziej
 [@mshalaby]: https://github.com/mshalaby
 [@munen]: https://github.com/munen
+[@mvz]: https://github.com/mvz
 [@ndbroadbent]: https://github.com/ndbroadbent
+[@ngouy]: https://github.com/ngouy
 [@Nguyenanh]: https://github.com/Nguyenanh
 [@orkhan]: https://github.com/orkhan
 [@panasyuk]: https://github.com/panasyuk
@@ -730,22 +792,27 @@ Please check [0-6-stable] for previous changes.
 [@rogerkk]: https://github.com/rogerkk
 [@roramirez]: https://github.com/roramirez
 [@seanlinsley]: https://github.com/seanlinsley
+[@sergey-alekseev]: https://github.com/sergey-alekseev
 [@sgara]: https://github.com/sgara
 [@ShallmentMo]: https://github.com/ShallmentMo
 [@shekibobo]: https://github.com/shekibobo
 [@shouya]: https://github.com/shouya
 [@sjieg]: https://github.com/sjieg
+[@sprql]: https://github.com/sprql
 [@stefsava]: https://github.com/stefsava
 [@stereoscott]: https://github.com/stereoscott
 [@taralbass]: https://github.com/taralbass
 [@tiagotex]: https://github.com/tiagotex
 [@timoschilling]: https://github.com/timoschilling
 [@TimPetricola]: https://github.com/TimPetricola
+[@tomgilligan]: https://github.com/tomgilligan
+[@tordans]: https://github.com/tordans
 [@utkarsh2102]: https://github.com/utkarsh2102
 [@varyonic]: https://github.com/varyonic
 [@vcsjones]: https://github.com/vcsjones
 [@vfonic]: https://github.com/vfonic
 [@violeta-p]: https://github.com/violeta-p
+[@vlad-psh]: https://github.com/vlad-psh
 [@WaKeMaTTa]: https://github.com/WaKeMaTTa
 [@wasifhossain]: https://github.com/wasifhossain
 [@westonganger]: https://github.com/westonganger

data/app/assets/javascripts/active_admin/base.js

@@ -81,7 +81,7 @@
       }
     });
   }
-  var onDOMReady = function onDOMReady() {
+  var onDOMReady$2 = function onDOMReady() {
     $(".batch_actions_selector li a").off("click confirm:complete");
     $(".batch_actions_selector li a").on("click", function(event) {
       var _this = this;
@@ -125,7 +125,7 @@
       });
     }
   };
-  $(document).ready(onDOMReady).on("page:load turbolinks:load", onDOMReady);
+  $(document).ready(onDOMReady$2).on("page:load turbolinks:load", onDOMReady$2);
   var CheckboxToggler = function() {
     function CheckboxToggler(options, container) {
       this.options = options;
@@ -471,7 +471,14 @@
   function _inheritsLoose(subClass, superClass) {
     subClass.prototype = Object.create(superClass.prototype);
     subClass.prototype.constructor = subClass;
-    subClass.__proto__ = superClass;
+    _setPrototypeOf(subClass, superClass);
+  }
+  function _setPrototypeOf(o, p) {
+    _setPrototypeOf = Object.setPrototypeOf || function _setPrototypeOf(o, p) {
+      o.__proto__ = p;
+      return o;
+    };
+    return _setPrototypeOf(o, p);
   }
   var TableCheckboxToggler = function(_CheckboxToggler) {
     _inheritsLoose(TableCheckboxToggler, _CheckboxToggler);
@@ -501,10 +508,10 @@
     return TableCheckboxToggler;
   }(CheckboxToggler);
   $.widget.bridge("tableCheckboxToggler", TableCheckboxToggler);
-  var onDOMReady$2 = function onDOMReady() {
+  var onDOMReady = function onDOMReady() {
     return $("#active_admin_content .tabs").tabs();
   };
-  $(document).ready(onDOMReady$2).on("page:load turbolinks:load", onDOMReady$2);
+  $(document).ready(onDOMReady).on("page:load turbolinks:load", onDOMReady);
   function modal_dialog(message, inputs, callback) {
     console.warn("ActiveAdmin.modal_dialog is deprecated in favor of ActiveAdmin.ModalDialog, please update usage.");
     return ModalDialog(message, inputs, callback);

data/app/assets/stylesheets/active_admin/_base.scss

@@ -1,41 +1,47 @@
 /* Active Admin CSS */
-// Normalize
-@import "./normalize";
+@media screen {
+  // Normalize
+  @import "./normalize";
 
-// Partials
-@import "./typography";
-@import "./header";
-@import "./forms";
-@import "./components/comments";
-@import "./components/flash_messages";
-@import "./components/date_picker";
-@import "./components/tables";
-@import "./components/batch_actions";
-@import "./components/modal_dialog";
-@import "./components/blank_slates";
-@import "./components/breadcrumbs";
-@import "./components/dropdown_menu";
-@import "./components/buttons";
-@import "./components/grid";
-@import "./components/links";
-@import "./components/pagination";
-@import "./components/panels";
-@import "./components/columns";
-@import "./components/scopes";
-@import "./components/status_tags";
-@import "./components/table_tools";
-@import "./components/index_list";
-@import "./components/unsupported_browser";
-@import "./components/tabs";
-@import "./pages/logged_out";
-@import "./structure/footer";
-@import "./structure/main_structure";
-@import "./structure/title_bar";
+  // Partials
+  @import "./typography";
+  @import "./header";
+  @import "./forms";
+  @import "./components/comments";
+  @import "./components/flash_messages";
+  @import "./components/date_picker";
+  @import "./components/tables";
+  @import "./components/batch_actions";
+  @import "./components/modal_dialog";
+  @import "./components/blank_slates";
+  @import "./components/breadcrumbs";
+  @import "./components/dropdown_menu";
+  @import "./components/buttons";
+  @import "./components/grid";
+  @import "./components/links";
+  @import "./components/pagination";
+  @import "./components/panels";
+  @import "./components/columns";
+  @import "./components/scopes";
+  @import "./components/status_tags";
+  @import "./components/table_tools";
+  @import "./components/index_list";
+  @import "./components/unsupported_browser";
+  @import "./components/tabs";
+  @import "./pages/logged_out";
+  @import "./structure/footer";
+  @import "./structure/main_structure";
+  @import "./structure/title_bar";
 
-body {
-  @include sans-family;
-  line-height: 1.5;
-  font-size: 72%;
-  background: $body-background-color;
-  color: $text-color;
+  body {
+    @include sans-family;
+    line-height: 1.5;
+    font-size: 72%;
+    background: $body-background-color;
+    color: $text-color;
+  }
+}
+
+@media print {
+  @import "./print";
 }

data/app/assets/stylesheets/active_admin/_forms.scss

@@ -276,10 +276,10 @@ $sidebar-inner-content-width: $sidebar-width - ($section-padding * 2);
 
 $filter-field-seperator-width: 12px;
 
-$side-by-side-filter-input-width: ($sidebar-inner-content-width / 2) - ($text-input-horizontal-padding * 2) - $filter-field-seperator-width;
-$side-by-side-filter-select-width: ($sidebar-inner-content-width / 2) - $filter-field-seperator-width;
+$side-by-side-filter-input-width: ($sidebar-inner-content-width * 0.5) - ($text-input-horizontal-padding * 2) - $filter-field-seperator-width;
+$side-by-side-filter-select-width: ($sidebar-inner-content-width * 0.5) - $filter-field-seperator-width;
 
-$date-range-filter-input-width: ($sidebar-inner-content-width / 2) - ($filter-field-seperator-width / 2);
+$date-range-filter-input-width: ($sidebar-inner-content-width * 0.5) - ($filter-field-seperator-width * 0.5);
 
 form.filter_form {
   .filter_form_field {

data/app/views/active_admin/devise/shared/_links.erb

@@ -27,7 +27,7 @@
 <%- if devise_mapping.omniauthable? %>
   <%- resource_class.omniauth_providers.each do |provider| %>
     <%= link_to t('active_admin.devise.links.sign_in_with_omniauth_provider', provider: provider.to_s.titleize),
-          omniauth_authorize_path(resource_name, provider) %>
+          omniauth_authorize_path(resource_name, provider), method: :post %>
     <br>
   <% end -%>
 <% end -%>

data/app/views/active_admin/page/index.html.arb

@@ -1 +1,2 @@
+# frozen_string_literal: true
 insert_tag active_admin_application.view_factory["page"]

data/app/views/active_admin/resource/edit.html.arb

@@ -1 +1,2 @@
+# frozen_string_literal: true
 insert_tag renderer_for(:edit)

data/app/views/active_admin/resource/index.html.arb

@@ -1 +1,2 @@
+# frozen_string_literal: true
 insert_tag renderer_for(:index)

data/app/views/active_admin/resource/new.html.arb

@@ -1 +1,2 @@
+# frozen_string_literal: true
 insert_tag renderer_for(:new)

data/app/views/active_admin/resource/show.html.arb

@@ -1 +1,2 @@
+# frozen_string_literal: true
 insert_tag renderer_for(:show)

data/app/views/layouts/active_admin.html.arb

@@ -1 +1,2 @@
+# frozen_string_literal: true
 insert_tag view_factory.layout

data/config/locales/ko.yml

@@ -69,7 +69,7 @@ ko:
         one: "성공적으로 1개 %{model}을/를 삭제하였습니다"
         other: "성공적으로 %{count}개의 %{plural_model}을/를 삭제하였습니다"
       selection_toggle_explanation: "(선택 항목 바꾸기)"
-      action_label: "%{title} 선택됨"
+      action_label: "선택한 항목 %{title}"
       labels:
         destroy: "삭제"
     comments:

data/config/locales/nl.yml

@@ -114,7 +114,7 @@ nl:
         submit: "inloggen"
       reset_password:
         title: "Wachtwoord vergeten?"
-        submit: "Reset mijn wachtwoord vergeten"
+        submit: "Reset mijn wachtwoord"
       change_password:
         title: "Wijzig uw wachtwoord"
         submit: "Mijn wachtwoord wijzigen"

data/config/locales/ro.yml

@@ -47,8 +47,9 @@ ro:
       multiple: "Sunt afisate <b>%{from}&nbsp;-&nbsp;%{to}</b> din <b>%{total}</b> inregistrari"
       multiple_without_total: "Sunt afisate <b>%{from}&nbsp;-&nbsp;%{to}</b>"
       entry:
-        one: "inregistrare"
-        other: "inregistrari"
+        one: "înregistrăre"
+        few: "înregistrări"
+        other: "înregistrări"
     any: "Oricare"
     blank_slate:
       content: "Momentan nu exista %{resource_name}."

data/docs/0-installation.md

@@ -29,7 +29,7 @@ After installing the gem, you need to run the generator. Here are your options:
   rails g active_admin:install --skip-users
   ```
 
-* If you want to use an existing user class, provide it as an argument:
+* If you want to customize the name of the generated user class, or if you want to use an existing user class, provide the class name as an argument:
 
   ```sh
   rails g active_admin:install User

data/docs/8-custom-actions.md

@@ -62,7 +62,7 @@ HTTP verbs. In that case, this is the suggested approach:
 ```ruby
 member_action :foo, method: [:get, :post] do
   if request.post?
-    resource.update_attributes! foo: params[:foo] || {}
+    resource.update! foo: params[:foo] || {}
     head :ok
   else
     render :foo

data/docs/Gemfile

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 source "https://rubygems.org"
 
 gem "github-pages"