activeadmin 2.4.0 → 2.8.0
Sign up to get free protection for your applications and to get access to all the features.
Potentially problematic release.
This version of activeadmin might be problematic. Click here for more details.
- checksums.yaml +4 -4
- data/CHANGELOG.md +148 -30
- data/CONTRIBUTING.md +36 -56
- data/README.md +2 -2
- data/app/assets/javascripts/active_admin/base.js +517 -0
- data/app/assets/stylesheets/active_admin/_base.scss +29 -29
- data/app/assets/stylesheets/active_admin/_header.scss +40 -8
- data/app/assets/stylesheets/active_admin/_mixins.scss +1 -1
- data/{vendor → app}/assets/stylesheets/active_admin/_normalize.scss +0 -0
- data/app/assets/stylesheets/active_admin/components/_comments.scss +2 -2
- data/app/assets/stylesheets/active_admin/components/_tables.scss +1 -2
- data/app/assets/stylesheets/active_admin/mixins/_all.scss +8 -8
- data/app/assets/stylesheets/active_admin/mixins/_variables.scss +8 -0
- data/app/assets/stylesheets/active_admin/print.scss +2 -2
- data/app/assets/stylesheets/active_admin/structure/_main_structure.scss +1 -1
- data/app/javascript/active_admin/base.js +28 -0
- data/app/{assets/javascripts/active_admin/ext/jquery-ui.es6 → javascript/active_admin/ext/jquery-ui.js} +0 -0
- data/app/{assets/javascripts/active_admin/ext/jquery.es6 → javascript/active_admin/ext/jquery.js} +0 -0
- data/app/{assets/javascripts/active_admin/lib/batch_actions.es6 → javascript/active_admin/initializers/batch-actions.js} +4 -2
- data/app/javascript/active_admin/initializers/checkbox-toggler.js +3 -0
- data/app/{assets/javascripts/active_admin/initializers/datepicker.es6 → javascript/active_admin/initializers/datepicker.js} +0 -0
- data/app/javascript/active_admin/initializers/dropdown-menu.js +9 -0
- data/app/javascript/active_admin/initializers/filters.js +10 -0
- data/app/{assets/javascripts/active_admin/lib/has_many.es6 → javascript/active_admin/initializers/has-many.js} +0 -0
- data/app/javascript/active_admin/initializers/per-page.js +13 -0
- data/app/javascript/active_admin/initializers/table-checkbox-toggler.js +3 -0
- data/app/{assets/javascripts/active_admin/initializers/tabs.es6 → javascript/active_admin/initializers/tabs.js} +0 -0
- data/app/{assets/javascripts/active_admin/lib/checkbox-toggler.es6 → javascript/active_admin/lib/checkbox-toggler.js} +5 -5
- data/app/{assets/javascripts/active_admin/lib/dropdown-menu.es6 → javascript/active_admin/lib/dropdown-menu.js} +3 -10
- data/app/javascript/active_admin/lib/filters.js +39 -0
- data/app/{assets/javascripts/active_admin/lib/modal_dialog.es6 → javascript/active_admin/lib/modal-dialog.js} +10 -8
- data/app/javascript/active_admin/lib/per-page.js +38 -0
- data/app/{assets/javascripts/active_admin/lib/table-checkbox-toggler.es6 → javascript/active_admin/lib/table-checkbox-toggler.js} +5 -3
- data/app/javascript/active_admin/lib/utils.js +40 -0
- data/app/views/layouts/active_admin_logged_out.html.erb +15 -5
- data/config/locales/ar.yml +6 -6
- data/config/locales/az.yml +138 -0
- data/config/locales/en-CA.yml +3 -3
- data/config/locales/en-GB.yml +3 -3
- data/config/locales/en.yml +3 -3
- data/config/locales/es-MX.yml +2 -1
- data/config/locales/es.yml +5 -5
- data/config/locales/fr.yml +4 -4
- data/config/locales/it.yml +18 -0
- data/config/locales/ja.yml +3 -3
- data/config/locales/lv.yml +2 -2
- data/config/locales/vi.yml +6 -5
- data/docs/0-installation.md +26 -2
- data/docs/1-general-configuration.md +20 -0
- data/docs/11-decorators.md +16 -5
- data/docs/2-resource-customization.md +10 -1
- data/docs/3-index-pages.md +1 -1
- data/docs/9-batch-actions.md +2 -2
- data/docs/Gemfile.lock +119 -109
- data/docs/_includes/top-menu.html +1 -1
- data/docs/documentation.md +1 -1
- data/docs/index.html +6 -6
- data/lib/active_admin.rb +43 -44
- data/lib/active_admin/application.rb +7 -7
- data/lib/active_admin/authorization_adapter.rb +3 -3
- data/lib/active_admin/base_controller/authorization.rb +9 -9
- data/lib/active_admin/batch_actions/controller.rb +3 -3
- data/lib/active_admin/batch_actions/views/batch_action_form.rb +1 -1
- data/lib/active_admin/batch_actions/views/batch_action_selector.rb +5 -5
- data/lib/active_admin/collection_decorator.rb +31 -0
- data/lib/active_admin/csv_builder.rb +11 -7
- data/lib/active_admin/dependency.rb +7 -7
- data/lib/active_admin/filters.rb +1 -1
- data/lib/active_admin/filters/active_filter.rb +1 -1
- data/lib/active_admin/filters/forms.rb +3 -3
- data/lib/active_admin/filters/resource_extension.rb +1 -1
- data/lib/active_admin/form_builder.rb +5 -5
- data/lib/active_admin/helpers/optional_display.rb +2 -2
- data/lib/active_admin/inputs/filters/base/search_method_select.rb +2 -2
- data/lib/active_admin/inputs/filters/date_range_input.rb +15 -12
- data/lib/active_admin/localizers/resource_localizer.rb +1 -1
- data/lib/active_admin/menu.rb +5 -2
- data/lib/active_admin/menu_item.rb +7 -7
- data/lib/active_admin/namespace.rb +7 -7
- data/lib/active_admin/namespace_settings.rb +3 -0
- data/lib/active_admin/orm/active_record/comments.rb +11 -11
- data/lib/active_admin/orm/active_record/comments/comment.rb +3 -3
- data/lib/active_admin/orm/active_record/comments/views/active_admin_comments.rb +3 -3
- data/lib/active_admin/pundit_adapter.rb +4 -4
- data/lib/active_admin/resource.rb +1 -1
- data/lib/active_admin/resource/action_items.rb +1 -1
- data/lib/active_admin/resource/menu.rb +4 -4
- data/lib/active_admin/resource/naming.rb +4 -4
- data/lib/active_admin/resource/routes.rb +5 -5
- data/lib/active_admin/resource/scope_to.rb +7 -7
- data/lib/active_admin/resource_controller.rb +4 -3
- data/lib/active_admin/resource_controller/data_access.rb +1 -1
- data/lib/active_admin/resource_controller/decorators.rb +5 -25
- data/lib/active_admin/resource_controller/polymorphic_routes.rb +3 -2
- data/lib/active_admin/resource_dsl.rb +5 -5
- data/lib/active_admin/scope.rb +5 -5
- data/lib/active_admin/version.rb +1 -1
- data/lib/active_admin/view_factory.rb +16 -16
- data/lib/active_admin/view_helpers/breadcrumb_helper.rb +1 -1
- data/lib/active_admin/view_helpers/display_helper.rb +3 -3
- data/lib/active_admin/view_helpers/fields_for.rb +1 -1
- data/lib/active_admin/views/components/attributes_table.rb +2 -2
- data/lib/active_admin/views/components/dropdown_menu.rb +2 -2
- data/lib/active_admin/views/components/index_list.rb +1 -1
- data/lib/active_admin/views/components/menu_item.rb +1 -1
- data/lib/active_admin/views/components/paginated_collection.rb +15 -14
- data/lib/active_admin/views/components/scopes.rb +2 -0
- data/lib/active_admin/views/components/table_for.rb +12 -11
- data/lib/active_admin/views/components/tabs.rb +1 -1
- data/lib/active_admin/views/index_as_table.rb +6 -6
- data/lib/active_admin/views/pages/base.rb +9 -5
- data/lib/active_admin/views/pages/index.rb +9 -8
- data/lib/generators/active_admin/assets/templates/active_admin.scss +2 -2
- data/lib/generators/active_admin/devise/devise_generator.rb +4 -4
- data/lib/generators/active_admin/install/install_generator.rb +7 -1
- data/lib/generators/active_admin/install/templates/active_admin.rb.erb +9 -2
- data/lib/generators/active_admin/resource/resource_generator.rb +1 -1
- data/lib/generators/active_admin/webpacker/plugins/jquery.js +7 -0
- data/lib/generators/active_admin/webpacker/templates/active_admin.js +5 -0
- data/lib/generators/active_admin/webpacker/templates/active_admin.scss +17 -0
- data/lib/generators/active_admin/webpacker/templates/print.scss +2 -0
- data/lib/generators/active_admin/webpacker/webpacker_generator.rb +26 -0
- metadata +44 -48
- data/app/assets/images/active_admin/nested_menu_arrow.gif +0 -0
- data/app/assets/images/active_admin/nested_menu_arrow_dark.gif +0 -0
- data/app/assets/images/active_admin/orderable.png +0 -0
- data/app/assets/javascripts/active_admin/base.es6 +0 -23
- data/app/assets/javascripts/active_admin/initializers/filters.es6 +0 -45
- data/app/assets/javascripts/active_admin/lib/active_admin.es6 +0 -41
- data/app/assets/javascripts/active_admin/lib/per_page.es6 +0 -47
checksums.yaml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
---
|
2
2
|
SHA256:
|
3
|
-
metadata.gz:
|
4
|
-
data.tar.gz:
|
3
|
+
metadata.gz: 1eae0d60f49f4133f9500f31625e24882ac57efa140f8052c87dd65a0cfbd353
|
4
|
+
data.tar.gz: 8db6863400174d2ed23adcf9985efff541ef858afe56339822d9cf02411052c4
|
5
5
|
SHA512:
|
6
|
-
metadata.gz:
|
7
|
-
data.tar.gz:
|
6
|
+
metadata.gz: cf3d8b2a337b50a73a5806ce18e2c40c9985d5db2a064d417057b349d172909fb1ed6e248ea271c76e331a76a76578f975e044373dbc0ca5bd2141f0ac365df4
|
7
|
+
data.tar.gz: 88b06f52c04bae83a5068301b0013366db174638392a8b850bec32b20ff3e72adfb480335211558319ee671b1a7a28955fbf4334b8ebf89c836107c7b85c1e61
|
data/CHANGELOG.md
CHANGED
@@ -2,13 +2,96 @@
|
|
2
2
|
|
3
3
|
## Unreleased
|
4
4
|
|
5
|
+
## 2.8.0 [☰](https://github.com/activeadmin/activeadmin/compare/v2.7.0..v2.8.0)
|
6
|
+
|
7
|
+
### Enhancements
|
8
|
+
|
9
|
+
* Allow using PORO decorators. [#6249] by [@brunvez]
|
10
|
+
* Make sure `ActiveAdmin.routes` provides routes in a consistent order. [#6124] by [@jiikko]
|
11
|
+
* Use proper closing tags for HTML in ModalDialog component. [#6221] by [@javierjulio]
|
12
|
+
|
13
|
+
### Bug Fixes
|
14
|
+
|
15
|
+
* Fix comment layout so regardless of size, each is aligned and spaced evenly. [#6393] by [@Ivanov-Anton]
|
16
|
+
|
17
|
+
### Translation Improvements
|
18
|
+
|
19
|
+
* Fix several Arabic translations. [#6368] by [@mshalaby]
|
20
|
+
* Add missing `scope/all` italian translation. [#6341] by [@fuzziness]
|
21
|
+
* Improve Japanese translation. [#6315] by [@rn0rno]
|
22
|
+
* Fix es and es-MX sign_in and sign_up translation. [#6210] by [@roramirez]
|
23
|
+
|
24
|
+
### Documentation
|
25
|
+
|
26
|
+
* Fix filter_columns_for_large_association and filter_method_for_large_association examples. [#6232] by [@ndbroadbent]
|
27
|
+
|
28
|
+
### Dependency Changes
|
29
|
+
|
30
|
+
* Allow formtastic 4. [#6318] by [@deivid-rodriguez]
|
31
|
+
* Drop Ruby 2.4 support. [#6198] by [@deivid-rodriguez]
|
32
|
+
|
33
|
+
## 2.7.0 [☰](https://github.com/activeadmin/activeadmin/compare/v2.6.1..v2.7.0)
|
34
|
+
|
35
|
+
### Enhancements
|
36
|
+
|
37
|
+
* Extend menu to allow for nested submenus. [#5994] by [@taralbass]
|
38
|
+
* Add Webpacker compatibility with opt-in config switch and installation generator. [#5855] by [@sgara]
|
39
|
+
|
40
|
+
### Bug Fixes
|
41
|
+
|
42
|
+
* Fix scopes renderer when resource has only optional scopes and their conditions are false. [#6149] by [@Looooong]
|
43
|
+
* Fix some missing wrapper markup in "logged out" layout. [#6086] by [@irmela]
|
44
|
+
* Fix some typos in Vietnamese translation. [#6099] by [@giapnhdev]
|
45
|
+
|
46
|
+
## 2.6.1 [☰](https://github.com/activeadmin/activeadmin/compare/v2.6.0..v2.6.1)
|
47
|
+
|
48
|
+
### Bug Fixes
|
49
|
+
|
50
|
+
* Fix some ruby 2.7 warnings about keyword args. [#6000] by [@vcsjones]
|
51
|
+
* Missing `create_another` translation in Vietnamese. [#6002] by [@imcvampire]
|
52
|
+
* Using "destroy" for user facing message is too robotic, prefer "delete". [#6047] by [@vfonic]
|
53
|
+
* Typo in confirmation message for comment deletion. [#6047] by [@vfonic]
|
54
|
+
|
55
|
+
## 2.6.0 [☰](https://github.com/activeadmin/activeadmin/compare/v2.5.0..v2.6.0)
|
56
|
+
|
57
|
+
### Enhancements
|
58
|
+
|
59
|
+
* Display multiple flash messages in separate elements. [#5929] by [@mirelon]
|
60
|
+
* Make delete confirmation messages in French & Spanish gender-neutral. [#5946] by [@cprodhomme]
|
61
|
+
|
62
|
+
### Bug Fixes
|
63
|
+
|
64
|
+
* Export ModalDialog component to re-enable client side usage. [#5956] by [@sgara]
|
65
|
+
* Use default ActionView options instead of default Formtastic options for DateRangeInput [#5957] by [@mirelon]
|
66
|
+
* Fix i18n key in docs example to translate scopes. [#5943] by [@adler99]
|
67
|
+
|
68
|
+
## 2.5.0 [☰](https://github.com/activeadmin/activeadmin/compare/v2.4.0..v2.5.0)
|
69
|
+
|
70
|
+
### Enhancements
|
71
|
+
|
72
|
+
* Azerbaijani translation. [#5078] by [@orkhan]
|
73
|
+
|
74
|
+
### Bug Fixes
|
75
|
+
|
76
|
+
* Convert namespace to sym to prevent duplicate namespaces such as :foo and 'foo'. [#5931] by [@westonganger]
|
77
|
+
* Use filter label when condition has a predicate. [#5886] by [@ko-lem]
|
78
|
+
* Fix error when routing with array containing symbol. [#5870] by [@jwesorick]
|
79
|
+
* Fix error when there is a model named `Tag` and `meta_tags` have been configured. [#5895] by [@micred], [@FabioRos] and [@deivid-rodriguez]
|
80
|
+
* Allow specifying custom `input_html` for `DateRangeInput`. [#5867] by [@mirelon]
|
81
|
+
* Adjust `#main_content` right margin to take into account possible custom values of `$sidebar-width` and `$section-padding`. [#5887] by [@guigs]
|
82
|
+
* Improved polymorphic routes generation to avoid problems when multiple `belongs_to` are defined. [#5938] by [@leio10]
|
83
|
+
|
84
|
+
### Dependency Changes
|
85
|
+
|
86
|
+
* Support for Rails 5.0 and Rails 5.1 has been dropped. [#5877] by [@deivid-rodriguez]
|
87
|
+
|
5
88
|
## 2.4.0 [☰](https://github.com/activeadmin/activeadmin/compare/v2.3.1..v2.4.0)
|
6
89
|
|
7
90
|
### Enhancements
|
8
91
|
|
9
92
|
* Make optimization to not use expensive COUNT queries also work for decorated actions. [#5811] by [@irmela]
|
10
|
-
* Render a text filter instead of a select for large associations (opt-in) [#5548] by [@DanielHeath]
|
11
|
-
* Improve German translations [#5874] by [@juril33t]
|
93
|
+
* Render a text filter instead of a select for large associations (opt-in). [#5548] by [@DanielHeath]
|
94
|
+
* Improve German translations. [#5874] by [@juril33t]
|
12
95
|
|
13
96
|
## 2.3.1 [☰](https://github.com/activeadmin/activeadmin/compare/v2.3.0..v2.3.1)
|
14
97
|
|
@@ -20,8 +103,6 @@
|
|
20
103
|
|
21
104
|
### Enhancements
|
22
105
|
|
23
|
-
#### Minor
|
24
|
-
|
25
106
|
* Bump minimum ransack requirement to make sure everyone gets a version that works ok with all supported versions of Rails. [#5831] by [@deivid-rodriguez]
|
26
107
|
|
27
108
|
### Bug Fixes
|
@@ -36,14 +117,12 @@
|
|
36
117
|
|
37
118
|
### Enhancements
|
38
119
|
|
39
|
-
#### Minor
|
40
|
-
|
41
120
|
* The `status_tag` component now supports different labels for `false` and `nil` boolean cases through the locale. Both default to display "No" for backwards compatibility. [#5794] by [@javierjulio]
|
42
121
|
* Add Macedonian locale. [#5710] by [@violeta-p]
|
43
122
|
|
44
123
|
### Bug Fixes
|
45
124
|
|
46
|
-
* Fix pundit policy retrieving for static pages when the pundit namespace is
|
125
|
+
* Fix pundit policy retrieving for static pages when the pundit namespace is `:active_admin`. [#5777] by [@kwent]
|
47
126
|
* Fix show page title not being properly escaped if title's content included HTML. [#5802] by [@deivid-rodriguez]
|
48
127
|
* Revert [21b6138f] from [#5740] since it actually caused the performance in development to regress. [#5801] by [@deivid-rodriguez]
|
49
128
|
|
@@ -55,7 +134,7 @@
|
|
55
134
|
* Crash when rendering comments from a custom controller block. [#5758] by [@deivid-rodriguez]
|
56
135
|
* Switch `sass` dependency to `sassc-rails`, since `sass` is no longer supported and since it restores support for directly importing `css` files. [#5504] by [@deivid-rodriguez]
|
57
136
|
|
58
|
-
###
|
137
|
+
### Dependency Changes
|
59
138
|
|
60
139
|
* Support for ruby 2.3 has been removed. [#5751] by [@deivid-rodriguez]
|
61
140
|
|
@@ -67,8 +146,6 @@ _No changes_.
|
|
67
146
|
|
68
147
|
### Enhancements
|
69
148
|
|
70
|
-
#### Minor
|
71
|
-
|
72
149
|
* Require arbre `~> 1.2, >= 1.2.1`. [#5726] by [@ionut998], and [#5738] by [@deivid-rodriguez]
|
73
150
|
|
74
151
|
## 2.0.0.rc1 [☰](https://github.com/activeadmin/activeadmin/compare/v1.4.3..v2.0.0.rc1)
|
@@ -84,9 +161,6 @@ _No changes_.
|
|
84
161
|
```
|
85
162
|
|
86
163
|
* Consider authorization when displaying comments in show page. [#5555] by [@amiuhle]
|
87
|
-
|
88
|
-
#### Minor
|
89
|
-
|
90
164
|
* Add better support for rendering lists. [#5370] by [@dkniffin]
|
91
165
|
* Undeprecate `config.register_stylesheet` and `config.register_javascript` for lack of better solution for including external assets. It might be reevaluated in the future. [#5662] by [@deivid-rodriguez]
|
92
166
|
|
@@ -103,7 +177,7 @@ _No changes_.
|
|
103
177
|
* Sidebar title internationalization. [#5417] by [@WaKeMaTTa]
|
104
178
|
* `filter` labels not allowing a `Proc` to be passed. [#5418] by [@WaKeMaTTa]
|
105
179
|
|
106
|
-
###
|
180
|
+
### Dependency Changes
|
107
181
|
|
108
182
|
* Rails 4.2 support has been dropped. [#5104] by [@javierjulio] and [@deivid-rodriguez]
|
109
183
|
* Dependency on coffee-rails has been removed. [#5081] by [@javierjulio]
|
@@ -139,8 +213,6 @@ _No changes_.
|
|
139
213
|
|
140
214
|
### Enhancements
|
141
215
|
|
142
|
-
#### Minor
|
143
|
-
|
144
216
|
* Add missing I18n for comments. [#5458], [#5461] by [@mauriciopasquier]
|
145
217
|
* Fix batch_actions.delete_confirmation translation in zh-CN.yml. [#5453] by [@ShallmentMo]
|
146
218
|
* Add some missing italian translations. [#5433] by [@stefsava]
|
@@ -178,8 +250,6 @@ _No changes_.
|
|
178
250
|
|
179
251
|
### Enhancements
|
180
252
|
|
181
|
-
#### Major
|
182
|
-
|
183
253
|
* Rails 5.2 support [#5343] by [@varyonic], [#5399], [#5401] by [@zorab47]
|
184
254
|
|
185
255
|
## 1.2.1 [☰](https://github.com/activeadmin/activeadmin/compare/v1.2.0..v1.2.1)
|
@@ -192,8 +262,6 @@ _No changes_.
|
|
192
262
|
|
193
263
|
### Enhancements
|
194
264
|
|
195
|
-
#### Minor
|
196
|
-
|
197
265
|
* Do not display pagination info when there are no comments. [#5119] by [@alex-bogomolov]
|
198
266
|
* Revert generated config files to pluralized. [#5120] by [@varyonic], [#5137] by [@deivid-rodriguez]
|
199
267
|
* Warn when action definition overwrites controller method. [#5167] by [@aarek]
|
@@ -224,7 +292,7 @@ _No changes_.
|
|
224
292
|
* Fixed [#5043]. Do not crash in sidebar rendering when a default scope is not specified. [#5044] by [@Fivell]
|
225
293
|
* Fixed [#3894]. Make tab's component work with non-ascii titles. [#5046] by [@Fivell]
|
226
294
|
|
227
|
-
###
|
295
|
+
### Dependency Changes
|
228
296
|
|
229
297
|
* Ruby 2.1 support has been dropped. [#5003] by [@deivid-rodriguez]
|
230
298
|
* Replaced `sass-rails` with `sass` dependency. [#5037] by [@javierjulio]
|
@@ -262,8 +330,6 @@ _No changes_.
|
|
262
330
|
|
263
331
|
### Enhancements
|
264
332
|
|
265
|
-
#### Minor
|
266
|
-
|
267
333
|
* Support proc as an input_html option value when declaring filters. [#5029] by [@Fivell]
|
268
334
|
* Base localization support, better associations handling for active filters sidebar. [#4951] by [@Fivell]
|
269
335
|
* Allow AA scopes to return paginated collections. [#4996] by [@Fivell]
|
@@ -287,16 +353,11 @@ _No changes_.
|
|
287
353
|
|
288
354
|
### Enhancements
|
289
355
|
|
290
|
-
#### Major
|
291
|
-
|
292
356
|
* Migration from Metasearch to Ransack. [#1979] by [@seanlinsley]
|
293
357
|
* Rails 4 support. [#2326] by many people :heart:
|
294
358
|
* Rails 4.2 support. [#3731] by [@gonzedge] and [@timoschilling]
|
295
359
|
* Rails 5 support. [#4254] by [@seanlinsley]
|
296
360
|
* Rails 5.1 support. [#4882] by [@varyonic]
|
297
|
-
|
298
|
-
#### Minor
|
299
|
-
|
300
361
|
* "Create another" checkbox for the new resource page. [#4477] by [@bolshakov]
|
301
362
|
* Page supports belongs_to. [#4759] by [@Fivell] and [@zorab47]
|
302
363
|
* Support for custom sorting strategies. [#4768] by [@Fivell]
|
@@ -427,6 +488,7 @@ Please check [0-6-stable] for previous changes.
|
|
427
488
|
[#5052]: https://github.com/activeadmin/activeadmin/pull/5052
|
428
489
|
[#5060]: https://github.com/activeadmin/activeadmin/pull/5060
|
429
490
|
[#5069]: https://github.com/activeadmin/activeadmin/pull/5069
|
491
|
+
[#5078]: https://github.com/activeadmin/activeadmin/pull/5078
|
430
492
|
[#5081]: https://github.com/activeadmin/activeadmin/pull/5081
|
431
493
|
[#5088]: https://github.com/activeadmin/activeadmin/pull/5088
|
432
494
|
[#5093]: https://github.com/activeadmin/activeadmin/pull/5093
|
@@ -486,15 +548,16 @@ Please check [0-6-stable] for previous changes.
|
|
486
548
|
[#5504]: https://github.com/activeadmin/activeadmin/pull/5504
|
487
549
|
[#5517]: https://github.com/activeadmin/activeadmin/pull/5517
|
488
550
|
[#5537]: https://github.com/activeadmin/activeadmin/pull/5537
|
551
|
+
[#5548]: https://github.com/activeadmin/activeadmin/pull/5548
|
489
552
|
[#5555]: https://github.com/activeadmin/activeadmin/pull/5555
|
490
553
|
[#5583]: https://github.com/activeadmin/activeadmin/pull/5583
|
554
|
+
[#5590]: https://github.com/activeadmin/activeadmin/pull/5590
|
491
555
|
[#5608]: https://github.com/activeadmin/activeadmin/pull/5608
|
492
556
|
[#5611]: https://github.com/activeadmin/activeadmin/pull/5611
|
493
557
|
[#5627]: https://github.com/activeadmin/activeadmin/pull/5627
|
494
558
|
[#5631]: https://github.com/activeadmin/activeadmin/pull/5631
|
495
559
|
[#5632]: https://github.com/activeadmin/activeadmin/pull/5632
|
496
560
|
[#5650]: https://github.com/activeadmin/activeadmin/pull/5650
|
497
|
-
[#5590]: https://github.com/activeadmin/activeadmin/pull/5590
|
498
561
|
[#5662]: https://github.com/activeadmin/activeadmin/pull/5662
|
499
562
|
[#5710]: https://github.com/activeadmin/activeadmin/pull/5710
|
500
563
|
[#5726]: https://github.com/activeadmin/activeadmin/pull/5726
|
@@ -512,13 +575,46 @@ Please check [0-6-stable] for previous changes.
|
|
512
575
|
[#5822]: https://github.com/activeadmin/activeadmin/pull/5822
|
513
576
|
[#5826]: https://github.com/activeadmin/activeadmin/pull/5826
|
514
577
|
[#5831]: https://github.com/activeadmin/activeadmin/pull/5831
|
515
|
-
[#5548]: https://github.com/activeadmin/activeadmin/pull/5548
|
516
578
|
[#5842]: https://github.com/activeadmin/activeadmin/pull/5842
|
517
579
|
[#5854]: https://github.com/activeadmin/activeadmin/pull/5854
|
580
|
+
[#5855]: https://github.com/activeadmin/activeadmin/pull/5855
|
581
|
+
[#5867]: https://github.com/activeadmin/activeadmin/pull/5867
|
582
|
+
[#5870]: https://github.com/activeadmin/activeadmin/pull/5870
|
518
583
|
[#5874]: https://github.com/activeadmin/activeadmin/pull/5874
|
584
|
+
[#5877]: https://github.com/activeadmin/activeadmin/pull/5877
|
585
|
+
[#5886]: https://github.com/activeadmin/activeadmin/pull/5886
|
586
|
+
[#5887]: https://github.com/activeadmin/activeadmin/pull/5887
|
587
|
+
[#5894]: https://github.com/activeadmin/activeadmin/pull/5894
|
588
|
+
[#5895]: https://github.com/activeadmin/activeadmin/pull/5895
|
589
|
+
[#5929]: https://github.com/activeadmin/activeadmin/pull/5929
|
590
|
+
[#5931]: https://github.com/activeadmin/activeadmin/pull/5931
|
591
|
+
[#5938]: https://github.com/activeadmin/activeadmin/pull/5938
|
592
|
+
[#5943]: https://github.com/activeadmin/activeadmin/pull/5943
|
593
|
+
[#5946]: https://github.com/activeadmin/activeadmin/pull/5946
|
594
|
+
[#5956]: https://github.com/activeadmin/activeadmin/pull/5956
|
595
|
+
[#5957]: https://github.com/activeadmin/activeadmin/pull/5957
|
596
|
+
[#5994]: https://github.com/activeadmin/activeadmin/pull/5994
|
597
|
+
[#6000]: https://github.com/activeadmin/activeadmin/pull/6000
|
598
|
+
[#6002]: https://github.com/activeadmin/activeadmin/pull/6002
|
599
|
+
[#6047]: https://github.com/activeadmin/activeadmin/pull/6047
|
600
|
+
[#6086]: https://github.com/activeadmin/activeadmin/pull/6086
|
601
|
+
[#6099]: https://github.com/activeadmin/activeadmin/pull/6099
|
602
|
+
[#6124]: https://github.com/activeadmin/activeadmin/pull/6124
|
603
|
+
[#6149]: https://github.com/activeadmin/activeadmin/pull/6149
|
604
|
+
[#6198]: https://github.com/activeadmin/activeadmin/pull/6198
|
605
|
+
[#6210]: https://github.com/activeadmin/activeadmin/pull/6210
|
606
|
+
[#6221]: https://github.com/activeadmin/activeadmin/pull/6221
|
607
|
+
[#6232]: https://github.com/activeadmin/activeadmin/pull/6232
|
608
|
+
[#6249]: https://github.com/activeadmin/activeadmin/pull/6249
|
609
|
+
[#6315]: https://github.com/activeadmin/activeadmin/pull/6315
|
610
|
+
[#6318]: https://github.com/activeadmin/activeadmin/pull/6318
|
611
|
+
[#6341]: https://github.com/activeadmin/activeadmin/pull/6341
|
612
|
+
[#6368]: https://github.com/activeadmin/activeadmin/pull/6368
|
613
|
+
[#6393]: https://github.com/activeadmin/activeadmin/pull/6393
|
519
614
|
|
520
615
|
[@5t111111]: https://github.com/5t111111
|
521
616
|
[@aarek]: https://github.com/aarek
|
617
|
+
[@adler99]: https://github.com/adler99
|
522
618
|
[@ajw725]: https://github.com/ajw725
|
523
619
|
[@alex-bogomolov]: https://github.com/alex-bogomolov
|
524
620
|
[@amiel]: https://github.com/amiel
|
@@ -527,10 +623,12 @@ Please check [0-6-stable] for previous changes.
|
|
527
623
|
[@bartoszkopinski]: https://github.com/bartoszkopinski
|
528
624
|
[@blocknotes]: https://github.com/blocknotes
|
529
625
|
[@bolshakov]: https://github.com/bolshakov
|
626
|
+
[@brunvez]: https://github.com/brunvez
|
530
627
|
[@buren]: https://github.com/buren
|
531
628
|
[@chancancode]: https://github.com/chancancode
|
532
629
|
[@chrp]: https://github.com/chrp
|
533
630
|
[@chumakoff]: https://github.com/chumakoff
|
631
|
+
[@cprodhomme]: https://github.com/cprodhomme
|
534
632
|
[@craigmcnamara]: https://github.com/craigmcnamara
|
535
633
|
[@DanielHeath]: https://github.com/DanielHeath
|
536
634
|
[@deivid-rodriguez]: https://github.com/deivid-rodriguez
|
@@ -541,38 +639,54 @@ Please check [0-6-stable] for previous changes.
|
|
541
639
|
[@drn]: https://github.com/drn
|
542
640
|
[@eikes]: https://github.com/eikes
|
543
641
|
[@f1sherman]: https://github.com/f1sherman
|
642
|
+
[@FabioRos]: https://github.com/FabioRos
|
544
643
|
[@faucct]: https://github.com/faucct
|
545
644
|
[@Fivell]: https://github.com/Fivell
|
645
|
+
[@fuzziness]: https://github.com/fuzziness
|
646
|
+
[@giapnhdev]: https://github.com/giapnhdev
|
546
647
|
[@glebtv]: https://github.com/glebtv
|
547
648
|
[@gonzedge]: https://github.com/gonzedge
|
649
|
+
[@guigs]: https://github.com/guigs
|
548
650
|
[@HappyKadaver]: https://github.com/HappyKadaver
|
651
|
+
[@imcvampire]: https://github.com/imcvampire
|
549
652
|
[@innparusu95]: https://github.com/innparusu95
|
550
653
|
[@ionut998]: https://github.com/ionut998
|
551
654
|
[@irmela]: https://github.com/irmela
|
655
|
+
[@Ivanov-Anton]: https://github.com/Ivanov-Anton
|
552
656
|
[@jasl]: https://github.com/jasl
|
553
657
|
[@javierjulio]: https://github.com/javierjulio
|
554
658
|
[@jawa]: https://github.com/jawa
|
555
659
|
[@JiiHu]: https://github.com/JiiHu
|
660
|
+
[@jiikko]: https://github.com/jiikko
|
556
661
|
[@johnnyshields]: https://github.com/johnnyshields
|
557
662
|
[@jscheid]: https://github.com/jscheid
|
558
663
|
[@juril33t]: https://github.com/juril33t
|
664
|
+
[@jwesorick]: https://github.com/jwesorick
|
559
665
|
[@kjeldahl]: https://github.com/kjeldahl
|
666
|
+
[@ko-lem]: https://github.com/ko-lem
|
560
667
|
[@kobeumut]: https://github.com/kobeumut
|
561
668
|
[@Kris-LIBIS]: https://github.com/Kris-LIBIS
|
562
669
|
[@kwent]: https://github.com/kwent
|
563
670
|
[@leio10]: https://github.com/leio10
|
671
|
+
[@Looooong]: https://github.com/Looooong
|
564
672
|
[@markstory]: https://github.com/markstory
|
565
673
|
[@mauriciopasquier]: https://github.com/mauriciopasquier
|
566
674
|
[@mconiglio]: https://github.com/mconiglio
|
675
|
+
[@micred]: https://github.com/micred
|
676
|
+
[@mirelon]: https://github.com/mirelon
|
677
|
+
[@mshalaby]: https://github.com/mshalaby
|
567
678
|
[@ndbroadbent]: https://github.com/ndbroadbent
|
568
679
|
[@Nguyenanh]: https://github.com/Nguyenanh
|
680
|
+
[@orkhan]: https://github.com/orkhan
|
569
681
|
[@panasyuk]: https://github.com/panasyuk
|
570
682
|
[@PChambino]: https://github.com/PChambino
|
571
683
|
[@potatosalad]: https://github.com/potatosalad
|
572
684
|
[@pranas]: https://github.com/pranas
|
573
685
|
[@renotocn]: https://github.com/renotocn
|
686
|
+
[@rn0rno]: https://github.com/rn0rno
|
574
687
|
[@RobinvanderVliet]: https://github.com/RobinvanderVliet
|
575
688
|
[@rogerkk]: https://github.com/rogerkk
|
689
|
+
[@roramirez]: https://github.com/roramirez
|
576
690
|
[@seanlinsley]: https://github.com/seanlinsley
|
577
691
|
[@sgara]: https://github.com/sgara
|
578
692
|
[@ShallmentMo]: https://github.com/ShallmentMo
|
@@ -580,13 +694,17 @@ Please check [0-6-stable] for previous changes.
|
|
580
694
|
[@shouya]: https://github.com/shouya
|
581
695
|
[@stefsava]: https://github.com/stefsava
|
582
696
|
[@stereoscott]: https://github.com/stereoscott
|
697
|
+
[@taralbass]: https://github.com/taralbass
|
583
698
|
[@tiagotex]: https://github.com/tiagotex
|
584
699
|
[@timoschilling]: https://github.com/timoschilling
|
585
700
|
[@TimPetricola]: https://github.com/TimPetricola
|
586
701
|
[@varyonic]: https://github.com/varyonic
|
702
|
+
[@vcsjones]: https://github.com/vcsjones
|
703
|
+
[@vfonic]: https://github.com/vfonic
|
587
704
|
[@violeta-p]: https://github.com/violeta-p
|
588
705
|
[@WaKeMaTTa]: https://github.com/WaKeMaTTa
|
589
706
|
[@wasifhossain]: https://github.com/wasifhossain
|
707
|
+
[@westonganger]: https://github.com/westonganger
|
590
708
|
[@Wowu]: https://github.com/Wowu
|
591
709
|
[@wspurgin]: https://github.com/wspurgin
|
592
710
|
[@zorab47]: https://github.com/zorab47
|
data/CONTRIBUTING.md
CHANGED
@@ -5,15 +5,17 @@ like you that make Active Admin such a great tool.
|
|
5
5
|
|
6
6
|
### Where do I go from here?
|
7
7
|
|
8
|
-
If you've noticed a bug or have a
|
9
|
-
|
10
|
-
|
11
|
-
|
8
|
+
If you've noticed a bug or have a feature request, [make one][new issue]! It's
|
9
|
+
generally best if you get confirmation of your bug or approval for your feature
|
10
|
+
request this way before starting to code.
|
11
|
+
|
12
|
+
If you have a general question about activeadmin, you can post it on [Stack
|
13
|
+
Overflow], the issue tracker is only for bugs and feature requests.
|
12
14
|
|
13
15
|
### Fork & create a branch
|
14
16
|
|
15
|
-
If this is something you think you can fix, then [fork Active Admin]
|
16
|
-
|
17
|
+
If this is something you think you can fix, then [fork Active Admin] and create
|
18
|
+
a branch with a descriptive name.
|
17
19
|
|
18
20
|
A good branch name would be (where issue #325 is the ticket you're working on):
|
19
21
|
|
@@ -34,6 +36,20 @@ Now install the development dependencies:
|
|
34
36
|
bundle install
|
35
37
|
```
|
36
38
|
|
39
|
+
Then install javascript dependencies with [Yarn] (requires a current version of [Node.js]):
|
40
|
+
|
41
|
+
```sh
|
42
|
+
bin/yarn install
|
43
|
+
```
|
44
|
+
|
45
|
+
JS assets are located in `app/javascript/active_admin`. The config will take care of compiling a complete bundle with [Rollup] using the `build` script and exported to `app/assets/javascripts/active_admin/base.js` ready to be used by Sprockets.
|
46
|
+
|
47
|
+
To update javascript bundle run (add `-w` flag for watch mode):
|
48
|
+
|
49
|
+
```sh
|
50
|
+
bin/yarn build
|
51
|
+
```
|
52
|
+
|
37
53
|
Now you should be able to run the entire suite using:
|
38
54
|
|
39
55
|
```sh
|
@@ -43,46 +59,22 @@ bin/rake
|
|
43
59
|
The test run will generate a sample Rails application in `tmp/test_apps` to run the
|
44
60
|
tests against.
|
45
61
|
|
46
|
-
If your tests are passing locally but they're failing on CircleCI, it's probably
|
47
|
-
because of some breaking change or problem with the latest version of some
|
48
|
-
dependency. You should be able to reproduce the issue locally by:
|
49
|
-
|
50
|
-
* Removing the `Gemfile.lock` file.
|
51
|
-
* Running `bundle install`.
|
52
|
-
* Re-running the tests again like you did previously.
|
53
|
-
|
54
|
-
This is not your fault though, so if this happens feel free to investigate, but
|
55
|
-
also feel free to ping maintainers about the issue you just found.
|
56
|
-
|
57
62
|
If you want to test against a Rails version different from the latest, make sure
|
58
63
|
you use the correct Gemfile, for example:
|
59
64
|
|
60
65
|
```sh
|
61
|
-
export BUNDLE_GEMFILE=gemfiles/
|
66
|
+
export BUNDLE_GEMFILE=gemfiles/rails_60/Gemfile
|
62
67
|
```
|
63
68
|
|
64
|
-
|
69
|
+
**Warning** SCSS assets are aimed to be used indifferently with Sprockets **and** webpacker.
|
70
|
+
As such, make sure not to use any sass-rails directives such as `asset-url` or `image-url`.
|
65
71
|
|
66
|
-
|
67
|
-
|
68
|
-
* If you're unable to find an open issue addressing the problem,
|
69
|
-
[open a new one][new issue]. Be sure to include a **title and clear
|
70
|
-
description**, as much relevant information as possible, and a **code sample**
|
71
|
-
or an **executable test case** demonstrating the expected behavior that is not
|
72
|
-
occurring.
|
73
|
-
|
74
|
-
* If possible, use the relevant bug report templates to create the issue.
|
75
|
-
Simply copy the content of the appropriate template into a .rb file, make the
|
76
|
-
necessary changes to demonstrate the issue, and **paste the content into the
|
77
|
-
issue description**:
|
78
|
-
* [**ActiveAdmin** master issues][master template]
|
79
|
-
|
80
|
-
### 5. Implement your fix or feature
|
72
|
+
### Implement your fix or feature
|
81
73
|
|
82
74
|
At this point, you're ready to make your changes! Feel free to ask for help;
|
83
75
|
everyone is a beginner at first :smile_cat:
|
84
76
|
|
85
|
-
###
|
77
|
+
### View your changes in a Rails application
|
86
78
|
|
87
79
|
Active Admin is meant to be used by humans, not cucumbers. So make sure to take
|
88
80
|
a look at your changes in a browser.
|
@@ -182,34 +174,22 @@ met.
|
|
182
174
|
|
183
175
|
Maintainers need to do the following to push out a release:
|
184
176
|
|
185
|
-
*
|
186
|
-
* Update `version.rb` file and changelog with new version number
|
187
|
-
* If it's not a patch level release, create a stable branch for that release,
|
188
|
-
otherwise switch to the stable branch corresponding to the patch release you
|
189
|
-
want to ship:
|
190
|
-
|
191
|
-
```sh
|
192
|
-
git checkout master
|
193
|
-
git fetch activeadmin
|
194
|
-
git rebase activeadmin/master
|
195
|
-
# If the release is 2.1.x then this should be: 2-1-stable
|
196
|
-
git checkout -b N-N-stable
|
197
|
-
git push activeadmin N-N-stable:N-N-stable
|
198
|
-
```
|
199
|
-
|
177
|
+
* Switch to the master branch and make sure it's up to date.
|
200
178
|
* Make sure you have [chandler] properly configured. Chandler is used to
|
201
179
|
automatically submit github release notes from the changelog right after
|
202
180
|
pushing the gem to rubygems.
|
203
|
-
* `bin/rake release
|
181
|
+
* Run one of `bin/rake release:prepare_{prerelease,prepatch,patch,preminor,minor,premajor,major}`, push the result and create a PR.
|
182
|
+
* Review and merge the PR. The generated changelog in the PR should include all user visible changes you intend to ship.
|
183
|
+
* Run `bin/rake release` from the target branch once the PR is merged.
|
204
184
|
|
205
185
|
[chandler]: https://github.com/mattbrictson/chandler#2-configure-credentials
|
206
|
-
[mailing list]: http://groups.google.com/group/activeadmin
|
207
186
|
[Stack Overflow]: http://stackoverflow.com/questions/tagged/activeadmin
|
208
|
-
[search the issue tracker]: https://github.com/activeadmin/activeadmin/issues?q=something
|
209
187
|
[new issue]: https://github.com/activeadmin/activeadmin/issues/new
|
210
188
|
[fork Active Admin]: https://help.github.com/articles/fork-a-repo
|
211
|
-
[searching all issues]: https://github.com/activeadmin/activeadmin/issues?q=
|
212
|
-
[master template]: https://github.com/activeadmin/activeadmin/blob/master/tasks/bug_report_template.rb
|
213
189
|
[make a pull request]: https://help.github.com/articles/creating-a-pull-request
|
214
190
|
[git rebasing]: http://git-scm.com/book/en/Git-Branching-Rebasing
|
215
|
-
[interactive rebase]: https://help.github.com/
|
191
|
+
[interactive rebase]: https://help.github.com/en/github/using-git/about-git-rebase
|
192
|
+
[shortcut reference links]: https://github.github.com/gfm/#shortcut-reference-link
|
193
|
+
[Rollup]: https://rollupjs.org/guide/en/#quick-start
|
194
|
+
[Yarn]: https://yarnpkg.com/en/docs/install
|
195
|
+
[Node.js]: https://nodejs.org/en/
|