activeadmin 2.2.0 → 2.6.0
Sign up to get free protection for your applications and to get access to all the features.
Potentially problematic release.
This version of activeadmin might be problematic. Click here for more details.
- checksums.yaml +4 -4
- data/CHANGELOG.md +111 -30
- data/CONTRIBUTING.md +50 -44
- data/README.md +9 -2
- data/app/assets/javascripts/active_admin/base.js +519 -0
- data/app/assets/stylesheets/active_admin/_base.scss +29 -29
- data/app/assets/stylesheets/active_admin/_header.scss +3 -5
- data/app/assets/stylesheets/active_admin/_mixins.scss +1 -1
- data/{vendor → app}/assets/stylesheets/active_admin/_normalize.scss +0 -0
- data/app/assets/stylesheets/active_admin/components/_tables.scss +1 -2
- data/app/assets/stylesheets/active_admin/mixins/_all.scss +8 -8
- data/app/assets/stylesheets/active_admin/mixins/_variables.scss +5 -0
- data/app/assets/stylesheets/active_admin/print.scss +2 -2
- data/app/assets/stylesheets/active_admin/structure/_main_structure.scss +1 -1
- data/app/javascript/active_admin/base.js +28 -0
- data/app/{assets/javascripts/active_admin/ext/jquery-ui.es6 → javascript/active_admin/ext/jquery-ui.js} +0 -0
- data/app/{assets/javascripts/active_admin/ext/jquery.es6 → javascript/active_admin/ext/jquery.js} +0 -0
- data/app/{assets/javascripts/active_admin/lib/batch_actions.es6 → javascript/active_admin/initializers/batch-actions.js} +9 -3
- data/app/javascript/active_admin/initializers/checkbox-toggler.js +3 -0
- data/app/{assets/javascripts/active_admin/initializers/datepicker.es6 → javascript/active_admin/initializers/datepicker.js} +0 -0
- data/app/javascript/active_admin/initializers/dropdown-menu.js +9 -0
- data/app/javascript/active_admin/initializers/filters.js +10 -0
- data/app/{assets/javascripts/active_admin/lib/has_many.es6 → javascript/active_admin/initializers/has-many.js} +0 -0
- data/app/javascript/active_admin/initializers/per-page.js +13 -0
- data/app/javascript/active_admin/initializers/table-checkbox-toggler.js +3 -0
- data/app/{assets/javascripts/active_admin/initializers/tabs.es6 → javascript/active_admin/initializers/tabs.js} +0 -0
- data/app/{assets/javascripts/active_admin/lib/checkbox-toggler.es6 → javascript/active_admin/lib/checkbox-toggler.js} +2 -2
- data/app/{assets/javascripts/active_admin/lib/dropdown-menu.es6 → javascript/active_admin/lib/dropdown-menu.js} +2 -9
- data/app/javascript/active_admin/lib/filters.js +39 -0
- data/app/{assets/javascripts/active_admin/lib/modal_dialog.es6 → javascript/active_admin/lib/modal-dialog.js} +3 -1
- data/app/javascript/active_admin/lib/per-page.js +38 -0
- data/app/{assets/javascripts/active_admin/lib/table-checkbox-toggler.es6 → javascript/active_admin/lib/table-checkbox-toggler.js} +4 -2
- data/app/javascript/active_admin/lib/utils.js +40 -0
- data/app/views/kaminari/active_admin_countless/_first_page.html.erb +11 -0
- data/app/views/kaminari/active_admin_countless/_gap.html.erb +8 -0
- data/app/views/kaminari/active_admin_countless/_next_page.html.erb +11 -0
- data/app/views/kaminari/active_admin_countless/_page.html.erb +12 -0
- data/app/views/kaminari/active_admin_countless/_paginator.html.erb +24 -0
- data/app/views/kaminari/active_admin_countless/_prev_page.html.erb +11 -0
- data/config/locales/az.yml +138 -0
- data/config/locales/ca.yml +0 -1
- data/config/locales/de.yml +18 -0
- data/config/locales/es.yml +3 -3
- data/config/locales/fr.yml +4 -4
- data/config/locales/sk.yml +59 -0
- data/docs/1-general-configuration.md +20 -0
- data/docs/2-resource-customization.md +1 -1
- data/docs/3-index-pages.md +1 -1
- data/docs/3-index-pages/index-as-table.md +7 -0
- data/docs/9-batch-actions.md +2 -2
- data/docs/Gemfile +0 -1
- data/docs/Gemfile.lock +103 -105
- data/docs/_config.yml +2 -0
- data/docs/_includes/top-menu.html +2 -2
- data/docs/index.html +108 -7
- data/docs/stylesheets/main.css +29 -0
- data/lib/active_admin.rb +0 -1
- data/lib/active_admin/application.rb +1 -1
- data/lib/active_admin/csv_builder.rb +1 -2
- data/lib/active_admin/filters/active_filter.rb +1 -1
- data/lib/active_admin/filters/resource_extension.rb +24 -0
- data/lib/active_admin/generators/boilerplate.rb +12 -4
- data/lib/active_admin/inputs/filters/date_range_input.rb +15 -12
- data/lib/active_admin/namespace_settings.rb +13 -0
- data/lib/active_admin/order_clause.rb +1 -1
- data/lib/active_admin/resource.rb +14 -1
- data/lib/active_admin/resource/belongs_to.rb +3 -0
- data/lib/active_admin/resource/model.rb +15 -0
- data/lib/active_admin/resource/routes.rb +11 -3
- data/lib/active_admin/resource_controller.rb +2 -0
- data/lib/active_admin/resource_controller/decorators.rb +2 -2
- data/lib/active_admin/resource_controller/polymorphic_routes.rb +37 -0
- data/lib/active_admin/version.rb +1 -1
- data/lib/active_admin/views/components/paginated_collection.rb +3 -2
- data/lib/active_admin/views/components/table_for.rb +1 -0
- data/lib/active_admin/views/index_as_table.rb +7 -0
- data/lib/active_admin/views/pages/base.rb +5 -3
- data/lib/active_admin/views/pages/index.rb +1 -0
- data/lib/generators/active_admin/install/templates/active_admin.rb.erb +14 -1
- data/lib/generators/active_admin/resource/templates/admin.rb.erb +4 -2
- metadata +35 -43
- data/app/assets/images/active_admin/nested_menu_arrow.gif +0 -0
- data/app/assets/images/active_admin/nested_menu_arrow_dark.gif +0 -0
- data/app/assets/images/active_admin/orderable.png +0 -0
- data/app/assets/javascripts/active_admin/base.es6 +0 -23
- data/app/assets/javascripts/active_admin/initializers/filters.es6 +0 -45
- data/app/assets/javascripts/active_admin/lib/active_admin.es6 +0 -41
- data/app/assets/javascripts/active_admin/lib/per_page.es6 +0 -47
checksums.yaml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
---
|
2
2
|
SHA256:
|
3
|
-
metadata.gz:
|
4
|
-
data.tar.gz:
|
3
|
+
metadata.gz: 31e6adaf39f455cb8188d2982a201d9853a2976e9ae446dcc7958882a6f15422
|
4
|
+
data.tar.gz: 58b45a79713a68cf75a9e0bb13b7cfe90bf5bf1c01e403375de2acdd4ad16881
|
5
5
|
SHA512:
|
6
|
-
metadata.gz:
|
7
|
-
data.tar.gz:
|
6
|
+
metadata.gz: 2c633c0f35fb6a9a90677e8f13d1c7194c8ff3ec3e267ca9249fd0343f09a319ac15148e8067be5b483fb5feab8d6cc9213208ffc24609b233b3b3335d2ba3ca
|
7
|
+
data.tar.gz: 815d48181cbdcc9e36ea268217e320f3542a8791b659b931ca51a7a035d478e3cf00fb84f23e5e7021bc015bafd6c28b04add620a3414953ba32e65d8b7a9da3
|
data/CHANGELOG.md
CHANGED
@@ -2,18 +2,77 @@
|
|
2
2
|
|
3
3
|
## Unreleased
|
4
4
|
|
5
|
-
## 2.
|
5
|
+
## 2.6.0 [☰](https://github.com/activeadmin/activeadmin/compare/v2.5.0..v2.6.0)
|
6
|
+
|
7
|
+
### Enhacements
|
8
|
+
|
9
|
+
* Display multiple flash messages in separate elements. [#5929] by [@mirelon]
|
10
|
+
* Make delete confirmation messages in French & Spanish gender-neutral. [#5946] by [@cprodhomme]
|
11
|
+
|
12
|
+
### Bug Fixes
|
13
|
+
|
14
|
+
* Export ModalDialog component to re-enable client side usage. [#5956] by [@sgara]
|
15
|
+
* Use default ActionView options instead of default Formtastic options for DateRangeInput [#5957] by [@mirelon]
|
16
|
+
* Fix i18n key in docs example to translate scopes. [#5943] by [@adler99]
|
17
|
+
|
18
|
+
## 2.5.0 [☰](https://github.com/activeadmin/activeadmin/compare/v2.4.0..v2.5.0)
|
6
19
|
|
7
20
|
### Enhancements
|
8
21
|
|
9
|
-
|
22
|
+
* Azerbaijani translation. [#5078] by [@orkhan]
|
23
|
+
|
24
|
+
### Bug Fixes
|
25
|
+
|
26
|
+
* Convert namespace to sym to prevent duplicate namespaces such as :foo and 'foo'. [#5931] by [@westonganger]
|
27
|
+
* Use filter label when condition has a predicate. [#5886] by [@ko-lem]
|
28
|
+
* Fix error when routing with array containing symbol. [#5870] by [@jwesorick]
|
29
|
+
* Fix error when there is a model named `Tag` and `meta_tags` have been configured. [#5895] by [@micred], [@FabioRos] and [@deivid-rodriguez]
|
30
|
+
* Allow specifying custom `input_html` for `DateRangeInput`. [#5867] by [@mirelon]
|
31
|
+
* Adjust `#main_content` right margin to take into account possible custom values of `$sidebar-width` and `$section-padding`. [#5887] by [@guigs]
|
32
|
+
* Improved polymorphic routes generation to avoid problems when multiple `belongs_to` are defined. [#5938] by [@leio10]
|
33
|
+
|
34
|
+
### Dependency Changes
|
35
|
+
|
36
|
+
* Support for Rails 5.0 and Rails 5.1 has been dropped. [#5877] by [@deivid-rodriguez]
|
37
|
+
|
38
|
+
## 2.4.0 [☰](https://github.com/activeadmin/activeadmin/compare/v2.3.1..v2.4.0)
|
39
|
+
|
40
|
+
### Enhancements
|
41
|
+
|
42
|
+
* Make optimization to not use expensive COUNT queries also work for decorated actions. [#5811] by [@irmela]
|
43
|
+
* Render a text filter instead of a select for large associations (opt-in). [#5548] by [@DanielHeath]
|
44
|
+
* Improve German translations. [#5874] by [@juril33t]
|
45
|
+
|
46
|
+
## 2.3.1 [☰](https://github.com/activeadmin/activeadmin/compare/v2.3.0..v2.3.1)
|
47
|
+
|
48
|
+
### Bug Fixes
|
49
|
+
|
50
|
+
* Revert ransack version pinning because 2.3 has an outstanding bug that affects quite a lot of users. See [this ransack issue](https://github.com/activerecord-hackery/ransack/issues/1039) for more information. [#5854] by [@deivid-rodriguez]
|
51
|
+
|
52
|
+
## 2.3.0 [☰](https://github.com/activeadmin/activeadmin/compare/v2.2.0..v2.3.0)
|
53
|
+
|
54
|
+
### Enhancements
|
55
|
+
|
56
|
+
* Bump minimum ransack requirement to make sure everyone gets a version that works ok with all supported versions of Rails. [#5831] by [@deivid-rodriguez]
|
57
|
+
|
58
|
+
### Bug Fixes
|
59
|
+
|
60
|
+
* Fix CSVBuilder not respecting `ActiveAdmin.application.csv_options = { humanize_name: false }` setting. [#5800] by [@HappyKadaver]
|
61
|
+
* Fix crash when displaying current filters after filtering by a nested resource. [#5816] by [@deivid-rodriguez]
|
62
|
+
* Fix pagination when `pagination_total` is false to not show a "Last" link, since it's incorrect because we don't have the total pages information. [#5822] by [@deivid-rodriguez]
|
63
|
+
* Fix optional nested resources causing incorrect routes to be generated, when renamed resources (through `:as` option) are involved. [#5826] by [@ndbroadbent], [@Kris-LIBIS] and [@deivid-rodriguez]
|
64
|
+
* Fix double modal issue in applications using turbolinks 5. [#5842] by [@sgara]
|
65
|
+
|
66
|
+
## 2.2.0 [☰](https://github.com/activeadmin/activeadmin/compare/v2.1.0..v2.2.0)
|
67
|
+
|
68
|
+
### Enhancements
|
10
69
|
|
11
70
|
* The `status_tag` component now supports different labels for `false` and `nil` boolean cases through the locale. Both default to display "No" for backwards compatibility. [#5794] by [@javierjulio]
|
12
71
|
* Add Macedonian locale. [#5710] by [@violeta-p]
|
13
72
|
|
14
73
|
### Bug Fixes
|
15
74
|
|
16
|
-
* Fix pundit policy retrieving for static pages when the pundit namespace is
|
75
|
+
* Fix pundit policy retrieving for static pages when the pundit namespace is `:active_admin`. [#5777] by [@kwent]
|
17
76
|
* Fix show page title not being properly escaped if title's content included HTML. [#5802] by [@deivid-rodriguez]
|
18
77
|
* Revert [21b6138f] from [#5740] since it actually caused the performance in development to regress. [#5801] by [@deivid-rodriguez]
|
19
78
|
|
@@ -25,7 +84,7 @@
|
|
25
84
|
* Crash when rendering comments from a custom controller block. [#5758] by [@deivid-rodriguez]
|
26
85
|
* Switch `sass` dependency to `sassc-rails`, since `sass` is no longer supported and since it restores support for directly importing `css` files. [#5504] by [@deivid-rodriguez]
|
27
86
|
|
28
|
-
###
|
87
|
+
### Dependency Changes
|
29
88
|
|
30
89
|
* Support for ruby 2.3 has been removed. [#5751] by [@deivid-rodriguez]
|
31
90
|
|
@@ -37,8 +96,6 @@ _No changes_.
|
|
37
96
|
|
38
97
|
### Enhancements
|
39
98
|
|
40
|
-
#### Minor
|
41
|
-
|
42
99
|
* Require arbre `~> 1.2, >= 1.2.1`. [#5726] by [@ionut998], and [#5738] by [@deivid-rodriguez]
|
43
100
|
|
44
101
|
## 2.0.0.rc1 [☰](https://github.com/activeadmin/activeadmin/compare/v1.4.3..v2.0.0.rc1)
|
@@ -54,9 +111,6 @@ _No changes_.
|
|
54
111
|
```
|
55
112
|
|
56
113
|
* Consider authorization when displaying comments in show page. [#5555] by [@amiuhle]
|
57
|
-
|
58
|
-
#### Minor
|
59
|
-
|
60
114
|
* Add better support for rendering lists. [#5370] by [@dkniffin]
|
61
115
|
* Undeprecate `config.register_stylesheet` and `config.register_javascript` for lack of better solution for including external assets. It might be reevaluated in the future. [#5662] by [@deivid-rodriguez]
|
62
116
|
|
@@ -73,7 +127,7 @@ _No changes_.
|
|
73
127
|
* Sidebar title internationalization. [#5417] by [@WaKeMaTTa]
|
74
128
|
* `filter` labels not allowing a `Proc` to be passed. [#5418] by [@WaKeMaTTa]
|
75
129
|
|
76
|
-
###
|
130
|
+
### Dependency Changes
|
77
131
|
|
78
132
|
* Rails 4.2 support has been dropped. [#5104] by [@javierjulio] and [@deivid-rodriguez]
|
79
133
|
* Dependency on coffee-rails has been removed. [#5081] by [@javierjulio]
|
@@ -109,8 +163,6 @@ _No changes_.
|
|
109
163
|
|
110
164
|
### Enhancements
|
111
165
|
|
112
|
-
#### Minor
|
113
|
-
|
114
166
|
* Add missing I18n for comments. [#5458], [#5461] by [@mauriciopasquier]
|
115
167
|
* Fix batch_actions.delete_confirmation translation in zh-CN.yml. [#5453] by [@ShallmentMo]
|
116
168
|
* Add some missing italian translations. [#5433] by [@stefsava]
|
@@ -148,8 +200,6 @@ _No changes_.
|
|
148
200
|
|
149
201
|
### Enhancements
|
150
202
|
|
151
|
-
#### Major
|
152
|
-
|
153
203
|
* Rails 5.2 support [#5343] by [@varyonic], [#5399], [#5401] by [@zorab47]
|
154
204
|
|
155
205
|
## 1.2.1 [☰](https://github.com/activeadmin/activeadmin/compare/v1.2.0..v1.2.1)
|
@@ -162,8 +212,6 @@ _No changes_.
|
|
162
212
|
|
163
213
|
### Enhancements
|
164
214
|
|
165
|
-
#### Minor
|
166
|
-
|
167
215
|
* Do not display pagination info when there are no comments. [#5119] by [@alex-bogomolov]
|
168
216
|
* Revert generated config files to pluralized. [#5120] by [@varyonic], [#5137] by [@deivid-rodriguez]
|
169
217
|
* Warn when action definition overwrites controller method. [#5167] by [@aarek]
|
@@ -194,7 +242,7 @@ _No changes_.
|
|
194
242
|
* Fixed [#5043]. Do not crash in sidebar rendering when a default scope is not specified. [#5044] by [@Fivell]
|
195
243
|
* Fixed [#3894]. Make tab's component work with non-ascii titles. [#5046] by [@Fivell]
|
196
244
|
|
197
|
-
###
|
245
|
+
### Dependency Changes
|
198
246
|
|
199
247
|
* Ruby 2.1 support has been dropped. [#5003] by [@deivid-rodriguez]
|
200
248
|
* Replaced `sass-rails` with `sass` dependency. [#5037] by [@javierjulio]
|
@@ -232,8 +280,6 @@ _No changes_.
|
|
232
280
|
|
233
281
|
### Enhancements
|
234
282
|
|
235
|
-
#### Minor
|
236
|
-
|
237
283
|
* Support proc as an input_html option value when declaring filters. [#5029] by [@Fivell]
|
238
284
|
* Base localization support, better associations handling for active filters sidebar. [#4951] by [@Fivell]
|
239
285
|
* Allow AA scopes to return paginated collections. [#4996] by [@Fivell]
|
@@ -257,16 +303,11 @@ _No changes_.
|
|
257
303
|
|
258
304
|
### Enhancements
|
259
305
|
|
260
|
-
#### Major
|
261
|
-
|
262
306
|
* Migration from Metasearch to Ransack. [#1979] by [@seanlinsley]
|
263
307
|
* Rails 4 support. [#2326] by many people :heart:
|
264
308
|
* Rails 4.2 support. [#3731] by [@gonzedge] and [@timoschilling]
|
265
309
|
* Rails 5 support. [#4254] by [@seanlinsley]
|
266
310
|
* Rails 5.1 support. [#4882] by [@varyonic]
|
267
|
-
|
268
|
-
#### Minor
|
269
|
-
|
270
311
|
* "Create another" checkbox for the new resource page. [#4477] by [@bolshakov]
|
271
312
|
* Page supports belongs_to. [#4759] by [@Fivell] and [@zorab47]
|
272
313
|
* Support for custom sorting strategies. [#4768] by [@Fivell]
|
@@ -397,6 +438,7 @@ Please check [0-6-stable] for previous changes.
|
|
397
438
|
[#5052]: https://github.com/activeadmin/activeadmin/pull/5052
|
398
439
|
[#5060]: https://github.com/activeadmin/activeadmin/pull/5060
|
399
440
|
[#5069]: https://github.com/activeadmin/activeadmin/pull/5069
|
441
|
+
[#5078]: https://github.com/activeadmin/activeadmin/pull/5078
|
400
442
|
[#5081]: https://github.com/activeadmin/activeadmin/pull/5081
|
401
443
|
[#5088]: https://github.com/activeadmin/activeadmin/pull/5088
|
402
444
|
[#5093]: https://github.com/activeadmin/activeadmin/pull/5093
|
@@ -474,21 +516,48 @@ Please check [0-6-stable] for previous changes.
|
|
474
516
|
[#5758]: https://github.com/activeadmin/activeadmin/pull/5758
|
475
517
|
[#5777]: https://github.com/activeadmin/activeadmin/pull/5777
|
476
518
|
[#5794]: https://github.com/activeadmin/activeadmin/pull/5794
|
519
|
+
[#5800]: https://github.com/activeadmin/activeadmin/pull/5800
|
477
520
|
[#5801]: https://github.com/activeadmin/activeadmin/pull/5801
|
478
521
|
[#5802]: https://github.com/activeadmin/activeadmin/pull/5802
|
522
|
+
[#5811]: https://github.com/activeadmin/activeadmin/pull/5811
|
523
|
+
[#5816]: https://github.com/activeadmin/activeadmin/pull/5816
|
524
|
+
[#5822]: https://github.com/activeadmin/activeadmin/pull/5822
|
525
|
+
[#5826]: https://github.com/activeadmin/activeadmin/pull/5826
|
526
|
+
[#5831]: https://github.com/activeadmin/activeadmin/pull/5831
|
527
|
+
[#5548]: https://github.com/activeadmin/activeadmin/pull/5548
|
528
|
+
[#5842]: https://github.com/activeadmin/activeadmin/pull/5842
|
529
|
+
[#5854]: https://github.com/activeadmin/activeadmin/pull/5854
|
530
|
+
[#5874]: https://github.com/activeadmin/activeadmin/pull/5874
|
531
|
+
[#5877]: https://github.com/activeadmin/activeadmin/pull/5877
|
532
|
+
[#5886]: https://github.com/activeadmin/activeadmin/pull/5886
|
533
|
+
[#5870]: https://github.com/activeadmin/activeadmin/pull/5870
|
534
|
+
[#5895]: https://github.com/activeadmin/activeadmin/pull/5895
|
535
|
+
[#5867]: https://github.com/activeadmin/activeadmin/pull/5867
|
536
|
+
[#5887]: https://github.com/activeadmin/activeadmin/pull/5887
|
537
|
+
[#5931]: https://github.com/activeadmin/activeadmin/pull/5931
|
538
|
+
[#5938]: https://github.com/activeadmin/activeadmin/pull/5938
|
539
|
+
[#5929]: https://github.com/activeadmin/activeadmin/pull/5929
|
540
|
+
[#5943]: https://github.com/activeadmin/activeadmin/pull/5943
|
541
|
+
[#5946]: https://github.com/activeadmin/activeadmin/pull/5946
|
542
|
+
[#5956]: https://github.com/activeadmin/activeadmin/pull/5956
|
543
|
+
[#5957]: https://github.com/activeadmin/activeadmin/pull/5957
|
479
544
|
|
480
545
|
[@5t111111]: https://github.com/5t111111
|
481
546
|
[@aarek]: https://github.com/aarek
|
547
|
+
[@adler99]: https://github.com/adler99
|
482
548
|
[@ajw725]: https://github.com/ajw725
|
483
549
|
[@alex-bogomolov]: https://github.com/alex-bogomolov
|
484
550
|
[@amiel]: https://github.com/amiel
|
485
551
|
[@amiuhle]: https://github.com/amiuhle
|
486
552
|
[@andreslemik]: https://github.com/andreslemik
|
553
|
+
[@bartoszkopinski]: https://github.com/bartoszkopinski
|
487
554
|
[@blocknotes]: https://github.com/blocknotes
|
488
555
|
[@bolshakov]: https://github.com/bolshakov
|
489
556
|
[@buren]: https://github.com/buren
|
490
557
|
[@chancancode]: https://github.com/chancancode
|
558
|
+
[@chrp]: https://github.com/chrp
|
491
559
|
[@chumakoff]: https://github.com/chumakoff
|
560
|
+
[@cprodhomme]: https://github.com/cprodhomme
|
492
561
|
[@craigmcnamara]: https://github.com/craigmcnamara
|
493
562
|
[@DanielHeath]: https://github.com/DanielHeath
|
494
563
|
[@deivid-rodriguez]: https://github.com/deivid-rodriguez
|
@@ -499,25 +568,39 @@ Please check [0-6-stable] for previous changes.
|
|
499
568
|
[@drn]: https://github.com/drn
|
500
569
|
[@eikes]: https://github.com/eikes
|
501
570
|
[@f1sherman]: https://github.com/f1sherman
|
571
|
+
[@FabioRos]: https://github.com/FabioRos
|
502
572
|
[@faucct]: https://github.com/faucct
|
503
573
|
[@Fivell]: https://github.com/Fivell
|
504
574
|
[@glebtv]: https://github.com/glebtv
|
505
575
|
[@gonzedge]: https://github.com/gonzedge
|
576
|
+
[@guigs]: https://github.com/guigs
|
577
|
+
[@HappyKadaver]: https://github.com/HappyKadaver
|
506
578
|
[@innparusu95]: https://github.com/innparusu95
|
507
579
|
[@ionut998]: https://github.com/ionut998
|
580
|
+
[@irmela]: https://github.com/irmela
|
508
581
|
[@jasl]: https://github.com/jasl
|
509
582
|
[@javierjulio]: https://github.com/javierjulio
|
510
583
|
[@jawa]: https://github.com/jawa
|
511
584
|
[@JiiHu]: https://github.com/JiiHu
|
512
585
|
[@johnnyshields]: https://github.com/johnnyshields
|
586
|
+
[@jscheid]: https://github.com/jscheid
|
587
|
+
[@juril33t]: https://github.com/juril33t
|
588
|
+
[@jwesorick]: https://github.com/jwesorick
|
513
589
|
[@kjeldahl]: https://github.com/kjeldahl
|
590
|
+
[@ko-lem]: https://github.com/ko-lem
|
514
591
|
[@kobeumut]: https://github.com/kobeumut
|
592
|
+
[@Kris-LIBIS]: https://github.com/Kris-LIBIS
|
515
593
|
[@kwent]: https://github.com/kwent
|
516
594
|
[@leio10]: https://github.com/leio10
|
517
595
|
[@markstory]: https://github.com/markstory
|
518
596
|
[@mauriciopasquier]: https://github.com/mauriciopasquier
|
519
597
|
[@mconiglio]: https://github.com/mconiglio
|
598
|
+
[@micred]: https://github.com/micred
|
599
|
+
[@mirelon]: https://github.com/mirelon
|
600
|
+
[@ndbroadbent]: https://github.com/ndbroadbent
|
520
601
|
[@Nguyenanh]: https://github.com/Nguyenanh
|
602
|
+
[@orkhan]: https://github.com/orkhan
|
603
|
+
[@panasyuk]: https://github.com/panasyuk
|
521
604
|
[@PChambino]: https://github.com/PChambino
|
522
605
|
[@potatosalad]: https://github.com/potatosalad
|
523
606
|
[@pranas]: https://github.com/pranas
|
@@ -525,6 +608,7 @@ Please check [0-6-stable] for previous changes.
|
|
525
608
|
[@RobinvanderVliet]: https://github.com/RobinvanderVliet
|
526
609
|
[@rogerkk]: https://github.com/rogerkk
|
527
610
|
[@seanlinsley]: https://github.com/seanlinsley
|
611
|
+
[@sgara]: https://github.com/sgara
|
528
612
|
[@ShallmentMo]: https://github.com/ShallmentMo
|
529
613
|
[@shekibobo]: https://github.com/shekibobo
|
530
614
|
[@shouya]: https://github.com/shouya
|
@@ -534,13 +618,10 @@ Please check [0-6-stable] for previous changes.
|
|
534
618
|
[@timoschilling]: https://github.com/timoschilling
|
535
619
|
[@TimPetricola]: https://github.com/TimPetricola
|
536
620
|
[@varyonic]: https://github.com/varyonic
|
537
|
-
[@
|
621
|
+
[@violeta-p]: https://github.com/violeta-p
|
538
622
|
[@WaKeMaTTa]: https://github.com/WaKeMaTTa
|
623
|
+
[@wasifhossain]: https://github.com/wasifhossain
|
624
|
+
[@westonganger]: https://github.com/westonganger
|
539
625
|
[@Wowu]: https://github.com/Wowu
|
540
626
|
[@wspurgin]: https://github.com/wspurgin
|
541
627
|
[@zorab47]: https://github.com/zorab47
|
542
|
-
[@chrp]: https://github.com/chrp
|
543
|
-
[@bartoszkopinski]: https://github.com/bartoszkopinski
|
544
|
-
[@panasyuk]: https://github.com/panasyuk
|
545
|
-
[@jscheid]: https://github.com/jscheid
|
546
|
-
[@violeta-p]: https://github.com/violeta-p
|
data/CONTRIBUTING.md
CHANGED
@@ -5,15 +5,17 @@ like you that make Active Admin such a great tool.
|
|
5
5
|
|
6
6
|
### Where do I go from here?
|
7
7
|
|
8
|
-
If you've noticed a bug or have a
|
9
|
-
|
10
|
-
|
11
|
-
|
8
|
+
If you've noticed a bug or have a feature request, [make one][new issue]! It's
|
9
|
+
generally best if you get confirmation of your bug or approval for your feature
|
10
|
+
request this way before starting to code.
|
11
|
+
|
12
|
+
If you have a general question about activeadmin, you can post it on [Stack
|
13
|
+
Overflow], the issue tracker is only for bugs and feature requests.
|
12
14
|
|
13
15
|
### Fork & create a branch
|
14
16
|
|
15
|
-
If this is something you think you can fix, then [fork Active Admin]
|
16
|
-
|
17
|
+
If this is something you think you can fix, then [fork Active Admin] and create
|
18
|
+
a branch with a descriptive name.
|
17
19
|
|
18
20
|
A good branch name would be (where issue #325 is the ticket you're working on):
|
19
21
|
|
@@ -26,8 +28,7 @@ git checkout -b 325-add-japanese-translations
|
|
26
28
|
Make sure you're using a recent ruby and have the `bundler` gem installed, at
|
27
29
|
least version `1.14.3`.
|
28
30
|
|
29
|
-
You'll also need chrome
|
30
|
-
scenarios.
|
31
|
+
You'll also need chrome installed in order to run cucumber scenarios.
|
31
32
|
|
32
33
|
Now install the development dependencies:
|
33
34
|
|
@@ -35,55 +36,45 @@ Now install the development dependencies:
|
|
35
36
|
bundle install
|
36
37
|
```
|
37
38
|
|
38
|
-
|
39
|
+
Then install javascript dependencies with [Yarn] (requires a current version of [Node.js]):
|
39
40
|
|
40
41
|
```sh
|
41
|
-
bin/
|
42
|
+
bin/yarn install
|
42
43
|
```
|
43
44
|
|
44
|
-
The
|
45
|
-
tests against.
|
46
|
-
|
47
|
-
If your tests are passing locally but they're failing on CircleCI, it's probably
|
48
|
-
because of some breaking change or problem with the latest version of some
|
49
|
-
dependency. You should be able to reproduce the issue locally by:
|
45
|
+
JS assets are located in `app/javascript/active_admin`. The config will take care of compiling a complete bundle with [Rollup] using the `build` script and exported to `app/assets/javascripts/active_admin/base.js` ready to be used by Sprockets.
|
50
46
|
|
51
|
-
|
52
|
-
* Running `bundle install`.
|
53
|
-
* Re-running the tests again like you did previously.
|
47
|
+
To update javascript bundle run (add `-w` flag for watch mode):
|
54
48
|
|
55
|
-
|
56
|
-
|
49
|
+
```sh
|
50
|
+
bin/yarn build
|
51
|
+
```
|
57
52
|
|
58
|
-
|
59
|
-
you use the correct Gemfile, for example:
|
53
|
+
Now you should be able to run the entire suite using:
|
60
54
|
|
61
55
|
```sh
|
62
|
-
|
56
|
+
bin/rake
|
63
57
|
```
|
64
58
|
|
65
|
-
|
59
|
+
The test run will generate a sample Rails application in `tmp/test_apps` to run the
|
60
|
+
tests against.
|
66
61
|
|
67
|
-
|
62
|
+
If you want to test against a Rails version different from the latest, make sure
|
63
|
+
you use the correct Gemfile, for example:
|
68
64
|
|
69
|
-
|
70
|
-
|
71
|
-
|
72
|
-
or an **executable test case** demonstrating the expected behavior that is not
|
73
|
-
occurring.
|
65
|
+
```sh
|
66
|
+
export BUNDLE_GEMFILE=gemfiles/rails_60/Gemfile
|
67
|
+
```
|
74
68
|
|
75
|
-
|
76
|
-
|
77
|
-
necessary changes to demonstrate the issue, and **paste the content into the
|
78
|
-
issue description**:
|
79
|
-
* [**ActiveAdmin** master issues][master template]
|
69
|
+
**Warning** SCSS assets are aimed to be used indifferently with Sprockets **and** webpacker.
|
70
|
+
As such, make sure not to use any sass-rails directives such as `asset-url` or `image-url`.
|
80
71
|
|
81
|
-
###
|
72
|
+
### Implement your fix or feature
|
82
73
|
|
83
74
|
At this point, you're ready to make your changes! Feel free to ask for help;
|
84
75
|
everyone is a beginner at first :smile_cat:
|
85
76
|
|
86
|
-
###
|
77
|
+
### View your changes in a Rails application
|
87
78
|
|
88
79
|
Active Admin is meant to be used by humans, not cucumbers. So make sure to take
|
89
80
|
a look at your changes in a browser.
|
@@ -95,7 +86,7 @@ bin/rake local server
|
|
95
86
|
```
|
96
87
|
|
97
88
|
This will automatically create a Rails app if none already exists, and store it
|
98
|
-
in the
|
89
|
+
in the `tmp/development_apps` folder.
|
99
90
|
|
100
91
|
You should now be able to open <http://localhost:3000/admin> in your browser.
|
101
92
|
You can log in using:
|
@@ -124,6 +115,22 @@ checks as the rest of the project. `bin/rake lint` will give you feedback in
|
|
124
115
|
this regard. You can check & fix style issues by running each linter
|
125
116
|
individually. Run `bin/rake -T lint` to see the available linters.
|
126
117
|
|
118
|
+
### Add a changelog entry
|
119
|
+
|
120
|
+
If your PR includes user-observable changes, you'll be asked to add a changelog
|
121
|
+
entry following the existing changelog format.
|
122
|
+
|
123
|
+
The changelog format is the following:
|
124
|
+
|
125
|
+
* One line per PR describing your fix or enhancement.
|
126
|
+
* Entries end with a dot, followed by "[#pr-number] by [@github-username]".
|
127
|
+
* Entries are added under the "Unreleased" section at the top of the file, under
|
128
|
+
the "Bug Fixes" or "Enhancements" subsection.
|
129
|
+
* References to github usernames and pull requests use [shortcut reference
|
130
|
+
links].
|
131
|
+
* Your github username reference definition is included in the correct
|
132
|
+
alphabetical position at the bottom of the file.
|
133
|
+
|
127
134
|
### Make a Pull Request
|
128
135
|
|
129
136
|
At this point, you should switch back to your master branch and make sure it's
|
@@ -204,14 +211,13 @@ Maintainers need to do the following to push out a release:
|
|
204
211
|
* `bin/rake release`
|
205
212
|
|
206
213
|
[chandler]: https://github.com/mattbrictson/chandler#2-configure-credentials
|
207
|
-
[chromedriver]: https://sites.google.com/a/chromium.org/chromedriver/getting-started
|
208
|
-
[mailing list]: http://groups.google.com/group/activeadmin
|
209
214
|
[Stack Overflow]: http://stackoverflow.com/questions/tagged/activeadmin
|
210
|
-
[search the issue tracker]: https://github.com/activeadmin/activeadmin/issues?q=something
|
211
215
|
[new issue]: https://github.com/activeadmin/activeadmin/issues/new
|
212
216
|
[fork Active Admin]: https://help.github.com/articles/fork-a-repo
|
213
|
-
[searching all issues]: https://github.com/activeadmin/activeadmin/issues?q=
|
214
|
-
[master template]: https://github.com/activeadmin/activeadmin/blob/master/tasks/bug_report_template.rb
|
215
217
|
[make a pull request]: https://help.github.com/articles/creating-a-pull-request
|
216
218
|
[git rebasing]: http://git-scm.com/book/en/Git-Branching-Rebasing
|
217
219
|
[interactive rebase]: https://help.github.com/articles/interactive-rebase
|
220
|
+
[shortcut reference links]: https://github.github.com/gfm/#shortcut-reference-link
|
221
|
+
[Rollup]: https://rollupjs.org/guide/en/#quick-start
|
222
|
+
[Yarn]: https://yarnpkg.com/en/docs/install
|
223
|
+
[Node.js]: https://nodejs.org/en/
|