activeadmin 1.4.2 → 2.3.0

data/CONTRIBUTING.md

@@ -26,8 +26,7 @@ git checkout -b 325-add-japanese-translations
 Make sure you're using a recent ruby and have the `bundler` gem installed, at
 least version `1.14.3`.
 
-You'll also need chrome and [chromedriver] installed in order to run cucumber
-scenarios.
+You'll also need chrome installed in order to run cucumber scenarios.
 
 Now install the development dependencies:
 
@@ -38,10 +37,10 @@ bundle install
 Now you should be able to run the entire suite using:
 
 ```sh
-bundle exec rake
+bin/rake
 ```
 
-The test run will generate a sample Rails application in `spec/rails` to run the
+The test run will generate a sample Rails application in `tmp/test_apps` to run the
 tests against.
 
 If your tests are passing locally but they're failing on CircleCI, it's probably
@@ -91,11 +90,11 @@ a look at your changes in a browser.
 To boot up a test Rails app:
 
 ```sh
-bundle exec rake local server
+bin/rake local server
 ```
 
 This will automatically create a Rails app if none already exists, and store it
-in the `.test-rails-apps` folder.
+in the `tmp/development_apps` folder.
 
 You should now be able to open <http://localhost:3000/admin> in your browser.
 You can log in using:
@@ -107,21 +106,22 @@ If you need to perform any other commands on the test application, just pass
 them to the `local` rake task. For example, to boot the rails console:
 
 ```sh
-bundle exec rake local console
+bin/rake local console
 ```
 
-Or to migrate the database:
+Or to migrate the database, if you create a new migration or just play around
+with the db:
 
 ```sh
-bundle exec rake local db:migrate
+bin/rake local db:migrate
 ```
 
 ### Get the style right
 
 Your patch should follow the same conventions & pass the same code quality
-checks as the rest of the project. `bundle exec rake lint` will give you
-feedback in this regard. You can check & fix style issues by running each linter
-individually. Run `bundle exec rake -T lint` to see the available linters.
+checks as the rest of the project. `bin/rake lint` will give you feedback in
+this regard. You can check & fix style issues by running each linter
+individually. Run `bin/rake -T lint` to see the available linters.
 
 ### Make a Pull Request
 
@@ -184,7 +184,9 @@ Maintainers need to do the following to push out a release:
 
 * Make sure all pull requests are in and that changelog is current
 * Update `version.rb` file and changelog with new version number
-* Create a stable branch for that release:
+* If it's not a patch level release, create a stable branch for that release,
+  otherwise switch to the stable branch corresponding to the patch release you
+  want to ship:
 
   ```sh
   git checkout master
@@ -195,16 +197,19 @@ Maintainers need to do the following to push out a release:
   git push activeadmin N-N-stable:N-N-stable
   ```
 
-* `bundle exec rake release`
+* Make sure you have [chandler] properly configured. Chandler is used to
+  automatically submit github release notes from the changelog right after
+  pushing the gem to rubygems.
+* `bin/rake release`
 
-[chromedriver]: https://sites.google.com/a/chromium.org/chromedriver/getting-started
+[chandler]: https://github.com/mattbrictson/chandler#2-configure-credentials
 [mailing list]: http://groups.google.com/group/activeadmin
 [Stack Overflow]: http://stackoverflow.com/questions/tagged/activeadmin
 [search the issue tracker]: https://github.com/activeadmin/activeadmin/issues?q=something
 [new issue]: https://github.com/activeadmin/activeadmin/issues/new
 [fork Active Admin]: https://help.github.com/articles/fork-a-repo
 [searching all issues]: https://github.com/activeadmin/activeadmin/issues?q=
-[master template]: https://github.com/activeadmin/activeadmin/blob/master/lib/bug_report_templates/active_admin_master.rb
+[master template]: https://github.com/activeadmin/activeadmin/blob/master/tasks/bug_report_template.rb
 [make a pull request]: https://help.github.com/articles/creating-a-pull-request
 [git rebasing]: http://git-scm.com/book/en/Git-Branching-Rebasing
 [interactive rebase]: https://help.github.com/articles/interactive-rebase

data/README.md

@@ -5,7 +5,7 @@ creating elegant backends for website administration.
 
 [![Version         ][rubygems_badge]][rubygems]
 [![Circle CI       ][circle_badge]][circle]
-[![Coverage        ][codecov_badge]][codecov]
+[![Coverage        ][coverage_badge]][coverage]
 [![Tidelift        ][tidelift_badge]][tidelift]
 [![Inch CI         ][inch_badge]][inch]
 
@@ -21,6 +21,11 @@ creating elegant backends for website administration.
 * Try the [live demo][demo].
 * The [wiki] includes links to tutorials, articles and sample projects.
 
+## For enterprise
+
+Active Admin for enterprise is available via the Tidelift subscription. [Learn
+More][tidelift_enterprise].
+
 ## Need help?
 
 Please use [StackOverflow][stackoverflow] for help requests and how-to questions.
@@ -32,16 +37,22 @@ Google Groups, IRC #activeadmin and Gitter are not actively monitored.
 
 ## Want to contribute?
 
-The [contributing guide][contributing]
-is a good place to start. If you have questions, feel free to ask.
+If you want to contribute through code or documentation, the [Contributing
+guide is the best place to start][contributing]. If you have questions, feel free
+to ask.
 
 ## Want to support us?
 
-Subscribe to [Tidelift][tidelift] to support Active Admin and get licensing assurances and timely security notifications.
+If you want to support us financially, you can [help fund the project
+through a Tidelift subscription][tidelift_support]. By buying a Tidelift subscription
+you make sure your whole dependency stack is properly maintained, while also
+getting a comprehensive view of outdated dependencies, new releases, security
+alerts, and licensing compatibility issues.
 
-You can support us with a weekly tip via [Liberapay][liberapay.com].
+You can also support us with a weekly tip via [Liberapay].
 
-[![Support via Liberapay][liberapay_button]][liberapay_donate]
+Finally, we have an [Open Collective][opencollective page] where you can become a backer or
+sponsor for the project, and also submit expenses to it.
 
 ## Dependencies
 
@@ -56,6 +67,23 @@ Tool                  | Description
 [Kaminari]            | Elegant pagination for any sort of collection
 [Ransack]             | Provides a simple search API to query your data
 
+## Security contact information
+
+Please use the Tidelift security contact to [report a security vulnerability][Tidelift security contact].
+Tidelift will coordinate the fix and disclosure.
+
+## Acknowledgements
+
+Thanks to [Greg Bell][Greg] for creating and sharing this project with the open source community.
+
+Thanks to [all the people that ever contributed through code][contributors] or
+other means such as bug reports, issue triaging, feature suggestions, code
+snippet tips, Slack discussions and so on.
+
+Thanks to [Tidelift][tidelift] and all our Tidelift subscribers.
+
+Thanks to [Open Collective][opencollective contributors] and all our Open Collective contributors.
+
 [Arbre]: https://github.com/activeadmin/arbre
 [Devise]: https://github.com/plataformatec/devise
 [Formtastic]: https://github.com/justinfrench/formtastic
@@ -67,18 +95,23 @@ Tool                  | Description
 [rubygems]: https://rubygems.org/gems/activeadmin
 [circle_badge]: https://circleci.com/gh/activeadmin/activeadmin/tree/master.svg
 [circle]: https://circleci.com/gh/activeadmin/activeadmin/tree/master
-[codecov_badge]: https://codecov.io/gh/activeadmin/activeadmin/branch/master/graph/badge.svg
-[codecov]: https://codecov.io/gh/activeadmin/activeadmin
+[coverage_badge]: https://api.codeclimate.com/v1/badges/779e407d22bacff19733/test_coverage
+[coverage]: https://codeclimate.com/github/activeadmin/activeadmin/test_coverage
 [inch_badge]: http://inch-ci.org/github/activeadmin/activeadmin.svg?branch=master
 [inch]: http://inch-ci.org/github/activeadmin/activeadmin
 [tidelift_badge]: https://tidelift.com/badges/github/activeadmin/activeadmin
 [tidelift]: https://tidelift.com/subscription/pkg/rubygems-activeadmin?utm_source=rubygems-activeadmin&utm_medium=readme
+[tidelift_enterprise]: https://tidelift.com/subscription/pkg/rubygems-activeadmin?utm_source=rubygems-activeadmin&utm_medium=referral&utm_campaign=github&utm_content=enterprise
+[tidelift_support]: https://tidelift.com/subscription/pkg/rubygems-activeadmin?utm_source=rubygems-activeadmin&utm_medium=referral&utm_campaign=github&utm_content=support
 
 [docs]: http://activeadmin.info/0-installation.html
 [demo]: http://demo.activeadmin.info/admin
 [wiki]: https://github.com/activeadmin/activeadmin/wiki
 [stackoverflow]: http://stackoverflow.com/questions/tagged/activeadmin
 [contributing]: https://github.com/activeadmin/activeadmin/blob/master/CONTRIBUTING.md
-[liberapay.com]: https://liberapay.com
-[liberapay_button]: https://liberapay.com/assets/widgets/donate.svg
-[liberapay_donate]: https://liberapay.com/Active-Admin/donate
+[Liberapay]: https://liberapay.com/Active-Admin/donate
+[Tidelift security contact]: https://tidelift.com/security
+[Greg]: https://github.com/gregbell
+[contributors]: https://github.com/activeadmin/activeadmin/graphs/contributors
+[opencollective page]: https://opencollective.com/activeadmin
+[opencollective contributors]: https://opencollective.com/activeadmin#contributors

data/app/assets/javascripts/active_admin/base.es6

@@ -0,0 +1,23 @@
+//= require jquery3
+//= require jquery-ui/widgets/datepicker
+//= require jquery-ui/widgets/dialog
+//= require jquery-ui/widgets/sortable
+//= require jquery-ui/widgets/tabs
+//= require jquery-ui/widget
+//= require jquery_ujs
+//= require_self
+//= require ./ext/jquery
+//= require ./ext/jquery-ui
+//= require ./lib/active_admin
+//= require ./lib/batch_actions
+//= require ./lib/dropdown-menu
+//= require ./lib/has_many
+//= require ./lib/modal_dialog
+//= require ./lib/per_page
+//= require ./lib/checkbox-toggler
+//= require ./lib/table-checkbox-toggler
+//= require ./initializers/datepicker
+//= require ./initializers/filters
+//= require ./initializers/tabs
+
+window.ActiveAdmin = {}

data/app/assets/javascripts/active_admin/ext/jquery-ui.es6

@@ -0,0 +1,7 @@
+// Short-circuits `_focusTabbable` to focus on the modal itself instead of
+// elements inside the modal. Without this, if a datepicker is the first input,
+// it'll immediately pop up when the modal opens.
+// See this ticket for more info: http://bugs.jqueryui.com/ticket/4731
+$.ui.dialog.prototype._focusTabbable = function() {
+  this.uiDialog.focus();
+};

data/app/assets/javascripts/active_admin/ext/jquery.es6

@@ -0,0 +1,9 @@
+// `serializeArray` generates => [{ name: 'foo', value: 'bar' }]
+// This function remaps it to => { foo: 'bar' }
+$.fn.serializeObject = function() {
+  return this.serializeArray()
+    .reduce((obj, item) => {
+      obj[item.name] = item.value
+      return obj
+    }, {});
+};

data/app/assets/javascripts/active_admin/initializers/datepicker.es6

@@ -0,0 +1,16 @@
+(($) => {
+
+  $(document)
+    .on('focus', 'input.datepicker:not(.hasDatepicker)', function() {
+      const input = $(this);
+
+      // Only create datepickers in compatible browsers
+      if (input[0].type === 'date') { return; }
+
+      const defaults = { dateFormat: 'yy-mm-dd' };
+      const options  = input.data('datepicker-options');
+
+      input.datepicker($.extend(defaults, options));
+    });
+
+})(jQuery);

data/app/assets/javascripts/active_admin/initializers/filters.es6

@@ -0,0 +1,45 @@
+(($, ActiveAdmin) => {
+
+  class Filters {
+
+    static _clearForm(event) {
+      const regex = /^(q\[|q%5B|q%5b|page|utf8|commit)/;
+      const params = ActiveAdmin
+        .queryStringToParams()
+        .filter(({name}) => !name.match(regex));
+
+      event.preventDefault();
+
+      if (ActiveAdmin.turbolinks) {
+        ActiveAdmin.turbolinksVisit(params);
+      } else {
+        window.location.search = ActiveAdmin.toQueryString(params);
+      }
+    }
+
+    static _disableEmptyInputFields(event) {
+      const params = $(this)
+        .find(':input')
+        .filter((i, input) => input.value === '')
+        .prop({ disabled: true })
+        .end()
+        .serializeArray();
+
+      if (ActiveAdmin.turbolinks) {
+        event.preventDefault();
+        ActiveAdmin.turbolinksVisit(params);
+      }
+    }
+
+    static _setSearchType() {
+      $(this).siblings('input').prop({name: `q[${this.value}]`});
+    }
+
+  }
+
+  $(document).
+    on('click', '.clear_filters_btn', Filters._clearForm).
+    on('submit', '.filter_form', Filters._disableEmptyInputFields).
+    on('change', '.filter_form_field.select_and_search select', Filters._setSearchType);
+
+})(jQuery, window.activeadmin);

data/app/assets/javascripts/active_admin/initializers/tabs.es6

@@ -0,0 +1,6 @@
+let onDOMReady = () =>
+  $('#active_admin_content .tabs').tabs()
+
+$(document).
+  ready(onDOMReady).
+  on('page:load turbolinks:load', onDOMReady)

data/app/assets/javascripts/active_admin/lib/active_admin.es6

@@ -0,0 +1,41 @@
+((window, $) => {
+
+  class ActiveAdmin {
+
+    static get turbolinks() {
+      return (typeof Turbolinks !== 'undefined' && Turbolinks.supported);
+    }
+
+    static turbolinksVisit(params) {
+      const path = [window.location.pathname, '?', this.toQueryString(params)].join('')
+      Turbolinks.visit(path);
+    }
+
+    static queryString() {
+      return (window.location.search || '').replace(/^\?/, '');
+    }
+
+    static queryStringToParams() {
+      const decode = (value) => decodeURIComponent((value || '').replace(/\+/g, '%20'));
+
+      return this.queryString()
+        .split("&")
+        .map(pair => pair.split("="))
+        .map(([key, value]) => {
+          return { name: decode(key), value: decode(value) }
+        });
+    }
+
+    static toQueryString(params) {
+      const encode = (value) => encodeURIComponent(value || '');
+
+      return params
+        .map(({name, value}) => [ encode(name), encode(value) ])
+        .map(pair => pair.join('='))
+        .join('&')
+    }
+  }
+
+  window.activeadmin = ActiveAdmin
+
+})(window, jQuery);

data/app/assets/javascripts/active_admin/lib/batch_actions.es6

@@ -0,0 +1,59 @@
+const onDOMReady = function() {
+  // Detach any previously attached handlers before re-attaching them.
+  // This avoids double-registered handlers when Turbolinks is enabled
+  $('.batch_actions_selector li a').off('click confirm:complete');
+
+  //
+  // Use ActiveAdmin.modal_dialog to prompt user if
+  // confirmation is required for current Batch Action
+  //
+  $('.batch_actions_selector li a').on('click', function(event){
+    let message;
+    event.stopPropagation(); // prevent Rails UJS click event
+    event.preventDefault();
+    if ((message = $(this).data('confirm'))) {
+      ActiveAdmin.modal_dialog(message, $(this).data('inputs'), inputs => {
+        $(this).trigger('confirm:complete', inputs);
+      });
+    } else {
+      $(this).trigger('confirm:complete');
+    }
+  });
+
+  $('.batch_actions_selector li a').on('confirm:complete', function(event, inputs){
+    let val;
+    if ((val = JSON.stringify(inputs))) {
+      $('#batch_action_inputs').removeAttr('disabled').val(val);
+    } else {
+      $('#batch_action_inputs').attr('disabled', 'disabled');
+    }
+
+    $('#batch_action').val($(this).data('action'));
+    $('#collection_selection').submit();
+  });
+
+  //
+  // Add checkbox selection to resource tables and lists if batch actions are enabled
+  //
+
+  if ($(".batch_actions_selector").length && $(":checkbox.toggle_all").length) {
+
+    if ($(".paginated_collection table.index_table").length) {
+      $(".paginated_collection table.index_table").tableCheckboxToggler();
+    } else {
+      $(".paginated_collection").checkboxToggler();
+    }
+
+    $(document).on('change', '.paginated_collection :checkbox', function() {
+      if ($(".paginated_collection :checkbox:checked").length && $(".dropdown_menu_list").children().length) {
+        $(".batch_actions_selector").each(function() { $(this).aaDropdownMenu("enable"); });
+      } else {
+        $(".batch_actions_selector").each(function() { $(this).aaDropdownMenu("disable"); });
+      }
+    });
+  }
+};
+
+$(document).
+  ready(onDOMReady).
+  on('page:load turbolinks:load', onDOMReady);

data/app/assets/javascripts/active_admin/lib/checkbox-toggler.es6

@@ -0,0 +1,49 @@
+ActiveAdmin.CheckboxToggler = class CheckboxToggler {
+  constructor(options, container){
+    this.options = options;
+    this.container = container;
+    this._init();
+    this._bind();
+  }
+
+  option(key, value) {
+  }
+
+  _init() {
+    if (!this.container) {
+      throw new Error('Container element not found');
+    } else {
+      this.$container = $(this.container);
+    }
+
+    if (!this.$container.find('.toggle_all').length) {
+      throw new Error('"toggle all" checkbox not found');
+    } else {
+      this.toggle_all_checkbox = this.$container.find('.toggle_all');
+    }
+
+    this.checkboxes = this.$container.find(':checkbox').not(this.toggle_all_checkbox);
+  }
+
+  _bind() {
+    this.checkboxes.change(event => this._didChangeCheckbox(event.target));
+    this.toggle_all_checkbox.change(() => this._didChangeToggleAllCheckbox());
+  }
+
+  _didChangeCheckbox(checkbox){
+    const numChecked = this.checkboxes.filter(':checked').length;
+
+    const allChecked = numChecked === this.checkboxes.length;
+    const someChecked = (numChecked > 0) && (numChecked < this.checkboxes.length);
+
+    this.toggle_all_checkbox.prop({ checked: allChecked, indeterminate: someChecked });
+  }
+
+  _didChangeToggleAllCheckbox() {
+    const setting = this.toggle_all_checkbox.prop('checked');
+    this.checkboxes.prop({ checked: setting });
+    return setting;
+  }
+};
+
+$.widget.bridge('checkboxToggler', ActiveAdmin.CheckboxToggler);