activeadmin 1.3.1 → 1.4.0

data/spec/unit/order_clause_spec.rb

@@ -1,81 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe ActiveAdmin::OrderClause do
-  subject { described_class.new(config, clause) }
-
-  let(:application) { ActiveAdmin::Application.new }
-  let(:namespace) { ActiveAdmin::Namespace.new application, :admin }
-  let(:config) { ActiveAdmin::Resource.new namespace, Post }
-
-  describe 'id_asc (existing column)' do
-    let(:clause) { 'id_asc' }
-
-    it { is_expected.to be_valid }
-
-    describe '#field' do
-      subject { super().field }
-      it { is_expected.to eq('id') }
-    end
-
-    describe '#order' do
-      subject { super().order }
-      it { is_expected.to eq('asc') }
-    end
-
-    specify '#to_sql prepends table name' do
-      expect(subject.to_sql).to eq '"posts"."id" asc'
-    end
-  end
-
-  describe 'virtual_column_asc' do
-    let(:clause) { 'virtual_column_asc' }
-
-    it { is_expected.to be_valid }
-
-    describe '#field' do
-      subject { super().field }
-      it { is_expected.to eq('virtual_column') }
-    end
-
-    describe '#order' do
-      subject { super().order }
-      it { is_expected.to eq('asc') }
-    end
-
-    specify '#to_sql' do
-      expect(subject.to_sql).to eq '"virtual_column" asc'
-    end
-  end
-
-  describe "hstore_col->'field'_desc" do
-    let(:clause) { "hstore_col->'field'_desc" }
-
-    it { is_expected.to be_valid }
-
-    describe '#field' do
-      subject { super().field }
-      it { is_expected.to eq("hstore_col->'field'") }
-    end
-
-    describe '#order' do
-      subject { super().order }
-      it { is_expected.to eq('desc') }
-    end
-
-    it 'converts to sql' do
-      expect(subject.to_sql).to eq %Q("hstore_col"->'field' desc)
-    end
-  end
-
-  describe '_asc' do
-    let(:clause) { '_asc' }
-
-    it { is_expected.not_to be_valid }
-  end
-
-  describe 'nil' do
-    let(:clause) { nil }
-
-    it { is_expected.not_to be_valid }
-  end
-end

data/spec/unit/page_controller_spec.rb

@@ -1,5 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe ActiveAdmin::PageController do
-  let(:controller) { ActiveAdmin::PageController.new }
-end

data/spec/unit/page_spec.rb

@@ -1,128 +0,0 @@
-require 'rails_helper'
-require File.expand_path('config_shared_examples', File.dirname(__FILE__))
-
-module ActiveAdmin
-  RSpec.describe Page do
-
-    it_should_behave_like "ActiveAdmin::Resource"
-    before { load_defaults! }
-
-    let(:application){ ActiveAdmin::Application.new }
-    let(:namespace){ Namespace.new(application, :admin) }
-    let(:page_name) { "Chocolate I lØve You!" }
-
-    def config(options = {})
-      @config ||= namespace.register_page("Chocolate I lØve You!", options)
-    end
-
-    describe "controller name" do
-      it "should return a namespaced controller name" do
-        expect(config.controller_name).to eq "Admin::ChocolateILoveYouController"
-      end
-      context "when non namespaced controller" do
-        let(:namespace){ ActiveAdmin::Namespace.new(application, :root) }
-        it "should return a non namespaced controller name" do
-          expect(config.controller_name).to eq "ChocolateILoveYouController"
-        end
-      end
-    end
-
-    describe "#resource_name" do
-      it "returns the name" do
-        expect(config.resource_name).to eq "Chocolate I lØve You!"
-      end
-
-      it "returns the singular, lowercase name" do
-        if RUBY_VERSION >= '2.4.0'
-          expect(config.resource_name.singular).to eq "chocolate i løve you!"
-        else
-          expect(config.resource_name.singular).to eq "chocolate i lØve you!"
-        end
-      end
-    end
-
-    describe "#plural_resource_label" do
-      it "returns the singular name" do
-        expect(config.plural_resource_label).to eq "Chocolate I lØve You!"
-      end
-    end
-
-    describe "#underscored_resource_name" do
-      it "returns the resource name underscored" do
-        expect(config.underscored_resource_name).to eq "chocolate_i_love_you"
-      end
-    end
-
-    describe "#camelized_resource_name" do
-      it "returns the resource name camel case" do
-        expect(config.camelized_resource_name).to eq "ChocolateILoveYou"
-      end
-    end
-
-    describe "#namespace_name" do
-      it "returns the name of the namespace" do
-        expect(config.namespace_name).to eq "admin"
-      end
-    end
-
-    it "should not belong_to anything" do
-      expect(config.belongs_to?).to eq false
-    end
-
-    it "should not have any action_items" do
-      expect(config.action_items?).to eq false
-    end
-
-    it "should not have any sidebar_sections" do
-      expect(config.sidebar_sections?).to eq false
-    end
-
-    context "with belongs to config" do
-      let!(:post_config) { namespace.register Post }
-      let!(:page_config) {
-        namespace.register_page page_name do
-          belongs_to :post
-        end
-      }
-
-      it "configures page with belongs_to" do
-        expect(page_config.belongs_to?).to be true
-      end
-
-      it "sets navigation menu to parent" do
-        expect(page_config.navigation_menu_name).to eq :post
-      end
-
-      it "builds a belongs_to relationship" do
-        belongs_to = page_config.belongs_to_config
-
-        expect(belongs_to.target).to eq(post_config)
-        expect(belongs_to.owner).to eq(page_config)
-        expect(belongs_to.optional?).to be_falsy
-      end
-
-      it "forwards belongs_to call to controller" do
-        options = { optional: true }
-        expect(page_config.controller).to receive(:belongs_to).with(:post, options)
-        page_config.belongs_to :post, options
-      end
-    end # context "with belongs to config" do
-
-    context "with optional belongs to config" do
-      let!(:post_config) { namespace.register Post }
-      let!(:page_config) {
-        namespace.register_page page_name do
-          belongs_to :post, optional: true
-        end
-      }
-
-      it "does not override default navigation menu" do
-        expect(page_config.navigation_menu_name).to eq(:default)
-      end
-    end # context "with optional belongs to config" do
-
-    it "has no belongs_to by default" do
-      expect(config.belongs_to?).to be_falsy
-    end
-  end
-end

data/spec/unit/pretty_format_spec.rb

@@ -1,82 +0,0 @@
-require 'rails_helper'
-require 'active_admin/view_helpers/display_helper'
-
-RSpec.describe "#pretty_format" do
-  include ActiveAdmin::ViewHelpers::DisplayHelper
-
-  def method_missing(*args, &block)
-    mock_action_view.send *args, &block
-  end
-
-  ['hello', 23, 5.67, 10**30, :foo, Arbre::Element.new.br].each do |obj|
-    it "should call `to_s` on #{obj.class}s" do
-      expect(pretty_format(obj)).to eq obj.to_s
-    end
-  end
-
-  shared_examples_for 'a time-ish object' do |t|
-    it "formats it with the default long format" do
-      expect(pretty_format(t)).to eq "February 28, 1985 20:15"
-    end
-
-    it "formats it with a customized long format" do
-      with_translation time: { formats: { long: "%B %d, %Y, %l:%M%P" } } do
-        expect(pretty_format(t)).to eq "February 28, 1985,  8:15pm"
-      end
-    end
-
-    context "with a custom localize format" do
-      around do |example|
-        previous_localize_format = ActiveAdmin.application.localize_format
-        ActiveAdmin.application.localize_format = :short
-        example.call
-        ActiveAdmin.application.localize_format = previous_localize_format
-      end
-
-      it "formats it with the default custom format" do
-        expect(pretty_format(t)).to eq "28 Feb 20:15"
-      end
-
-      it "formats it with i18n custom format" do
-        with_translation time: { formats: { short: "%-m %d %Y" } } do
-          expect(pretty_format(t)).to eq "2 28 1985"
-        end
-      end
-    end
-
-    context "with non-English locale" do
-      around do |example|
-        I18n.with_locale(:es) { example.call }
-      end
-
-      it "formats it with the default long format" do
-        expect(pretty_format(t)).to eq "28 de febrero de 1985 20:15"
-      end
-
-      it "formats it with a customized long format" do
-        with_translation time: { formats: { long: "El %d de %B de %Y a las %H horas y %M minutos" } } do
-          expect(pretty_format(t)).to eq "El 28 de febrero de 1985 a las 20 horas y 15 minutos"
-        end
-      end
-    end
-  end
-
-  it_behaves_like 'a time-ish object', Time.utc(1985, "feb", 28, 20, 15, 1)
-  it_behaves_like 'a time-ish object', DateTime.new(1985, 2, 28, 20, 15, 1)
-
-  context "given an ActiveRecord object" do
-    it "should delegate to auto_link" do
-      post = Post.new
-      expect(self).to receive(:auto_link).with(post) { "model name" }
-      expect(pretty_format(post)).to eq "model name"
-    end
-  end
-
-  context "given an arbitrary object" do
-    it "should delegate to `display_name`" do
-      something = Class.new.new
-      expect(self).to receive(:display_name).with(something) { "I'm not famous" }
-      expect(pretty_format(something)).to eq "I'm not famous"
-    end
-  end
-end

data/spec/unit/pundit_adapter_spec.rb

@@ -1,98 +0,0 @@
-require 'rails_helper'
-
-class DefaultPolicy < ApplicationPolicy
-  def respond_to_missing?(method, include_private = false)
-    method.to_s[0...3] == "foo" || super
-  end
-
-  def method_missing(method, *args, &block)
-    if method.to_s[0...3] == "foo"
-      method.to_s[4...7] == "yes"
-    else
-      super
-    end
-  end
-
-  class Scope
-
-    attr_reader :user, :scope
-
-    def initialize(user, scope)
-      @user = user
-      @scope = scope
-    end
-
-    def resolve
-      scope
-    end
-  end
-end
-
-RSpec.describe ActiveAdmin::PunditAdapter do
-
-  describe "full integration" do
-
-    let(:application) { ActiveAdmin::Application.new }
-    let(:namespace) { ActiveAdmin::Namespace.new(application, "Admin") }
-    let(:resource) { namespace.register(Post) }
-    let(:auth) { namespace.authorization_adapter.new(resource, double) }
-    let(:default_policy_klass) { DefaultPolicy }
-    let(:default_policy_klass_name) { "DefaultPolicy" }
-
-    before do
-      namespace.authorization_adapter = ActiveAdmin::PunditAdapter
-    end
-
-    it "should initialize the ability stored in the namespace configuration" do
-      expect(auth.authorized?(:read, Post)).to eq true
-      expect(auth.authorized?(:update, Post)).to eq false
-    end
-
-    it "should scope the collection" do
-      class RSpec::Mocks::DoublePolicy < ApplicationPolicy
-        class Scope < Struct.new(:user, :scope)
-          def resolve
-            scope
-          end
-        end
-      end
-
-      collection = double
-      auth.scope_collection(collection, :read)
-      expect(collection).to eq collection
-    end
-
-    it "works well with method_missing" do
-      allow(auth).to receive(:retrieve_policy).and_return(DefaultPolicy.new(double, double))
-      expect(auth.authorized?(:foo_no)).to eq false
-      expect(auth.authorized?(:foo_yes)).to eq true
-      expect(auth.authorized?(:bar_yes)).to eq false
-    end
-
-    context 'when Pundit is unable to find policy scope' do
-      let(:collection) { double("collection", to_sym: :collection) }
-      subject(:scope) { auth.scope_collection(collection, :read) }
-
-      before do
-        allow(ActiveAdmin.application).to receive(:pundit_default_policy).and_return default_policy_klass_name
-        allow(Pundit).to receive(:policy_scope!) { raise Pundit::NotDefinedError.new }
-      end
-
-      it("should return default policy's scope if defined") { is_expected.to eq(collection) }
-    end
-
-    context "when Pundit is unable to find policy" do
-      let(:record) { double }
-
-      subject(:policy) { auth.retrieve_policy(record) }
-
-      before do
-        allow(ActiveAdmin.application).to receive(:pundit_default_policy).and_return default_policy_klass_name
-        allow(Pundit).to receive(:policy!) { raise Pundit::NotDefinedError.new }
-      end
-
-      it("should return default policy instance") { is_expected.to be_instance_of(default_policy_klass) }
-    end
-  end
-
-end

data/spec/unit/resource/action_items_spec.rb

@@ -1,69 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe ActiveAdmin::Resource::ActionItems do
-
-  let(:resource) do
-    namespace = ActiveAdmin::Namespace.new(ActiveAdmin::Application.new, :admin)
-    namespace.register(Post)
-  end
-
-  describe "adding a new action item" do
-
-    before do
-      resource.clear_action_items!
-      resource.add_action_item :empty, class: :test do
-        # Empty ...
-      end
-    end
-
-    it "should add an action item" do
-      expect(resource.action_items.size).to eq 1
-    end
-
-    it "should store an instance of ActionItem" do
-      expect(resource.action_items.first).to be_an_instance_of(ActiveAdmin::ActionItem)
-    end
-
-    it "should store the block in the action item" do
-      expect(resource.action_items.first.block).to_not eq nil
-    end
-
-    it "should include class from options" do
-      expect(resource.action_items.first.html_class).to eq("action_item test")
-    end
-
-  end
-
-  describe "setting an action item to only display on specific controller actions" do
-
-    before do
-      resource.clear_action_items!
-      resource.add_action_item :new, only: :index do
-        raise StandardError
-      end
-      resource.add_action_item :edit, only: :show do
-        # Empty ...
-      end
-    end
-
-    it "should return only relevant action items" do
-      expect(resource.action_items_for(:index).size).to eq 1
-      expect {
-        resource.action_items_for(:index).first.call
-      }.to raise_exception(StandardError)
-    end
-
-  end
-
-  describe "default action items" do
-    it "should have 3 action items" do
-      expect(resource.action_items.size).to eq 3
-    end
-
-    it 'can be removed by name' do
-      resource.remove_action_item :new
-      expect(resource.action_items.size).to eq 2
-    end
-  end
-
-end