activeadmin 1.1.0 → 2.4.0

data/spec/unit/resource_controller_spec.rb

@@ -1,273 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe ActiveAdmin::ResourceController do
-
-  let(:controller) { Admin::PostsController.new }
-
-  describe "callbacks" do
-    before :all do
-      application = ::ActiveAdmin::Application.new
-      namespace = ActiveAdmin::Namespace.new(application, :admin)
-      namespace.register Post do
-        after_build :call_after_build
-        before_save :call_before_save
-        after_save :call_after_save
-        before_create :call_before_create
-        after_create :call_after_create
-        before_update :call_before_update
-        after_update :call_after_update
-        before_destroy :call_before_destroy
-        after_destroy :call_after_destroy
-
-        controller do
-          def call_after_build(obj); end
-          def call_before_save(obj); end
-          def call_after_save(obj); end
-          def call_before_create(obj); end
-          def call_after_create(obj); end
-          def call_before_update(obj); end
-          def call_after_update(obj); end
-          def call_before_destroy(obj); end
-          def call_after_destroy(obj); end
-        end
-      end
-    end
-
-    describe "performing create" do
-      let(:resource){ double("Resource", save: true) }
-
-      before do
-        expect(resource).to receive(:save)
-      end
-
-      it "should call the before create callback" do
-        expect(controller).to receive(:call_before_create).with(resource)
-        controller.send :create_resource, resource
-      end
-      it "should call the before save callback" do
-        expect(controller).to receive(:call_before_save).with(resource)
-        controller.send :create_resource, resource
-      end
-      it "should call the after save callback" do
-        expect(controller).to receive(:call_after_save).with(resource)
-        controller.send :create_resource, resource
-      end
-      it "should call the after create callback" do
-        expect(controller).to receive(:call_after_create).with(resource)
-        controller.send :create_resource, resource
-      end
-    end
-
-    describe "performing update" do
-      let(:resource){ double("Resource", :attributes= => true, save: true) }
-      let(:attributes){ [{}] }
-
-      before do
-        expect(resource).to receive(:attributes=).with(attributes[0])
-        expect(resource).to receive(:save)
-      end
-
-      it "should call the before update callback" do
-        expect(controller).to receive(:call_before_update).with(resource)
-        controller.send :update_resource, resource, attributes
-      end
-      it "should call the before save callback" do
-        expect(controller).to receive(:call_before_save).with(resource)
-        controller.send :update_resource, resource, attributes
-      end
-      it "should call the after save callback" do
-        expect(controller).to receive(:call_after_save).with(resource)
-        controller.send :update_resource, resource, attributes
-      end
-      it "should call the after create callback" do
-        expect(controller).to receive(:call_after_update).with(resource)
-        controller.send :update_resource, resource, attributes
-      end
-    end
-
-    describe "performing destroy" do
-      let(:resource){ double("Resource", destroy: true) }
-
-      before do
-        expect(resource).to receive(:destroy)
-      end
-
-      it "should call the before destroy callback" do
-        expect(controller).to receive(:call_before_destroy).with(resource)
-        controller.send :destroy_resource, resource
-      end
-
-      it "should call the after destroy callback" do
-        expect(controller).to receive(:call_after_destroy).with(resource)
-        controller.send :destroy_resource, resource
-      end
-    end
-  end
-end
-
-RSpec.describe "A specific resource controller", type: :controller do
-  before do
-    load_resources { ActiveAdmin.register Post }
-
-    @controller = Admin::PostsController.new
-  end
-
-  describe "authenticating the user" do
-    it "should do nothing when no authentication_method set" do
-      namespace = controller.class.active_admin_config.namespace
-      expect(namespace).to receive(:authentication_method).once.and_return(nil)
-
-      controller.send(:authenticate_active_admin_user)
-    end
-
-    it "should call the authentication_method when set" do
-      namespace = controller.class.active_admin_config.namespace
-
-      expect(namespace).to receive(:authentication_method).twice.
-        and_return(:authenticate_admin_user!)
-
-      expect(controller).to receive(:authenticate_admin_user!).and_return(true)
-
-      controller.send(:authenticate_active_admin_user)
-    end
-
-  end
-
-  describe "retrieving the current user" do
-    it "should return nil when no current_user_method set" do
-      namespace = controller.class.active_admin_config.namespace
-      expect(namespace).to receive(:current_user_method).once.and_return(nil)
-
-      expect(controller.send(:current_active_admin_user)).to eq nil
-    end
-
-    it "should call the current_user_method when set" do
-      user = double
-      namespace = controller.class.active_admin_config.namespace
-
-      expect(namespace).to receive(:current_user_method).twice.
-        and_return(:current_admin_user)
-
-      expect(controller).to receive(:current_admin_user).and_return(user)
-
-      expect(controller.send(:current_active_admin_user)).to eq user
-    end
-  end
-
-  describe 'retrieving the resource' do
-    let(:post) { Post.new title: "An incledibly unique Post Title" }
-    let(:http_params){ { id: '1' } }
-
-    before do
-      allow(Post).to receive(:find).and_return(post)
-      controller.class_eval { public :resource }
-      allow(controller).to receive(:params).and_return(ActionController::Parameters.new(http_params))
-    end
-
-    subject { controller.resource }
-
-    it "returns a Post" do
-      expect(subject).to be_kind_of(Post)
-    end
-
-    context 'with a decorator' do
-      let(:config) { controller.class.active_admin_config }
-      before { config.decorator_class_name = '::PostDecorator' }
-      it 'returns a PostDecorator' do
-        expect(subject).to be_kind_of(PostDecorator)
-      end
-
-      it 'returns a PostDecorator that wraps the post' do
-        expect(subject.title).to eq post.title
-      end
-    end
-  end
-
-  describe 'retrieving the resource collection' do
-    let(:config) { controller.class.active_admin_config }
-    before do
-      Post.create!(title: "An incledibly unique Post Title") if Post.count == 0
-      config.decorator_class_name = nil
-      request = double 'Request', format: 'application/json'
-      allow(controller).to receive(:params) { {} }
-      allow(controller).to receive(:request){ request }
-    end
-
-    subject { controller.send :collection }
-
-    it {
-      is_expected.to be_a ActiveRecord::Relation
-    }
-
-    it "returns a collection of posts" do
-      expect(subject.first).to be_kind_of(Post)
-    end
-
-    context 'with a decorator' do
-      before { config.decorator_class_name = 'PostDecorator' }
-
-      it 'returns a collection decorator using PostDecorator' do
-        expect(subject).to be_a Draper::CollectionDecorator
-        expect(subject.decorator_class).to eq PostDecorator
-      end
-
-      it 'returns a collection decorator that wraps the post' do
-        expect(subject.first.title).to eq Post.first.title
-      end
-    end
-  end
-
-  describe "performing batch_action" do
-    let(:batch_action) { ActiveAdmin::BatchAction.new :flag, "Flag", &batch_action_block }
-    let(:batch_action_block) { proc { } }
-    let(:params) { ActionController::Parameters.new(http_params) }
-
-    before do
-      allow(controller.class.active_admin_config).to receive(:batch_actions).and_return([batch_action])
-      allow(controller).to receive(:params) { params }
-    end
-
-    describe "when params batch_action matches existing BatchAction" do
-
-      let(:http_params) do
-        { batch_action: "flag", collection_selection: ["1"] }
-      end
-
-      it "should call the block with args" do
-        expect(controller).to receive(:instance_exec).with(["1"], {})
-        controller.batch_action
-      end
-
-      it "should call the block in controller scope" do
-        expect(controller).to receive(:render_in_context).with(controller, nil).and_return({})
-        controller.batch_action
-      end
-    end
-
-    describe "when params batch_action doesn't match a BatchAction" do
-      let(:http_params) do
-        { batch_action: "derp", collection_selection: ["1"] }
-      end
-
-      it "should raise an error" do
-        expect {
-          controller.batch_action
-        }.to raise_error("Couldn't find batch action \"derp\"")
-      end
-    end
-
-    describe "when params batch_action is blank" do
-      let(:http_params) do
-        { collection_selection: ["1"] }
-      end
-
-      it "should raise an error" do
-        expect {
-          controller.batch_action
-        }.to raise_error("Couldn't find batch action \"\"")
-      end
-    end
-
-  end
-
-end

data/spec/unit/resource_registration_spec.rb

@@ -1,61 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe "Registering an object to administer" do
-  let(:application) { ActiveAdmin::Application.new }
-
-  context "with no configuration" do
-    let(:namespace) { ActiveAdmin::Namespace.new(application, :admin) }
-
-    before do
-      application.namespaces[namespace.name] = namespace
-    end
-
-    it "should call register on the namespace" do
-      expect(namespace).to receive(:register)
-
-      application.register Category
-    end
-
-    it "should dispatch a Resource::RegisterEvent" do
-      expect(ActiveSupport::Notifications).to receive(:publish).with(ActiveAdmin::Resource::RegisterEvent, an_instance_of(ActiveAdmin::Resource))
-
-      application.register Category
-    end
-  end
-
-  context "with a different namespace" do
-    it "should call register on the namespace" do
-      namespace = ActiveAdmin::Namespace.new(application, :hello_world)
-      application.namespaces[namespace.name] = namespace
-      expect(namespace).to receive(:register)
-
-      application.register Category, namespace: :hello_world
-    end
-
-    it "should generate a Namespace::RegisterEvent and a Resource::RegisterEvent" do
-      expect(ActiveSupport::Notifications).to receive(:publish).with(ActiveAdmin::Namespace::RegisterEvent, an_instance_of(ActiveAdmin::Namespace))
-      expect(ActiveSupport::Notifications).to receive(:publish).with(ActiveAdmin::Resource::RegisterEvent, an_instance_of(ActiveAdmin::Resource))
-      application.register Category, namespace: :not_yet_created
-    end
-  end
-
-  context "with no namespace" do
-    it "should call register on the root namespace" do
-      namespace = ActiveAdmin::Namespace.new(application, :root)
-      application.namespaces[namespace.name] = namespace
-      expect(namespace).to receive(:register)
-
-      application.register Category, namespace: false
-    end
-  end
-
-  context "when being registered multiple times" do
-    it "should run the dsl in the same config object" do
-      config_1 = ActiveAdmin.register(Category) { filter :name }
-      config_2 = ActiveAdmin.register(Category) { filter :id }
-      expect(config_1).to eq config_2
-      expect(config_1.filters.size).to eq 2
-    end
-  end
-
-end

data/spec/unit/resource_spec.rb

@@ -1,320 +0,0 @@
-require 'rails_helper'
-require File.expand_path('config_shared_examples', File.dirname(__FILE__))
-
-module ActiveAdmin
-  RSpec.describe Resource do
-
-    it_should_behave_like "ActiveAdmin::Resource"
-    before { load_defaults! }
-
-    let(:application){ ActiveAdmin::Application.new }
-    let(:namespace){ Namespace.new(application, :admin) }
-
-    def config(options = {})
-      @config ||= Resource.new(namespace, Category, options)
-    end
-
-    it { respond_to :resource_class }
-
-    describe "#resource_table_name" do
-      it "should return the resource's table name" do
-        expect(config.resource_table_name).to eq '"categories"'
-      end
-      context "when the :as option is given" do
-        it "should return the resource's table name" do
-          expect(config(as: "My Category").resource_table_name).to eq '"categories"'
-        end
-      end
-    end
-
-    describe "#resource_column_names" do
-      it "should return the resource's column names" do
-        expect(config.resource_column_names).to eq Category.column_names
-      end
-    end
-
-    describe '#decorator_class' do
-      it 'returns nil by default' do
-        expect(config.decorator_class).to eq nil
-      end
-      context 'when a decorator is defined' do
-        let(:resource) { namespace.register(Post) { decorate_with PostDecorator } }
-        specify '#decorator_class_name should return PostDecorator' do
-          expect(resource.decorator_class_name).to eq '::PostDecorator'
-        end
-
-        it 'returns the decorator class' do
-          expect(resource.decorator_class).to eq PostDecorator
-        end
-      end
-    end
-
-    describe "controller name" do
-      it "should return a namespaced controller name" do
-        expect(config.controller_name).to eq "Admin::CategoriesController"
-      end
-      context "when non namespaced controller" do
-        let(:namespace){ ActiveAdmin::Namespace.new(application, :root) }
-        it "should return a non namespaced controller name" do
-          expect(config.controller_name).to eq "CategoriesController"
-        end
-      end
-    end
-
-    describe "#include_in_menu?" do
-      let(:namespace){ ActiveAdmin::Namespace.new(application, :admin) }
-      subject{ resource }
-
-      context "when regular resource" do
-        let(:resource){ namespace.register(Post) }
-        it { is_expected.to be_include_in_menu }
-      end
-
-      context "when menu set to false" do
-        let(:resource){ namespace.register(Post){ menu false } }
-        it { is_expected.not_to be_include_in_menu }
-      end
-    end
-
-    describe "#belongs_to" do
-
-      it "should build a belongs to configuration" do
-        expect(config.belongs_to_config).to eq nil
-        config.belongs_to :posts
-        expect(config.belongs_to_config).to_not eq nil
-      end
-
-      it "should not set the target menu to the belongs to target" do
-        expect(config.navigation_menu_name).to eq ActiveAdmin::DEFAULT_MENU
-        config.belongs_to :posts
-        expect(config.navigation_menu_name).to eq ActiveAdmin::DEFAULT_MENU
-      end
-
-    end
-
-    describe "scoping" do
-      context "when using a block" do
-        before do
-          @resource = application.register Category do
-            scope_to do
-              "scoped"
-            end
-          end
-        end
-        it "should call the proc for the begin of association chain" do
-          begin_of_association_chain = @resource.controller.new.send(:begin_of_association_chain)
-          expect(begin_of_association_chain).to eq "scoped"
-        end
-      end
-
-      context "when using a symbol" do
-        before do
-          @resource = application.register Category do
-            scope_to :current_user
-          end
-        end
-        it "should call the method for the begin of association chain" do
-          controller = @resource.controller.new
-          expect(controller).to receive(:current_user).and_return(true)
-          begin_of_association_chain = controller.send(:begin_of_association_chain)
-          expect(begin_of_association_chain).to eq true
-        end
-      end
-
-      describe "getting the method for the association chain" do
-        context "when a simple registration" do
-          before do
-            @resource = application.register Category do
-              scope_to :current_user
-            end
-          end
-          it "should return the pluralized collection name" do
-            expect(@resource.controller.new.send(:method_for_association_chain)).to eq :categories
-          end
-        end
-        context "when passing in the method as an option" do
-          before do
-            @resource = application.register Category do
-              scope_to :current_user, association_method: :blog_categories
-            end
-          end
-          it "should return the method from the option" do
-            expect(@resource.controller.new.send(:method_for_association_chain)).to eq :blog_categories
-          end
-        end
-      end
-    end
-
-    describe "sort order" do
-      class MockResource
-      end
-
-      context "when resource class responds to primary_key" do
-        it "should sort by primary key desc by default" do
-          expect(MockResource).to receive(:primary_key).and_return("pk")
-          config = Resource.new(namespace, MockResource)
-          expect(config.sort_order).to eq "pk_desc"
-        end
-      end
-
-      context "when resource class does not respond to primary_key" do
-        it "should default to id" do
-          config = Resource.new(namespace, MockResource)
-          expect(config.sort_order).to eq "id_desc"
-        end
-      end
-
-      it "should be set-able" do
-        config.sort_order = "task_id_desc"
-        expect(config.sort_order).to eq "task_id_desc"
-      end
-
-    end
-
-    describe "adding a scope" do
-
-      it "should add a scope" do
-        config.scope :published
-        expect(config.scopes.first).to be_a(ActiveAdmin::Scope)
-        expect(config.scopes.first.name).to eq "Published"
-        expect(config.scopes.first.show_count).to eq true
-      end
-
-      context 'when show_count disabled' do
-        it "should add a scope show_count = false" do
-          namespace.scopes_show_count = false
-          config.scope :published
-          expect(config.scopes.first.show_count).to eq false
-        end
-      end
-
-      it "should retrive a scope by its id" do
-        config.scope :published
-        expect(config.get_scope_by_id(:published).name).to eq "Published"
-      end
-
-      it "should retrieve the default scope by proc" do
-        config.scope :published, default: proc{ true }
-        config.scope :all
-        expect(config.default_scope.name).to eq "Published"
-      end
-
-    end
-
-    describe "#csv_builder" do
-      context "when no csv builder set" do
-        it "should return a default column builder with id and content columns" do
-          expect(config.csv_builder.exec_columns.size).to eq @config.content_columns.size + 1
-        end
-      end
-
-      context "when csv builder set" do
-        it "shuld return the csv_builder we set" do
-          csv_builder = CSVBuilder.new
-          config.csv_builder = csv_builder
-          expect(config.csv_builder).to eq csv_builder
-        end
-      end
-    end
-
-    describe "#breadcrumb" do
-      subject { config.breadcrumb }
-
-      context "when no breadcrumb is set" do
-        it { is_expected.to eq(namespace.breadcrumb) }
-      end
-
-      context "when breadcrumb is set" do
-        context "when set to true" do
-          before { config.breadcrumb = true }
-          it { is_expected.to eq true }
-        end
-
-        context "when set to false" do
-          before { config.breadcrumb = false }
-          it { is_expected.to eq false }
-        end
-      end
-    end
-
-    describe '#find_resource' do
-      let(:resource) { namespace.register(Post) }
-      let(:post) { double }
-      before do
-        allow(Post).to receive(:find_by).with("id" => "12345") { post }
-        allow(Post).to receive(:find_by).with("id" => "54321") { nil }
-      end
-
-      it 'can find the resource' do
-        expect(resource.find_resource('12345')).to eq post
-      end
-
-      context 'with a decorator' do
-        let(:resource) { namespace.register(Post) { decorate_with PostDecorator } }
-        it 'decorates the resource' do
-          expect(resource.find_resource('12345')).to eq PostDecorator.new(post)
-        end
-
-        it 'does not decorate a not found resource' do
-          expect(resource.find_resource('54321')).to equal nil
-        end
-      end
-
-      context 'when using a nonstandard primary key' do
-        let(:different_post) { double }
-        before do
-          allow(Post).to receive(:primary_key).and_return 'something_else'
-          allow(Post).to receive(:find_by).
-              with("something_else" => "55555") { different_post }
-        end
-
-        it 'can find the post by the custom primary key' do
-          expect(resource.find_resource('55555')).to eq different_post
-        end
-      end
-
-      context 'when using controller finder' do
-        let(:resource) do
-          namespace.register(Post) do
-            controller do
-              defaults finder: :find_by_title!
-            end
-          end
-        end
-
-        it 'can find the post by controller finder' do
-          allow(Post).to receive(:find_by_title!).with('title-name').and_return(post)
-
-          expect(resource.find_resource('title-name')).to eq post
-        end
-      end
-    end
-
-    describe "delegation" do
-      let(:controller) {
-        Class.new do
-          def method_missing(name, *args, &block)
-            "called #{name}"
-          end
-        end.new
-      }
-      let(:resource) { ActiveAdmin::ResourceDSL.new(double) }
-
-      before do
-        expect(resource).to receive(:controller).and_return(controller)
-      end
-
-      context "actions" do
-        [
-          :before_action, :skip_before_action,
-          :after_action, :skip_after_action,
-          :around_action, :skip_action
-        ].each do |method|
-          it "delegates #{method}" do
-            expect(resource.send(method)).to eq "called #{method}"
-          end
-        end
-      end
-    end
-  end
-end