activeadmin 1.1.0 → 2.14.0

data/spec/unit/abstract_view_factory_spec.rb

@@ -1,78 +0,0 @@
-require 'rails_helper'
-
-require 'active_admin/abstract_view_factory'
-
-RSpec.describe ActiveAdmin::AbstractViewFactory do
-
-  let(:view_factory){ ActiveAdmin::AbstractViewFactory.new }
-  let(:view){ Class.new }
-
-  describe "registering a new view key" do
-    before do
-      view_factory.register my_new_view_class: view
-    end
-
-    it "should respond to :my_new_view_class" do
-      expect(view_factory.respond_to? :my_new_view_class).to be true
-    end
-
-    it "should respond to :my_new_view_class=" do
-      expect(view_factory.respond_to? :my_new_view_class=).to be true
-    end
-
-    it "should generate a getter method" do
-      expect(view_factory.my_new_view_class).to eq view
-    end
-
-    it "should be settable view a setter method" do
-      view_factory.my_new_view_class = "Some Obj"
-      expect(view_factory.my_new_view_class).to eq "Some Obj"
-    end
-  end
-
-  describe "array syntax access" do
-    before do
-      view_factory.register my_new_view_class: view
-    end
-
-    it "should be available through array syntax" do
-      expect(view_factory[:my_new_view_class]).to eq view
-    end
-
-    it "should be settable through array syntax" do
-      view_factory[:my_new_view_class] = "My New View Class"
-      expect(view_factory[:my_new_view_class]).to eq "My New View Class"
-    end
-  end
-
-  describe "registering default views" do
-    before do
-      ActiveAdmin::AbstractViewFactory.register my_default_view_class: view
-    end
-    it "should generate a getter method" do
-      expect(view_factory.my_default_view_class).to eq view
-    end
-    it "should be settable view a setter method and not change default" do
-      view_factory.my_default_view_class = "Some Obj"
-      expect(view_factory.my_default_view_class).to eq "Some Obj"
-      expect(view_factory.default_for(:my_default_view_class)).to eq view
-    end
-  end
-
-  describe "subclassing the ViewFactory" do
-    let(:subclass) do
-      ActiveAdmin::AbstractViewFactory.register my_subclassed_view: "From Parent"
-      Class.new(ActiveAdmin::AbstractViewFactory) do
-        def my_subclassed_view
-          "From Subclass"
-        end
-      end
-    end
-
-    it "should use the subclass implementation" do
-      factory = subclass.new
-      expect(factory.my_subclassed_view).to eq "From Subclass"
-    end
-  end
-
-end

data/spec/unit/action_builder_spec.rb

@@ -1,125 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe 'defining actions from registration blocks', type: :controller do
-  let(:klass){ Admin::PostsController }
-
-  before do
-    load_resources { action! }
-
-    @controller = klass.new
-  end
-
-  describe 'creates a member action' do
-    after(:each) do
-      klass.clear_member_actions!
-    end
-
-    context 'with a block' do
-      let(:action!) do
-        ActiveAdmin.register Post do
-          member_action :comment do
-            # Do nothing
-          end
-        end
-      end
-
-      it 'should create a new public instance method' do
-        expect(klass.public_instance_methods.collect(&:to_s)).to include('comment')
-      end
-
-      it 'should add itself to the member actions config' do
-        expect(klass.active_admin_config.member_actions.size).to eq 1
-      end
-
-      it 'should create a new named route' do
-        expect(Rails.application.routes.url_helpers.methods.collect(&:to_s)).to include('comment_admin_post_path')
-      end
-    end
-
-    context 'without a block' do
-      let(:action!) do
-        ActiveAdmin.register Post do
-          member_action :comment
-        end
-      end
-
-      it 'should still generate a new empty action' do
-        expect(klass.public_instance_methods.collect(&:to_s)).to include('comment')
-      end
-    end
-
-    context 'with :title' do
-      let(:action!) do
-        ActiveAdmin.register Post do
-          member_action :comment, title: 'My Awesome Comment' do
-            render json: {a: 2}
-          end
-        end
-      end
-
-      it 'sets the page title' do
-        params = {id: 1}
-        params = {params: params} if ActiveAdmin::Dependency.rails5?
-        get :comment, params
-
-        expect(controller.instance_variable_get(:@page_title)).to eq 'My Awesome Comment'
-      end
-    end
-  end
-
-  describe 'creates a collection action' do
-    after(:each) do
-      klass.clear_collection_actions!
-    end
-
-    context 'with a block' do
-      let(:action!) do
-        ActiveAdmin.register Post do
-          collection_action :comments do
-            # Do nothing
-          end
-        end
-      end
-
-      it 'should create a public instance method' do
-        expect(klass.public_instance_methods.collect(&:to_s)).to include('comments')
-      end
-
-      it 'should add itself to the member actions config' do
-        expect(klass.active_admin_config.collection_actions.size).to eq 1
-      end
-
-      it 'should create a named route' do
-        expect(Rails.application.routes.url_helpers.methods.collect(&:to_s)).to include('comments_admin_posts_path')
-      end
-    end
-
-    context 'without a block' do
-      let(:action!) do
-        ActiveAdmin.register Post do
-          collection_action :comments
-        end
-      end
-
-      it 'should still generate a new empty action' do
-        expect(klass.public_instance_methods.collect(&:to_s)).to include('comments')
-      end
-    end
-
-    context 'with :title' do
-      let(:action!) do
-        ActiveAdmin.register Post do
-          collection_action :comments, title: 'My Awesome Comments' do
-            render json: {a: 2}
-          end
-        end
-      end
-
-      it 'sets the page title' do
-        get :comments
-
-        expect(controller.instance_variable_get(:@page_title)).to eq 'My Awesome Comments'
-      end
-    end
-  end
-end

data/spec/unit/active_admin_spec.rb

@@ -1,11 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe ActiveAdmin do
-  %w(register register_page unload! load! routes).each do |method|
-    it "delegates ##{method} to application" do
-      expect(ActiveAdmin.application).to receive(method)
-
-      ActiveAdmin.send(method)
-    end
-  end
-end

data/spec/unit/application_spec.rb

@@ -1,184 +0,0 @@
-require 'rails_helper'
-require 'fileutils'
-
-RSpec.describe ActiveAdmin::Application do
-
-  let(:application) { ActiveAdmin::Application.new }
-
-  around do |example|
-    old_load_paths = application.load_paths
-    # TODO: Figure out why load paths need to be overriden
-    application.load_paths = [File.expand_path('app/admin', Rails.root)]
-
-    example.call
-
-    application.load_paths = old_load_paths
-  end
-
-  it "should have a default load path of ['app/admin']" do
-    expect(application.load_paths).to eq [File.expand_path('app/admin', Rails.root)]
-  end
-
-  it "should remove app/admin from the autoload paths (Active Admin deals with loading)" do
-    expect(ActiveSupport::Dependencies.autoload_paths).to_not include(File.join(Rails.root, "app/admin"))
-  end
-
-  it "should store the site's title" do
-    expect(application.site_title).to eq ""
-  end
-
-  it "should set the site title" do
-    application.site_title = "New Title"
-    expect(application.site_title).to eq "New Title"
-  end
-
-  it "should store the site's title link" do
-    expect(application.site_title_link).to eq ""
-  end
-
-  it "should set the site's title link" do
-    application.site_title_link = "http://www.mygreatsite.com"
-    expect(application.site_title_link).to eq "http://www.mygreatsite.com"
-  end
-
-  it "should store the site's title image" do
-    expect(application.site_title_image).to eq ""
-  end
-
-  it "should set the site's title image" do
-    application.site_title_image = "http://railscasts.com/assets/episodes/stills/284-active-admin.png?1316476106"
-    expect(application.site_title_image).to eq "http://railscasts.com/assets/episodes/stills/284-active-admin.png?1316476106"
-  end
-
-  it "should store the site's favicon" do
-    expect(application.favicon).to eq false
-  end
-
-  it "should return default localize format" do
-    expect(application.localize_format).to eq :long
-  end
-
-  it "should set localize format" do
-    application.localize_format = :default
-    expect(application.localize_format).to eq :default
-  end
-
-  it "should set the site's favicon" do
-    application.favicon = "/a/favicon.ico"
-    expect(application.favicon).to eq "/a/favicon.ico"
-  end
-
-  it "should store meta tags" do
-    expect(application.meta_tags).to eq({})
-  end
-
-  it "should set meta tags" do
-    application.meta_tags = { author: "My Company" }
-    expect(application.meta_tags).to eq(author: "My Company")
-  end
-
-  it "should contains robots meta tags by default" do
-    result = application.meta_tags_for_logged_out_pages
-    expect(result).to eq(robots: "noindex, nofollow")
-  end
-
-  it "should set meta tags for logged out pages" do
-    value = { author: "My Company" }
-    application.meta_tags_for_logged_out_pages = value
-    expect(application.meta_tags_for_logged_out_pages).to eq value
-  end
-
-  it "should have a view factory" do
-    expect(application.view_factory).to be_an_instance_of(ActiveAdmin::ViewFactory)
-  end
-
-  it "should allow comments by default" do
-    expect(application.comments).to eq true
-  end
-
-  it "should have default order clause class" do
-    expect(application.order_clause).to eq ActiveAdmin::OrderClause
-  end
-
-  it "should have default show_count for scopes" do
-    expect(application.scopes_show_count).to eq true
-  end
-
-  describe "authentication settings" do
-
-    it "should have no default current_user_method" do
-      expect(application.current_user_method).to eq false
-    end
-
-    it "should have no default authentication method" do
-      expect(application.authentication_method).to eq false
-    end
-
-    it "should have a logout link path (Devise's default)" do
-      expect(application.logout_link_path).to eq :destroy_admin_user_session_path
-    end
-
-    it "should have a logout link method (Devise's default)" do
-      expect(application.logout_link_method).to eq :get
-    end
-  end
-
-  describe "files in load path" do
-    it "should load files in the first level directory" do
-      expect(application.files).to include(File.expand_path("app/admin/dashboard.rb", Rails.root))
-    end
-
-    it "should load files from subdirectories" do
-      test_dir = File.expand_path("app/admin/public", Rails.root)
-      test_file = File.expand_path("app/admin/public/posts.rb", Rails.root)
-
-      begin
-        FileUtils.mkdir_p(test_dir)
-        FileUtils.touch(test_file)
-        expect(application.files).to include(test_file)
-      ensure
-        FileUtils.remove_entry_secure(test_dir, force: true)
-      end
-    end
-  end
-
-  describe "#namespace" do
-
-    it "should yield a new namespace" do
-      application.namespace :new_namespace do |ns|
-        expect(ns.name).to eq :new_namespace
-      end
-    end
-
-    it "should return an instantiated namespace" do
-      admin = application.namespace :admin
-      expect(admin).to eq application.namespaces[:admin]
-    end
-
-    it "should yield an existing namespace" do
-      expect {
-        application.namespace :admin do |ns|
-          expect(ns).to eq application.namespaces[:admin]
-          raise "found"
-        end
-      }.to raise_error("found")
-    end
-
-    it "should not pollute the global app" do
-      expect(application.namespaces).to be_empty
-      application.namespace(:brand_new_ns)
-      expect(application.namespaces.names).to eq [:brand_new_ns]
-      expect(ActiveAdmin.application.namespaces.names).to eq [:admin]
-    end
-  end
-
-  describe "#register_page" do
-    it "finds or create the namespace and register the page to it" do
-      namespace = double
-      expect(application).to receive(:namespace).with("public").and_return namespace
-      expect(namespace).to receive(:register_page).with("My Page", {namespace: "public"})
-      application.register_page("My Page", namespace: "public")
-    end
-  end
-
-end

data/spec/unit/asset_registration_spec.rb

@@ -1,81 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe ActiveAdmin::AssetRegistration do
-  include ActiveAdmin::AssetRegistration
-
-  before do
-    clear_stylesheets!
-    clear_javascripts!
-  end
-
-  it "is deprecated" do
-    expect(ActiveAdmin::Deprecation)
-      .to receive(:warn)
-      .with(<<-MSG.strip_heredoc
-        The `register_stylesheet` config is deprecated and will be removed
-        in v2. Import your "sample_styles.css" stylesheet in the active_admin.scss.
-      MSG
-      )
-
-    register_stylesheet "sample_styles.css"
-
-    expect(ActiveAdmin::Deprecation)
-      .to receive(:warn)
-      .with(<<-MSG.strip_heredoc
-        The `register_javascript` config is deprecated and will be removed
-        in v2. Import your "sample_scripts.js" javascript in the active_admin.js.
-      MSG
-      )
-
-    register_javascript "sample_scripts.js"
-  end
-
-  it "should register a stylesheet file" do
-    expect(ActiveAdmin::Deprecation).to receive(:warn).once
-    register_stylesheet "active_admin.css"
-    expect(stylesheets.length).to eq 1
-    expect(stylesheets.keys.first).to eq "active_admin.css"
-  end
-
-  it "should clear all existing stylesheets" do
-    expect(ActiveAdmin::Deprecation).to receive(:warn).once
-    register_stylesheet "active_admin.css"
-    expect(stylesheets.length).to eq 1
-    clear_stylesheets!
-    expect(stylesheets).to be_empty
-  end
-
-  it "should allow media option when registering stylesheet" do
-    expect(ActiveAdmin::Deprecation).to receive(:warn).once
-    register_stylesheet "active_admin.css", media: :print
-    expect(stylesheets.values.first[:media]).to eq :print
-  end
-
-  it "shouldn't register a stylesheet twice" do
-    expect(ActiveAdmin::Deprecation).to receive(:warn).twice
-    register_stylesheet "active_admin.css"
-    register_stylesheet "active_admin.css"
-    expect(stylesheets.length).to eq 1
-  end
-
-  it "should register a javascript file" do
-    expect(ActiveAdmin::Deprecation).to receive(:warn).once
-    register_javascript "active_admin.js"
-    expect(javascripts).to eq ["active_admin.js"].to_set
-  end
-
-  it "should clear all existing javascripts" do
-    expect(ActiveAdmin::Deprecation).to receive(:warn).once
-    register_javascript "active_admin.js"
-    expect(javascripts).to eq ["active_admin.js"].to_set
-    clear_javascripts!
-    expect(javascripts).to be_empty
-  end
-
-  it "shouldn't register a javascript twice" do
-    expect(ActiveAdmin::Deprecation).to receive(:warn).twice
-    register_javascript "active_admin.js"
-    register_javascript "active_admin.js"
-    expect(javascripts.length).to eq 1
-  end
-end

data/spec/unit/authorization/authorization_adapter_spec.rb

@@ -1,61 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe ActiveAdmin::AuthorizationAdapter do
-
-  let(:adapter) { ActiveAdmin::AuthorizationAdapter.new(double, double) }
-
-  describe "#authorized?" do
-
-    it "should always return true" do
-      expect(adapter.authorized?(:read, "Resource")).to eq true
-    end
-
-  end
-
-  describe "#scope_collection" do
-
-    it "should return the collection unscoped" do
-      collection = double
-      expect(adapter.scope_collection(collection, ActiveAdmin::Auth::READ)).to eq collection
-    end
-
-  end
-
-  describe "using #normalized in a subclass" do
-
-    let(:auth_class) do
-      Class.new(ActiveAdmin::AuthorizationAdapter) do
-
-        def authorized?(action, subject = nil)
-          case subject
-          when normalized(String)
-            true
-          else
-            false
-          end
-        end
-
-      end
-    end
-
-    let(:adapter) { auth_class.new(double, double) }
-
-    it "should match against a class" do
-      expect(adapter.authorized?(:read, String)).to eq true
-    end
-
-    it 'should match against an instance' do
-      expect(adapter.authorized?(:read, "String")).to eq true
-    end
-
-    it 'should not match a different class' do
-      expect(adapter.authorized?(:read, Hash)).to eq false
-    end
-
-    it 'should not match a different instance' do
-      expect(adapter.authorized?(:read, {})).to eq false
-    end
-
-  end
-
-end

data/spec/unit/authorization/controller_authorization_spec.rb

@@ -1,43 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe "Controller Authorization", type: :controller do
-
-  let(:authorization){ controller.send(:active_admin_authorization) }
-
-  before do
-    load_resources { ActiveAdmin.register Post }
-    @controller = Admin::PostsController.new
-    allow(authorization).to receive(:authorized?)
-  end
-
-  it "should authorize the index action" do
-    expect(authorization).to receive(:authorized?).with(auth::READ, Post).and_return true
-    get :index
-    expect(response).to be_success
-  end
-
-  it "should authorize the new action" do
-    expect(authorization).to receive(:authorized?).with(auth::CREATE, an_instance_of(Post)).and_return true
-    get :new
-    expect(response).to be_success
-  end
-
-  it "should authorize the create action with the new resource" do
-    expect(authorization).to receive(:authorized?).with(auth::CREATE, an_instance_of(Post)).and_return true
-    post :create
-    expect(response).to redirect_to action: 'show', id: Post.last.id
-  end
-
-  it "should redirect when the user isn't authorized" do
-    expect(authorization).to receive(:authorized?).with(auth::READ, Post).and_return false
-    get :index
-    expect(response.body).to eq '<html><body>You are being <a href="http://test.host/admin">redirected</a>.</body></html>'
-    expect(response).to redirect_to '/admin'
-  end
-
-  private
-
-  def auth
-    ActiveAdmin::Authorization
-  end
-end

data/spec/unit/authorization/index_overriding_spec.rb

@@ -1,23 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe 'Index overriding', type: :controller do
-  before do
-    load_resources { ActiveAdmin.register Post }
-    @controller = Admin::PostsController.new
-
-    @controller.instance_eval do
-      def index
-        super do
-          render ActiveAdmin::Dependency.rails.render_key => 'Rendered from passed block'
-          return
-        end
-      end
-    end
-  end
-
-  it 'should call block passed to overridden index' do
-    get :index
-    expect(response.body).to eq 'Rendered from passed block'
-  end
-
-end

data/spec/unit/auto_link_spec.rb

@@ -1,93 +0,0 @@
-require 'rails_helper'
-require 'active_admin/view_helpers/active_admin_application_helper'
-require 'active_admin/view_helpers/auto_link_helper'
-require 'active_admin/view_helpers/display_helper'
-require 'active_admin/view_helpers/method_or_proc_helper'
-
-RSpec.describe "auto linking resources", type: :view do
-  include ActiveAdmin::ViewHelpers::ActiveAdminApplicationHelper
-  include ActiveAdmin::ViewHelpers::AutoLinkHelper
-  include ActiveAdmin::ViewHelpers::DisplayHelper
-  include MethodOrProcHelper
-
-  let(:active_admin_namespace){ ActiveAdmin.application.namespace(:admin) }
-  let(:post){ Post.create! title: "Hello World" }
-
-  before do
-    allow(self).to receive(:authorized?).and_return(true)
-  end
-
-  context "when the resource is not registered" do
-    before do
-      load_resources {}
-    end
-
-    it "should return the display name of the object" do
-      expect(auto_link(post)).to eq "Hello World"
-    end
-  end
-
-  context "when the resource is registered" do
-    before do
-      load_resources do
-        active_admin_namespace.register Post
-      end
-    end
-
-    it "should return a link with the display name of the object" do
-      expect(auto_link(post)).to \
-          match(%r{<a href="/admin/posts/\d+">Hello World</a>})
-    end
-
-    it "should keep locale in the url if present" do
-      expect(self).to receive(:url_options).and_return(locale: 'en')
-
-      expect(auto_link(post)).to \
-          match(%r{<a href="/admin/posts/\d+\?locale=en">Hello World</a>})
-    end
-
-    context "but the user doesn't have access" do
-      before do
-        allow(self).to receive(:authorized?).and_return(false)
-      end
-
-      it "should return the display name of the object" do
-        expect(auto_link(post)).to eq "Hello World"
-      end
-    end
-  end
-
-  context "when the resource is registered with the show action disabled" do
-    before do
-      load_resources do
-        active_admin_namespace.register(Post) { actions :all, except: :show }
-      end
-    end
-
-    it "should fallback to edit" do
-      expect(auto_link(post)).to \
-        match(%r{<a href="/admin/posts/\d+/edit">Hello World</a>})
-    end
-
-    it "should keep locale in the url if present" do
-      expect(self).to receive(:url_options).and_return(locale: 'en')
-
-      expect(auto_link(post)).to \
-        match(%r{<a href="/admin/posts/\d+/edit\?locale=en">Hello World</a>})
-    end
-  end
-
-  context "when the resource is registered with the show & edit actions disabled" do
-    before do
-      load_resources do
-        active_admin_namespace.register(Post) do
-          actions :all, except: [:show, :edit]
-        end
-      end
-
-      it "should return the display name of the object" do
-        expect(auto_link(post)).to eq "Hello World"
-      end
-    end
-  end
-end