activeadmin 1.0.0.pre4 → 1.0.0.pre5

data/spec/unit/component_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 
 class MockComponentClass < ActiveAdmin::Component; end
 
-describe ActiveAdmin::Component do
+RSpec.describe ActiveAdmin::Component do
 
   let(:component_class){ MockComponentClass }
   let(:component){ component_class.new }

data/spec/unit/config_shared_examples.rb

@@ -1,4 +1,4 @@
-shared_examples_for "ActiveAdmin::Resource" do
+RSpec.shared_examples_for "ActiveAdmin::Resource" do
   describe "namespace" do
     it "should return the namespace" do
       expect(config.namespace).to eq(namespace)

data/spec/unit/controller_filters_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-describe ActiveAdmin::Application do
+RSpec.describe ActiveAdmin::Application do
   let(:application){ ActiveAdmin::Application.new }
   let(:controllers){ application.controllers_for_filters }
 

data/spec/unit/csv_builder_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rails_helper'
 
-describe ActiveAdmin::CSVBuilder do
+RSpec.describe ActiveAdmin::CSVBuilder do
 
   describe '.default_for_resource using Post' do
     let(:csv_builder) { ActiveAdmin::CSVBuilder.default_for_resource(Post).tap(&:exec_columns) }
@@ -189,8 +189,8 @@ describe ActiveAdmin::CSVBuilder do
 
   context "build csv using the supplied order" do
     before do
-      @post1 = Post.create!(title: "Hello1", published_at: Date.today - 2.day )
-      @post2 = Post.create!(title: "Hello2", published_at: Date.today - 1.day )
+      @post1 = Post.create!(title: "Hello1", published_date: Date.today - 2.day )
+      @post2 = Post.create!(title: "Hello2", published_date: Date.today - 1.day )
     end
     let(:dummy_controller) {
       class DummyController
@@ -199,7 +199,7 @@ describe ActiveAdmin::CSVBuilder do
         end
 
         def collection
-          Post.order('published_at DESC')
+          Post.order('published_date DESC')
         end
 
         def apply_decorator(resource)
@@ -215,7 +215,7 @@ describe ActiveAdmin::CSVBuilder do
       ActiveAdmin::CSVBuilder.new do
         column "id"
         column "title"
-        column "published_at"
+        column "published_date"
       end
     end
 

data/spec/unit/dependency_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-describe ActiveAdmin::Dependency do
+RSpec.describe ActiveAdmin::Dependency do
 
   k = ActiveAdmin::Dependency
 

data/spec/unit/devise_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-describe ActiveAdmin::Devise::Controller do
+RSpec.describe ActiveAdmin::Devise::Controller do
 
   let(:controller_class) do
     klass = Class.new do
@@ -12,10 +12,22 @@ describe ActiveAdmin::Devise::Controller do
   end
 
   let(:controller) { controller_class.new }
+  let(:action_controller_config) { Rails.configuration.action_controller }
+
+  def with_temp_relative_url_root(relative_url_root)
+    previous_relative_url_root = action_controller_config[:relative_url_root]
+    action_controller_config[:relative_url_root] = relative_url_root
+
+    yield
+  ensure
+    action_controller_config[:relative_url_root] = previous_relative_url_root
+  end
 
   context 'with a RAILS_RELATIVE_URL_ROOT set' do
 
-    before { Rails.configuration.action_controller[:relative_url_root] = '/foo' }
+    around do |example|
+      with_temp_relative_url_root('/foo') { example.call }
+    end
 
     it "should set the root path to the default namespace" do
       expect(controller.root_path).to eq "/foo/admin"
@@ -30,7 +42,9 @@ describe ActiveAdmin::Devise::Controller do
 
   context 'without a RAILS_RELATIVE_URL_ROOT set' do
 
-    before { Rails.configuration.action_controller[:relative_url_root] = nil }
+    around do |example|
+      with_temp_relative_url_root(nil) { example.call }
+    end
 
     it "should set the root path to the default namespace" do
       expect(controller.root_path).to eq "/admin"

data/spec/unit/dsl_spec.rb

@@ -6,11 +6,11 @@ module MockModuleToInclude
   end
 end
 
-describe ActiveAdmin::DSL do
+RSpec.describe ActiveAdmin::DSL do
 
   let(:application) { ActiveAdmin::Application.new }
   let(:namespace) { ActiveAdmin::Namespace.new application, :admin }
-  let(:resource_config) { ActiveAdmin::Resource.new namespace, Post }
+  let(:resource_config) { namespace.register Post }
   let(:dsl){ ActiveAdmin::DSL.new(resource_config) }
 
   describe "#include" do

data/spec/unit/filters/active_spec.rb

@@ -0,0 +1,21 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin::Filters::Active do
+  subject { described_class.new(Post, params) }
+  let(:params_klass) do
+    if defined? ::ActionController::Parameters
+      ::ActionController::Parameters
+    else
+      HashWithIndifferentAccess #remove this when drop rails 3 support
+    end
+  end
+
+  let(:params) do
+    params_klass.new(q: {author_id_eq: 1})
+  end
+
+  it 'should have filters' do
+    expect(subject.filters.size).to eq(1)
+  end
+
+end

data/spec/unit/filters/filter_form_builder_spec.rb

@@ -1,12 +1,6 @@
 require 'rails_helper'
 
-class Post
-  ransacker :custom_searcher do
-    # nothing to see here
-  end
-end
-
-describe ActiveAdmin::Filters::ViewHelper do
+RSpec.describe ActiveAdmin::Filters::ViewHelper do
 
   # Setup an ActionView::Base object which can be used for
   # generating the form for.
@@ -102,6 +96,19 @@ describe ActiveAdmin::Filters::ViewHelper do
       expect(body).to have_selector("option[value=title_starts_with][selected=selected]", text: "Starts with")
     end
 
+    context "with filters options" do
+      let(:body) { Capybara.string(filter :title, filters: [:contains, :starts_with]) }
+
+      it "should generate provided options for filter select" do
+        expect(body).to have_selector("option[value=title_contains]", text: "Contains")
+        expect(body).to have_selector("option[value=title_starts_with]", text: "Starts with")
+      end
+
+      it "should not generate a select option for ends with" do
+        expect(body).not_to have_selector("option[value=title_ends_with]")
+      end
+    end
+
     context "with predicate" do
       %w[eq equals cont contains start starts_with end ends_with].each do |predicate|
         describe "'#{predicate}'" do
@@ -153,39 +160,68 @@ describe ActiveAdmin::Filters::ViewHelper do
     end
   end
 
-  describe "datetime attribute" do
-    let(:body) { Capybara.string(filter :created_at) }
+  describe "date attribute" do
+    let(:body) { Capybara.string(filter :published_date) }
 
     it "should generate a date greater than" do
-      expect(body).to have_selector("input.datepicker[name='q[created_at_gteq_date]']")
+      expect(body).to have_selector("input.datepicker[name='q[published_date_gteq]']")
     end
     it "should generate a seperator" do
       expect(body).to have_selector("span.seperator")
     end
     it "should generate a date less than" do
-      expect(body).to have_selector("input.datepicker[name='q[created_at_lteq_date]']")
+      expect(body).to have_selector("input.datepicker[name='q[published_date_lteq]']")
     end
   end
 
-  describe "integer attribute" do
-    let(:body) { Capybara.string(filter :id) }
+  describe "datetime attribute" do
+    let(:body) { Capybara.string(filter :created_at) }
 
-    it "should generate a select option for equal to" do
-      expect(body).to have_selector("option[value=id_equals]", text: "Equals")
+    it "should generate a date greater than" do
+      expect(body).to have_selector("input.datepicker[name='q[created_at_gteq_datetime]']")
     end
-    it "should generate a select option for greater than" do
-      expect(body).to have_selector("option", text: "Greater than")
+    it "should generate a seperator" do
+      expect(body).to have_selector("span.seperator")
     end
-    it "should generate a select option for less than" do
-      expect(body).to have_selector("option", text: "Less than")
+    it "should generate a date less than" do
+      expect(body).to have_selector("input.datepicker[name='q[created_at_lteq_datetime]']")
     end
-    it "should generate a text field for input" do
-      expect(body).to have_selector("input[name='q[id_equals]']")
+  end
+
+  describe "integer attribute" do
+    context "without options" do
+      let(:body) { Capybara.string(filter :id) }
+
+      it "should generate a select option for equal to" do
+        expect(body).to have_selector("option[value=id_equals]", text: "Equals")
+      end
+      it "should generate a select option for greater than" do
+        expect(body).to have_selector("option[value=id_greater_than]", text: "Greater than")
+      end
+      it "should generate a select option for less than" do
+        expect(body).to have_selector("option[value=id_less_than]", text: "Less than")
+      end
+      it "should generate a text field for input" do
+        expect(body).to have_selector("input[name='q[id_equals]']")
+      end
+      it "should select the option which is currently being filtered" do
+        scope = Post.search id_greater_than: 1
+        body = Capybara.string(render_filter scope, id: {})
+        expect(body).to have_selector("option[value=id_greater_than][selected=selected]", text: "Greater than")
+      end
     end
-    it "should select the option which is currently being filtered" do
-      scope = Post.search id_greater_than: 1
-      body = Capybara.string(render_filter scope, id: {})
-      expect(body).to have_selector("option[value=id_greater_than][selected=selected]", text: "Greater than")
+
+    context "with filters options" do
+      let(:body) { Capybara.string(filter :id, filters: [:equals, :greater_than]) }
+
+      it "should generate provided options for filter select" do
+        expect(body).to have_selector("option[value=id_equals]", text: "Equals")
+        expect(body).to have_selector("option[value=id_greater_than]", text: "Greater than")
+      end
+
+      it "should not generate a select option for less than" do
+        expect(body).not_to have_selector("option[value=id_less_than]")
+      end
     end
   end
 
@@ -389,21 +425,52 @@ describe ActiveAdmin::Filters::ViewHelper do
 
   describe "custom search methods" do
 
+    it "should use the default type of the ransacker" do
+      body = Capybara.string(filter :custom_searcher_numeric)
+      expect(body).to have_selector("option[value=custom_searcher_numeric_equals]")
+      expect(body).to have_selector("option[value=custom_searcher_numeric_greater_than]")
+      expect(body).to have_selector("option[value=custom_searcher_numeric_less_than]")
+    end
+
     it "should work as select" do
-      body = Capybara.string(filter :custom_searcher, as: :select, collection: ['foo'])
-      expect(body).to have_selector("select[name='q[custom_searcher]']")
+      body = Capybara.string(filter :custom_title_searcher, as: :select, collection: ['foo'])
+      expect(body).to have_selector("select[name='q[custom_title_searcher_eq]']")
     end
 
     it "should work as string" do
-      body = Capybara.string(filter :custom_searcher, as: :string)
-      expect(body).to have_selector("input[name='q[custom_searcher]']")
+      body = Capybara.string(filter :custom_title_searcher, as: :string)
+      expect(body).to have_selector("option[value=custom_title_searcher_contains]")
+      expect(body).to have_selector("option[value=custom_title_searcher_starts_with]")
+    end
+
+    describe "custom date range search" do
+      let(:qteq) { "2010-10-01" }
+      let(:lteq) { "2010-10-02" }
+      let(:scope){ Post.search custom_created_at_searcher_gteq_datetime: qteq, custom_created_at_searcher_lteq_datetime: lteq }
+      let(:body) { Capybara.string(render_filter scope, custom_created_at_searcher: {as: :date_range}) }
+
+      it "should work as date_range" do
+        expect(body).to have_selector("input[name='q[custom_created_at_searcher_gteq_datetime]'][value='2010-10-01']")
+        expect(body).to have_selector("input[name='q[custom_created_at_searcher_lteq_datetime]'][value='2010-10-02']")
+      end
+
+      context "filter value can't be casted to date" do
+        let(:qteq) { "Ooops" }
+        let(:lteq) { "Ooops" }
+
+        it "should work display empty filter values" do
+          expect(body).to have_selector("input[name='q[custom_created_at_searcher_gteq_datetime]'][value='']")
+          expect(body).to have_selector("input[name='q[custom_created_at_searcher_lteq_datetime]'][value='']")
+        end
+      end
+
     end
   end
 
   describe "does not support some filter inputs" do
     it "should fallback to use formtastic inputs" do
-      body = Capybara.string(filter :custom_searcher, as: :text)
-      expect(body).to have_selector("textarea[name='q[custom_searcher]']")
+      body = Capybara.string(filter :custom_title_searcher, as: :text)
+      expect(body).to have_selector("textarea[name='q[custom_title_searcher]']")
     end
   end
 

data/spec/unit/filters/humanized_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-describe ActiveAdmin::Filters::Humanized do
+RSpec.describe ActiveAdmin::Filters::Humanized do
   describe '#value' do
     it 'should equal query string parameter if not an Array' do
       param = ['category_id_eq', '1']
@@ -52,5 +52,13 @@ describe ActiveAdmin::Filters::Humanized do
         expect(humanizer.body).to eq("Name Predicate Does Not Exist")
       end
     end
+
+    context 'when column name similar to predicate' do
+      it 'parses correct predicate' do
+        param = ['time_start_gteq', 'test']
+        humanizer = ActiveAdmin::Filters::Humanized.new(param)
+        expect(humanizer.body).to eq('Time Start greater than or equal to')
+      end
+    end
   end
 end

data/spec/unit/filters/resource_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-describe ActiveAdmin::Filters::ResourceExtension do
+RSpec.describe ActiveAdmin::Filters::ResourceExtension do
 
   let(:resource) do
     namespace = ActiveAdmin::Namespace.new(ActiveAdmin::Application.new, :admin)
@@ -13,7 +13,7 @@ describe ActiveAdmin::Filters::ResourceExtension do
 
   it "should return the defaults if no filters are set" do
     expect(resource.filters.keys).to match_array([
-      :author, :body, :category, :created_at, :custom_searcher, :position, :published_at, :starred, :taggings, :title, :updated_at
+      :author, :body, :category, :created_at, :custom_created_at_searcher, :custom_title_searcher, :custom_searcher_numeric, :position, :published_date, :starred, :taggings, :title, :updated_at
     ])
   end
 
@@ -35,7 +35,7 @@ describe ActiveAdmin::Filters::ResourceExtension do
   it "should return the defaults without associations if default association filters are disabled on the namespace" do
     resource.namespace.include_default_association_filters = false
     expect(resource.filters.keys).to match_array([
-      :body, :created_at, :custom_searcher, :position, :published_at, :starred, :title, :updated_at
+      :body, :created_at, :custom_created_at_searcher, :custom_title_searcher, :custom_searcher_numeric, :position, :published_date, :starred, :title, :updated_at
     ])
   end
 
@@ -104,7 +104,8 @@ describe ActiveAdmin::Filters::ResourceExtension do
       resource.add_filter :count, as: :string
 
       expect(resource.filters.keys).to match_array([
-        :author, :body, :category, :count, :created_at, :custom_searcher, :position, :published_at, :starred, :taggings, :title, :updated_at
+        :author, :body, :category, :count, :created_at, :custom_created_at_searcher, :custom_title_searcher, :custom_searcher_numeric, :position, :published_date, :starred, :taggings, :title, :updated_at
+
       ])
     end
 

data/spec/unit/form_builder_spec.rb

@@ -1,8 +1,7 @@
 require 'rails_helper'
 require "rspec/mocks/standalone"
 
-describe ActiveAdmin::FormBuilder do
-
+RSpec.describe ActiveAdmin::FormBuilder do
   # Setup an ActionView::Base object which can be used for
   # generating the form for.
   let(:helpers) do
@@ -63,7 +62,7 @@ describe ActiveAdmin::FormBuilder do
     context "it with custom settings" do
       let :body do
         build_form do |f|
-          f.inputs class: "custom_class" do
+          f.inputs class: "custom_class", name: 'custom_name', custom_attr: 'custom_attr' do
             f.input :title
             f.input :body
           end
@@ -71,7 +70,15 @@ describe ActiveAdmin::FormBuilder do
       end
 
       it "should generate a fieldset with a inputs and custom class" do
-        expect(body).to have_selector("fieldset.inputs.custom_class")
+        expect(body).to have_selector("fieldset.custom_class")
+      end
+
+      it "should generate a fieldset with a custom legend" do
+        expect(body).to have_css("legend", text: 'custom_name')
+      end
+
+      it "should generate a fieldset with a custom attributes" do
+        expect(body).to have_selector("fieldset[custom_attr='custom_attr']")
       end
     end
   end
@@ -277,6 +284,36 @@ describe ActiveAdmin::FormBuilder do
 
   end
 
+  context "with inputs component inside has_many" do
+
+    def user
+      u = User.new
+      u.profile = Profile.new(bio: 'bio')
+      u
+    end
+
+    let :body do
+      author = user()
+      build_form do |f|
+        f.form_builder.instance_eval do
+          @object.author = author
+        end
+        f.inputs name: 'Author', for: :author do |author|
+          author.has_many :profile, allow_destroy: true do |profile|
+            profile.inputs  "inputs for profile #{profile.object.bio}" do
+              profile.input :bio
+            end
+          end
+        end
+      end
+    end
+
+    it "should see the profile fields for an existing profile" do
+      expect(body).to have_selector("[id='post_author_attributes_profile_attributes_bio']", count: 1)
+      expect(body).to have_selector("textarea[name='post[author_attributes][profile_attributes][bio]']")
+    end
+  end
+
   context "with a has_one relation on an author's profile" do
     let :body do
       author = user()
@@ -402,7 +439,7 @@ describe ActiveAdmin::FormBuilder do
         end
         f.inputs do
           f.input :author
-          f.input :published_at
+          f.input :created_at
         end
       end
     end
@@ -410,10 +447,10 @@ describe ActiveAdmin::FormBuilder do
       expect(body).to have_selector("input[name='post[title]']", count: 1)
       expect(body).to have_selector("textarea[name='post[body]']", count: 1)
       expect(body).to have_selector("select[name='post[author_id]']", count: 1)
-      expect(body).to have_selector("select[name='post[published_at(1i)]']", count: 1)
-      expect(body).to have_selector("select[name='post[published_at(2i)]']", count: 1)
-      expect(body).to have_selector("select[name='post[published_at(3i)]']", count: 1)
-      expect(body).to have_selector("select[name='post[published_at(4i)]']", count: 1)
+      expect(body).to have_selector("select[name='post[created_at(1i)]']", count: 1)
+      expect(body).to have_selector("select[name='post[created_at(2i)]']", count: 1)
+      expect(body).to have_selector("select[name='post[created_at(3i)]']", count: 1)
+      expect(body).to have_selector("select[name='post[created_at(4i)]']", count: 1)
     end
   end
 
@@ -502,7 +539,6 @@ describe ActiveAdmin::FormBuilder do
       it "should add a custom header" do
         expect(body).to have_selector("h3", text: "Post")
       end
-
     end
 
     describe "without heading and new record link" do
@@ -539,9 +575,8 @@ describe ActiveAdmin::FormBuilder do
       end
 
       it "should add a custom header" do
-        expect(body).to have_selector("h3", "Test heading")
+        expect(body).to have_selector("h3", text: "Test heading")
       end
-
     end
 
     describe "with custom new record link" do
@@ -557,29 +592,20 @@ describe ActiveAdmin::FormBuilder do
       it "should add a custom new record link" do
         expect(body).to have_selector("a", text: "My Custom New Post")
       end
-
     end
 
     describe "with allow destroy" do
-      context "with an existing post" do
-        let :body do
-          s = self
-          build_form({url: '/categories'}, Category.new) do |f|
-            s.instance_exec do
-              allow(f.object.posts.build).to receive(:new_record?).and_return(false)
-            end
-            f.has_many :posts, allow_destroy: true do |p|
-              p.input :title
-            end
-          end
+      shared_examples_for "has many with allow_destroy = true" do |child_num|
+        it "should render the nested form" do
+          expect(body).to have_selector("input[name='category[posts_attributes][#{child_num}][title]']")
         end
 
         it "should include a boolean field for _destroy" do
-          expect(body).to have_selector("input[name='category[posts_attributes][0][_destroy]']")
+          expect(body).to have_selector("input[name='category[posts_attributes][#{child_num}][_destroy]']")
         end
 
         it "should have a check box with 'Remove' as its label" do
-          expect(body).to have_selector("label[for=category_posts_attributes_0__destroy]", text: "Delete")
+          expect(body).to have_selector("label[for=category_posts_attributes_#{child_num}__destroy]", text: "Delete")
         end
 
         it "should wrap the destroy field in an li with class 'has_many_delete'" do
@@ -587,22 +613,143 @@ describe ActiveAdmin::FormBuilder do
         end
       end
 
-      context "with a new post" do
+      shared_examples_for "has many with allow_destroy = false" do |child_num|
+        it "should render the nested form" do
+          expect(body).to have_selector("input[name='category[posts_attributes][#{child_num}][title]']")
+        end
+
+        it "should not have a boolean field for _destroy" do
+          expect(body).not_to have_selector("input[name='category[posts_attributes][#{child_num}][_destroy]']")
+        end
+
+        it "should not have a check box with 'Remove' as its label" do
+          expect(body).not_to have_selector("label[for=category_posts_attributes_#{child_num}__destroy]", text: "Remove")
+        end
+      end
+
+      shared_examples_for "has many with allow_destroy as String, Symbol or Proc" do |allow_destroy_option|
         let :body do
+          s = self
           build_form({url: '/categories'}, Category.new) do |f|
-            f.object.posts.build
-            f.has_many :posts, allow_destroy: true do |p|
+            s.instance_exec do
+              allow(f.object.posts.build).to receive(:foo?).and_return(true)
+              allow(f.object.posts.build).to receive(:foo?).and_return(false)
+
+              f.object.posts.each do |post|
+                allow(post).to receive(:new_record?).and_return(false)
+              end
+            end
+            f.has_many :posts, allow_destroy: allow_destroy_option do |p|
               p.input :title
             end
           end
         end
 
-        it "should not have a boolean field for _destroy" do
-          expect(body).not_to have_selector("input[name='category[posts_attributes][0][_destroy]']")
+        context 'for the child that responds with true' do
+          it_behaves_like "has many with allow_destroy = true", 0
         end
 
-        it "should not have a check box with 'Remove' as its label" do
-          expect(body).not_to have_selector("label[for=category_posts_attributes_0__destroy]", text: "Remove")
+        context 'for the child that responds with false' do
+          it_behaves_like "has many with allow_destroy = false", 1
+        end
+      end
+
+      context "with an existing post" do
+        context "with allow_destroy = true" do
+          let :body do
+            s = self
+            build_form({url: '/categories'}, Category.new) do |f|
+              s.instance_exec do
+                allow(f.object.posts.build).to receive(:new_record?).and_return(false)
+              end
+              f.has_many :posts, allow_destroy: true do |p|
+                p.input :title
+              end
+            end
+          end
+
+          it_behaves_like "has many with allow_destroy = true", 0
+        end
+
+        context "with allow_destroy = false" do
+          let :body do
+            s = self
+            build_form({url: '/categories'}, Category.new) do |f|
+              s.instance_exec do
+                allow(f.object.posts.build).to receive(:new_record?).and_return(false)
+              end
+              f.has_many :posts, allow_destroy: false do |p|
+                p.input :title
+              end
+            end
+          end
+
+          it_behaves_like "has many with allow_destroy = false", 0
+        end
+
+        context "with allow_destroy = nil" do
+          let :body do
+            s = self
+            build_form({url: '/categories'}, Category.new) do |f|
+              s.instance_exec do
+                allow(f.object.posts.build).to receive(:new_record?).and_return(false)
+              end
+              f.has_many :posts, allow_destroy: nil do |p|
+                p.input :title
+              end
+            end
+          end
+
+          it_behaves_like "has many with allow_destroy = false", 0
+        end
+
+        context "with allow_destroy as Symbol" do
+          it_behaves_like("has many with allow_destroy as String, Symbol or Proc", :foo?)
+        end
+
+        context "with allow_destroy as String" do
+          it_behaves_like("has many with allow_destroy as String, Symbol or Proc", "foo?")
+        end
+
+        context "with allow_destroy as proc" do
+          it_behaves_like("has many with allow_destroy as String, Symbol or Proc",
+                          Proc.new { |child| child.foo? })
+        end
+
+        context "with allow_destroy as lambda" do
+          it_behaves_like("has many with allow_destroy as String, Symbol or Proc",
+                          lambda { |child| child.foo? })
+        end
+
+        context "with allow_destroy as any other expression that evaluates to true" do
+          let :body do
+            s = self
+            build_form({url: '/categories'}, Category.new) do |f|
+              s.instance_exec do
+                allow(f.object.posts.build).to receive(:new_record?).and_return(false)
+              end
+              f.has_many :posts, allow_destroy: Object.new do |p|
+                p.input :title
+              end
+            end
+          end
+
+          it_behaves_like "has many with allow_destroy = true", 0
+        end
+      end
+
+      context "with a new post" do
+        context "with allow_destroy = true" do
+          let :body do
+            build_form({url: '/categories'}, Category.new) do |f|
+              f.object.posts.build
+              f.has_many :posts, allow_destroy: true do |p|
+                p.input :title
+              end
+            end
+          end
+
+          it_behaves_like "has many with allow_destroy = false", 0
         end
       end
     end