activeadmin 0.6.0 → 0.6.1

data/spec/unit/routing_spec.rb

@@ -9,66 +9,12 @@ describe ActiveAdmin, "Routing", :type => :routing do
     reload_routes!
   end
 
-  include Rails.application.routes.url_helpers
-
-  describe "root" do
-    before do
-      pending "Y U NO PASS?"
-    end
-    context "when default configuration" do
-      context "when in admin namespace" do
-        it "should route the admin dashboard" do
-          get('/admin').should route_to('admin/dashboard#index')
-        end
-      end
-
-      context "when in root namespace" do
-        before(:each) do
-          load_resources { ActiveAdmin.register(Post, :namespace => false) }
-          reload_routes!
-        end
-
-        it "should route the root dashboard" do
-          pending "Y U NO PASS?"
-
-          get('/').should route_to('dashboard#index')
-        end
-      end
-    end
-
-    context "when customized configuration to root to post#index" do
-      before do
-        @original_root = ActiveAdmin.application.root_to
-        ActiveAdmin.application.root_to = "posts#index"
-      end
-
-      after do
-        ActiveAdmin.application.root_to = @original_root
-        reload_routes!
-      end
-
-      context "when in admin namespace" do
-        before do
-          load_resources { ActiveAdmin.register(Post) }
-        end
-
-        it "should route to admin/posts#index" do
-          get('/admin').should route_to('admin/posts#index')
-        end
-      end
-
-      context "when in root namespace" do
-        before do
-          load_resources { ActiveAdmin.register(Post, :namespace => false) }
-        end
-
-        it "should route to posts#index" do
-          pending "Y U NO PASS?"
+  it "should only have the namespaces necessary for route testing" do
+    ActiveAdmin.application.namespaces.keys.should eq [:admin, :root]
+  end
 
-          get('/').should route_to('posts#index')
-        end
-      end
-    end
+  it "should route to the admin dashboard" do
+    get('/admin').should route_to 'admin/dashboard#index'
   end
 
   describe "standard resources" do
@@ -115,7 +61,7 @@ describe ActiveAdmin, "Routing", :type => :routing do
     context "with member action" do
       context "without an http verb" do
         before do
-          load_resources do 
+          load_resources do
             ActiveAdmin.register(Post){ member_action "do_something" }
           end
         end
@@ -128,7 +74,7 @@ describe ActiveAdmin, "Routing", :type => :routing do
 
       context "with one http verb" do
         before do
-          load_resources do 
+          load_resources do
             ActiveAdmin.register(Post){ member_action "do_something", :method => :post }
           end
         end
@@ -140,7 +86,7 @@ describe ActiveAdmin, "Routing", :type => :routing do
 
       context "with two http verbs" do
         before do
-          load_resources do 
+          load_resources do
             ActiveAdmin.register(Post){ member_action "do_something", :method => [:put, :delete] }
           end
         end
@@ -149,8 +95,8 @@ describe ActiveAdmin, "Routing", :type => :routing do
           {:put => "/admin/posts/1/do_something"}.should be_routable
         end
 
-        it "should properly route the second verb" do        
-          {:delete => "/admin/posts/1/do_something"}.should be_routable     
+        it "should properly route the second verb" do
+          {:delete => "/admin/posts/1/do_something"}.should be_routable
         end
       end
     end

data/spec/unit/scope_spec.rb

@@ -72,6 +72,25 @@ describe ActiveAdmin::Scope do
 
   end
 
+  describe "#default" do
+
+    it "should accept a boolean" do
+      scope = ActiveAdmin::Scope.new(:method, nil, :default => true)
+      scope.default_block.should == true
+    end
+
+    it "should default to a false #default_block" do
+      scope = ActiveAdmin::Scope.new(:method, nil)
+      scope.default_block.call.should == false
+    end
+
+    it "should store the :default proc" do
+      scope = ActiveAdmin::Scope.new(:with_block, nil, :default => proc{ true })
+      scope.default_block.call.should == true
+    end
+
+  end
+
   describe "show_count" do
 
     it "should allow setting of show_count to prevent showing counts" do

data/spec/unit/settings_spec.rb

@@ -0,0 +1,88 @@
+require 'spec_helper'
+
+describe ActiveAdmin::Settings do
+
+  subject{ Class.new{ include ActiveAdmin::Settings } }
+
+  it{ should respond_to :setting }
+  it{ should respond_to :deprecated_setting }
+  it{ should respond_to :default_settings }
+
+  describe "class API" do
+    it "should create settings" do
+      subject.setting :foo, 'bar'
+      subject.default_settings[:foo].should eq 'bar'
+    end
+
+    it "should create deprecated settings" do
+      ActiveAdmin::Deprecation.should_receive(:deprecate).twice
+      subject.deprecated_setting :baz, 32
+      subject.default_settings[:baz].should eq 32
+    end
+  end
+
+  describe "instance API" do
+
+    before do
+      subject.setting :foo, 'bar'
+      subject.deprecated_setting :baz, 32
+    end
+    let(:instance) { subject.new }
+
+    it "should have access to a default value" do
+      instance.foo.should eq 'bar'
+      instance.foo = 'qqq'
+      instance.foo.should eq 'qqq'
+    end
+
+    it "should have access to a deprecated value" do
+      ActiveAdmin::Deprecation.should_receive(:warn).exactly(3).times
+      instance.baz.should eq 32
+      instance.baz = [45]
+      instance.baz.should eq [45]
+    end
+  end
+
+end
+
+
+describe ActiveAdmin::Settings::Inheritance do
+
+  subject do
+    Class.new do
+      include ActiveAdmin::Settings
+      include ActiveAdmin::Settings::Inheritance
+    end
+  end
+
+  it{ should respond_to :settings_inherited_by }
+  it{ should respond_to :inheritable_setting }
+  it{ should respond_to :deprecated_inheritable_setting }
+
+  let(:heir) { Class.new }
+
+  before do
+    subject.settings_inherited_by heir
+  end
+
+  describe "class API" do
+    it "should add setting to an heir" do
+      subject.inheritable_setting :one, 2
+      heir.default_settings[:one].should eq 2
+    end
+
+    it "should add deprecated setting to an heir" do
+      ActiveAdmin::Deprecation.should_receive(:deprecate).exactly(4).times
+      subject.deprecated_inheritable_setting :three, 4
+      heir.default_settings[:three].should eq 4
+    end
+  end
+
+  describe "instance API" do
+    before{ subject.inheritable_setting :left, :right }
+    it "should work" do
+      heir.new.left.should eq :right
+    end
+  end
+
+end

data/spec/unit/view_factory_spec.rb

@@ -9,6 +9,7 @@ end
 describe ActiveAdmin::ViewFactory do
 
   it_should_have_view :global_navigation,    ActiveAdmin::Views::TabbedNavigation
+  it_should_have_view :utility_navigation,   ActiveAdmin::Views::TabbedNavigation
   it_should_have_view :site_title,           ActiveAdmin::Views::SiteTitle
   it_should_have_view :action_items,         ActiveAdmin::Views::ActionItems
   it_should_have_view :header,               ActiveAdmin::Views::Header

data/spec/unit/{breadcrumbs_spec.rb → view_helpers/breadcrumbs_spec.rb}

@@ -11,10 +11,20 @@ describe "Breadcrumbs" do
     # Mock link to and return a hash
     def link_to(name, url); {:name => name, :path => url}; end
 
+    let(:post) { mock(:display_name => 'Hello World') }
+
+    let(:post_config) { stub(find_resource: post) }
+
+    let :active_admin_config do
+      active_admin_config = stub
+      active_admin_config.stub_chain(:belongs_to_config, :target).and_return post_config
+      active_admin_config
+    end
+
     let(:trail) { breadcrumb_links(path) }
 
     context "when request '/admin'" do
-      let(:path){ "/admin" }
+      let(:path) { "/admin" }
 
       it "should not have any items" do
         trail.size.should == 0
@@ -65,6 +75,7 @@ describe "Breadcrumbs" do
       end
 
       context "when Post.find(1) doesn't exist" do
+        before { post_config.stub(find_resource: nil) }
         it "should have a link to /admin/posts/1" do
           trail[2][:name].should == "1"
           trail[2][:path].should == "/admin/posts/1"
@@ -72,9 +83,6 @@ describe "Breadcrumbs" do
       end
 
       context "when Post.find(1) does exist" do
-        before do
-          Post.stub!(:find_by_id).and_return{ mock(:display_name => "Hello World") }
-        end
         it "should have a link to /admin/posts/1 using display name" do
           trail[2][:name].should == "Hello World"
           trail[2][:path].should == "/admin/posts/1"
@@ -98,6 +106,7 @@ describe "Breadcrumbs" do
       end
 
       context "when Post.find(4e24d6249ccf967313000000) doesn't exist" do
+        before { post_config.stub(find_resource: nil) }
         it "should have a link to /admin/posts/4e24d6249ccf967313000000" do
           trail[2][:name].should == "4e24d6249ccf967313000000"
           trail[2][:path].should == "/admin/posts/4e24d6249ccf967313000000"
@@ -106,10 +115,10 @@ describe "Breadcrumbs" do
 
       context "when Post.find(4e24d6249ccf967313000000) does exist" do
         before do
-          Post.stub!(:find_by_id).with('4e24d6249ccf967313000000').and_return{ mock(:display_name => "Hello World") }
+          post_config.stub(:find_resource => mock(:display_name => 'Hello :)'))
         end
         it "should have a link to /admin/posts/4e24d6249ccf967313000000 using display name" do
-          trail[2][:name].should == "Hello World"
+          trail[2][:name].should == "Hello :)"
           trail[2][:path].should == "/admin/posts/4e24d6249ccf967313000000"
         end
       end
@@ -130,7 +139,7 @@ describe "Breadcrumbs" do
         trail[1][:path].should == "/admin/posts"
       end
       it "should have a link to /admin/posts/1" do
-        trail[2][:name].should == "1"
+        trail[2][:name].should == "Hello World"
         trail[2][:path].should == "/admin/posts/1"
       end
       it "should have a link to /admin/posts/1/comments" do

data/spec/unit/view_helpers/display_name_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+describe "display_name" do
+
+  include ActiveAdmin::ViewHelpers
+
+  [:display_name, :full_name, :name, :username, :login, :title, :email, :to_s].each do |m|
+    it "should return #{m} when defined" do
+      r = Class.new do
+        define_method m do
+          m.to_s
+        end
+      end.new
+      display_name(r).should == m.to_s
+    end
+  end
+
+  it "should memeoize the result for the class" do
+    subject { Class.new.new }
+    subject.should_receive(:name).twice.and_return "My Name"
+    display_name(subject).should == "My Name"
+    ActiveAdmin.application.should_not_receive(:display_name_methods)
+    display_name(subject).should == "My Name"
+  end
+
+  it "should not call a method if it's an association" do
+    subject { Class.new.new }
+    subject.stub_chain(:class, :reflect_on_all_associations).and_return [ mock(:name => :login) ]
+    subject.stub :login
+    subject.should_not_receive :login
+    subject.stub(:email).and_return 'foo@bar.baz'
+    display_name(subject).should == 'foo@bar.baz'
+  end
+
+  [nil, false].each do |type|
+    it "should return nil when the passed object is #{type.inspect}" do
+      display_name(type).should eq nil
+    end
+  end
+
+end

data/spec/unit/view_helpers/form_helper_spec.rb

@@ -1,11 +1,45 @@
 require 'spec_helper'
 
 describe ActiveAdmin::ViewHelpers::FormHelper do
+
+  describe '.active_admin_form_for' do
+    let(:view) { action_view }
+    let(:resource) { stub('resource') }
+    let(:default_options) { { builder: ActiveAdmin::FormBuilder } }
+
+    it 'calls semantic_form_for with the ActiveAdmin form builder' do
+      view.should_receive(:semantic_form_for).with(resource, builder: ActiveAdmin::FormBuilder)
+      view.active_admin_form_for(resource)
+    end
+
+    it 'allows the form builder to be customized' do
+      # We can't use a stub here because options gets marshalled, and a new
+      # instance built. Any constant will work.
+      custom_builder = Object
+      view.should_receive(:semantic_form_for).with(resource, builder: custom_builder)
+      view.active_admin_form_for(resource, builder: custom_builder)
+    end
+
+    context 'with a decorated resource' do
+      let(:decorated) { stub('decorated_resource', model: resource) }
+
+      it 'can disable automatic decoration' do
+        view.should_receive(:semantic_form_for).with(resource, default_options.merge(decorate: false))
+        view.active_admin_form_for(decorated, decorate: false)
+      end
+
+      it 'can enable automatic decoration' do
+        view.should_receive(:semantic_form_for).with(decorated, default_options.merge(decorate: true))
+        view.active_admin_form_for(decorated, decorate: true)
+      end
+    end
+  end
+
   describe ".hidden_field_tags_for" do
     let(:view) { action_view }
 
     it "should render hidden field tags for params" do
-      view.hidden_field_tags_for(:scope => "All", :filter => "None").should == 
+      view.hidden_field_tags_for(:scope => "All", :filter => "None").should ==
         %{<input id="hidden_active_admin_scope" name="scope" type="hidden" value="All" />\n<input id="hidden_active_admin_filter" name="filter" type="hidden" value="None" />}
     end
 
@@ -14,7 +48,7 @@ describe ActiveAdmin::ViewHelpers::FormHelper do
     end
 
     it "should filter out the field passed via the option :except" do
-      view.hidden_field_tags_for({:scope => "All", :filter => "None"}, :except => :filter).should == 
+      view.hidden_field_tags_for({:scope => "All", :filter => "None"}, :except => :filter).should ==
         %{<input id="hidden_active_admin_scope" name="scope" type="hidden" value="All" />}
     end
   end

data/spec/unit/views/components/attributes_table_spec.rb

@@ -46,8 +46,16 @@ describe ActiveAdmin::Views::AttributesTable do
             row("Body") { post.body }
           end
         }
-      }
-
+      },
+      "when you create each row with a custom block that returns nil" => proc {
+        render_arbre_component(assigns) {
+          attributes_table_for post do
+            row("Id")   { text_node post.id; nil }
+            row("Title"){ text_node post.title; nil }
+            row("Body") { text_node post.body; nil }
+          end
+        }
+      },
     }.each do |context_title, table_decleration|
       context context_title do
         let(:table) { instance_eval &table_decleration }
@@ -68,15 +76,15 @@ describe ActiveAdmin::Views::AttributesTable do
 
         describe "rendering the rows" do
           [
-            ["Id" , "2"],
+            ["Id" , "1"],
             ["Title" , "Hello World"],
             ["Body" , "<span class=\"empty\">Empty</span>"]
           ].each_with_index do |set, i|
-            let(:title){ set[0] }
-            let(:content){ set[1] }
-            let(:current_row){ table.find_by_tag("tr")[i] }
-
             describe "for #{set[0]}" do
+              let(:title){ set[0] }
+              let(:content){ set[1] }
+              let(:current_row){ table.find_by_tag("tr")[i] }
+
               it "should have the title '#{set[0]}'" do
                 current_row.find_by_tag("th").first.content.should == title
               end
@@ -111,11 +119,11 @@ describe ActiveAdmin::Views::AttributesTable do
     end
 
     it "should check if an association exists when an attribute has id in it" do
-      post.author = User.new(:username => "john_doe")
+      post.author = User.new :username => 'john_doe', :first_name => 'John', :last_name => 'Doe'
       table = render_arbre_component(assigns) {
         attributes_table_for post, :author_id
       }
-      table.find_by_tag("td").first.content.should == "john_doe"
+      table.find_by_tag('td').first.content.should == 'John Doe'
     end
 
   end