activeadmin 0.5.0 → 0.5.1

data/spec/unit/application_spec.rb

@@ -30,7 +30,7 @@ describe ActiveAdmin::Application do
     application.site_title = "New Title"
     application.site_title.should == "New Title"
   end
-  
+
   it "should store the site's title link" do
     application.site_title_link.should == ""
   end
@@ -39,11 +39,11 @@ describe ActiveAdmin::Application do
     application.site_title_link = "http://www.mygreatsite.com"
     application.site_title_link.should == "http://www.mygreatsite.com"
   end
-  
+
   it "should store the site's title image" do
     application.site_title_image.should == ""
   end
-  
+
   it "should set the site's title image" do
     application.site_title_image = "http://railscasts.com/assets/episodes/stills/284-active-admin.png?1316476106"
     application.site_title_image.should == "http://railscasts.com/assets/episodes/stills/284-active-admin.png?1316476106"
@@ -53,7 +53,7 @@ describe ActiveAdmin::Application do
     application.view_factory.should be_an_instance_of(ActiveAdmin::ViewFactory)
   end
 
-  it "should have deprecated admin notes by default" do 
+  it "should have deprecated admin notes by default" do
     application.admin_notes.should be_nil
   end
 
@@ -80,6 +80,19 @@ describe ActiveAdmin::Application do
     end
   end
 
+  describe "inheritable settings" do
+    it "should set csv_options" do
+      application.csv_options.should == {}
+    end
+
+    context "when deprecated" do
+      it "should set and warn csv_column_separator" do
+        ActiveAdmin::Deprecation.should_receive(:warn)
+        application.csv_column_separator.should == ','
+      end
+    end
+  end
+
   describe "files in load path" do
     it "should load files in the first level directory" do
       application.files_in_load_path.should include(File.expand_path("app/admin/dashboard.rb", Rails.root))

data/spec/unit/belongs_to_spec.rb

@@ -4,7 +4,7 @@ describe ActiveAdmin::Resource::BelongsTo do
 
 
   let(:application){ ActiveAdmin::Application.new }
-  let(:namespace){ Namespace.new(application, :admin) }
+  let(:namespace){ ActiveAdmin::Namespace.new(application, :admin) }
   let(:post){ namespace.register(Post) }
   let(:belongs_to){ ActiveAdmin::Resource::BelongsTo.new(post, :user) }
 

data/spec/unit/config_shared_examples.rb

@@ -33,16 +33,20 @@ shared_examples_for "ActiveAdmin::Config" do
   describe "Menu" do
     describe "menu item" do
 
-	  it "initializes a new menu item with defaults" do
+    it "initializes a new menu item with defaults" do
         config.menu_item.label.should == config.plural_resource_label
-	  end
+    end
 
-      it "initialize a new menu item with custom options" do
-		config.menu :label => "Hello"
-        config.menu_item.label.should == "Hello"
-      end
+    it "initialize a new menu item with custom options" do
+      config.menu :label => "Hello"
+      config.menu_item.label.should == "Hello"
+    end
 
+    it "initialize a new menu item with label as Proc object" do
+      config.menu :label => proc { "Hello" }
+      config.menu_item.label.should == "Hello"
     end
+  end
 
     describe "#include_in_menu?" do
       it "should be included in menu by default" do
@@ -62,10 +66,14 @@ shared_examples_for "ActiveAdmin::Config" do
       end
 
       it "should return the name if set" do
-		config.menu :parent => "Blog"
+        config.menu :parent => "Blog"
         config.parent_menu_item_name.should == "Blog"
       end
 
+      it "initialize a new parent menu item with label as Proc object" do
+        config.menu :parent => proc{ "Blog" }
+        config.parent_menu_item_name.should == "Blog"
+      end
     end
 
   end

data/spec/unit/controller_filters_spec.rb

@@ -4,29 +4,29 @@ describe ActiveAdmin, "filters" do
   let(:application){ ActiveAdmin::Application.new }
 
   describe "before filters" do
-    it "should add a new before filter to ActiveAdmin::ResourceController" do
-      ActiveAdmin::ResourceController.should_receive(:before_filter).and_return(true)
+    it "should add a new before filter to ActiveAdmin::BaseController" do
+      ActiveAdmin::BaseController.should_receive(:before_filter).and_return(true)
       application.before_filter :my_filter, :only => :show
     end
   end
   
   describe "skip before filters" do
-    it "should add a new skip before filter to ActiveAdmin::ResourceController" do
-      ActiveAdmin::ResourceController.should_receive(:skip_before_filter).and_return(true)
+    it "should add a new skip before filter to ActiveAdmin::BaseController" do
+      ActiveAdmin::BaseController.should_receive(:skip_before_filter).and_return(true)
       application.skip_before_filter :my_filter, :only => :show
     end
   end
 
   describe "after filters" do
-    it "should add a new after filter to ActiveAdmin::ResourceController" do
-      ActiveAdmin::ResourceController.should_receive(:after_filter).and_return(true)
+    it "should add a new after filter to ActiveAdmin::BaseController" do
+      ActiveAdmin::BaseController.should_receive(:after_filter).and_return(true)
       application.after_filter :my_filter, :only => :show
     end
   end
 
   describe "around filters" do
-    it "should add a new around filter to ActiveAdmin::ResourceController" do
-      ActiveAdmin::ResourceController.should_receive(:around_filter).and_return(true)
+    it "should add a new around filter to ActiveAdmin::BaseController" do
+      ActiveAdmin::BaseController.should_receive(:around_filter).and_return(true)
       application.around_filter :my_filter, :only => :show
     end
   end

data/spec/unit/csv_builder_spec.rb

@@ -90,4 +90,14 @@ describe ActiveAdmin::CSVBuilder do
     end
   end
 
+  context "with csv_options" do
+    let(:builder) do
+      ActiveAdmin::CSVBuilder.new :options => {:force_quotes => true}
+    end
+
+    it "should have proper separator" do
+      builder.options.should == {:force_quotes => true}
+    end
+  end
+
 end

data/spec/unit/devise_spec.rb

@@ -12,16 +12,37 @@ describe ActiveAdmin::Devise::Controller do
   end
 
   let(:controller) { controller_class.new }
+  
+  context 'with a RAILS_RELATIVE_URL_ROOT set' do
+    
+    before { Rails.configuration.action_controller[:relative_url_root] = '/foo' }
+    
+    it "should set the root path to the default namespace" do
+      controller.root_path.should == "/foo/admin"
+    end
 
-  it "should set the root path to the default namespace" do
-    controller.root_path.should == "/admin"
+    it "should set the root path to '/' when no default namespace" do
+      ActiveAdmin.application.stub!(:default_namespace => false)
+      controller.root_path.should == "/foo/"
+    end
+    
   end
-
-  it "should set the root path to '/' when no default namespace" do
-    ActiveAdmin.application.stub!(:default_namespace => false)
-    controller.root_path.should == "/"
+  
+  context 'without a RAILS_RELATIVE_URL_ROOT set' do
+    
+    before { Rails.configuration.action_controller[:relative_url_root] = nil }
+    
+    it "should set the root path to the default namespace" do
+      controller.root_path.should == "/admin"
+    end
+    
+    it "should set the root path to '/' when no default namespace" do
+      ActiveAdmin.application.stub!(:default_namespace => false)
+      controller.root_path.should == "/"
+    end
+    
   end
-
+  
   describe "#config" do
     let(:config) { ActiveAdmin::Devise.config }
 

data/spec/unit/filters/filter_form_builder_spec.rb

@@ -119,6 +119,28 @@ describe ActiveAdmin::Filters::ViewHelper do
     it "should select the option which is currently being filtered"
   end
 
+  describe "boolean attribute" do
+    context "boolean datatypes" do
+      let(:body) { filter :starred }
+
+      it "should create a check box for equals to" do
+        body.should have_tag("input", :attributes => {
+                                            :name => "q[starred_eq]",
+                                            :type => "checkbox" })
+      end
+    end
+
+    context "non-boolean data types" do
+      let(:body) { filter :title_is_present, :as => :boolean }
+
+      it "should create a check box for equals to" do
+        body.should have_tag("input", :attributes => {
+                                            :name => "q[title_is_present]",
+                                            :type => "checkbox" })
+      end
+    end
+  end
+
   describe "belong to" do
     before do
       @john = User.create :first_name => "John", :last_name => "Doe", :username => "john_doe"
@@ -135,6 +157,8 @@ describe ActiveAdmin::Filters::ViewHelper do
       it "should render as belongs to select" do
         body.should have_tag("select", :attributes => {
                                             :name => "q[author_id_eq]"})
+        body.should have_tag("option", "john_doe", :attributes => {
+                                                           :value => @john.id })
         body.should have_tag("option", "jane_doe", :attributes => {
                                                           :value => @jane.id })
       end

data/spec/unit/filters/resource_spec.rb

@@ -9,7 +9,7 @@ describe ActiveAdmin::Filters::ResourceExtension do
 
   it "should return the defaults if no filters are set" do
     resource.filters.map{|f| f[:attribute].to_s }.sort.should == %w{
-      author body category created_at published_at title updated_at
+      author body category created_at published_at starred title updated_at
     }
   end
 
@@ -28,6 +28,12 @@ describe ActiveAdmin::Filters::ResourceExtension do
     resource.filters.should be_empty
   end
 
+  it "should remove a filter" do
+    resource.filters.should include({:attribute => :author})
+    resource.remove_filter :author
+    resource.filters.should_not include({:attribute => :author})
+  end
+
   it "should add a filter" do
     resource.add_filter :title
     resource.filters.should == [{:attribute => :title}]
@@ -38,6 +44,14 @@ describe ActiveAdmin::Filters::ResourceExtension do
     resource.filters.should == [{:attribute => :title, :as => :string}]
   end
 
+  it "should preserve default filters" do
+    resource.preserve_default_filters!
+    resource.add_filter :count, :as => :string
+    resource.filters.map{|f| f[:attribute].to_s }.sort.should == %w{
+      author body category count created_at published_at starred title updated_at
+    }
+  end
+
   it "should raise an exception if trying to add a filter when they are disabled" do
     resource.filters = false
     expect {

data/spec/unit/form_builder_spec.rb

@@ -338,6 +338,10 @@ describe ActiveAdmin::FormBuilder do
         Capybara.string(body).should have_css(".has_many > fieldset > ol > li > a", :class => "button", :href => "#", :content => "Delete")
       end
 
+      it "should include the nested record's class name in the js" do
+        body.should have_tag("a", :attributes => { :onclick => /NEW_POST_RECORD/ })
+      end
+
       it "should add a link to add new nested records" do
         Capybara.string(body).should have_css(".has_many > fieldset > ol > li > a", :class => "button", :href => "#", :content => "Add New Post")
       end

data/spec/unit/resource_controller_spec.rb

@@ -55,6 +55,7 @@ describe ActiveAdmin::ResourceController do
     end
   end
 
+
   describe "callbacks" do
     let(:application){ ::ActiveAdmin::Application.new }
     let(:namespace){ ActiveAdmin::Namespace.new(application, :admin) }
@@ -162,6 +163,69 @@ end
 
 describe Admin::PostsController, :type => "controller" do
 
+  describe 'retreiving the resource' do
+    let(:controller){ Admin::PostsController.new }
+    let(:post) { Post.new :title => "An incledibly unique Post Title" }
+    before do
+      Post.stub(:find).and_return(post)
+      controller.class_eval { public :resource }
+      controller.stub(:params).and_return({ :id => '1' })
+    end
+
+    subject { controller.resource }
+    it "returns a Post" do
+      subject.should be_kind_of(Post)
+    end
+
+    context 'with a decorator' do
+      let(:config) { controller.class.active_admin_config }
+      before { config.decorator_class_name = '::PostDecorator' }
+      it 'returns a PostDecorator' do
+        subject.should be_kind_of(PostDecorator)
+      end
+
+      it 'returns a PostDecorator that wraps the post' do
+        subject.title.should == post.title
+      end
+    end
+  end
+
+  describe 'retreiving the resource collection' do
+    let(:controller){ Admin::PostsController.new }
+    before do
+      Post.create!(:title => "An incledibly unique Post Title") if Post.count == 0
+      controller.class_eval { public :collection }
+    end
+
+    subject { controller.collection }
+
+    it {
+      pending # doesn't pass when running whole spec suite (WTF)
+      should be_kind_of(ActiveRecord::Relation)
+    }
+
+    it "returns a collection of posts" do
+      pending # doesn't pass when running whole spec suite (WTF)
+      subject.first.should be_kind_of(Post)
+    end
+
+    context 'with a decorator' do
+      let(:config) { controller.class.active_admin_config }
+      before { config.decorator_class_name = '::PostDecorator' }
+
+      it 'returns a PostDecorator' do
+        pending # doesn't pass when running whole spec suite (WTF)
+        subject.should be_kind_of(PostDecorator::DecoratedEnumerableProxy)
+      end
+
+      it 'returns a PostDecorator that wraps the post' do
+        pending # doesn't pass when running whole spec suite (WTF)
+        subject.first.title.should == Post.first.title
+      end
+    end
+  end
+
+
   describe "performing batch_action" do
     let(:controller){ Admin::PostsController.new }
     before do
@@ -171,7 +235,7 @@ describe Admin::PostsController, :type => "controller" do
 
       controller.class.active_admin_config.stub!(:batch_actions).and_return([batch_action])
     end
-    
+
     describe "when params batch_action matches existing BatchAction" do
       it "should call the block with args" do
         pending # dont know how to check if the block was called
@@ -181,7 +245,7 @@ describe Admin::PostsController, :type => "controller" do
     describe "when params batch_action doesn't match a BatchAction" do
       it "should raise an error" do
         pending # doesn't pass when running whole spec suite (WTF)
-        
+
         lambda {
           post(:batch_action, :batch_action => "derp", :collection_selection => ["1"])
         }.should raise_error("Couldn't find batch action \"derp\"")
@@ -191,7 +255,7 @@ describe Admin::PostsController, :type => "controller" do
     describe "when params batch_action is blank" do
       it "should raise an error" do
         pending # doesn't pass when running whole spec suite (WTF)
-       
+
         lambda {
           post(:batch_action, :collection_selection => ["1"])
         }.should raise_error("Couldn't find batch action \"\"")

data/spec/unit/resource_spec.rb

@@ -28,6 +28,23 @@ module ActiveAdmin
       end
     end
 
+    describe '#decorator_class' do
+      it 'returns nil by default' do
+        config.decorator_class.should be_nil
+      end
+      context 'when a decorator is defined' do
+        let(:resource) { namespace.register(Post) { decorate_with PostDecorator } }
+        specify '#decorator_class_name should return PostDecorator' do
+          resource.decorator_class_name.should == '::PostDecorator'
+        end
+
+        it 'returns the decorator class' do
+          resource.decorator_class.should == PostDecorator
+        end
+      end
+    end
+
+
     describe "controller name" do
       it "should return a namespaced controller name" do
         config.controller_name.should == "Admin::CategoriesController"

data/spec/unit/view_helpers/download_format_links_helper_spec.rb

@@ -0,0 +1,39 @@
+require 'spec_helper'
+
+describe ActiveAdmin::ViewHelpers::DownloadFormatLinksHelper do
+
+  describe "class methods" do
+    before :each do
+
+      begin
+        # The mime type to be used in respond_to |format| style web-services in rails
+        Mime::Type.register "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet", :xlsx
+      rescue NameError
+        puts "Mime module not defined. Skipping registration of xlsx"
+      end
+
+      class Foo
+        include ActiveAdmin::ViewHelpers::DownloadFormatLinksHelper
+      end
+    end
+
+    it "extends the class to add a formats class method that returns the default formats." do
+      Foo.formats.should == [:csv, :xml, :json]
+    end
+
+    it "does not let you alter the formats array directly" do
+      Foo.formats << :xlsx
+      Foo.formats.should == [:csv, :xml, :json]
+    end
+
+    it "allows us to add new formats" do
+      Foo.add_format :xlsx
+      Foo.formats.should == [:csv, :xml, :json, :xlsx]
+    end
+
+    it "raises an exception if you provide an unregisterd mime type extension" do
+      expect{ Foo.add_format :hoge }.to raise_error
+    end
+
+  end
+end