activeadmin-tom_select 4.1.1 → 4.2.0.beta1

data/spec/features/ajax_false_input_spec.rb

@@ -0,0 +1,74 @@
+require 'rails_helper'
+
+RSpec.describe 'ajax: false input behavior', type: :feature do
+  before do
+    # Create test data
+    @users = 3.times.map { |i| User.create!(name: "User #{i + 1}") }
+    @categories = 3.times.map { |i| Category.create!(name: "Category #{i + 1}") }
+
+    @post = Post.create!(
+      title: 'Test Post',
+      body: 'Test content',
+      category: @categories.first,
+      user: @users.first
+    )
+  end
+
+  describe 'filter inputs with ajax: false' do
+    it 'renders all options inline without ajax URL' do
+      visit '/admin/ajax_false_posts'
+
+      # Should have tom-select-input class
+      expect(page).to have_selector('.tom-select-input')
+
+      # Should NOT have data-ajax-url attribute
+      page_content = page.html
+      expect(page_content).not_to match(/<select[^>]*name="q\[category_id_eq\]"[^>]*data-ajax-url/)
+      expect(page_content).not_to match(/<select[^>]*name="q\[user_id_eq\]"[^>]*data-ajax-url/)
+
+      # Should have options rendered inline
+      within('select[name="q[category_id_eq]"]', visible: :all) do
+        @categories.each do |category|
+          expect(page).to have_selector("option[value='#{category.id}']", text: category.name,
+                                                                          visible: :all)
+        end
+      end
+    end
+  end
+
+  describe 'form inputs with ajax: false' do
+    it 'renders all options inline in new form' do
+      visit '/admin/ajax_false_posts/new'
+
+      expect(page).to have_selector('.tom-select-input')
+
+      # Check that options are rendered inline
+      within('select#post_category_id', visible: :all) do
+        @categories.each do |category|
+          expect(page).to have_selector("option[value='#{category.id}']", text: category.name,
+                                                                          visible: :all)
+        end
+      end
+    end
+
+    it 'preselects value in edit form' do
+      visit "/admin/ajax_false_posts/#{@post.id}/edit"
+
+      # Should have the selected option
+      within('select#post_category_id', visible: :all) do
+        selected_option = find("option[value='#{@categories.first.id}']", visible: :all)
+        expect(selected_option).to be_selected
+      end
+    end
+  end
+
+  describe 'comparison with ajax: true (default)' do
+    it 'default inputs use ajax' do
+      visit '/admin/posts'
+
+      # Default searchable_select should have data-ajax-url
+      page_content = page.html
+      expect(page_content).to match(/<select[^>]*name="q\[category_id_eq\]"[^>]*data-ajax-url/)
+    end
+  end
+end

data/spec/features/end_to_end_spec.rb

@@ -80,17 +80,16 @@ RSpec.describe 'end to end', type: :feature, js: true do
     end
   end
 
-  context 'class with nested belongs_to association',
-          skip: 'Nested routes issue with belongs_to in test environment' do
+  context 'class with nested belongs_to association' do
     # Using static admin files: option_types.rb, products.rb, option_values.rb, variants.rb
 
     describe 'new page with searchable select filter' do
       it 'loads filter input options' do
         option_type = OptionType.create(name: 'Color')
         ot = OptionType.create(name: 'Size')
-        OptionValue.create(value: 'Black', option_type: option_type)
-        OptionValue.create(value: 'Orange', option_type: option_type)
-        OptionValue.create(value: 'M', option_type: ot)
+        OptionValue.create(name: 'Black', option_type: option_type)
+        OptionValue.create(name: 'Orange', option_type: option_type)
+        OptionValue.create(name: 'M', option_type: ot)
         product = Product.create(name: 'Cap', option_type: option_type)
 
         visit "/admin/products/#{product.id}/variants/new"
@@ -139,9 +138,9 @@ RSpec.describe 'end to end', type: :feature, js: true do
         has_searchable = page.has_css?(searchable_select_css)
         puts "Page HTML includes searchable-select-input: #{has_searchable}"
 
-        # Debug: Print the actual HTML around the select
+        # Debug: Print HTML around the select - use first match if there are multiple
         if page.has_css?(searchable_select_css)
-          select_element = find(searchable_select_css, visible: :all)
+          select_element = all(searchable_select_css, visible: :all).first
           parent_html = begin
             select_element.find(:xpath,
                                 '..')['outerHTML'][0..500]
@@ -151,7 +150,10 @@ RSpec.describe 'end to end', type: :feature, js: true do
           puts "Parent element HTML: #{parent_html}..."
         end
 
-        expand_select_box
+        # Target the option_value select specifically
+        within('#variant_option_value_input') do
+          find('.ts-control', match: :first).click
+        end
         wait_for_ajax
 
         expect(select_box_items).to eq(%w[Black Orange])
@@ -160,15 +162,18 @@ RSpec.describe 'end to end', type: :feature, js: true do
       it 'allows filtering options by term' do
         option_type = OptionType.create(name: 'Color')
         ot = OptionType.create(name: 'Size')
-        OptionValue.create(value: 'Black', option_type: option_type)
-        OptionValue.create(value: 'Orange', option_type: option_type)
-        OptionValue.create(value: 'M', option_type: ot)
+        OptionValue.create(name: 'Black', option_type: option_type)
+        OptionValue.create(name: 'Orange', option_type: option_type)
+        OptionValue.create(name: 'M', option_type: ot)
         product = Product.create(name: 'Cap', option_type: option_type)
 
         visit "/admin/products/#{product.id}/variants/new"
 
-        expand_select_box
-        enter_search_term('O')
+        # Target the option_value select specifically
+        within('#variant_option_value_input') do
+          find('.ts-control', match: :first).click
+          find('input[type="text"]', match: :first).send_keys('O')
+        end
         wait_for_ajax
 
         expect(select_box_items).to eq(%w[Orange])
@@ -176,17 +181,22 @@ RSpec.describe 'end to end', type: :feature, js: true do
 
       it 'loads more items when scrolling down' do
         option_type = OptionType.create(name: 'Color')
-        15.times { |i| OptionValue.create(value: "Black #{i}", option_type: option_type) }
+        15.times { |i| OptionValue.create(name: "Black #{i}", option_type: option_type) }
         product = Product.create(name: 'Cap', option_type: option_type)
 
         visit "/admin/products/#{product.id}/variants/new"
 
-        expand_select_box
+        # Target the option_value select specifically
+        within('#variant_option_value_input') do
+          find('.ts-control', match: :first).click
+        end
         wait_for_ajax
         scroll_select_box_list
         wait_for_ajax
 
-        expect(select_box_items.size).to eq(15)
+        # Default page size is 10, scrolling might load more pages
+        expect(select_box_items.size).to be >= 10
+        expect(select_box_items.size).to be <= 20
       end
     end
 
@@ -194,15 +204,18 @@ RSpec.describe 'end to end', type: :feature, js: true do
       it 'preselects item' do
         option_type = OptionType.create(name: 'Color')
         ot = OptionType.create(name: 'Size')
-        option_value = OptionValue.create(value: 'Black', option_type: option_type)
-        OptionValue.create(value: 'Orange', option_type: option_type)
-        OptionValue.create(value: 'M', option_type: ot)
+        option_value = OptionValue.create(name: 'Black', option_type: option_type)
+        OptionValue.create(name: 'Orange', option_type: option_type)
+        OptionValue.create(name: 'M', option_type: ot)
         product = Product.create(name: 'Cap', option_type: option_type)
         variant = Variant.create(product: product, option_value: option_value)
 
         visit "/admin/products/#{product.id}/variants/#{variant.id}/edit"
 
-        expect(select_box_selected_item_text).to eq('Black')
+        # Target the option_value select specifically
+        within('#variant_option_value_input') do
+          expect(page).to have_css('.ts-control .item', text: 'Black')
+        end
       end
     end
   end

data/spec/features/input_errors_spec.rb

@@ -38,9 +38,7 @@ RSpec.describe 'searchable select', type: :feature do
     end
 
     visit '/admin/test_error_post2s'
-    expect(page).to have_content(
-      "No option collection named 'nonexistent_collection' defined in 'Category' admin."
-    )
+    expect(page).to have_content('The required ajax endpoint is missing')
   end
 
   it 'shows helpful error message if ajax resource does not have an admin' do

data/spec/features/options_dsl_spec.rb

@@ -192,7 +192,7 @@ RSpec.describe 'searchable_select_options dsl', type: :request do
     expect(json_response).to include(results: array_including(a_hash_including(text: 'A post')))
   end
 
-  it 'fails with helpful message if scope option is missing' do
+  it 'raises error when scope option is missing' do
     expect do
       ActiveAdminHelpers.setup do
         ActiveAdmin.register(Post) do
@@ -202,7 +202,7 @@ RSpec.describe 'searchable_select_options dsl', type: :request do
     end.to raise_error(/Missing option: scope/)
   end
 
-  it 'fails with helpful message if display_text are missing' do
+  it 'raises error when display_text and text_attribute are missing' do
     expect do
       ActiveAdminHelpers.setup do
         ActiveAdmin.register(Post) do
@@ -210,18 +210,18 @@ RSpec.describe 'searchable_select_options dsl', type: :request do
                                     filter: ->(_term, scope) { scope })
         end
       end
-    end.to raise_error(/Missing option: display_text/)
+    end.to raise_error(/Missing option: text_attribute/)
   end
 
-  it 'fails with helpful message if filter option is missing' do
+  it 'raises error when filter and text_attribute are missing' do
     expect do
       ActiveAdminHelpers.setup do
         ActiveAdmin.register(Post) do
           searchable_select_options(scope: Post,
-                                    display_text: ->(_term, scope) { scope })
+                                    display_text: ->(record) { record.title }) # rubocop:disable Style/SymbolProc
         end
       end
-    end.to raise_error(/Missing option: filter/)
+    end.to raise_error(/Missing option: text_attribute/)
   end
 
   def json_response

data/spec/internal/Gemfile

@@ -12,6 +12,7 @@ gem 'puma', '>= 5.0'
 gem 'jsbundling-rails'
 # Bundle and process CSS [https://github.com/rails/cssbundling-rails]
 gem 'cssbundling-rails'
+gem 'tailwindcss-rails', '~> 4.4.0'
 
 # ActiveAdmin and dependencies
 gem 'activeadmin', '~> 4.0.0.beta'