activeadmin-searchable_select 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6a0f1ed4c7ca3f0b20a9a1844aa46ecf2693b5b91f447874cbfbc013d5a84e31
-  data.tar.gz: cdca70eae83da1caf578f39957b66fe30cec69a76c67f7f06d2a45bb3c680f7d
+  metadata.gz: fe0935611dac081858397d808fa99c65a72944153ce323c8b10f3afb96657a83
+  data.tar.gz: e5c1faa951288612248a1f87f4ed1961f7f45861b7ac1946a404c5f15030f656
 SHA512:
-  metadata.gz: b509e473b24b32cad8c401f197413c7b01c7de196aaf0a2a4a735f7f6bd40d4ea76ed7733f9b00f87ecf23e6d3aba0bceee599f85c4e39fb1a17639b4234d94f
-  data.tar.gz: f224c6cc6fe60af0373b1d82c9d57a43282c3f327bf5c3c295d2b1d17ce5f9aace56aa0d4320405f40783a270fedaa8137496712091fc167712b9b1e1364a029
+  metadata.gz: '097917cab8c292dcf3cdab69661ff59f6a0377698514b6f7323b28a3a70bc2c3f66c41b64a7e26ae47f981559f791d6ae35df96ec1a736f214fcd7753cd25693'
+  data.tar.gz: 10592311d0cf0ad805abaf218ce97a9af4ff8a8350b861571465e01106815d6b3eaddd9641f2256e5323e5a05a6ed7cd0759a6531cdfe5af2cf858e69affedf2

data/.rubocop.yml

@@ -1,5 +1,7 @@
 AllCops:
   TargetRubyVersion: 2.3
+  Exclude:
+    - 'bin/**/*'
 
 # The default of 80 characters is a little to narrow.
 Metrics/LineLength:

data/CHANGELOG.md

@@ -1,20 +1,16 @@
 # CHANGELOG
 
-### Version 1.3.0
+### Version 1.4.0
 
-2021-02-03
+2021-02-04
 
-[Compare changes](https://github.com/codevise/activeadmin-searchable_select/compare/1-2-stable...v1.3.0)
+[Compare changes](https://github.com/codevise/activeadmin-searchable_select/compare/1-3-stable...v1.4.0)
 
-- Add support for Ruby 3
-  ([#26](https://github.com/codevise/activeadmin-searchable_select/pull/26))
-- Add a small description of how to pass options to Select2
-  ([#27](https://github.com/codevise/activeadmin-searchable_select/pull/27))
-- Update CI Setup
-  ([#25](https://github.com/codevise/activeadmin-searchable_select/pull/25))
-- Allow Bundler 2 in development dependencies
-  ([#18](https://github.com/codevise/activeadmin-searchable_select/pull/18))
+- Support admin resources for namespaced models.
+  ([#30](https://github.com/codevise/activeadmin-searchable_select/pull/30))
+- Improve README.md
+  ([#28](https://github.com/codevise/activeadmin-searchable_select/pull/28))
 
 See
-[1-2-stable branch](https://github.com/codevise/activeadmin-searchable_select/blob/1-2-stable/CHANGELOG.md)
+[1-3-stable branch](https://github.com/codevise/activeadmin-searchable_select/blob/1-3-stable/CHANGELOG.md)
 for previous changes.

data/README.md

@@ -238,7 +238,7 @@ for feature specs:
 ```ruby
   RSpec.configure do |config|
     config.before(:each) do |example|
-      ActiveAdmin::Select2.inline_ajax_options = (example.metadata[:type] == :feature)
+      ActiveAdmin::SearchableSelect.inline_ajax_options = (example.metadata[:type] == :feature)
     end
   end
 

data/lib/activeadmin/searchable_select/select_input_extension.rb

@@ -45,9 +45,11 @@ module ActiveAdmin
 
       def ajax_url
         return unless options[:ajax]
-        template.polymorphic_path([template.active_admin_namespace.route_prefix, ajax_resource_class],
-                                  action: option_collection.collection_action_name,
-                                  **ajax_params)
+        [ajax_resource.route_collection_path,
+         '/',
+         option_collection.collection_action_name,
+         '?',
+         ajax_params.to_query].join
       end
 
       def all_options_collection

data/lib/activeadmin/searchable_select/version.rb

@@ -1,5 +1,5 @@
 module ActiveAdmin
   module SearchableSelect
-    VERSION = '1.3.0'.freeze
+    VERSION = '1.4.0'.freeze
   end
 end

data/spec/features/end_to_end_spec.rb

@@ -5,60 +5,92 @@ require 'support/capybara'
 require 'support/active_admin_helpers'
 
 RSpec.describe 'end to end', type: :feature, js: true do
-  before(:each) do
-    ActiveAdminHelpers.setup do
-      ActiveAdmin.register(Category) do
-        searchable_select_options(scope: Category, text_attribute: :name)
-      end
+  context 'class name without namespaces' do
+    before(:each) do
+      ActiveAdminHelpers.setup do
+        ActiveAdmin.register(Category) do
+          searchable_select_options(scope: Category, text_attribute: :name)
+        end
 
-      ActiveAdmin.register(Post) do
-        filter(:category, as: :searchable_select, ajax: true)
+        ActiveAdmin.register(Post) do
+          filter(:category, as: :searchable_select, ajax: true)
 
-        form do |f|
-          f.input(:category, as: :searchable_select, ajax: true)
+          form do |f|
+            f.input(:category, as: :searchable_select, ajax: true)
+          end
         end
-      end
 
-      ActiveAdmin.setup {}
+        ActiveAdmin.setup {}
+      end
     end
-  end
 
-  describe 'index page with searchable select filter' do
-    it 'loads filter input options' do
-      Category.create(name: 'Music')
-      Category.create(name: 'Travel')
+    describe 'index page with searchable select filter' do
+      it 'loads filter input options' do
+        Category.create(name: 'Music')
+        Category.create(name: 'Travel')
 
-      visit '/admin/posts'
+        visit '/admin/posts'
 
-      expand_select_box
-      wait_for_ajax
+        expand_select_box
+        wait_for_ajax
 
-      expect(select_box_items).to eq(%w(Music Travel))
-    end
+        expect(select_box_items).to eq(%w(Music Travel))
+      end
+
+      it 'allows filtering options by term' do
+        Category.create(name: 'Music')
+        Category.create(name: 'Travel')
+
+        visit '/admin/posts'
+
+        expand_select_box
+        enter_search_term('T')
+        wait_for_ajax
+
+        expect(select_box_items).to eq(%w(Travel))
+      end
+
+      it 'loads more items when scrolling down' do
+        15.times { |i| Category.create(name: "Category #{i}") }
+        visit '/admin/posts'
 
-    it 'allows filtering options by term' do
-      Category.create(name: 'Music')
-      Category.create(name: 'Travel')
+        expand_select_box
+        wait_for_ajax
+        scroll_select_box_list
+        wait_for_ajax
 
-      visit '/admin/posts'
+        expect(select_box_items.size).to eq(15)
+      end
+    end
+  end
 
-      expand_select_box
-      enter_search_term('T')
-      wait_for_ajax
+  context 'class name with namespace' do
+    before(:each) do
+      ActiveAdminHelpers.setup do
+        ActiveAdmin.register RGB::Color, as: 'color' do
+          searchable_select_options scope: RGB::Color, text_attribute: :code
+        end
 
-      expect(select_box_items).to eq(%w(Travel))
+        ActiveAdmin.register Internal::TagName, as: 'Tag Name' do
+          filter :color, as: :searchable_select, ajax: { resource: RGB::Color }
+        end
+
+        ActiveAdmin.setup {}
+      end
     end
 
-    it 'loads more items when scrolling down' do
-      15.times { |i| Category.create(name: "Category #{i}") }
-      visit '/admin/posts'
+    describe 'index page with searchable select filter' do
+      it 'loads filter input options' do
+        RGB::Color.create(code: '#eac112', description: 'Orange')
+        RGB::Color.create(code: '#19bf25', description: 'Green')
 
-      expand_select_box
-      wait_for_ajax
-      scroll_select_box_list
-      wait_for_ajax
+        visit '/admin/tag_names'
 
-      expect(select_box_items.size).to eq(15)
+        expand_select_box
+        wait_for_ajax
+
+        expect(select_box_items).to eq(%w(#eac112 #19bf25))
+      end
     end
   end
 

data/spec/internal/db/schema.rb

@@ -20,6 +20,17 @@ ActiveRecord::Schema.define do
     t.boolean :published
   end
 
+  create_table(:rgb_colors, force: true) do |t|
+    t.string :code
+    t.text :description
+  end
+
+  create_table(:internal_tag_names, force: true) do |t|
+    t.string :name
+    t.text :description
+    t.integer :color_id
+  end
+
   create_table(:users, force: true) do |t|
     t.string :name
   end

data/spec/support/models.rb

@@ -13,6 +13,20 @@ class Post < ActiveRecord::Base
   scope(:published, -> { where(published: true) })
 end
 
+module RGB
+  class Color < ActiveRecord::Base
+    self.table_name = :rgb_colors
+    has_many :tags, class_name: 'Internal::TagName'
+  end
+end
+
+module Internal
+  class TagName < ActiveRecord::Base
+    self.table_name = :internal_tag_names
+    belongs_to :color, class_name: 'RGB::Color', foreign_key: :color_id
+  end
+end
+
 RSpec.configure do |config|
   config.after do
     DatabaseCleaner.strategy = :truncation

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activeadmin-searchable_select
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Codevise Solutions Ltd
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-02-03 00:00:00.000000000 Z
+date: 2021-02-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -375,7 +375,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.0.8
 signing_key: 
 specification_version: 4
 summary: Use searchable selects based on Select2 in Active Admin forms and filters.