active_windows 0.1.4 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2b6484d037d47f4cfa292310a435491c37b03c15921159e34df31e6d69972f9f
-  data.tar.gz: 20ec937b0f30935c9d2775508c4a22e75edaa791b0e4ad4ce51bced086efa512
+  metadata.gz: b393a3c07582141b6656bbf2f9ffe55193f6fd32c3505af7875a9e6f76fec7d0
+  data.tar.gz: 7571dfc93bc77a96e495b2c74799100320e7bf6666809ceb754ec5fc64efffc9
 SHA512:
-  metadata.gz: 5abfc8d5ca03ab4bd1c8ef3f76c0919b9b4dce21b2d576ad1650d0bebc870c9f29c6944441560bed1c6a73fe3742ae7adfa25f9d6439e66723e759fa07890a1a
-  data.tar.gz: 6b195b1e5afb8b55b641208c9ebb9540b329d9a0f2de18e33ec3dcfd17acb85bf15d461bde3cb004261744289c253a8ea033311c0d3ec1edab9b184acd55fc56
+  metadata.gz: 8380c1b66b1a1a3c31f9e9c5a9035c43ff7689e499254b4bd7d9b250fbfaeb36054c8a012e49f4f84756a0a6ab8c42bf3a931bad82fda768b07556f955bdac3a
+  data.tar.gz: 92128ba7625b79177654e2f09a76f163d5901ddf2105f84174fe591d81dd020d276fdddb428d76649c0648ac7127f2bfcbee4b539c007221c74be1c6d231ae85

data/README.md

@@ -84,6 +84,19 @@ Available options:
 | `:frame` | `String` | Raw SQL frame clause (e.g. `"ROWS BETWEEN 1 PRECEDING AND 1 FOLLOWING"`) |
 | `:value` | `Symbol`, `String`, `Array` | Expression(s) passed as function arguments |
 
+### Association Names
+
+You can use `belongs_to` association names instead of foreign key columns. ActiveWindows automatically resolves them:
+
+```ruby
+# These are equivalent:
+Order.row_number.partition_by(:user).window_order(:amount).as(:rn)
+Order.row_number.partition_by(:user_id).window_order(:amount).as(:rn)
+
+# Works in the hash API too:
+Order.window(row_number: { partition: :user, order: :amount, as: :rn })
+```
+
 ### Chaining with ActiveRecord
 
 Window functions integrate naturally with standard ActiveRecord methods:

data/docs/REVIEW_AND_PLAN.md

@@ -34,6 +34,8 @@ The gem provides a fluent DSL for SQL window functions in ActiveRecord. Core fun
 - ~~**PostgreSQL CI**~~ — Added. GitHub Actions workflow tests against PostgreSQL 17 with service container.
 - ~~**MySQL CI**~~ — Added. GitHub Actions workflow tests against MySQL 8.0 with service container.
 - ~~**MySQL compatibility**~~ — Fixed. Aliases now use `klass.connection.quote_column_name` to properly quote reserved words (e.g., `rank`) with backticks on MySQL and double quotes on PostgreSQL/SQLite. Test assertions use adapter-agnostic `q()` and `col()` helpers.
+- ~~**WindowChain `order` naming collision**~~ — Fixed. Renamed to `window_order` to avoid conflict with ActiveRecord's `.order()`. WindowChain now delegates `.order()` to the relation for query-level ordering. Uses `method_missing` for full relation method coverage.
+- ~~**Association name resolution**~~ — Added. `partition_by(:user)` automatically resolves to `user_id` via `belongs_to` reflection. Works in both fluent and hash APIs. 74 tests, 355 assertions.
 
 ---
 

data/lib/active_windows/active_record_extensions.rb

@@ -72,9 +72,18 @@ module ActiveWindows
       raise ArgumentError, "wrong number of arguments (given 0, expected 1+)" if args.empty?
 
       processed = process_window_args(args)
-      arel_nodes = processed.map { |name, options| build_window_function(name, options || {}) }
 
       result = spawn
+
+      # Auto-join has_one associations referenced in partition/order
+      joins_needed = processed.flat_map do |_name, options|
+        next [] unless options.is_a?(Hash)
+        association_joins_for(options[:partition]) + association_joins_for(options[:order])
+      end.uniq
+      result = result.joins(*joins_needed) if joins_needed.any?
+
+      arel_nodes = processed.map { |name, options| build_window_function(name, options || {}) }
+
       # Ensure we keep all columns alongside the window function columns
       result = result.select(klass.arel_table[Arel.star]) if result.select_values.empty?
       result.select(*arel_nodes)
@@ -217,7 +226,30 @@ module ActiveWindows
       if name.is_a?(Arel::Nodes::Node) || name.is_a?(Arel::Nodes::SqlLiteral)
         name
       else
-        klass.arel_table[name.to_sym]
+        resolve_column(name)
+      end
+    end
+
+    def resolve_column(name)
+      name_sym = name.to_sym
+      return klass.arel_table[name_sym] if klass.column_names.include?(name.to_s)
+
+      reflection = klass.reflect_on_association(name_sym)
+      if reflection&.macro == :belongs_to
+        klass.arel_table[reflection.foreign_key.to_sym]
+      elsif reflection&.macro == :has_one
+        reflection.klass.arel_table[reflection.klass.primary_key.to_sym]
+      else
+        klass.arel_table[name_sym]
+      end
+    end
+
+    def association_joins_for(columns)
+      Array(columns).filter_map do |col|
+        next unless col.is_a?(Symbol) || col.is_a?(String)
+
+        reflection = klass.reflect_on_association(col.to_sym)
+        col.to_sym if reflection&.macro == :has_one
       end
     end
 

data/lib/active_windows/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveWindows
-  VERSION = "0.1.4"
+  VERSION = "0.1.6"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_windows
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.6
 platform: ruby
 authors:
 - Andrei Andriichuk