active_windows 0.1.3 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 40d81b47d0bf35406b6d9004f3eb82b0137b3bfc0dc5bed7e2d33b697753aeae
-  data.tar.gz: 11897b5353a3c8b993922c7af8a4819964d417640bce9501182b145750051144
+  metadata.gz: 03e84e2dfa5e33f68986b9d63c7875e490ceaaab2f8e1a50a9974c42f883d1b5
+  data.tar.gz: e2565adc58e0a2ccc236970baa804ede27522ce6d3688131bc5a23554cde71e1
 SHA512:
-  metadata.gz: 3b858116cd6290e77e23c5688336102efd83a234bb2caca193728e9b9458a91591fe0653420f5cc400238603921f86e472d3d92ab4028342e4ad9eb2396b4d2e
-  data.tar.gz: 3974f6c3a73e2efbbb6aeb603c2ab4ddfd65a88eb23d10353fe94ef50746f38fc4c5c7abceec862f2eb53e8b26f710d3a7b9e274f3889132d83c48874d984e3d
+  metadata.gz: 375915ceb4ff9845df08d952bf6e6e48f9e46e07ae4a7857dbca78ea698b7f5025ee634254fd5d8d03c7a7810df4c5ece16406864b4feba8604d7ce98b336770
+  data.tar.gz: 0c4df8c117ab1f49b08bb16f3e7573d2600339ff26bc64bea6f2d42aa3ae5e419ebd4c33e8c833f8e057d919f10ebaf6f0f1713e0077603fb40d5e6cb6b5da93

data/README.md

@@ -84,6 +84,19 @@ Available options:
 | `:frame` | `String` | Raw SQL frame clause (e.g. `"ROWS BETWEEN 1 PRECEDING AND 1 FOLLOWING"`) |
 | `:value` | `Symbol`, `String`, `Array` | Expression(s) passed as function arguments |
 
+### Association Names
+
+You can use `belongs_to` association names instead of foreign key columns. ActiveWindows automatically resolves them:
+
+```ruby
+# These are equivalent:
+Order.row_number.partition_by(:user).window_order(:amount).as(:rn)
+Order.row_number.partition_by(:user_id).window_order(:amount).as(:rn)
+
+# Works in the hash API too:
+Order.window(row_number: { partition: :user, order: :amount, as: :rn })
+```
+
 ### Chaining with ActiveRecord
 
 Window functions integrate naturally with standard ActiveRecord methods:

data/docs/REVIEW_AND_PLAN.md

@@ -34,6 +34,8 @@ The gem provides a fluent DSL for SQL window functions in ActiveRecord. Core fun
 - ~~**PostgreSQL CI**~~ — Added. GitHub Actions workflow tests against PostgreSQL 17 with service container.
 - ~~**MySQL CI**~~ — Added. GitHub Actions workflow tests against MySQL 8.0 with service container.
 - ~~**MySQL compatibility**~~ — Fixed. Aliases now use `klass.connection.quote_column_name` to properly quote reserved words (e.g., `rank`) with backticks on MySQL and double quotes on PostgreSQL/SQLite. Test assertions use adapter-agnostic `q()` and `col()` helpers.
+- ~~**WindowChain `order` naming collision**~~ — Fixed. Renamed to `window_order` to avoid conflict with ActiveRecord's `.order()`. WindowChain now delegates `.order()` to the relation for query-level ordering. Uses `method_missing` for full relation method coverage.
+- ~~**Association name resolution**~~ — Added. `partition_by(:user)` automatically resolves to `user_id` via `belongs_to` reflection. Works in both fluent and hash APIs. 74 tests, 355 assertions.
 
 ---
 

data/lib/active_windows/active_record_extensions.rb

@@ -44,11 +44,24 @@ module ActiveWindows
       @relation.window(to_window_hash)
     end
 
-    # Delegate common relation/query methods so the chain is transparent
-    delegate :to_sql, :to_a, :to_ary, :load, :loaded?, :each, :map, :first, :last, :count,
-             :where, :select, :joins, :group, :having, :order, :limit, :offset, :reorder, :pluck,
-             :find_each, :find_in_batches, :inspect, :exists?, :any?, :none?, :empty?,
-             to: :to_relation
+    # Delegate to the materialized relation so the chain is transparent.
+    # Explicit delegates for Ruby protocol methods that must be defined eagerly.
+    delegate :to_sql, :to_a, :to_ary, :inspect, to: :to_relation
+
+    private
+
+    def method_missing(method, ...)
+      relation = to_relation
+      if relation.respond_to?(method)
+        relation.public_send(method, ...)
+      else
+        super
+      end
+    end
+
+    def respond_to_missing?(method, include_private = false)
+      to_relation.respond_to?(method, include_private) || super
+    end
   end
 
   module QueryMethods
@@ -204,10 +217,20 @@ module ActiveWindows
       if name.is_a?(Arel::Nodes::Node) || name.is_a?(Arel::Nodes::SqlLiteral)
         name
       else
-        klass.arel_table[name.to_sym]
+        klass.arel_table[resolve_column_name(name)]
       end
     end
 
+    def resolve_column_name(name)
+      name_sym = name.to_sym
+      return name_sym if klass.column_names.include?(name.to_s)
+
+      reflection = klass.reflect_on_association(name_sym)
+      return reflection.foreign_key.to_sym if reflection&.macro == :belongs_to
+
+      name_sym
+    end
+
     def arel_order(expr)
       case expr
       when Arel::Nodes::Node, Arel::Nodes::SqlLiteral

data/lib/active_windows/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveWindows
-  VERSION = "0.1.3"
+  VERSION = "0.1.5"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_windows
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.5
 platform: ruby
 authors:
 - Andrei Andriichuk