active_version 1.0.1 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4636e51affa996a3f7c8cd98f32e05d6d1892ffe2dc3a79b58edb17bde8619f4
-  data.tar.gz: 42b4f546aeec443faf25d9d3b039ed515499f6b9284b520792afd4af711a721e
+  metadata.gz: fc38a55e873e8ea603bef6bb4bb15350b03582214fc1a48856a05cb35498b845
+  data.tar.gz: 34f0c43fb603e0109729c2254ae6d7ee1f95f14f56f3a0b408ffdb1429efdb48
 SHA512:
-  metadata.gz: b78b064c4a79a1d1ce1780de50e009116e2e0864c25323745f6596385d197d058cc7c4a08bc58f07a7ff7addc678415482d7011698f1114da920b3f282498cc0
-  data.tar.gz: 3b35459213700a318435ea787706e6565dfa6c95e311fa7e0f3ef7ad39206f9330b465791cc074be818f1b045e60c154d6d188d1385a4aa54bb81cd0b9daef3f
+  metadata.gz: e13a251346e48e51c617961f433f7384f4cb1dce283f41b1cda977180feb1a116a83a83bf39e241bf15d5f7f67daa926dacb19774ee6c496981e9fbc6c49efb7
+  data.tar.gz: 0cd3cfe32df95ac78d6591f5127f1a44c340cb69238b77471029fb5827c4d3c946a44c62b7734fe065bbe75db208162b206919254e4ad33addf5f4a3dab39b2c

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # CHANGELOG
 
+## 1.2.0 (2026-03-27)
+
+- Fixed SQL generation for audit creation to avoid duplicate `created_at` and `updated_at` columns (or other possible duplicate columns)
+
+## 1.1.0 (2026-03-27)
+
+- Added `audit_auditable_optional` configuration option to control polymorphic `belongs_to :auditable` optionality
+
 ## 1.0.1 (2026-03-11)
 
 - Fixed Rails 7.2 thread-local audited options handling in `with_audited_options`

data/README.md

@@ -182,6 +182,8 @@ end
 
 ### Destination Audit Model Configuration (Preferred)
 
+The gem defines `belongs_to :auditable` (or your configured column) once, with `optional: false` by default (see `config.audit_auditable_optional`). Set `config.audit_auditable_optional = true` if `auditable_id` is composite or synthetic so polymorphic `load` may not resolve even when columns are valid. Do not re-declare `belongs_to :auditable` in subclasses to tweak options, that can leave duplicate validators from Rails. For presence checks without relying on association load, validate `auditable_type` and `auditable_id` explicitly.
+
 ```ruby
 class PostAudit < ApplicationRecord
   include ActiveVersion::Audits::AuditRecord

data/lib/active_version/audits/audit_record.rb

@@ -135,7 +135,12 @@ module ActiveVersion
             # Set up polymorphic association only when conventional id/type columns exist.
             auditable_column = ActiveVersion.column_mapper.column_for(source_class, :audits, :auditable)
             if column_names.include?("#{auditable_column}_id") && column_names.include?("#{auditable_column}_type")
-              send(:belongs_to, auditable_column, polymorphic: true)
+              send(
+                :belongs_to,
+                auditable_column,
+                polymorphic: true,
+                optional: ActiveVersion.config.audit_auditable_optional
+              )
             end
 
             # Set up user association (if configured)

data/lib/active_version/audits/has_audits/change_filters.rb

@@ -104,11 +104,15 @@ module ActiveVersion
         end
 
         def prepare_sql_values(changes)
-          changes.each_with_object({}) do |(k, v), h|
-            h[k] = v.last if v.is_a?(Array)
-            h[k] = v unless v.is_a?(Array)
-            h[k] = JSON.generate(h[k]) if h[k].is_a?(Hash) || h[k].is_a?(Array)
+          h = changes.each_with_object({}) do |(k, v), acc|
+            acc[k] = v.last if v.is_a?(Array)
+            acc[k] = v unless v.is_a?(Array)
+            acc[k] = JSON.generate(acc[k]) if acc[k].is_a?(Hash) || acc[k].is_a?(Array)
           end
+          # Arel INSERT uses keys as column names; stringify so :action / mirror :attrs match
+          # string keys from column_mapper and so symbol + string for the same column cannot
+          # both appear (PG::DuplicateColumn).
+          h.transform_keys(&:to_s)
         end
       end
     end

data/lib/active_version/configuration.rb

@@ -26,6 +26,7 @@ module ActiveVersion
     attr_accessor :audit_version_column
     attr_accessor :audit_user_column
     attr_accessor :audit_auditable_column
+    attr_accessor :audit_auditable_optional
     attr_accessor :audit_associated_column
     attr_accessor :audit_remote_address_column
     attr_accessor :audit_request_uuid_column
@@ -64,6 +65,7 @@ module ActiveVersion
       @audit_version_column = :version
       @audit_user_column = :user_id
       @audit_auditable_column = :auditable
+      @audit_auditable_optional = false
       @audit_associated_column = :associated
       @audit_remote_address_column = :remote_address
       @audit_request_uuid_column = :request_uuid

data/lib/active_version/version.rb

@@ -1,3 +1,3 @@
 module ActiveVersion
-  VERSION = "1.0.1"
+  VERSION = "1.2.0"
 end

data/lib/generators/active_version/install/templates/initializer.rb.erb

@@ -31,6 +31,10 @@ ActiveVersion.configure do |config|
   config.audit_remote_address_column = :remote_address
   config.audit_request_uuid_column = :request_uuid
 
+  # Polymorphic belongs_to :auditable uses optional: false by default. Set true if
+  # auditable_id is composite / synthetic and Rails' must-exist validation is wrong for your app.
+  # config.audit_auditable_optional = true
+
   # Infrastructure note:
   # Connection routing / connection topology / partition lifecycle are application-owned.
   # ActiveVersion reads/writes using the active ActiveRecord connection.

data/sig/active_version/configuration.rbs

@@ -21,6 +21,7 @@ module ActiveVersion
     attr_accessor audit_version_column: Symbol | String
     attr_accessor audit_user_column: Symbol | String
     attr_accessor audit_auditable_column: Symbol | String
+    attr_accessor audit_auditable_optional: bool
     attr_accessor audit_associated_column: Symbol | String
     attr_accessor audit_remote_address_column: Symbol | String
     attr_accessor audit_request_uuid_column: Symbol | String

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_version
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.2.0
 platform: ruby
 authors:
 - Andrei Makarov