active_validation 2.6.0 → 3.0.0

data/lib/active_validation/validators/email_validator.rb

@@ -2,7 +2,7 @@ class EmailValidator < ActiveModel::EachValidator
 
   def validate_each(record, attribute, value)
     unless valid?(value.to_s, options)
-      record.errors[attribute] << (options.fetch(:message, false) || I18n.t('active_validation.errors.messages.email'.freeze))
+      record.errors[attribute] << options.fetch(:message, I18n.t("active_validation.errors.messages.email"))
     end
   end
 
@@ -21,9 +21,9 @@ class EmailValidator < ActiveModel::EachValidator
   end
 
   def valid?(value, options)
-    valid_length?(value) &&
-    valid_format?(value) &&
-    valid_domain?(value, [*(options.fetch(:domain, nil))])
+    options = [*(options.fetch(:domain, nil))]
+
+    valid_length?(value) && valid_format?(value) && valid_domain?(value, options)
   end
 
-end
+end

data/lib/active_validation/validators/equality_validator.rb

@@ -7,28 +7,24 @@ class EqualityValidator < ActiveModel::EachValidator
         "ArgumentError: missing ':to' attribute for comparison."
     end
 
-    operator  = options.fetch(:operator, nil)
+    operator = options.fetch(:operator, nil)
     operators = OPERATORS.keys
     unless operators.include?(operator)
       raise ArgumentError,
-        "Unknown operator: #{operator.inspect}. Valid operators are: #{operators.map(&:inspect).join(', '.freeze)}"
+        "Unknown operator: #{operator.inspect}. Valid operators are: #{operators.map(&:inspect).join(", ")}"
     end
-    operator  = OPERATORS.fetch(operator)
+    operator = OPERATORS.fetch(operator)
 
-    unless value.send(operator.to_sym, record.send(to.to_sym))
-      record.errors[attribute] << (options.fetch(:message, false) || I18n.t('active_validation.errors.messages.equality'.freeze, attr: to, operator: operator))
+    unless value.send(operator, record.send(to))
+      record.errors[attribute] << options.fetch(:message, I18n.t("active_validation.errors.messages.equality", attr: to, operator: operator))
     end
   end
 
   private
 
   OPERATORS = {
-    less_than: :<,
-    less_than_or_equal_to: :<=,
-    greater_than: :>,
-    greater_than_or_equal_to: :>=,
-    equal_to: :==,
-    not_equal_to: :!=
-  }.freeze
+    less_than: :<, less_than_or_equal_to: :<=, greater_than: :>,
+    greater_than_or_equal_to: :>=, equal_to: :==, not_equal_to: :!=
+  }
 
-end
+end

data/lib/active_validation/validators/hex_validator.rb

@@ -2,7 +2,7 @@ class HexValidator < ActiveModel::EachValidator
 
   def validate_each(record, attribute, value)
     unless valid?(value.to_s)
-      record.errors[attribute] << (options.fetch(:message, false) || I18n.t('active_validation.errors.messages.hex'.freeze))
+      record.errors[attribute] << options.fetch(:message, I18n.t("active_validation.errors.messages.hex"))
     end
   end
 
@@ -17,8 +17,7 @@ class HexValidator < ActiveModel::EachValidator
   end
 
   def valid?(value)
-    valid_length?(value) &&
-    valid_format?(value)
+    valid_length?(value) && valid_format?(value)
   end
 
-end
+end

data/lib/active_validation/validators/imei_validator.rb

@@ -2,7 +2,7 @@ class ImeiValidator < ActiveModel::EachValidator
 
   def validate_each(record, attribute, value)
     unless valid?(value.to_s)
-      record.errors[attribute] << (options.fetch(:message, false) || I18n.t('active_validation.errors.messages.imei'.freeze))
+      record.errors[attribute] << options.fetch(:message, I18n.t("active_validation.errors.messages.imei"))
     end
   end
 
@@ -17,23 +17,21 @@ class ImeiValidator < ActiveModel::EachValidator
   end
 
   def valid_luhn?(value)
-    number = value.gsub(/\D/, ''.freeze).reverse
+    number = value.gsub(/\D/, "").reverse
 
     total = 0
-    number.chars.lazy.each_with_index do |c, i|
+    number.chars.each_with_index do |c, i|
       result = c.to_i
       result *= 2 if i.odd?
       result = (1 + (result - 10)) if (result >= 10)
-      total  += result
+      total += result
     end
 
     (total % 10).zero?
   end
 
   def valid?(value)
-    valid_length?(value) &&
-    valid_format?(value) &&
-    valid_luhn?(value)
+    valid_length?(value) && valid_format?(value) && valid_luhn?(value)
   end
 
-end
+end

data/lib/active_validation/validators/ip_validator.rb

@@ -2,7 +2,7 @@ class IpValidator < ActiveModel::EachValidator
 
   def validate_each(record, attribute, value)
     unless valid?(value.to_s)
-      record.errors[attribute] << (options.fetch(:message, false) || I18n.t('active_validation.errors.messages.ip'.freeze))
+      record.errors[attribute] << options.fetch(:message, I18n.t("active_validation.errors.messages.ip"))
     end
   end
 
@@ -17,8 +17,7 @@ class IpValidator < ActiveModel::EachValidator
   end
 
   def valid?(value)
-    valid_length?(value) &&
-    valid_format?(value)
+    valid_length?(value) && valid_format?(value)
   end
 
-end
+end

data/lib/active_validation/validators/isbn_validator.rb

@@ -2,18 +2,19 @@ class IsbnValidator < ActiveModel::EachValidator
 
   def validate_each(record, attribute, value)
     unless valid?(value.to_s)
-      record.errors[attribute] << (options.fetch(:message, false) || I18n.t('active_validation.errors.messages.isbn'.freeze))
+      record.errors[attribute] << options.fetch(:message, I18n.t("active_validation.errors.messages.isbn"))
     end
   end
 
   private
 
+  CHARS_VALUES = ["0", "1", "2" , "3", "4", "5", "6", "7", "8", "9", "0", "x"]
+
   def valid_format?(value)
-    value = ''.freeze if value.blank?
-    value = value.gsub(/-| /, ''.freeze).downcase.chars
+    return(false) if value.empty?
+    value = value.gsub(/-| /, "").downcase.chars
 
-    [10, 13].freeze.include?(value.size) &&
-    value.all? { |c| ['0', '1', '2' , '3', '4', '5', '6', '7', '8', '9', '0', 'x'].freeze.include?(c) }
+    [10, 13].include?(value.size) && value.all? { |c| CHARS_VALUES.include?(c) }
   end
 
   def valid_length?(value)
@@ -21,8 +22,7 @@ class IsbnValidator < ActiveModel::EachValidator
   end
 
   def valid?(value)
-    valid_length?(value) &&
-    valid_format?(value)
+    valid_length?(value) && valid_format?(value)
   end
 
-end
+end

data/lib/active_validation/validators/isin_validator.rb

@@ -2,23 +2,27 @@ class IsinValidator < ActiveModel::EachValidator
 
   def validate_each(record, attribute, value)
     unless valid?(value.to_s)
-      record.errors[attribute] << (options.fetch(:message, false) || I18n.t('active_validation.errors.messages.isin'.freeze))
+      record.errors[attribute] << options.fetch(:message, I18n.t("active_validation.errors.messages.isin"))
     end
   end
 
   private
 
   def valid_checksum?(value)
-    characters  = value.chars
-    digits      = characters.map { |c| c.match(/[A-Z]/) ? (c.ord - 55) : c.to_i }
-    even_values = digits.values_at(* digits.each_index.select { |i| i.even? })
-    odd_values  = digits.values_at(* digits.each_index.select { |i| i.odd? })
-
-    longest, shortest = (even_values.last == characters.map(&:to_i)) ? [even_values, odd_values] : [odd_values, even_values]
+    characters = value.chars
+    digits = characters.map { |c| c.match(/[A-Z]/) ? (c.ord - 55) : c.to_i }
+    even_values = digits.values_at(*digits.each_index.select { |i| i.even? })
+    odd_values = digits.values_at(*digits.each_index.select { |i| i.odd? })
+
+    longest, shortest = if even_values.last == characters.map(&:to_i)
+      [even_values, odd_values]
+    else
+      [odd_values, even_values]
+    end
 
     longest = longest.map { |i| i * 2 }
-    values  = longest.concat(shortest).to_s.scan(/./).map(&:to_i)
-    total   = values.inject(&:+)
+    values = longest.concat(shortest).to_s.scan(/./).map(&:to_i)
+    total = values.inject(&:+)
 
     (10 - (total % 10)) % 10
   end
@@ -32,9 +36,7 @@ class IsinValidator < ActiveModel::EachValidator
   end
 
   def valid?(value)
-    valid_length?(value) &&
-    valid_format?(value) &&
-    valid_checksum?(value)
+    valid_length?(value) && valid_format?(value) && valid_checksum?(value)
   end
 
-end
+end

data/lib/active_validation/validators/mac_address_validator.rb

@@ -2,24 +2,21 @@ class MacAddressValidator < ActiveModel::EachValidator
 
   def validate_each(record, attribute, value)
     unless valid?(value.to_s)
-      record.errors[attribute] << (options.fetch(:message, false) || I18n.t('active_validation.errors.messages.mac_address'.freeze))
+      record.errors[attribute] << options.fetch(:message, I18n.t("active_validation.errors.messages.mac_address"))
     end
   end
 
   private
 
   DEFAULT_FORMATS = [
-    /^([\h]{2}:){5}[\h]{2}?$/i,
-    /^([\h]{2}[-|\.|\s]){5}[\h]{2}?$/i,
-    /^([\h]{6})[-|\.][\h]{6}?$/i,
-    /^([\h]{6}):[\h]{6}?$/i,
-    /^([\h]{4}[-|\.|\s]){2}[\h]{4}?$/i,
-    /^[\h]{12}?$/i
-  ].freeze
+    /^([\h]{2}:){5}[\h]{2}?$/i, /^([\h]{2}[-|\.|\s]){5}[\h]{2}?$/i,
+    /^([\h]{6})[-|\.][\h]{6}?$/i, /^([\h]{6}):[\h]{6}?$/i,
+    /^([\h]{4}[-|\.|\s]){2}[\h]{4}?$/i, /^[\h]{12}?$/i
+  ]
 
   def valid_format?(value)
     result = false
-    DEFAULT_FORMATS.lazy.each { |p| break if result = (value =~ p) }
+    DEFAULT_FORMATS.each { |p| break if result = (value =~ p) }
     result
   end
 
@@ -28,8 +25,7 @@ class MacAddressValidator < ActiveModel::EachValidator
   end
 
   def valid?(value)
-    valid_length?(value) &&
-    valid_format?(value)
+    valid_length?(value) && valid_format?(value)
   end
 
-end
+end

data/lib/active_validation/validators/name_validator.rb

@@ -2,14 +2,14 @@ class NameValidator < ActiveModel::EachValidator
 
   def validate_each(record, attribute, value)
     unless valid?(value.to_s)
-      record.errors[attribute] << (options.fetch(:message, false) || I18n.t('active_validation.errors.messages.name'.freeze))
+      record.errors[attribute] << options.fetch(:message, I18n.t("active_validation.errors.messages.name"))
     end
   end
 
   private
 
   def valid_format?(value)
-    value =~ /\A([a-zA-Z'-]+\s+){1,4}[a-zA-Z'-]*\z/i
+    value =~ /\A([a-zA-Z"-]+\s+){1,4}[a-zA-Z"-]*\z/i
   end
 
   def valid_length?(value)
@@ -17,8 +17,7 @@ class NameValidator < ActiveModel::EachValidator
   end
 
   def valid?(value)
-    valid_length?(value) &&
-    valid_format?(value)
+    valid_length?(value) && valid_format?(value)
   end
 
-end
+end

data/lib/active_validation/validators/password_validator.rb

@@ -2,7 +2,7 @@ class PasswordValidator < ActiveModel::EachValidator
 
   def validate_each(record, attribute, value)
     unless valid?(value.to_s, options)
-      record.errors[attribute] << (options.fetch(:message, false) || I18n.t('active_validation.errors.messages.password'.freeze))
+      record.errors[attribute] << options.fetch(:message, I18n.t("active_validation.errors.messages.password"))
     end
   end
 
@@ -17,8 +17,7 @@ class PasswordValidator < ActiveModel::EachValidator
   end
 
   def valid?(value, options)
-    valid_length?(value) &&
-    valid_format?(value, options)
+    valid_length?(value) && valid_format?(value, options)
   end
 
-end
+end

data/lib/active_validation/validators/phone_validator.rb

@@ -2,7 +2,7 @@ class PhoneValidator < ActiveModel::EachValidator
 
   def validate_each(record, attribute, value)
     unless valid?(value.to_s)
-      record.errors[attribute] << (options.fetch(:message, false) || I18n.t('active_validation.errors.messages.phone'.freeze))
+      record.errors[attribute] << options.fetch(:message, I18n.t("active_validation.errors.messages.phone"))
     end
   end
 
@@ -17,8 +17,7 @@ class PhoneValidator < ActiveModel::EachValidator
   end
 
   def valid?(value)
-    valid_length?(value) &&
-    valid_format?(value)
+    valid_length?(value) && valid_format?(value)
   end
 
-end
+end

data/lib/active_validation/validators/sedol_validator.rb

@@ -2,18 +2,18 @@ class SedolValidator < ActiveModel::EachValidator
 
   def validate_each(record, attribute, value)
     unless valid?(value.to_s)
-      record.errors[attribute] << (options.fetch(:message, false) || I18n.t('active_validation.errors.messages.sedol'.freeze))
+      record.errors[attribute] << options.fetch(:message, I18n.t("active_validation.errors.messages.sedol"))
     end
   end
 
   private
 
   def valid_checksum?(value)
-    digits  = value.chars.map { |d| d.match(/[A-Z]/) ? (d.ord - 55) : d.to_i }
-    weights = [1, 3, 1, 7, 3, 9, 1].freeze
+    digits = value.chars.map { |d| d.match(/[A-Z]/) ? (d.ord - 55) : d.to_i }
+    weights = [1, 3, 1, 7, 3, 9, 1]
 
     total = 0
-    digits.lazy.each_with_index { |d, i| total += (weights[i] * d) }
+    digits.each_with_index { |d, i| total += (weights[i] * d) }
 
     (10 - total % 10) % 10
   end
@@ -27,9 +27,7 @@ class SedolValidator < ActiveModel::EachValidator
   end
 
   def valid?(value)
-    valid_length?(value) &&
-    valid_format?(value) &&
-    valid_checksum?(value)
+    valid_length?(value) && valid_format?(value) && valid_checksum?(value)
   end
 
-end
+end

data/lib/active_validation/validators/slug_validator.rb

@@ -2,7 +2,7 @@ class SlugValidator < ActiveModel::EachValidator
 
   def validate_each(record, attribute, value)
     unless valid?(value.to_s)
-      record.errors[attribute] << (options.fetch(:message, false) || I18n.t('active_validation.errors.messages.slug'.freeze))
+      record.errors[attribute] << options.fetch(:message, I18n.t("active_validation.errors.messages.slug"))
     end
   end
 
@@ -17,8 +17,7 @@ class SlugValidator < ActiveModel::EachValidator
   end
 
   def valid?(value)
-    valid_length?(value) &&
-    valid_format?(value)
+    valid_length?(value) && valid_format?(value)
   end
 
-end
+end

data/lib/active_validation/validators/ssn_validator.rb

@@ -2,7 +2,7 @@ class SsnValidator < ActiveModel::EachValidator
 
   def validate_each(record, attribute, value)
     unless valid?(value.to_s)
-      record.errors[attribute] << (options.fetch(:message, false) || I18n.t('active_validation.errors.messages.ssn'.freeze))
+      record.errors[attribute] << options.fetch(:message, I18n.t("active_validation.errors.messages.ssn"))
     end
   end
 
@@ -17,8 +17,7 @@ class SsnValidator < ActiveModel::EachValidator
   end
 
   def valid?(value)
-    valid_length?(value) &&
-    valid_format?(value)
+    valid_length?(value) && valid_format?(value)
   end
 
-end
+end

data/lib/active_validation/validators/tracking_number_validator.rb

@@ -2,32 +2,28 @@ class TrackingNumberValidator < ActiveModel::EachValidator
 
   def validate_each(record, attribute, value)
     unless valid?(value.to_s, options)
-      record.errors[attribute] << (options.fetch(:message, false) || I18n.t('active_validation.errors.messages.tracking_number'.freeze))
+      record.errors[attribute] << options.fetch(:message, I18n.t("active_validation.errors.messages.tracking_number"))
     end
   end
 
   private
 
   DEFAULT_CARRIERS_AND_SERVICES = {
-    dhl: {
-      express:     /^([0-9]{9,9})([0-9])$/,
-      express_air: /^([0-9]{10,10})([0-9])$/
-    },
-    fedex:  {
-      express:    /^([0-9]{11,11})([0-9])$/,
-      ground:     /^([0-9]{14,14})([0-9])$/,
-      ground18:   /^[0-9]{2,2}([0-9]{15,15})([0-9])$/,
-      ground96:   /^96[0-9]{5,5}([0-9]{14,14})([0-9])$/,
+    dhl: { express: /^([0-9]{9,9})([0-9])$/, express_air: /^([0-9]{10,10})([0-9])$/ },
+    fedex: {
+      express: /^([0-9]{11,11})([0-9])$/, ground: /^([0-9]{14,14})([0-9])$/,
+      ground18: /^[0-9]{2,2}([0-9]{15,15})([0-9])$/,
+      ground96: /^96[0-9]{5,5}([0-9]{14,14})([0-9])$/,
       smart_post: /^((?:92)?[0-9]{5}[0-9]{14})([0-9])$/
     },
     ontrac: { express: /^(C[0-9]{13,13})([0-9])$/ },
-    ups:    { express: /^1Z(\w{15,15})(\w)$/ },
-    usps:   {
+    ups: { express: /^1Z(\w{15,15})(\w)$/ },
+    usps: {
       usps13: /^([A-Z]{2,2})([0-9]{9,9})([A-Z]{2,2})$/,
       usps20: /^([0-9]{2,2})([0-9]{9,9})([0-9]{8,8})([0-9])$/,
       usps91: /^(?:420\d{5})?(9[1-5](?:[0-9]{19}|[0-9]{23}))([0-9])$/
     }
-  }.freeze
+  }
 
   # DHL
   DEFAULT_CARRIERS_AND_SERVICES.fetch(:dhl).each do |service, pattern|
@@ -50,26 +46,26 @@ class TrackingNumberValidator < ActiveModel::EachValidator
     sequence, check_digit = formula
 
     total = 0
-    sequence.chars.zip([3, 1, 7, 3, 1, 7, 3, 1, 7, 3, 1].freeze).lazy.each do |(char1, char2)|
+    sequence.chars.zip([3, 1, 7, 3, 1, 7, 3, 1, 7, 3, 1]).each do |char1, char2|
       total += (char1.to_i * char2)
     end
 
     (total % 11 % 10) == check_digit.to_i
   end
 
-  DEFAULT_CARRIERS_AND_SERVICES.fetch(:fedex).only(:ground, :ground18, :ground96).each_with_index do |(service, pattern), i|
+  DEFAULT_CARRIERS_AND_SERVICES.fetch(:fedex).select { |k, v| [:ground, :ground18, :ground96].include?(k) }.each_with_index do |(service, pattern), i|
     define_method("valid_fedex_#{service}_checksum?") do |value|
-      return(false) unless value.size == [15, 18, 22].freeze.at(i)
+      return(false) unless value.size == [15, 18, 22].at(i)
 
       formula = value.scan(pattern).flatten.compact
       return(false) if formula.empty?
       sequence, check_digit = formula
 
       total = 0
-      sequence.chars.reverse.lazy.each_with_index do |character, i|
+      sequence.chars.reverse.each_with_index do |character, i|
         result = character.to_i
         result *= 3 if i.even?
-        total  += result
+        total += result
       end
 
       check = total % 10
@@ -88,10 +84,10 @@ class TrackingNumberValidator < ActiveModel::EachValidator
     sequence, check_digit = formula
 
     total = 0
-    sequence.chars.reverse.lazy.each_with_index do |character, i|
+    sequence.chars.reverse.each_with_index do |character, i|
       result = character.to_i
       result *= 3 if i.even?
-      total  += result
+      total += result
     end
 
     check = total % 10
@@ -100,20 +96,20 @@ class TrackingNumberValidator < ActiveModel::EachValidator
   end
 
   # Ontrac & UPS
-  DEFAULT_CARRIERS_AND_SERVICES.only(:ontrac, :ups).each_with_index do |(carrier, services), i|
+  DEFAULT_CARRIERS_AND_SERVICES.select { |k, v| [:ontrac, :ups].include?(k) }.each_with_index do |(carrier, services), i|
     services.each do |service, pattern|
       define_method("valid_#{carrier}_#{service}_checksum?") do |value|
-        return(false) unless value.size == [15, 18].freeze.at(i)
+        return(false) unless value.size == [15, 18].at(i)
 
         formula = value.scan(pattern).flatten.compact
         return(false) if formula.empty?
         sequence, check_digit = formula
 
         total = 0
-        sequence.chars.lazy.each_with_index do |character, i|
+        sequence.chars.each_with_index do |character, i|
           result = character[/[0-9]/] ? character.to_i : ((character[0].ord - 3) % 10)
           result *= 2 if i.odd?
-          total  += result
+          total += result
         end
 
         check = total % 10
@@ -127,24 +123,22 @@ class TrackingNumberValidator < ActiveModel::EachValidator
   def valid_usps_usps13_checksum?(value)
     return(false) unless value.size == 13
 
-    pattern  = DEFAULT_CARRIERS_AND_SERVICES.fetch(:usps).fetch(:usps13)
+    pattern = DEFAULT_CARRIERS_AND_SERVICES.fetch(:usps).fetch(:usps13)
     sequence = value.scan(pattern).flatten.compact
     return(false) if sequence.empty?
 
-    characters  = sequence[1].chars
+    characters = sequence[1].chars
     check_digit = characters.pop.to_i
 
     total = 0
-    characters.zip([8, 6, 4, 2, 3, 5, 9, 7].freeze).lazy.each do |pair|
+    characters.zip([8, 6, 4, 2, 3, 5, 9, 7]).each do |pair|
       total += (pair[0].to_i * pair[1].to_i)
     end
 
     remainder = total % 11
-    check     = case remainder
-    when 1
-      0
-    when 0
-      5
+    check = case remainder
+    when 1 then 0;
+    when 0 then 5;
     else
       11 - remainder
     end
@@ -155,18 +149,18 @@ class TrackingNumberValidator < ActiveModel::EachValidator
   def valid_usps_usps20_checksum?(value)
     return(false) unless value.size == 20
 
-    pattern  = DEFAULT_CARRIERS_AND_SERVICES.fetch(:usps).fetch(:usps20)
+    pattern = DEFAULT_CARRIERS_AND_SERVICES.fetch(:usps).fetch(:usps20)
     sequence = value.scan(pattern).flatten.compact
     return(false) if sequence.empty?
 
-    characters  = sequence.first(3).join.chars
+    characters = sequence.first(3).join.chars
     check_digit = sequence.last.to_i
 
     total = 0
-    characters.reverse.lazy.each_with_index do |character, i|
+    characters.reverse.each_with_index do |character, i|
       result = character.to_i
       result *= 3 if i.even?
-      total  += result
+      total += result
     end
 
     check = total % 10
@@ -178,18 +172,18 @@ class TrackingNumberValidator < ActiveModel::EachValidator
     value = "91#{value}" unless value =~ /^(420\d{5})?9[1-5]/
     return(false) unless value.size == 22
 
-    pattern  = DEFAULT_CARRIERS_AND_SERVICES.fetch(:usps).fetch(:usps91)
+    pattern = DEFAULT_CARRIERS_AND_SERVICES.fetch(:usps).fetch(:usps91)
     sequence = value.scan(pattern).flatten.compact
     return(false) if sequence.empty?
 
-    characters  = sequence.first.chars
+    characters = sequence.first.chars
     check_digit = sequence.last.to_i
 
     total = 0
-    characters.reverse.lazy.each_with_index do |character, i|
+    characters.reverse.each_with_index do |character, i|
       result = character.to_i
       result *= 3 if i.even?
-      total  += result
+      total += result
     end
 
     check = total % 10
@@ -199,9 +193,9 @@ class TrackingNumberValidator < ActiveModel::EachValidator
 
   # Base
   def valid_checksum?(value, options)
-    carrier = options[:carrier]
-    service = options[:service]
-    result  = false
+    carrier = options.fetch(:carrier, nil)
+    service = options.fetch(:service, nil)
+    result = false
 
     if carrier.nil? && service.nil?
       DEFAULT_CARRIERS_AND_SERVICES.each do |carrier, services|
@@ -228,8 +222,7 @@ class TrackingNumberValidator < ActiveModel::EachValidator
   end
 
   def valid?(value, options)
-    valid_length?(value) &&
-    valid_checksum?(value, options)
+    valid_length?(value) && valid_checksum?(value, options)
   end
 
-end
+end

data/lib/active_validation/validators/type_validator.rb

@@ -6,7 +6,7 @@ class TypeValidator < ActiveModel::EachValidator
 
   def validate_each(record, attribute, value)
     unless valid?(value, options)
-      record.errors[attribute] << (options.fetch(:message, false) || I18n.t('active_validation.errors.messages.type'.freeze))
+      record.errors[attribute] << options.fetch(:message, I18n.t("active_validation.errors.messages.type"))
     end
   end