active_validation 1.0.0 → 1.1.0

data/active_validation.gemspec

@@ -8,14 +8,15 @@ Gem::Specification.new do |spec|
   spec.version       = ActiveValidation::VERSION
   spec.authors       = ["Juan Gomez"]
   spec.email         = ["j.gomez@drexed.com"]
+
   spec.summary       = %q{Gem for commonly used validators.}
   spec.description   = %q{Validate commonly used attributes easily with ActiveValidation.}
   spec.homepage      = "https://github.com/drexed/active_validation"
   spec.license       = "MIT"
 
-  spec.files         = `git ls-files -z`.split("\x0")
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  spec.bindir        = "exe"
+  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
   spec.add_runtime_dependency "activemodel"

data/bin/console

@@ -0,0 +1,14 @@
+#!/usr/bin/env ruby
+
+require "bundler/setup"
+require "active_validation"
+
+# You can add fixtures and/or initialization code here to make experimenting
+# with your gem easier. You can also use a different console, if you like.
+
+# (If you use this, don't forget to add pry to your Gemfile!)
+# require "pry"
+# Pry.start
+
+require "irb"
+IRB.start

data/bin/rake

@@ -0,0 +1,16 @@
+#!/usr/bin/env ruby
+#
+# This file was generated by Bundler.
+#
+# The application 'rake' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require 'pathname'
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+require 'rubygems'
+require 'bundler/setup'
+
+load Gem.bin_path('rake', 'rake')

data/bin/setup

@@ -0,0 +1,7 @@
+#!/bin/bash
+set -euo pipefail
+IFS=$'\n\t'
+
+bundle install
+
+# Do any other automated setup that you need to do here

data/config/locales/en.yml

@@ -6,6 +6,10 @@ en:
         alpha_numeric: "is not a valid alpha-numeric characters"
         base64: "is not a valid Base64 encode"
         boolean: "is not a valid boolean"
+        coordinate:
+          coordinate: "is not a valid coordinate"
+          latitude: "is not a valid latitude"
+          longitude: "is not a valid longitude"
         credit_card: "is not a valid credit card"
         currency: "is not a valid currency"
         cusip: "is not a valid CUSIP"
@@ -16,8 +20,6 @@ en:
         ip: "is not a valid IP"
         isbn: "is not a valid ISBN"
         isin: "is not a valid ISIN"
-        longitude: "is not a valid latitude"
-        longitude: "is not a valid longitude"
         mac_address: "is not a valid MAC address"
         name: "is not a valid name"
         password: "is not a valid password"
@@ -41,6 +43,9 @@ en:
         ensure_valid_boolean_format_of:
           failure_message_for_should: "%{model} should ensure valid boolean format of attribute %{attr}"
           failure_message_for_should_not: "%{model} should not ensure valid boolean format of attribute %{attr}"
+        ensure_valid_coordinate_format_of:
+          failure_message_for_should: "%{model} should ensure valid coordinate format of attribute %{attr}"
+          failure_message_for_should_not: "%{model} should not ensure valid coordinate format of attribute %{attr}"
         ensure_valid_credit_card_format_of:
           failure_message_for_should: "%{model} should ensure valid credit card format of attribute %{attr}"
           failure_message_for_should_not: "%{model} should not ensure valid credit card format of attribute %{attr}"
@@ -71,12 +76,6 @@ en:
         ensure_valid_isin_format_of:
           failure_message_for_should: "%{model} should ensure valid ISIN format of attribute %{attr}"
           failure_message_for_should_not: "%{model} should not ensure valid ISIN format of attribute %{attr}"
-        ensure_valid_latitude_format_of:
-          failure_message_for_should: "%{model} should ensure valid latitude format of attribute %{attr}"
-          failure_message_for_should_not: "%{model} should not ensure valid latitude format of attribute %{attr}"
-        ensure_valid_longitude_format_of:
-          failure_message_for_should: "%{model} should ensure valid longitude format of attribute %{attr}"
-          failure_message_for_should_not: "%{model} should not ensure valid longitude format of attribute %{attr}"
         ensure_valid_mac_address_format_of:
           failure_message_for_should: "%{model} should ensure valid MAC address format of attribute %{attr}"
           failure_message_for_should_not: "%{model} should not ensure valid MAC address format of attribute %{attr}"

data/lib/active_validation.rb

@@ -6,6 +6,7 @@ require 'active_validation/validators/alpha_validator'
 require 'active_validation/validators/alpha_numeric_validator'
 require 'active_validation/validators/base64_validator'
 require 'active_validation/validators/boolean_validator'
+require 'active_validation/validators/coordinate_validator'
 require 'active_validation/validators/credit_card_validator'
 require 'active_validation/validators/currency_validator'
 require 'active_validation/validators/cusip_validator'
@@ -16,8 +17,6 @@ require 'active_validation/validators/imei_validator'
 require 'active_validation/validators/ip_validator'
 require 'active_validation/validators/isbn_validator'
 require 'active_validation/validators/isin_validator'
-require 'active_validation/validators/latitude_validator'
-require 'active_validation/validators/longitude_validator'
 require 'active_validation/validators/mac_address_validator'
 require 'active_validation/validators/name_validator'
 require 'active_validation/validators/password_validator'
@@ -35,6 +34,7 @@ if defined?(RSpec)
   require 'active_validation/matchers/ensure_valid_alpha_numeric_format_of'
   require 'active_validation/matchers/ensure_valid_base64_format_of'
   require 'active_validation/matchers/ensure_valid_boolean_format_of'
+  require 'active_validation/matchers/ensure_valid_coordinate_format_of'
   require 'active_validation/matchers/ensure_valid_credit_card_format_of'
   require 'active_validation/matchers/ensure_valid_currency_format_of'
   require 'active_validation/matchers/ensure_valid_cusip_format_of'
@@ -45,8 +45,6 @@ if defined?(RSpec)
   require 'active_validation/matchers/ensure_valid_ip_format_of'
   require 'active_validation/matchers/ensure_valid_isbn_format_of'
   require 'active_validation/matchers/ensure_valid_isin_format_of'
-  require 'active_validation/matchers/ensure_valid_latitude_format_of'
-  require 'active_validation/matchers/ensure_valid_longitude_format_of'
   require 'active_validation/matchers/ensure_valid_mac_address_format_of'
   require 'active_validation/matchers/ensure_valid_name_format_of'
   require 'active_validation/matchers/ensure_valid_password_format_of'
@@ -64,6 +62,7 @@ if defined?(Rails)
 
   module ActiveValidation
     class Railtie < ::Rails::Railtie
+
       initializer 'active_validation' do |app|
         ActiveValidation::Railtie.instance_eval do
           locales = locales_from(app.config.i18n.available_locales)
@@ -86,6 +85,7 @@ if defined?(Rails)
         array = Array(args || [])
         array.blank? ? '*' : array
       end
+
     end
   end
 end

data/lib/active_validation/matchers/{ensure_valid_latitude_format_of.rb → ensure_valid_coordinate_format_of.rb}

@@ -1,16 +1,16 @@
-RSpec::Matchers.define :ensure_valid_latitude_format_of do |attribute|
+RSpec::Matchers.define :ensure_valid_coordinate_format_of do |attribute|
   match do |model|
-    model.send("#{attribute}=", 91)
+    model.send("#{attribute}=", [91, 181])
     model.valid?
 
     if model.errors.has_key?(attribute)
-      model.errors[attribute].include?(I18n.t('active_validation.errors.messages.latitude'))
+      model.errors[attribute].include?(I18n.t('active_validation.errors.messages.coordinate.coordinate'))
     end
   end
 
   failure_message do |model|
     I18n.t(
-      'active_validation.matchers.ensure_valid_latitude_format_of.failure_message_for_should',
+      'active_validation.matchers.ensure_valid_coordinate_format_of.failure_message_for_should',
       attr: attribute.inspect,
       model: model.class.name
     )
@@ -18,7 +18,7 @@ RSpec::Matchers.define :ensure_valid_latitude_format_of do |attribute|
 
   failure_message_when_negated do |model|
     I18n.t(
-      'active_validation.matchers.ensure_valid_latitude_format_of.failure_message_for_should_not',
+      'active_validation.matchers.ensure_valid_coordinate_format_of.failure_message_for_should_not',
       attr: attribute.inspect,
       model: model.class.name
     )

data/lib/active_validation/validators/coordinate_validator.rb

@@ -0,0 +1,38 @@
+class CoordinateValidator < ActiveModel::EachValidator
+
+  def validate_each(record, attribute, value)
+    boundary = options.fetch(:boundary, :coordinate)
+    unless BOUNDARIES.include?(boundary)
+      raise ArgumentError,
+        "Unknown boundary: #{boundary.inspect}. Valid boundaries are: #{BOUNDARIES.map(&:inspect).join(', ')}"
+    end
+
+    unless value.present? && valid_boundary?(value)
+      record.errors[attribute] << (options[:message] || I18n.t("active_validation.errors.messages.coordinate.#{boundary}"))
+    end
+  end
+
+  private
+
+  BOUNDARIES = [:coordinate, :latitude, :longitude]
+
+  def valid_latitude?(value)
+    value >= -90 && value <= 90
+  end
+
+  def valid_longitude?(value)
+    value >= -180 && value <= 180
+  end
+
+  def valid_boundary?(value)
+    case options[:boundary]
+    when :latitude
+      valid_latitude?(value)
+    when :longitude
+      valid_longitude?(value)
+    else
+      valid_latitude?(value.first) && valid_longitude?(value.last)
+    end
+  end
+
+end

data/lib/active_validation/version.rb

@@ -1,3 +1,3 @@
 module ActiveValidation
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_validation
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Juan Gomez
 autorequire: 
-bindir: bin
+bindir: exe
 cert_chain: []
-date: 2015-02-25 00:00:00.000000000 Z
+date: 2015-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -119,17 +119,22 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - active_validation.gemspec
+- bin/console
+- bin/rake
+- bin/setup
 - config/locales/en.yml
 - lib/active_validation.rb
 - lib/active_validation/matchers/ensure_valid_alpha_format_of.rb
 - lib/active_validation/matchers/ensure_valid_alpha_numeric_format_of.rb
 - lib/active_validation/matchers/ensure_valid_base64_format_of.rb
 - lib/active_validation/matchers/ensure_valid_boolean_format_of.rb
+- lib/active_validation/matchers/ensure_valid_coordinate_format_of.rb
 - lib/active_validation/matchers/ensure_valid_credit_card_format_of.rb
 - lib/active_validation/matchers/ensure_valid_currency_format_of.rb
 - lib/active_validation/matchers/ensure_valid_cusip_format_of.rb
@@ -140,8 +145,6 @@ files:
 - lib/active_validation/matchers/ensure_valid_ip_format_of.rb
 - lib/active_validation/matchers/ensure_valid_isbn_format_of.rb
 - lib/active_validation/matchers/ensure_valid_isin_format_of.rb
-- lib/active_validation/matchers/ensure_valid_latitude_format_of.rb
-- lib/active_validation/matchers/ensure_valid_longitude_format_of.rb
 - lib/active_validation/matchers/ensure_valid_mac_address_format_of.rb
 - lib/active_validation/matchers/ensure_valid_name_format_of.rb
 - lib/active_validation/matchers/ensure_valid_password_format_of.rb
@@ -156,6 +159,7 @@ files:
 - lib/active_validation/validators/alpha_validator.rb
 - lib/active_validation/validators/base64_validator.rb
 - lib/active_validation/validators/boolean_validator.rb
+- lib/active_validation/validators/coordinate_validator.rb
 - lib/active_validation/validators/credit_card_validator.rb
 - lib/active_validation/validators/currency_validator.rb
 - lib/active_validation/validators/cusip_validator.rb
@@ -166,8 +170,6 @@ files:
 - lib/active_validation/validators/ip_validator.rb
 - lib/active_validation/validators/isbn_validator.rb
 - lib/active_validation/validators/isin_validator.rb
-- lib/active_validation/validators/latitude_validator.rb
-- lib/active_validation/validators/longitude_validator.rb
 - lib/active_validation/validators/mac_address_validator.rb
 - lib/active_validation/validators/name_validator.rb
 - lib/active_validation/validators/password_validator.rb
@@ -179,33 +181,6 @@ files:
 - lib/active_validation/validators/username_validator.rb
 - lib/active_validation/validators/uuid_validator.rb
 - lib/active_validation/version.rb
-- spec/lib/alpha_numeric_validator_spec.rb
-- spec/lib/alpha_validator_spec.rb
-- spec/lib/base64_validator_spec.rb
-- spec/lib/boolean_validator_spec.rb
-- spec/lib/credit_card_validator_spec.rb
-- spec/lib/currency_validator_spec.rb
-- spec/lib/cusip_validator_spec.rb
-- spec/lib/email_validator_spec.rb
-- spec/lib/equality_validator_spec.rb
-- spec/lib/hex_validator_spec.rb
-- spec/lib/imei_validator_spec.rb
-- spec/lib/ip_validator_spec.rb
-- spec/lib/isbn_validator_spec.rb
-- spec/lib/isin_validator_spec.rb
-- spec/lib/latitude_validator_spec.rb
-- spec/lib/longitude_validator_spec.rb
-- spec/lib/mac_address_validator_spec.rb
-- spec/lib/name_validator_spec.rb
-- spec/lib/password_validator_spec.rb
-- spec/lib/phone_validator_spec.rb
-- spec/lib/sedol_validator_spec.rb
-- spec/lib/slug_validator_spec.rb
-- spec/lib/ssn_validator_spec.rb
-- spec/lib/url_validator_spec.rb
-- spec/lib/username_validator_spec.rb
-- spec/lib/uuid_validator_spec.rb
-- spec/spec_helper.rb
 homepage: https://github.com/drexed/active_validation
 licenses:
 - MIT
@@ -226,35 +201,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Gem for commonly used validators.
-test_files:
-- spec/lib/alpha_numeric_validator_spec.rb
-- spec/lib/alpha_validator_spec.rb
-- spec/lib/base64_validator_spec.rb
-- spec/lib/boolean_validator_spec.rb
-- spec/lib/credit_card_validator_spec.rb
-- spec/lib/currency_validator_spec.rb
-- spec/lib/cusip_validator_spec.rb
-- spec/lib/email_validator_spec.rb
-- spec/lib/equality_validator_spec.rb
-- spec/lib/hex_validator_spec.rb
-- spec/lib/imei_validator_spec.rb
-- spec/lib/ip_validator_spec.rb
-- spec/lib/isbn_validator_spec.rb
-- spec/lib/isin_validator_spec.rb
-- spec/lib/latitude_validator_spec.rb
-- spec/lib/longitude_validator_spec.rb
-- spec/lib/mac_address_validator_spec.rb
-- spec/lib/name_validator_spec.rb
-- spec/lib/password_validator_spec.rb
-- spec/lib/phone_validator_spec.rb
-- spec/lib/sedol_validator_spec.rb
-- spec/lib/slug_validator_spec.rb
-- spec/lib/ssn_validator_spec.rb
-- spec/lib/url_validator_spec.rb
-- spec/lib/username_validator_spec.rb
-- spec/lib/uuid_validator_spec.rb
-- spec/spec_helper.rb
+test_files: []

data/lib/active_validation/matchers/ensure_valid_longitude_format_of.rb

@@ -1,26 +0,0 @@
-RSpec::Matchers.define :ensure_valid_longitude_format_of do |attribute|
-  match do |model|
-    model.send("#{attribute}=", 181)
-    model.valid?
-
-    if model.errors.has_key?(attribute)
-      model.errors[attribute].include?(I18n.t('active_validation.errors.messages.longitude'))
-    end
-  end
-
-  failure_message do |model|
-    I18n.t(
-      'active_validation.matchers.ensure_valid_longitude_format_of.failure_message_for_should',
-      attr: attribute.inspect,
-      model: model.class.name
-    )
-  end
-
-  failure_message_when_negated do |model|
-    I18n.t(
-      'active_validation.matchers.ensure_valid_longitude_format_of.failure_message_for_should_not',
-      attr: attribute.inspect,
-      model: model.class.name
-    )
-  end
-end

data/lib/active_validation/validators/latitude_validator.rb

@@ -1,9 +0,0 @@
-class LatitudeValidator < ActiveModel::EachValidator
-
-  def validate_each(record, attribute, value)
-    unless value.present? && value >= -90 && value <= 90
-      record.errors[attribute] << (options[:message] || I18n.t('active_validation.errors.messages.latitude'))
-    end
-  end
-
-end

data/lib/active_validation/validators/longitude_validator.rb

@@ -1,9 +0,0 @@
-class LongitudeValidator < ActiveModel::EachValidator
-
-  def validate_each(record, attribute, value)
-    unless value.present? && value >= -180 && value <= 180
-      record.errors[attribute] << (options[:message] || I18n.t('active_validation.errors.messages.longitude'))
-    end
-  end
-
-end

data/spec/lib/alpha_numeric_validator_spec.rb

@@ -1,91 +0,0 @@
-require 'spec_helper'
-
-describe AlphaNumericValidator do
-
-  context "has a valid value" do
-    let(:klass) do
-      Class.new do
-        include ActiveModel::Validations
-        attr_accessor :title, :name
-        validates :title, alpha_numeric: true
-      end
-    end
-
-    subject { klass.new }
-
-    it { should allow_value("Example").for(:title) }
-    it { should allow_value("Example Title").for(:title) }
-    it { should allow_value("Example1").for(:title) }
-    it { should allow_value("Example 1").for(:title) }
-
-    it { should_not allow_value('').for(:title) }
-    it { should_not allow_value(' ').for(:title) }
-    it { should_not allow_value(nil).for(:title) }
-    it { should_not allow_value("Ex-ample").for(:title) }
-    it { should_not allow_value("Ex-ample1").for(:title) }
-    it { should_not allow_value("! \#$%\`|").for(:title) }
-    it { should_not allow_value("<>@[]\`|").for(:title) }
-
-    it { should ensure_valid_alpha_numeric_format_of(:title) }
-    it { should_not ensure_valid_alpha_numeric_format_of(:name) }
-  end
-
-  context "with :strict option has a valid value" do
-    let(:klass) do
-      Class.new do
-        include ActiveModel::Validations
-        attr_accessor :title, :name
-        validates :title, alpha_numeric: { strict: true }
-      end
-    end
-
-    subject { klass.new }
-
-    it { should allow_value("Example").for(:title) }
-    it { should allow_value("Example1").for(:title) }
-
-    it { should_not allow_value('').for(:title) }
-    it { should_not allow_value(' ').for(:title) }
-    it { should_not allow_value(nil).for(:title) }
-    it { should_not allow_value("Example Title").for(:title) }
-    it { should_not allow_value("Example 1").for(:title) }
-    it { should_not allow_value("Ex-ample").for(:title) }
-    it { should_not allow_value("Ex-ample1").for(:title) }
-    it { should_not allow_value("! \#$%\`|").for(:title) }
-    it { should_not allow_value("<>@[]\`|").for(:title) }
-
-    it { should ensure_valid_alpha_numeric_format_of(:title) }
-    it { should_not ensure_valid_alpha_numeric_format_of(:name) }
-  end
-
-  context "with case: :lower option has a valid value" do
-    let(:klass) do
-      Class.new do
-        include ActiveModel::Validations
-        attr_accessor :title, :name
-        validates :title, alpha_numeric: { case: :lower }
-      end
-    end
-
-    subject { klass.new }
-
-    it { should allow_value("example1").for(:title) }
-    it { should allow_value("example title 1").for(:title) }
-
-    it { should_not allow_value('').for(:title) }
-    it { should_not allow_value(' ').for(:title) }
-    it { should_not allow_value(nil).for(:title) }
-    it { should_not allow_value("Example").for(:title) }
-    it { should_not allow_value("Example Title").for(:title) }
-    it { should_not allow_value("Example 1").for(:title) }
-    it { should_not allow_value("Example1").for(:title) }
-    it { should_not allow_value("Ex-ample").for(:title) }
-    it { should_not allow_value("Ex-ample1").for(:title) }
-    it { should_not allow_value("! \#$%\`|").for(:title) }
-    it { should_not allow_value("<>@[]\`|").for(:title) }
-
-    it { should ensure_valid_alpha_numeric_format_of(:title) }
-    it { should_not ensure_valid_alpha_numeric_format_of(:name) }
-  end
-
-end