active_utils 3.2.2 → 3.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6211b736c9e2eca5eecb46238d8ddf14993eff6e
-  data.tar.gz: ae32f4daff45189f5689a1384332e28bd48c3e46
+  metadata.gz: 94da83eb1fea5bd3c0d87913c99b1a99362a2f1f
+  data.tar.gz: 787909897ac8cfa2460dc60c90010f1a991c8d21
 SHA512:
-  metadata.gz: 7135845a5dc5cd1673ff1beaf85d7a81473614f8a1698e9064d44b83ecaade0e8057eb7346c2ac2d0a6142918a9e1caf4089064ded546e198378fbe82b836214
-  data.tar.gz: 8dc33a076e05c93360ec9f2a78a0569c6fb168c9991577a6ff60257e7e0215792d929e58c7efdcf87721093ec8f56e864fa082e168892cc53d012226a8cbb8ef
+  metadata.gz: 4d7c25a185919b588e70142d824eaca3dabf36be30ea7e1f4f348ea37263bade5486b33622e5180a6130a4e70e2f8d60dbec2f3b6638cc4984ecd4f72dde2889
+  data.tar.gz: 15be3d94760b7e483d02fbbeb15d5552fa15d1d652bd4c4313c8cb19634842e7571b41ec4b7e0485bc532d436782313fecc936229afabb0ce20a3ad002b265b3

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # ActiveUtils changelog
 
+### Version 3.2.3 (Nov. 21, 2016)
+- Add the `:delay` option in `ActiveUtils::NetworkConnectionRetries`
+
+### Version 3.2.2 (Jul. 4, 2016)
+- Add tests for Rails 5 support
+
+### Version 3.2.1 (Oct. 26, 2015)
+- Add the malaysian currency code "RM" in `ActiveUtils::CurrencyCode`
+
 ### Version 3.2.0 (Oct. 13, 2015)
 - Add #uses_postal_codes? to `ActiveUtils::Country`
 

data/lib/active_utils/network_connection_retries.rb

@@ -49,12 +49,18 @@ module ActiveUtils
         retries -= 1
 
         log_with_retry_details(options[:logger], initial_retries-retries, Time.now.to_f - request_start, e.message, options[:tag])
-        retry unless retries.zero?
+        unless retries.zero?
+          Kernel.sleep(options[:delay]) if options[:delay]
+          retry
+        end
         raise ActiveUtils::ConnectionError, e.message
       rescue ActiveUtils::ConnectionError, ActiveUtils::InvalidResponseError => e
         retries -= 1
         log_with_retry_details(options[:logger], initial_retries-retries, Time.now.to_f - request_start, e.message, options[:tag])
-        retry if (options[:retry_safe] || retry_safe) && !retries.zero?
+        if (options[:retry_safe] || retry_safe) && !retries.zero?
+          Kernel.sleep(options[:delay]) if options[:delay]
+          retry
+        end
         raise
       end
     end

data/lib/active_utils/version.rb

@@ -1,3 +1,3 @@
 module ActiveUtils
-  VERSION = "3.2.2"
+  VERSION = "3.2.3"
 end

data/test/unit/network_connection_retries_test.rb

@@ -149,6 +149,24 @@ class NetworkConnectionRetriesTest < Minitest::Test
     end
   end
 
+  def test_delay_between_retries
+    @requester.expects(:post).times(2).raises(EOFError).then.returns(@ok)
+    Kernel.expects(sleep: 0.5)
+
+    retry_exceptions retry_safe: true, delay: 0.5 do
+      @requester.post
+    end
+  end
+
+  def test_no_delay_without_specified_option
+    @requester.expects(:post).times(2).raises(EOFError).then.returns(@ok)
+    Kernel.expects(sleep: 0.5).never
+
+    retry_exceptions retry_safe: true do
+      @requester.post
+    end
+  end
+
   def test_failure_with_ssl_certificate
     @requester.expects(:post).raises(OpenSSL::X509::CertificateError)
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_utils
 version: !ruby/object:Gem::Version
-  version: 3.2.2
+  version: 3.2.3
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-04 00:00:00.000000000 Z
+date: 2016-11-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -149,7 +149,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: active_utils
-rubygems_version: 2.2.3
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Common utils used by active_merchant, active_fulfillment, and active_shipping