active_utils 3.0.0.pre2 → 3.0.0.pre3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c4c3b947ecf0454c6071d2d8a20b7782f0de5d7f
-  data.tar.gz: 4ac3a861bca6ad6899612ed6dd338afb366bc047
+  metadata.gz: d037875f79e6088131b44ecd2f152cfff65dabe9
+  data.tar.gz: ff0ddf8cc94a14729fb6e9f69d5f1cd97e66e294
 SHA512:
-  metadata.gz: 906e8cc8ab975a891574c135c3dd2c0d8b221d143315b51efce2a8809ec7cbe8045d8ad412898ed4fd3e947e440c33ee25a99ece2dcef98a3e9b6ea453a734d6
-  data.tar.gz: 2f41fdf4dd698d0a8adc081edc90abe7a9dc240e3c9f6e0a3b2d5411b1a8679fdf908d8770a839ec43cf02d683e481e36ecf995c654c85c654697bed7ffd6c0e
+  metadata.gz: 1c83a6b73f888febf70693e871279f550d5750aacb925250d61ccfc2901fbdd8a471bdedc4133231c0c306e3e267224107666c0c1b6f6fb59245300f1b1c0196
+  data.tar.gz: 2720cf9a1ce986629d79c7ad1f171f0b4963c050493308b119c6d0dd3af4b490fb9849a013e96c479cb80331af5a87c342dffb29e3920e7d21d330feba004a1b

data/.travis.yml

@@ -3,10 +3,10 @@ script: bundle exec rake test
 sudo: false
 
 rvm:
-- 1.9
-- 2.0
-- 2.1
-- 2.2
+- "1.9"
+- "2.0"
+- "2.1"
+- "2.2"
 
 gemfile:
 - Gemfile.activesupport32

data/CHANGELOG.md

@@ -0,0 +1,9 @@
+# ActiveUtils changelog
+
+
+### Version 3.0.0 (to be released)
+
+- Fully decoupled from ActiveMerchant: no longer uses `ActiveMerchant::` as namespace, but uses `ActiveUtils::` instead.
+- Bump ActiveSupport requirement to **>= 3.2**.
+- The `Utils` module to generate unique identifiers has been removed. Use `SecureRandom` instead.
+- Improved test setup.

data/CONTRIBUTING.md

@@ -0,0 +1,33 @@
+# Contributing to ActiveUtils
+
+We gladly accept bugfixes to this library. Please read the guidelines for reporting issues and submitting pull requests below.
+
+### Reporting issues
+
+- Include the version of ActiveUtils, Ruby, and ActiveSupport you are using.
+- If you run into an unexpected exception, please include a stacktrace.
+- Try to include a code snippet that demonstrates the problem.
+
+### Pull request guidelines
+
+1. [Fork it](http://github.com/Shopify/active_utils/fork) and clone your new repo
+2. Create a branch (`git checkout -b my_awesome_feature`)
+3. Commit your changes (`git add my/awesome/file.rb; git commit -m "Added my awesome feature"`)
+4. Push your changes to your fork (`git push origin my_awesome_feature`)
+5. Open a [Pull Request](https://github.com/shopify/active_utils/pulls)
+
+The most important guidelines:
+
+- All changes should be covered by tests.
+- Your code should support all the Ruby versions and ActiveSupport versions we have enabled on Travis CI.
+- Do not update the CHANGELOG, or the `ActiveUtils::VERSION` constant.
+
+Final note: maybe you should also update the mirrored version in ActiveMerchant.
+
+### Releasing
+
+1. Check the [semantic versioning page](http://semver.org) for info on how to version the new release.
+2. Update the  `ActiveUtils::VERSION` constant in **lib/active_utils/version.rb**.
+3. Add a `CHANGELOG.md` entry for the new release with the date.
+4. Tag the release commit on GitHub: `bundle exec rake tag_release`
+5. Release the gem to rubygems using ShipIt

data/Gemfile.activesupport32

@@ -1,4 +1,4 @@
 source "https://rubygems.org"
 gemspec
 
-gem 'activesupport', '~> 3.2'
+gem 'activesupport', '~> 3.2.0'

data/Gemfile.activesupport40

@@ -1,4 +1,4 @@
 source "https://rubygems.org"
 gemspec
 
-gem 'activesupport', '~> 4.0'
+gem 'activesupport', '~> 4.0.0'

data/Gemfile.activesupport41

@@ -1,4 +1,4 @@
 source "https://rubygems.org"
 gemspec
 
-gem 'activesupport', '~> 4.1'
+gem 'activesupport', '~> 4.1.0'

data/Gemfile.activesupport42

@@ -1,4 +1,4 @@
 source "https://rubygems.org"
 gemspec
 
-gem 'activesupport', '~> 4.2'
+gem 'activesupport', '~> 4.2.0'

data/README.md

@@ -1,16 +1,30 @@
-# Active Utils
-
-Active Utils extracts commonly used modules and classes used by [Active Merchant](http://github.com/Shopify/active_merchant), [Active Shipping](http://github.com/Shopify/active_shipping), and [Active Fulfillment](http://github.com/Shopify/active_fulfillment).
-
-### Includes
-
-* Connection - base class for making HTTP requests
-* Country - find countries mapped by name, country codes, and numeric values
-* Error - common error classes used throughout the Active projects
-* PostData - helper class for managing required fields that are to be POST-ed
-* PostsData - making SSL HTTP requests
-* RequiresParameters - helper method to ensure the required parameters are passed in
-* Utils - common utils such as uid generator
-* Validateable - module used for making models validateable
-* NetworkConnectionRetries - module for retrying network connections when connection errors occur
-* CurrencyCode - ensure currency codes are ISO, and convert colloquial codes to ISO.
+# ActiveUtils [![Build Status](https://travis-ci.org/Shopify/active_utils.svg?branch=master)](https://travis-ci.org/Shopify/active_utils)
+
+ActiveUtils extracts commonly used modules and classes extracted from [Active Merchant](http://github.com/Shopify/active_merchant), to be used for other integration libraries.
+
+### Included modules and classes
+
+* `Connection` - base class for making HTTP requests
+* `Country` - find countries mapped by name, country codes, and numeric values
+* `Error` - common error classes used throughout the Active projects
+* `PostData` - helper class for managing required fields that are to be POST-ed
+* `PostsData` - making SSL HTTP requests
+* `RequiresParameters` - helper method to ensure the required parameters are passed in
+* `Validateable` - module used for making models validateable
+* `NetworkConnectionRetries` - module for retrying network connections when connection errors occur
+* `CurrencyCode` - ensure currency codes are ISO, and convert colloquial codes to ISO.
+
+### Libraries that depend on ActiveUtils
+
+- [ActiveShipping](https://github.com/Shopify/active_shipping)
+- [ActiveFulfillment](https://github.com/Shopify/active_fulfillment)
+- [OffsitePayments](https://github.com/Shopify/offsite_payments)
+
+### ActiveMerchant link
+
+While most of the code in this library was extracted from ActiveMerchant, ActiveMerchant itself doesn't use this library anymore. For PCI compliance reasons, we aim to keep the number of dependencies of ActiveMerchant as low as possible. For this reason, many of these classes and modules are mirrored in ActiveMerchant (e.g. `ActiveUtils::Connection` vs. `ActiveMerchant::Connection`. When making changes to this library, you may want to mirror those changes in ActiveMerchant.
+
+### Misc
+
+- This project is MIT licensed.
+- Contributions are gladly accepted! See `CONTRIBUTING.md` for more information.

data/lib/active_utils/connection.rb

@@ -11,7 +11,7 @@ module ActiveUtils
     OPEN_TIMEOUT = 60
     READ_TIMEOUT = 60
     VERIFY_PEER = true
-    CA_FILE = (File.dirname(__FILE__) + '/../../certs/cacert.pem')
+    CA_FILE = (File.dirname(__FILE__) + '/../certs/cacert.pem')
     CA_PATH = nil
     RETRY_SAFE = false
     RUBY_184_POST_HEADERS = { "Content-Type" => "application/x-www-form-urlencoded" }

data/lib/active_utils/version.rb

@@ -1,3 +1,3 @@
 module ActiveUtils
-  VERSION = "3.0.0.pre2"
+  VERSION = "3.0.0.pre3"
 end

data/lib/active_utils.rb

@@ -19,7 +19,6 @@ module ActiveUtils
   autoload :PostData,                  'active_utils/post_data'
   autoload :PostsData,                 'active_utils/posts_data'
   autoload :RequiresParameters,        'active_utils/requires_parameters'
-  autoload :Utils,                     'active_utils/utils'
   autoload :Validateable,              'active_utils/validateable'
   autoload :CurrencyCode,              'active_utils/currency_code'
   autoload :InvalidCurrencyCodeError,  'active_utils/currency_code'

data/test/test_helper.rb

@@ -4,16 +4,8 @@ require 'mocha/setup'
 
 include ActiveUtils
 
-def suppress_warnings
-  original_verbosity, $VERBOSE = $VERBOSE, nil
-  yield
-ensure
-  $VERBOSE = original_verbosity
-end
-
-class Minitest::Test
-  def assert_deprecation_warning(message=nil)
-    ActiveUtils::Utils.expects(:deprecated).with(message ? message : anything)
-    yield
-  end
+# This makes sure that Minitest::Test exists when an older version of Minitest
+# (i.e. 4.x) is required by ActiveSupport.
+unless defined?(Minitest::Test)
+  Minitest::Test = MiniTest::Unit::TestCase
 end

data/test/unit/connection_test.rb

@@ -10,6 +10,10 @@ class ConnectionTest < Minitest::Test
     @connection.logger = stub(:info => nil, :debug => nil, :error => nil)
   end
 
+  def test_path_to_cert_is_correct
+    assert File.exists?(ActiveUtils::Connection::CA_FILE)
+  end
+
   def test_connection_endpoint_parses_string_to_uri
     assert_equal URI.parse(@endpoint), @connection.endpoint
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_utils
 version: !ruby/object:Gem::Version
-  version: 3.0.0.pre2
+  version: 3.0.0.pre3
 platform: ruby
 authors:
 - Shopify
@@ -30,7 +30,7 @@ cert_chain:
   fl3hbtVFTqbOlwL9vy1fudXcolIE/ZTcxQ+er07ZFZdKCXayR9PPs64heamfn0fp
   TConQSX2BnZdhIEYW+cKzEC/bLc=
   -----END CERTIFICATE-----
-date: 2015-01-05 00:00:00.000000000 Z
+date: 2015-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -111,6 +111,8 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".travis.yml"
+- CHANGELOG.md
+- CONTRIBUTING.md
 - Gemfile
 - Gemfile.activesupport32
 - Gemfile.activesupport40