active_utils 2.0.2 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c6b630a34ea73ba2891b97742823b62856bd532b
-  data.tar.gz: 27c652fccd8be0d20dfd462efb0c7f36afc5d6a3
+  metadata.gz: 180170853acf22a66e870a16f3081c97ccf1e7c4
+  data.tar.gz: 5dc60932763444c415f3cbffe1674daf606b9eb1
 SHA512:
-  metadata.gz: f6a173be5591946ed8679e8010b2c008a49228d3789581a1f360f74dc29b5d77d1a8d0734ad7e4401aba9dc68efe5c2702b8d82242057548ee87523578915219
-  data.tar.gz: 4338b8518c3673270d7cd469c489e0b9af4a2d7d8c951cc2f441babb1691f27ccfe877be561bc3d4816e141a39e081f0efa37ce6ff3cf8ab02947376848daa6e
+  metadata.gz: 29f63bd7f1ab24c9f97175354540cbc93a9572217daf94fde33bef40c9091af9dab98c971cd2b50a683e89eea6ffaca24517ab7263df0d2617f4c1a4a7d23d10
+  data.tar.gz: e81f8f53400e9fef54fe7460bfb7ea46801fccae99bce30d6861e51cd9b269b9c50cbccecfcd8de6dd43e163bd09fe4324aa16075c7e556bbc0a0fb4d3c126e7

data/Gemfile

@@ -1,3 +1,5 @@
 source "http://rubygems.org"
 
+gem 'minitest', ' ~> 4.0.0'
+
 gemspec

data/README.md

@@ -13,3 +13,4 @@ Active Utils extracts commonly used modules and classes used by [Active Merchant
 * Utils - common utils such as uid generator
 * Validateable - module used for making models validateable
 * NetworkConnectionRetries - module for retrying network connections when connection errors occur
+* CurrencyCode - ensure currency codes are ISO, and convert colloquial codes to ISO.

data/lib/active_utils/common/currency_code.rb

@@ -0,0 +1,50 @@
+module ActiveMerchant
+  class InvalidCurrencyCodeError < StandardError
+  end
+
+  class CurrencyCode
+    ISO_CURRENCIES = [
+      "AED", "ALL", "AMD", "ANG", "AOA", "ARS", "AUD", "AWG", "AZN", "BAM", "BBD", "BDT", "BGN", "BHD",
+      "BND", "BOB", "BRL", "BSD", "BTN", "BWP", "BYR", "BZD", "CAD", "CHF", "CLP", "CNY", "COP", "CRC",
+      "CZK", "DKK", "DOP", "DZD", "EGP", "ETB", "EUR", "FJD", "GBP", "GEL", "GHS", "GMD", "GTQ", "GYD",
+      "HKD", "HNL", "HRK", "HUF", "IDR", "ILS", "INR", "ISK", "JEP", "JMD", "JOD", "JPY", "KES", "KGS",
+      "KHR", "KRW", "KWD", "KYD", "KZT", "LBP", "LKR", "LTL", "LVL", "MAD", "MDL", "MGA", "MKD", "MMK",
+      "MNT", "MOP", "MUR", "MVR", "MXN", "MYR", "MZN", "NAD", "NGN", "NIO", "NOK", "NPR", "NZD", "OMR",
+      "PEN", "PGK", "PHP", "PKR", "PLN", "PYG", "QAR", "RON", "RSD", "RUB", "RWF", "SAR", "SCR", "SEK",
+      "SGD", "STD", "SYP", "THB", "TND", "TRY", "TTD", "TWD", "TZS", "UAH", "UGX", "USD", "UYU", "VEF",
+      "VND", "VUV", "WST", "XAF", "XCD", "XOF", "XPF", "ZAR", "ZMW"
+    ]
+
+    NON_ISO_TO_ISO = {
+      "ARN" => "ARS",
+      "AZM" => "AZN",
+      "CHP" => "CLP",
+      "DHS" => "AED",
+      "ECD" => "XCD",
+      "GHC" => "GHS",
+      "JAD" => "JMD",
+      "JYE" => "JPY",
+      "KUD" => "KWD",
+      "MZM" => "MZN",
+      "NTD" => "TWD",
+      "NMP" => "MXN",
+      "RDD" => "DOP",
+      "RMB" => "CNY",
+      "SFR" => "CHF",
+      "SID" => "SGD",
+      "UKL" => "GBP",
+      "WON" => "KRW"
+    }
+
+    def self.standardize(code)
+      code = code.upcase
+
+      return code if is_iso?(code)
+      NON_ISO_TO_ISO[code] || raise(InvalidCurrencyCodeError, "#{code} is not an ISO currency, nor can it be converted to one.")
+    end
+
+    def self.is_iso?(code)
+      ISO_CURRENCIES.include? code
+    end
+  end
+end

data/lib/active_utils/common/network_connection_retries.rb

@@ -2,10 +2,11 @@ module ActiveMerchant
   module NetworkConnectionRetries
     DEFAULT_RETRIES = 3
     DEFAULT_CONNECTION_ERRORS = {
-      EOFError          => "The remote server dropped the connection",
-      Errno::ECONNRESET => "The remote server reset the connection",
-      Timeout::Error    => "The connection to the remote server timed out",
-      Errno::ETIMEDOUT  => "The connection to the remote server timed out"
+      EOFError               => "The remote server dropped the connection",
+      Errno::ECONNRESET      => "The remote server reset the connection",
+      Timeout::Error         => "The connection to the remote server timed out",
+      Errno::ETIMEDOUT       => "The connection to the remote server timed out",
+      OpenSSL::SSL::SSLError => "The SSL connection to the remote server could not be established"
     }
 
     def self.included(base)

data/lib/active_utils/version.rb

@@ -1,3 +1,3 @@
 module ActiveUtils
-  VERSION = "2.0.2"
+  VERSION = "2.1.0"
 end

data/lib/active_utils.rb

@@ -17,4 +17,5 @@ module ActiveMerchant
   autoload :RequiresParameters,        'active_utils/common/requires_parameters'
   autoload :Utils,                     'active_utils/common/utils'
   autoload :Validateable,              'active_utils/common/validateable'
+  autoload :CurrencyCode,              'active_utils/common/currency_code'
 end

data/test/unit/currency_code_test.rb

@@ -0,0 +1,31 @@
+require 'test_helper'
+
+class CurrencyCodeTest < Test::Unit::TestCase
+  def test_is_iso_should_return_true_for_iso_currencies
+    assert CurrencyCode.is_iso?('CAD')
+    assert CurrencyCode.is_iso?('USD')
+    assert CurrencyCode.is_iso?('TWD')
+  end
+
+  def test_is_iso_should_return_false_for_non_iso_currencies
+    assert !CurrencyCode.is_iso?('NTD')
+    assert !CurrencyCode.is_iso?('RMB')
+  end
+
+  def test_standardize_should_not_change_iso_currencies
+    assert_equal 'CAD', CurrencyCode.standardize('CAD')
+    assert_equal 'USD', CurrencyCode.standardize('usd')
+    assert_equal 'TWD', CurrencyCode.standardize('TWD')
+  end
+
+  def test_standardize_should_convert_known_non_iso_to_iso
+    assert_equal 'TWD', CurrencyCode.standardize('NTD')
+    assert_equal 'CNY', CurrencyCode.standardize('rmb')
+  end
+
+  def test_standardize_should_raise_for_unknwon_currencies
+    assert_raise InvalidCurrencyCodeError do
+      CurrencyCode.standardize('Not Real')
+    end
+  end
+end

metadata

@@ -1,69 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: active_utils
 version: !ruby/object:Gem::Version
-  version: 2.0.2
+  version: 2.1.0
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-21 00:00:00.000000000 Z
+date: 2014-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.11
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.11
 - !ruby/object:Gem::Dependency
   name: i18n
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: 
@@ -73,7 +73,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
 - MIT-LICENSE
 - README.md
@@ -82,6 +82,7 @@ files:
 - lib/active_utils.rb
 - lib/active_utils/common/connection.rb
 - lib/active_utils/common/country.rb
+- lib/active_utils/common/currency_code.rb
 - lib/active_utils/common/error.rb
 - lib/active_utils/common/network_connection_retries.rb
 - lib/active_utils/common/post_data.rb
@@ -95,6 +96,7 @@ files:
 - test/unit/connection_test.rb
 - test/unit/country_code_test.rb
 - test/unit/country_test.rb
+- test/unit/currency_code_test.rb
 - test/unit/network_connection_retries_test.rb
 - test/unit/post_data_test.rb
 - test/unit/posts_data_test.rb
@@ -109,17 +111,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: active_utils
-rubygems_version: 2.0.3
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Common utils used by active_merchant, active_fulfillment, and active_shipping
@@ -128,6 +130,7 @@ test_files:
 - test/unit/connection_test.rb
 - test/unit/country_code_test.rb
 - test/unit/country_test.rb
+- test/unit/currency_code_test.rb
 - test/unit/network_connection_retries_test.rb
 - test/unit/post_data_test.rb
 - test/unit/posts_data_test.rb