active_utils 1.0.1 → 1.0.2

data/lib/active_utils/common/connection.rb

@@ -48,6 +48,15 @@ module ActiveMerchant
             when :post
               debug body
               http.post(endpoint.request_uri, body, RUBY_184_POST_HEADERS.merge(headers))
+            when :put
+              debug body
+              http.put(endpoint.request_uri, body, headers)
+            when :delete
+              # It's kind of ambiguous whether the RFC allows bodies
+              # for DELETE requests. But Net::HTTP's delete method
+              # very unambiguously does not.
+              raise ArgumentError, "DELETE requests do not support a request body" if body
+              http.delete(endpoint.request_uri, headers)
             else
               raise ArgumentError, "Unsupported request method #{method.to_s.upcase}"
             end

data/lib/active_utils/common/posts_data.rb

@@ -31,7 +31,7 @@ module ActiveMerchant #:nodoc:
     end
 
     def raw_ssl_request(method, endpoint, data, headers = {})
-      connection = Connection.new(endpoint)
+      connection = new_connection(endpoint)
       connection.open_timeout = open_timeout
       connection.read_timeout = read_timeout
       connection.retry_safe   = retry_safe
@@ -50,6 +50,10 @@ module ActiveMerchant #:nodoc:
 
     private
 
+    def new_connection(endpoint)
+      Connection.new(endpoint)
+    end
+
     def handle_response(response)
       case response.code.to_i
       when 200...300

data/lib/active_utils/version.rb

@@ -1,3 +1,3 @@
 module ActiveUtils
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

data/test/unit/connection_test.rb

@@ -37,6 +37,18 @@ class ConnectionTest < Test::Unit::TestCase
     assert_equal 'success', response.body
   end
 
+  def test_successful_put_request
+    Net::HTTP.any_instance.expects(:put).with('/tx.php', 'data', {}).returns(@ok)
+    response = @connection.request(:put, 'data', {})
+    assert_equal 'success', response.body
+  end
+
+  def test_successful_delete_request
+    Net::HTTP.any_instance.expects(:delete).with('/tx.php', {}).returns(@ok)
+    response = @connection.request(:delete, nil, {})
+    assert_equal 'success', response.body
+  end
+
   def test_get_raises_argument_error_if_passed_data
     assert_raise(ArgumentError) do
       @connection.request(:get, 'data', {})
@@ -45,7 +57,7 @@ class ConnectionTest < Test::Unit::TestCase
 
   def test_request_raises_when_request_method_not_supported
     assert_raise(ArgumentError) do
-      @connection.request(:delete, nil, {})
+      @connection.request(:head, nil, {})
     end
   end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: active_utils
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 19
   prerelease: 
   segments: 
   - 1
   - 0
-  - 1
-  version: 1.0.1
+  - 2
+  version: 1.0.2
 platform: ruby
 authors: 
 - Shopify
@@ -15,13 +15,13 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-09-14 00:00:00 -04:00
+date: 2012-01-16 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: activesupport
   prerelease: false
-  version_requirements: &id001 !ruby/object:Gem::Requirement 
+  requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -33,11 +33,11 @@ dependencies:
         - 11
         version: 2.3.11
   type: :runtime
-  requirement: *id001
+  version_requirements: *id001
 - !ruby/object:Gem::Dependency 
   name: i18n
   prerelease: false
-  version_requirements: &id002 !ruby/object:Gem::Requirement 
+  requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -47,11 +47,11 @@ dependencies:
         - 0
         version: "0"
   type: :runtime
-  requirement: *id002
+  version_requirements: *id002
 - !ruby/object:Gem::Dependency 
   name: rake
   prerelease: false
-  version_requirements: &id003 !ruby/object:Gem::Requirement 
+  requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -61,11 +61,11 @@ dependencies:
         - 0
         version: "0"
   type: :development
-  requirement: *id003
+  version_requirements: *id003
 - !ruby/object:Gem::Dependency 
   name: mocha
   prerelease: false
-  version_requirements: &id004 !ruby/object:Gem::Requirement 
+  requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -75,7 +75,7 @@ dependencies:
         - 0
         version: "0"
   type: :development
-  requirement: *id004
+  version_requirements: *id004
 description: 
 email: 
 - developers@jadedpixel.com
@@ -140,7 +140,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: active_utils
-rubygems_version: 1.6.2
+rubygems_version: 1.5.3
 signing_key: 
 specification_version: 3
 summary: Common utils used by active_merchant, active_fulfillment, and active_shipping