active_type 2.4.0 → 2.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ddb772a51e5470b64366773d50daa9d1527ccee54eff6f59121aa795c5bb57a4
-  data.tar.gz: 5a30c57fdc09d75347e25de79707752bf301ae5cc3cb1419232129c97e55124e
+  metadata.gz: 9b40a092b72f6361e4693545466f24456c99e8bcb99544b151ea3f2d7fc81dba
+  data.tar.gz: 25e7245a8e46d79a7ceb1e7de19c869e8cee5af3aabca774db5bd12e500e6a97
 SHA512:
-  metadata.gz: 7ad05ccd1badf7e22f1615ab8ed5c0f893e712ba2a669109839996c743b2ce4982492a317a64601cd4f5f52328e784cf1f15211bdf0e0a7684883501db1e51d5
-  data.tar.gz: 9b88114bf7e5bf46af8b6b59e069da70a71e469ac50a1490b0380515616929705b6fa43492e52dcc4d97e9d81604aeda3eb64749bbfbf22a0db881c6c5ec5a0e
+  metadata.gz: 15b0593912cfafd848d498cc9095928e30f925b5e1fdc82c1bdbb0e34e543f5b5f6ae981f003bd9eece9e8f3ab957daaf0b779980002b847bea73296719de286
+  data.tar.gz: 7b823c166979fe0786e455a39e81cf633db3784aa91a47e9c34491082489e7a7049e2997c46cc9470830fccab063c7ac693feba97eab897cea995d675cae12ae

data/.github/workflows/test.yml

@@ -87,6 +87,7 @@ jobs:
         image: postgres
         env:
           POSTGRES_PASSWORD: postgres
+          POSTGRES_DB: active_type_test
         options: >-
           --health-cmd pg_isready
           --health-interval 10s
@@ -116,16 +117,10 @@ jobs:
 
     steps:
       - uses: actions/checkout@v3
-      - name: Install database client
-        run: |
-          sudo apt-get install -y postgresql-client
       - name: Install ruby
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
           bundler-cache: true
-      - name: Setup databases
-        run: |
-          PGPASSWORD=postgres psql -c 'create database active_type_test;' -U postgres -p 5432 -h localhost
       - name: Run tests
         run: bundle exec rake spec

data/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 All notable changes to this project will be documented in this file.
 
+## 2.5.0 (2024-02-29)
+
+* Passing unfrozen objects as a default for an attribute is deprecated, since these objects might be shared between records.
+
+## 2.4.1 (2024-01-08)
+
+* Fixed: Calling `#attributes` on the base record after a cast works now and does not throw a `MutationAfterCastError`
+
 ## 2.4.0 (2023-12-22)
 * Added: You can implement an `#after_cast` that is called with the original record when calling `ActiveType.cast`.
  Thanks to @MaximilianoGarciaRoe.

data/Gemfile.5.2.mysql2.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (2.4.0)
+    active_type (2.5.0)
       activerecord (>= 3.2)
 
 GEM

data/Gemfile.5.2.pg.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (2.4.0)
+    active_type (2.5.0)
       activerecord (>= 3.2)
 
 GEM

data/Gemfile.5.2.sqlite3.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (2.4.0)
+    active_type (2.5.0)
       activerecord (>= 3.2)
 
 GEM

data/Gemfile.6.0.sqlite3.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (2.4.0)
+    active_type (2.5.0)
       activerecord (>= 3.2)
 
 GEM

data/Gemfile.6.1.pg.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (2.4.0)
+    active_type (2.5.0)
       activerecord (>= 3.2)
 
 GEM

data/Gemfile.6.1.sqlite3.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (2.4.0)
+    active_type (2.5.0)
       activerecord (>= 3.2)
 
 GEM

data/Gemfile.7.0.pg.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (2.4.0)
+    active_type (2.5.0)
       activerecord (>= 3.2)
 
 GEM

data/Gemfile.7.0.sqlite3.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (2.4.0)
+    active_type (2.5.0)
       activerecord (>= 3.2)
 
 GEM

data/lib/active_type/util/unmutable_attributes.rb

@@ -10,6 +10,7 @@ module ActiveType
     class UnmutableAttributes
 
       attr_reader :original_attributes
+      delegate :to_hash, to: :original_attributes
 
       def initialize(attributes)
         @original_attributes = attributes

data/lib/active_type/version.rb

@@ -1,3 +1,3 @@
 module ActiveType
-  VERSION = '2.4.0'
+  VERSION = '2.5.0'
 end

data/lib/active_type/virtual_attributes.rb

@@ -54,6 +54,7 @@ module ActiveType
       def build(name, type, options)
         validate_attribute_name!(name)
         options.assert_valid_keys(:default)
+        deprecate_non_frozen_defaults(options[:default], name)
         add_virtual_column(name, type, options)
         build_reader(name)
         build_writer(name)
@@ -68,6 +69,12 @@ module ActiveType
         @owner.virtual_columns_hash = @owner.virtual_columns_hash.merge(name.to_s => column)
       end
 
+      def deprecate_non_frozen_defaults(default, name)
+        unless default.respond_to?(:call) || default.frozen?
+          ActiveType.deprecator.warn("##{name}: Passing a non-frozen object as a default is deprecated. Mutating the attribute can change the default for other records. You can also wrap it in a proc.", caller_locations(3))
+        end
+      end
+
       def build_reader(name)
         @module.module_eval <<-BODY, __FILE__, __LINE__ + 1
           def #{name}

data/lib/active_type.rb

@@ -21,4 +21,8 @@ module ActiveType
   # Make Util methods available under the `ActiveType` namespace
   # like `ActiveType.cast(...)`
   extend Util
+
+  def self.deprecator
+    @deprecator ||= ActiveSupport::Deprecation.new
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_type
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.5.0
 platform: ruby
 authors:
 - Tobias Kraze
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-12-22 00:00:00.000000000 Z
+date: 2024-02-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler