RubyGems - active_type - Versions diffs - 1.8.0 → 1.10.1 - Mend

active_type 1.8.0 → 1.10.1

Files changed (22) hide show

checksums.yaml +4 -4
data/.github/workflows/test.yml +4 -12
data/.ruby-version +1 -1
data/CHANGELOG.md +21 -1
data/Gemfile.4.2.mysql2.lock +2 -2
data/Gemfile.4.2.pg.lock +2 -2
data/Gemfile.4.2.sqlite3.lock +2 -2
data/Gemfile.5.2.mysql2.lock +2 -2
data/Gemfile.5.2.pg.lock +1 -1
data/Gemfile.5.2.sqlite3.lock +1 -1
data/Gemfile.6.0.sqlite3.lock +1 -1
data/Gemfile.6.1.pg.lock +1 -1
data/Gemfile.6.1.sqlite3.lock +1 -1
data/README.md +2 -2
data/lib/active_type/record_extension/inheritance.rb +5 -5
data/lib/active_type/util.rb +2 -2
data/lib/active_type/version.rb +1 -1
metadata +2 -6
data/Gemfile.3.2.mysql2 +0 -10
data/Gemfile.3.2.mysql2.lock +0 -63
data/Gemfile.3.2.sqlite3 +0 -10
data/Gemfile.3.2.sqlite3.lock +0 -57

checksums.yaml CHANGED Viewed

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d14a09e976ff66dc4b1ead8c7f30cd4e81b226b005a296d65ee81770b140899a
-  data.tar.gz: 391c56642e084ef358af0bcb68909f512823db84e640d3b97e61efe0bce71c21
+  metadata.gz: 69b64cf59cc14b34fae5a6ce26172b11e4877f763e5b2aef834004e66d697f8c
+  data.tar.gz: b446e1c689241ff6f4b96494a29e7b05347e6962322c3eda37c4cf01647a125e
 SHA512:
-  metadata.gz: a924ce52a863ab2dbf8f1e0e40da9e8c4083f5a4f1bf3215ed44740471dc2ba8498066b9ace3a93c201cc8a2a078f5abf2ccb2816a7486f57e2cffa1b128703e
-  data.tar.gz: 3a3937c2815c14a432645559d87588a0ae3a6d07ee8f451ed6882e825978a391d96f109ff5f8fe1d20aebf3c87c5d952fd7aa999fe22cfd88f56a4d9d198ae37
+  metadata.gz: c9a257cb54508547e77592691c58193cf287866e32f51243a09b6300b58f78fe559ed8d6410d550906753cb850220178c23d35a5727850f23f7dad10f77e8b4f
+  data.tar.gz: ac3a81f9655a783fa15e928ee42c2d4a01ff04ff576f5709a7e862a99a2fdb2db1ca3107f50f1882ec57392f28cf23a25dfae57b0ecc3944d9da015edc7b4d3b

data/.github/workflows/test.yml CHANGED Viewed

@@ -14,12 +14,8 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - ruby: "2.3.8"
-            gemfile: Gemfile.3.2.sqlite3
-          - ruby: "2.3.8"
+          - ruby: "2.5.5"
             gemfile: Gemfile.4.2.sqlite3
-          - ruby: "2.3.8"
-            gemfile: Gemfile.5.2.sqlite3
           - ruby: "2.5.5"
             gemfile: Gemfile.5.2.sqlite3
           - ruby: "2.5.5"
@@ -80,12 +76,8 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - ruby: "2.3.8"
-            gemfile: Gemfile.3.2.mysql2
-          - ruby: "2.3.8"
+          - ruby: "2.5.5"
             gemfile: Gemfile.4.2.mysql2
-          - ruby: "2.3.8"
-            gemfile: Gemfile.5.2.mysql2
           - ruby: "2.6.3"
             gemfile: Gemfile.5.2.mysql2
           - ruby: "2.7.2"
@@ -135,9 +127,9 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - ruby: "2.3.8"
+          - ruby: "2.5.5"
             gemfile: Gemfile.4.2.pg
-          - ruby: "2.3.8"
+          - ruby: "2.5.5"
             gemfile: Gemfile.5.2.pg
           - ruby: "2.5.5"
             gemfile: Gemfile.6.1.pg

data/.ruby-version CHANGED Viewed

	@@ -1 +1 @@
1	- 2.3.8
1	+ 2.7.2

data/CHANGELOG.md CHANGED Viewed

@@ -4,9 +4,29 @@ All notable changes to this project will be documented in this file.
 ## Unreleased changes
+## 1.10.1 (2021-10-19)
+* Removed: When casting an unsaved record, the new record will no longer have the same associations as the base record. This was introduced with version 1.8.0 and lead to issues (#147 and #148). Therefore the change was rolled back.
+## 1.10.0 (2021-08-11)
+* Removed: Tests for Ruby 2.4 and ActiveRecord 3.2.
+## 1.9.1 (2021-06-29)
+* Fixed: Retain `#mutations_from_database` when using ActiveType.cast (Rails 5.2+). Thanks to @unrooty-infinum.
+## 1.9.0 (2021-05-20)
+* Fixed: Extended records now use their own I18n namespace when looking up translations for models or attributes.
+  (introduced in [1.4.0](https://github.com/makandra/active_type/commit/b2aa4247ed1d45a4cd7e51e13d945cba7c38c597))
+  There was an issue ([#142](https://github.com/makandra/active_type/issues/142)) when extending an already extended records again. Now the I18n lookup will fall back
+  fall back correctly to the extended record's or even the base record's namespace.
 ## 1.8.0 (2021-04-27)
-* Fixed: When casting an unsaved record, the new record will have the same associations as the base record.
+* Added: When casting an unsaved record, the new record will have the same associations as the base record.
 ## 1.7.0 (2021-04-27)

data/Gemfile.4.2.mysql2.lock CHANGED Viewed

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.6.0)
+    active_type (1.10.0)
       activerecord (>= 3.2)
 GEM
@@ -58,4 +58,4 @@ DEPENDENCIES
   rspec (~> 3.4)
 BUNDLED WITH
-   2.1.4
+   2.2.16

data/Gemfile.4.2.pg.lock CHANGED Viewed

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.6.0)
+    active_type (1.10.0)
       activerecord (>= 3.2)
 GEM
@@ -58,4 +58,4 @@ DEPENDENCIES
   rspec (~> 3.4)
 BUNDLED WITH
-   2.1.4
+   2.2.16

data/Gemfile.4.2.sqlite3.lock CHANGED Viewed

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.6.0)
+    active_type (1.10.0)
       activerecord (>= 3.2)
 GEM
@@ -58,4 +58,4 @@ DEPENDENCIES
   sqlite3
 BUNDLED WITH
-   2.1.4
+   2.2.16

data/Gemfile.5.2.mysql2.lock CHANGED Viewed

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.8.0)
+    active_type (1.10.1)
       activerecord (>= 3.2)
 GEM
@@ -56,4 +56,4 @@ DEPENDENCIES
   rspec (~> 3.4)
 BUNDLED WITH
-   2.1.4
+   2.2.16

data/Gemfile.5.2.pg.lock CHANGED Viewed

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.8.0)
+    active_type (1.10.1)
       activerecord (>= 3.2)
 GEM

data/Gemfile.5.2.sqlite3.lock CHANGED Viewed

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.8.0)
+    active_type (1.10.1)
       activerecord (>= 3.2)
 GEM

data/Gemfile.6.0.sqlite3.lock CHANGED Viewed

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.8.0)
+    active_type (1.10.1)
       activerecord (>= 3.2)
 GEM

data/Gemfile.6.1.pg.lock CHANGED Viewed

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.8.0)
+    active_type (1.10.1)
       activerecord (>= 3.2)
 GEM

data/Gemfile.6.1.sqlite3.lock CHANGED Viewed

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.8.0)
+    active_type (1.10.1)
       activerecord (>= 3.2)
 GEM

data/README.md CHANGED Viewed

@@ -405,14 +405,14 @@ Now, if you load `credentials`, you will automatically receive records of type `
 Supported Rails versions
 ------------------------
-ActiveType is tested against ActiveRecord 3.2, 4.2, 5.1, 5.2, 6.0 and 6.1.
+ActiveType is tested against ActiveRecord 4.2, 5.1, 5.2, 6.0 and 6.1.
 Later versions might work, earlier will not.
 Supported Ruby versions
 ------------------------
-ActiveType is tested against 2.3, 2.4, 2.5 and 3.0.
+ActiveType is tested against 2.5, 2.6, 2.7 and 3.0.
 Installation

data/lib/active_type/record_extension/inheritance.rb CHANGED Viewed

@@ -34,13 +34,13 @@ module ActiveType
               namespace = module_ancestors.detect do |n|
                 n.respond_to?(:use_relative_model_naming?) && n.use_relative_model_naming?
               end
-              # We create a Name object, with the parent class name, but self as the @klass reference
+              # We create a Name object, with the sti class name, but self as the @klass reference
               # This way lookup_ancestors is invoked on the right class instead of the extended_record_base_class
-              dup_model_name = ActiveModel::Name.new(self, namespace, extended_record_base_class.name)
-              key = name.underscore
-              # We fake the `i18n_key` to lookup on the derived class key
+              dup_model_name = ActiveModel::Name.new(self, namespace, sti_name)
+              key = name.underscore.to_sym
+              # We set the `i18n_key` to lookup on the derived class key
               # We keep the others the same to preserve parameter and route names
-              dup_model_name.define_singleton_method(:i18n_key) { key }
+              dup_model_name.instance_variable_set(:@i18n_key, key)
               dup_model_name
             else # name is nil for the anonymous intermediate class
               extended_record_base_class.model_name

data/lib/active_type/util.rb CHANGED Viewed

@@ -34,8 +34,8 @@ module ActiveType
         casted.instance_variable_set(:@new_record, record.new_record?)
         # Rails 3.2, 4.2
         casted.instance_variable_set(:@destroyed, record.destroyed?)
-        casted.instance_variable_set(:@association_cache, record.instance_variable_get(:@association_cache))
+        # Rails 5.2+
+        casted.instance_variable_set(:@mutations_from_database, record.instance_variable_get(:@mutations_from_database))
         # Rails 3.2, 4.2
         errors = record.errors

data/lib/active_type/version.rb CHANGED Viewed

@@ -1,3 +1,3 @@
 module ActiveType
-  VERSION = '1.8.0'
+  VERSION = '1.10.1'
 end

metadata CHANGED Viewed

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_type
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.10.1
 platform: ruby
 authors:
 - Tobias Kraze
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-04-27 00:00:00.000000000 Z
+date: 2021-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -65,10 +65,6 @@ files:
 - ".ruby-version"
 - CHANGELOG.md
 - Gemfile
-- Gemfile.3.2.mysql2
-- Gemfile.3.2.mysql2.lock
-- Gemfile.3.2.sqlite3
-- Gemfile.3.2.sqlite3.lock
 - Gemfile.4.2.mysql2
 - Gemfile.4.2.mysql2.lock
 - Gemfile.4.2.pg

data/Gemfile.3.2.mysql2 DELETED Viewed

@@ -1,10 +0,0 @@
-source 'https://rubygems.org'
-gem 'activerecord', '~> 3.2.22.5'
-gem 'rspec', '~> 3.4'
-gem 'mysql2', git: 'https://github.com/makandra/mysql2', branch: '0.3.x-lts'
-gem 'rake'
-gem 'gemika'
-gem 'active_type', :path => '.'
-gem 'i18n', '=0.6.11' # 0.7 no longer builds for Ruby 1.8.7

data/Gemfile.3.2.mysql2.lock DELETED Viewed

@@ -1,63 +0,0 @@
-GIT
-  remote: https://github.com/makandra/mysql2
-  revision: c920d41e43c4722d4c065d2ea9d21494c560bd85
-  branch: 0.3.x-lts
-  specs:
-    mysql2 (0.3.21)
-PATH
-  remote: .
-  specs:
-    active_type (1.6.0)
-      activerecord (>= 3.2)
-GEM
-  remote: https://rubygems.org/
-  specs:
-    activemodel (3.2.22.5)
-      activesupport (= 3.2.22.5)
-      builder (~> 3.0.0)
-    activerecord (3.2.22.5)
-      activemodel (= 3.2.22.5)
-      activesupport (= 3.2.22.5)
-      arel (~> 3.0.2)
-      tzinfo (~> 0.3.29)
-    activesupport (3.2.22.5)
-      i18n (~> 0.6, >= 0.6.4)
-      multi_json (~> 1.0)
-    arel (3.0.3)
-    builder (3.0.4)
-    diff-lcs (1.2.5)
-    gemika (0.4.1)
-    i18n (0.6.11)
-    multi_json (1.13.1)
-    rake (10.4.2)
-    rspec (3.4.0)
-      rspec-core (~> 3.4.0)
-      rspec-expectations (~> 3.4.0)
-      rspec-mocks (~> 3.4.0)
-    rspec-core (3.4.1)
-      rspec-support (~> 3.4.0)
-    rspec-expectations (3.4.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.4.0)
-    rspec-mocks (3.4.1)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.4.0)
-    rspec-support (3.4.1)
-    tzinfo (0.3.55)
-PLATFORMS
-  ruby
-DEPENDENCIES
-  active_type!
-  activerecord (~> 3.2.22.5)
-  gemika
-  i18n (= 0.6.11)
-  mysql2!
-  rake
-  rspec (~> 3.4)
-BUNDLED WITH
-   2.1.4

data/Gemfile.3.2.sqlite3 DELETED Viewed

@@ -1,10 +0,0 @@
-source 'https://rubygems.org'
-gem 'activerecord', '~> 3.2.22.5'
-gem 'rspec', '~>3.4'
-gem 'sqlite3'
-gem 'rake'
-gem 'gemika'
-gem 'active_type', :path => '.'
-gem 'i18n', '=0.6.11' # 0.7 no longer builds for Ruby 1.8.7

data/Gemfile.3.2.sqlite3.lock DELETED Viewed

@@ -1,57 +0,0 @@
-PATH
-  remote: .
-  specs:
-    active_type (1.6.0)
-      activerecord (>= 3.2)
-GEM
-  remote: https://rubygems.org/
-  specs:
-    activemodel (3.2.22.5)
-      activesupport (= 3.2.22.5)
-      builder (~> 3.0.0)
-    activerecord (3.2.22.5)
-      activemodel (= 3.2.22.5)
-      activesupport (= 3.2.22.5)
-      arel (~> 3.0.2)
-      tzinfo (~> 0.3.29)
-    activesupport (3.2.22.5)
-      i18n (~> 0.6, >= 0.6.4)
-      multi_json (~> 1.0)
-    arel (3.0.3)
-    builder (3.0.4)
-    diff-lcs (1.2.5)
-    gemika (0.4.1)
-    i18n (0.6.11)
-    multi_json (1.13.1)
-    rake (10.4.2)
-    rspec (3.4.0)
-      rspec-core (~> 3.4.0)
-      rspec-expectations (~> 3.4.0)
-      rspec-mocks (~> 3.4.0)
-    rspec-core (3.4.1)
-      rspec-support (~> 3.4.0)
-    rspec-expectations (3.4.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.4.0)
-    rspec-mocks (3.4.1)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.4.0)
-    rspec-support (3.4.1)
-    sqlite3 (1.3.11)
-    tzinfo (0.3.55)
-PLATFORMS
-  ruby
-DEPENDENCIES
-  active_type!
-  activerecord (~> 3.2.22.5)
-  gemika
-  i18n (= 0.6.11)
-  rake
-  rspec (~> 3.4)
-  sqlite3
-BUNDLED WITH
-   2.1.4