active_type 1.3.0 → 1.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b5e4919b7989f9d2ce9468d47196b1142270e6b3c2cce7e01945c20c36f4d2b8
-  data.tar.gz: 258bdcde75ea6cbe3c5ef9fb55cd6b0a140a0a8e251745b6d00a0ec7af1834d5
+  metadata.gz: dc8f689fdb28d28edb7fc550d21e0c9d4810f298da570e9e8dc223a028c09dc1
+  data.tar.gz: 7f41ea5cd75b455190740c263f836d42cd268e0ab15e3143c9c8dfedb21e0b04
 SHA512:
-  metadata.gz: ccdd4e34bfbee28b18560bc03a615f52ea4b13ee8a0ba5a33fd19552a2324142108746898159f9ff81ec30cdb420c4380d72c0b695067a7c83a58450be246645
-  data.tar.gz: 8a91a6d3e6587f22c1dc18129f1fb35821431057d44b0732a7ab25e6f02132edcdc134b7d26735d1efbb5ae8015b33d6d055c2a6336914107b17b0f52209b0b2
+  metadata.gz: da0b114cb9f97509bc8becad66a553538cbb362d07f9c8a6f1f17d7298282c302a83f477669110fd564f269b9dda5c2a009df41d40990a030044b90be869b03e
+  data.tar.gz: a9c59ed853ad1972ffd1d13d73eb452945f7c882bff1bc0dec49dec26a4b59c726b14381dd7a75f3905f0a5052906d027e8f500910e9b0395e6bc6a076639193

data/CHANGELOG.md

@@ -4,6 +4,45 @@ All notable changes to this project will be documented in this file.
 
 ## Unreleased changes
 
+## 1.4.2 (2020-09-17)
+
+* Fixed: Assigning values to virtual attributes through internal setter methods (e.g. `_write_attribute`) no longer results in "can't write unknown attribute" errors.
+
+## 1.4.1 (2020-08-05)
+
+* Fixed: Avoid `Module#parents` deprecation warning on Rails 6. Thanks to @cilim.
+
+## 1.4.0 (2020-07-27)
+
+* Extended records now use their own I18n namespace when looking up translations for models or attributes.
+  If the extended record's namespace does not contain a translation, the lookup will fall back to the
+  base record's namespace.
+
+  For instance, given the following class hierarchy:
+
+  ```
+  class User < ActiveRecord::Base
+  end
+
+  class User::Form < ActiveType::Record[User]
+  end
+  ```
+
+  The call `ExtendedParent.human_attribute_name(:foo)` would first look up the key in
+  `activerecord.attributes.user/form` first, then falls back to `activerecord.attributes.user`.
+
+  Thank you @fsateler!
+
+
+## 1.3.2 (2020-06-16)
+
+* Fixed: `nests_one` association record building used empty hash instead of passed in attributes. Credit to @chriscz.
+
+
+## 1.3.1 (2020-03-31)
+
+* Fixed: Avoid #change_association breaking for polymorphic associations. Thanks to @lucthev.
+
 
 ## 1.3.0 (2019-09-26)
 
@@ -26,7 +65,7 @@ All notable changes to this project will be documented in this file.
   end
   ```
 
-  queriying
+  querying
 
   ```
   ExtendedParent.all

data/Gemfile.3.2.mysql2.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.3.0)
+    active_type (1.4.2)
       activerecord (>= 3.2)
 
 GEM
@@ -54,4 +54,4 @@ DEPENDENCIES
   rspec (~> 3.4)
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/Gemfile.3.2.sqlite3.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.3.0)
+    active_type (1.4.2)
       activerecord (>= 3.2)
 
 GEM
@@ -54,4 +54,4 @@ DEPENDENCIES
   sqlite3
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/Gemfile.4.2.mysql2.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.3.0)
+    active_type (1.4.2)
       activerecord (>= 3.2)
 
 GEM
@@ -58,4 +58,4 @@ DEPENDENCIES
   rspec (~> 3.4)
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/Gemfile.4.2.pg.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.3.0)
+    active_type (1.4.2)
       activerecord (>= 3.2)
 
 GEM
@@ -58,4 +58,4 @@ DEPENDENCIES
   rspec (~> 3.4)
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/Gemfile.4.2.sqlite3.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.3.0)
+    active_type (1.4.2)
       activerecord (>= 3.2)
 
 GEM
@@ -58,4 +58,4 @@ DEPENDENCIES
   sqlite3
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/Gemfile.5.2.mysql2.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.3.0)
+    active_type (1.4.2)
       activerecord (>= 3.2)
 
 GEM
@@ -56,4 +56,4 @@ DEPENDENCIES
   rspec (~> 3.4)
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/Gemfile.5.2.pg.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.3.0)
+    active_type (1.4.2)
       activerecord (>= 3.2)
 
 GEM
@@ -56,4 +56,4 @@ DEPENDENCIES
   rspec (~> 3.4)
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/Gemfile.5.2.sqlite3.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.3.0)
+    active_type (1.4.2)
       activerecord (>= 3.2)
 
 GEM
@@ -56,4 +56,4 @@ DEPENDENCIES
   sqlite3
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/Gemfile.6.0.pg.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.3.0)
+    active_type (1.4.2)
       activerecord (>= 3.2)
 
 GEM
@@ -56,4 +56,4 @@ DEPENDENCIES
   rspec (~> 3.4)
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/lib/active_type/nested_attributes/nests_one_association.rb

@@ -30,8 +30,11 @@ module ActiveType
             end
           end
         elsif !destroy
-          assigned_child ||= add_child(parent, build_child(parent, {}))
-          assigned_child.attributes = attributes
+          if assigned_child
+            assigned_child.attributes = attributes
+          else
+            add_child(parent, build_child(parent, attributes))
+          end
         end
       end
 

data/lib/active_type/record_extension/inheritance.rb

@@ -15,7 +15,7 @@ module ActiveType
           options = scope
           scope = nil
         end
-        unless options[:foreign_key]
+        unless options[:foreign_key] || options[:as]
           options = options.merge(foreign_key: extended_record_base_class.name.foreign_key)
         end
         if ActiveRecord::VERSION::MAJOR > 3
@@ -28,7 +28,32 @@ module ActiveType
       module ClassMethods
 
         def model_name
-          extended_record_base_class.model_name
+          @_model_name ||= begin
+            if name
+              # Namespace detection copied from ActiveModel::Naming
+              namespace = module_ancestors.detect do |n|
+                n.respond_to?(:use_relative_model_naming?) && n.use_relative_model_naming?
+              end
+              # We create a Name object, with the parent class name, but self as the @klass reference
+              # This way lookup_ancestors is invoked on the right class instead of the extended_record_base_class
+              dup_model_name = ActiveModel::Name.new(self, namespace, extended_record_base_class.name)
+              key = name.underscore
+              # We fake the `i18n_key` to lookup on the derived class key
+              # We keep the others the same to preserve parameter and route names
+              dup_model_name.define_singleton_method(:i18n_key) { key }
+              dup_model_name
+            else # name is nil for the anonymous intermediate class
+              extended_record_base_class.model_name
+            end
+          end
+        end
+
+        def module_ancestors
+          if extended_record_base_class.respond_to?(:module_parents)
+            extended_record_base_class.module_parents
+          else
+            extended_record_base_class.parents
+          end
         end
 
         def sti_name

data/lib/active_type/version.rb

@@ -1,3 +1,3 @@
 module ActiveType
-  VERSION = '1.3.0'
+  VERSION = '1.4.2'
 end

data/lib/active_type/virtual_attributes.rb

@@ -144,28 +144,47 @@ module ActiveType
       @virtual_attributes_cache ||= {}
     end
 
-    def [](name)
+    def read_existing_virtual_attribute(name, &block_when_not_virtual)
       if self.singleton_class._has_virtual_column?(name)
         read_virtual_attribute(name)
       else
-        super
+        yield
       end
     end
 
-    # ActiveRecord 4.2.1
-    def _read_attribute(name)
+    def write_existing_virtual_attribute(name, value, &block_when_not_virtual)
       if self.singleton_class._has_virtual_column?(name)
-        read_virtual_attribute(name)
+        write_virtual_attribute(name, value)
       else
-        super
+        yield
+      end
+    end
+
+    def [](name)
+      read_existing_virtual_attribute(name) { super }
+    end
+
+    if ActiveRecord::VERSION::STRING >= '4.2.0'
+      def _read_attribute(name)
+        read_existing_virtual_attribute(name) { super }
+      end
+    else
+      def read_attribute(name)
+        read_existing_virtual_attribute(name) { super }
       end
     end
 
     def []=(name, value)
-      if self.singleton_class._has_virtual_column?(name)
-        write_virtual_attribute(name, value)
-      else
-        super
+      write_existing_virtual_attribute(name, value) { super }
+    end
+
+    if ActiveRecord::VERSION::STRING >= '5.2.0'
+      def _write_attribute(name, value)
+        write_existing_virtual_attribute(name, value) { super }
+      end
+    else
+      def write_attribute(name, value)
+        write_existing_virtual_attribute(name, value) { super }
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_type
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.2
 platform: ruby
 authors:
 - Tobias Kraze
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-26 00:00:00.000000000 Z
+date: 2020-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -123,8 +123,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.8
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Make any Ruby object quack like ActiveRecord