active_type 0.4.5 → 0.7.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: facbcaa21321fefe498b9dfd06e01373a76bc0c4
-  data.tar.gz: 1d49f4942cea269483f1e9f4c1054ef517267a8f
+  metadata.gz: f8e40c656b761439f7db54101905ac350792d30f
+  data.tar.gz: e986dc29174d96c5d7da9b611e123d885bc1954f
 SHA512:
-  metadata.gz: 37658e011161ce41985c72c649f62f6686f6465a7ead8e7546accfe7a38bc82fdde513701d3b2c7d3eb59ba63774d4597bad2f87b6c2b9e0b1bcd50606ac3c2e
-  data.tar.gz: 99064aa007b6b5b3f16063f884bee388e63ae2fdbed7b3b4afeae9aa5080ef01702edb2b63318ca402a195d3ea00d931d60a99abae56dc05c494167fab4b1643
+  metadata.gz: 3565ee831f0c113f398cb341fff3d439081ab9c4ff23ec60d2ddd38601d3d93885d082be331cadda22b6b32ebc13140d6ac3ff01750883beea5d0a89e60f883f
+  data.tar.gz: 6ae73d04f66d3634933a158cb5e808f7e7bee0df5894d46242a68fea2a5967a5dea464b56616f34b0c893917fba000f13e3fc15ac1bb857b1d70d20ea1b794e2

data/.gitignore

@@ -5,3 +5,4 @@ tags
 .idea
 tmp
 spec/support/database.yml
+.bundle

data/.rspec

@@ -0,0 +1 @@
+--color

data/.travis.yml

@@ -1,10 +1,8 @@
 language: ruby
 rvm:
-  - "1.8.7"
-  - "1.9.3"
-  - "2.0.0"
   - "2.1.7"
   - "2.2.4"
+  - "2.3.1"
 gemfile:
   - gemfiles/Gemfile.3.2.mysql2
   - gemfiles/Gemfile.3.2.sqlite3
@@ -13,10 +11,14 @@ gemfile:
   - gemfiles/Gemfile.4.2.1.mysql2
   - gemfiles/Gemfile.4.2.1.pg
   - gemfiles/Gemfile.4.2.1.sqlite3
+  - gemfiles/Gemfile.5.0.0.sqlite3
+  - gemfiles/Gemfile.5.1.0.mysql2
+  - gemfiles/Gemfile.5.1.0.pg
+  - gemfiles/Gemfile.5.1.0.sqlite3
 before_script:
   - psql -c 'create database active_type_test;' -U postgres
   - mysql -e 'create database IF NOT EXISTS active_type_test;'
-script: bundle exec rspec spec
+script: bundle exec rake spec
 sudo: false
 cache: bundler
 notifications:
@@ -27,29 +29,33 @@ branches:
     - master
 matrix:
   exclude:
-    - rvm: "1.8.7"
+    - rvm: "2.1.7"
       gemfile: gemfiles/Gemfile.4.0.sqlite3
-    - rvm: "1.8.7"
-      gemfile: gemfiles/Gemfile.4.1.sqlite3
-    - rvm: "1.8.7"
-      gemfile: gemfiles/Gemfile.4.2.1.sqlite3
-    - rvm: "1.8.7"
-      gemfile: gemfiles/Gemfile.4.2.1.mysql2
-    - rvm: "1.8.7"
-      gemfile: gemfiles/Gemfile.4.2.1.pg
-    - rvm: "1.9.3"
+    - rvm: "2.1.7"
       gemfile: gemfiles/Gemfile.4.2.1.mysql2
-    - rvm: "1.9.3"
+    - rvm: "2.1.7"
       gemfile: gemfiles/Gemfile.4.2.1.pg
-    - rvm: "2.0.0"
+    - rvm: "2.1.7"
+      gemfile: gemfiles/Gemfile.3.2.mysql2
+    - rvm: "2.1.7"
+      gemfile: gemfiles/Gemfile.4.1.sqlite3
+    - rvm: "2.1.7"
+      gemfile: gemfiles/Gemfile.5.0.0.sqlite3
+    - rvm: "2.1.7"
+      gemfile: gemfiles/Gemfile.5.1.0.sqlite3
+    - rvm: "2.1.7"
+      gemfile: gemfiles/Gemfile.5.1.0.mysql2
+    - rvm: "2.1.7"
+      gemfile: gemfiles/Gemfile.5.1.0.pg
+    - rvm: "2.2.4"
+      gemfile: gemfiles/Gemfile.4.0.sqlite3
+    - rvm: "2.2.4"
       gemfile: gemfiles/Gemfile.4.2.1.mysql2
-    - rvm: "2.0.0"
+    - rvm: "2.2.4"
       gemfile: gemfiles/Gemfile.4.2.1.pg
-    - rvm: "2.1.2"
-      gemfile: gemfiles/Gemfile.4.0.sqlite3
-    - rvm: "2.2.0"
-      gemfile: gemfiles/Gemfile.3.2.sqlite3
-    - rvm: "2.2.0"
+    - rvm: "2.2.4"
       gemfile: gemfiles/Gemfile.3.2.mysql2
-    - rvm: "2.2.0"
-      gemfile: gemfiles/Gemfile.4.0.sqlite3
+    - rvm: "2.2.4"
+      gemfile: gemfiles/Gemfile.4.1.sqlite3
+install:
+  - bundle install --no-deployment --jobs=3 --retry=3 --path=${BUNDLE_PATH:-vendor/bundle}

data/CHANGELOG.md

@@ -4,9 +4,80 @@ All notable changes to this project will be documented in this file.
 
 ActiveType is in a pre-1.0 state. This means that its APIs and behavior are subject to breaking changes without deprecation notices. Until 1.0, version numbers will follow a [Semver][]-ish `0.y.z` format, where `y` is incremented when new features or breaking changes are introduced, and `z` is incremented for lesser changes or bug fixes.
 
-## [Unreleased]
+## [0.7.5][] (2017-12-04)
 
-* Your contribution here!
+* Fixed an `chird record did not match id` exception introduced in the 0.7.3 update when using `nests_one`. Credit to @cerdiogenes.
+
+
+## [0.7.4][] (2017-09-01)
+
+* Bugfix: ActiveType.cast sets #type correctly when casting to an STI class
+
+## [0.7.3][] (2017-08-16)
+
+* `nests_many` / `nests_one` will now work for nested records with non-integer primary keys.
+
+
+## [0.7.2][] (2017-07-31)
+
+* Fixed a bug when converting datetimes from certain strings. This occured if the string included an explicit time zone (i.e. `record.date_time = '2017-07-31 12:30+03:00'`), which was not the local time.
+
+## [0.7.1][] (2017-06-19)
+
+* ActiveType::Object no longer requires a database connection on Rails 5+ (it never did on Rails 3 or 4).
+
+## [0.7.0][] (2017-04-21)
+
+* Support `index_errors: true` for `nest_many`.
+
+## [0.6.4][] (2017-02-27)
+
+* Fix an issue when using `ActiveType.cast` "too early".
+
+## [0.6.3][] (2017-01-30)
+
+* Fix a load error when using `ActiveType::Object` before using `ActiveRecord::Base` within a Rails app.
+
+## [0.6.2][] (2017-01-30)
+
+* When used with Rails, defer loading to not interfere with `ActiveRecord` configuration in initializers.
+
+## [0.6.1][] (2016-12-05)
+
+* Remove spec folder from packaged gem.
+
+## [0.6.0][] (2016-07-05)
+
+* Drop support for 1.8.7.
+* Rails 5 compatibility.
+
+## [0.5.1][] (2016-05-09)
+
+* Fix an issue with incorrectly copied errors on Util.cast.
+
+## [0.5.0][] (2016-04-08)
+
+* Nicer `#inspect` method.
+
+## [0.4.5][] (2016-02-01)
+
+* Fixed issue `#dup`ing `ActiveType::Object`
+
+## [0.4.4][] (2016-01-18)
+
+* Call `#after_commit` for `ActiveType::Object`
+
+## [0.4.3][] (2015-11-11)
+
+* Fix issue with Booleans on mysql.
+
+## [0.4.2][] (2015-09-24)
+
+* Add `attribute_will_change!` for virtual attributes.
+
+## [0.4.1][] (2015-09-24)
+
+* Add `attribute_was` for virtual attributes.
 
 ## [0.4.0][] (2015-06-12)
 

data/README.md

@@ -50,6 +50,23 @@ class SignUp < ActiveType::Record[User]
 end
 ```
 
+
+### A note on Rails 5
+
+Rails 5 comes with its own implementation of `.attribute`. This implementation is functionally very
+similar, but not identical to ActiveType's.
+
+We have decided to continue to use our own implementation. This means that if you use ActiveType, `ActiveRecord::Base.attribute` will be overriden.
+
+The following behaviours are different than in vanilla Rails 5:
+
+- Defaults `proc`s are evaluated in instance context, not class context.
+- Defaults are evaluated lazily.
+- You can override attributes with custom methods and use `super`.
+- Attributes will work on records retrieved via `.find`.
+- Attributes will be duped if you dup the record.
+
+
 ### ActiveType::Object
 
 
@@ -112,13 +129,13 @@ end
 If you want to inherit from an ActiveType class, simply do
 
 ```ruby
-  class SignUp < ActiveType::Record[User]
-    # ...
-  end
+class SignUp < ActiveType::Record[User]
+  # ...
+end
 
-  class SpecialSignUp < SignUp
-    # ...
-  end
+class SpecialSignUp < SignUp
+  # ...
+end
 ```
 
 ### Defaults ####
@@ -147,6 +164,27 @@ SignIn.new(email: "tobias@example.org").nickname # "tobias"
 SignIn.new(email: "tobias@example.org", :nickname => "kratob").nickname # "kratob"
 ```
 
+### Overriding accessors
+
+You can override attribute getters and setters using `super`:
+
+```ruby
+class SignIn < ActiveType::Object
+
+  attribute :email, :string
+  attribute :nickname, :string
+  
+  def email
+    super.downcase
+  end
+  
+  def nickname=(value)
+    super(value.titleize)
+  end
+  
+end
+```
+
 ### Nested attributes
 
 ActiveType supports its own variant of nested attributes via the `nests_one` /
@@ -270,6 +308,13 @@ Supported options for `nests_many` / `nests_one` are:
   nests_many :documents, default: proc { Documents.all }
   ```
 
+Options supported exclusively by `nests_many` are:
+
+- `index_errors`
+
+  Use a boolean to get indexed errors on related records. In Rails 5 you can make it global with
+  `config.active_record.index_nested_attribute_errors = true`.
+
 
 Casting records or relations
 ----------------------------
@@ -278,7 +323,7 @@ When working with ActiveType you will often find it useful to cast an ActiveReco
 
 Use `ActiveType.cast` for this:
 
-```
+```ruby
 class User < ActiveRecord::Base
   ...
 end
@@ -296,7 +341,7 @@ This is basically like [`ActiveRecord#becomes`](http://apidock.com/rails/v4.2.1/
 
 You can also cast an entire relation (scope) to a relation of an `ActiveType::Record`:
 
-```
+```ruby
 adult_users = User.where('age >= 18')
 adult_sign_ups = ActiveType.cast(adult_users, SignUp)
 sign_up = adult_sign_ups.find(1)
@@ -307,14 +352,14 @@ sign_up.is_a?(SignUp) # => true
 Supported Rails versions
 ------------------------
 
-ActiveType is tested against ActiveRecord 3.2, 4.0, 4.1 and 4.2.
+ActiveType is tested against ActiveRecord 3.2, 4.0, 4.1, 4.2, 5.0, and 5.1.
 
 Later versions might work, earlier will not.
 
 Supported Ruby versions
 ------------------------
 
-ActiveType is tested against MRI 1.8.7 (for 3.2 only), 1.9.3, 2.0.0, 2.1.2.
+ActiveType is tested against 2.1.7 (for 3.2, 4.x only), 2.2.4 and 2.3.1.
 
 
 Installation
@@ -333,7 +378,7 @@ Development
 - We run tests against several ActiveRecord versions.
 - You can bundle all versions with `rake all:install`.
 - You can run specs against all versions with `rake all:spec`.
-- You can run specs against a single version with `VERSION=4.0 rake`.
+- You can run specs against a single version with `VERSION=4.2.1.pg rake` or `VERSION="4.2.1.*" rake`.
 
 If you are getting testing failures due to Mysql trying to connect as `root` user, you can put your Mysql credentials into `spec/support/database.yml`.
 See `spec/support/database.sample.yml` for an example.

data/Rakefile

@@ -4,13 +4,20 @@ require 'bundler/gem_tasks'
 desc 'Default: Run all specs.'
 task :default => 'all:spec'
 
+
+desc "Run specs and isolated specs"
+task :spec do
+  success = run_specs
+  fail "Tests failed" unless success
+end
+
 namespace :all do
 
   desc "Run specs on all versions"
   task :spec do
     success = true
     for_each_gemfile do
-      success &= system("bundle exec rspec spec")
+      success &= run_specs
     end
     fail "Tests failed" unless success
   end
@@ -40,3 +47,17 @@ def for_each_gemfile
     yield
   end
 end
+
+def for_each_isolated_spec
+  Dir["spec/isolated/**/*_spec.rb"].sort.each do |isolated_spec|
+    yield(isolated_spec)
+  end
+end
+
+def run_specs
+  success = system("bundle exec rspec spec --exclude-pattern '**/isolated/**'")
+  for_each_isolated_spec do |isolated_spec|
+    success &= system("bundle exec rspec #{isolated_spec}")
+  end
+  success
+end

data/active_type.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |s|
   s.description = s.summary
   s.license = 'MIT'
 
-  s.files         = `git ls-files -z`.split("\x0")
+  s.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   s.executables   = s.files.grep(%r{^bin/}) { |f| File.basename(f) }
   s.test_files    = s.files.grep(%r{^(test|spec|features)/})
   s.require_paths = ["lib"]
@@ -21,4 +21,5 @@ Gem::Specification.new do |s|
 
   s.add_runtime_dependency('activerecord', '>= 3.2')
 
+  s.required_ruby_version = '>= 1.9.3'
 end

data/gemfiles/Gemfile.3.2.mysql2

@@ -3,6 +3,7 @@ source 'https://rubygems.org'
 gem 'activerecord', '=3.2.22'
 gem 'rspec', '~> 3.4'
 gem 'mysql2', '= 0.3.17'
+gem 'rake'
 
 gem 'active_type', :path => '..'
 gem 'i18n', '=0.6.11' # 0.7 no longer builds for Ruby 1.8.7

data/gemfiles/Gemfile.3.2.mysql2.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    active_type (0.4.5)
+    active_type (0.7.5)
       activerecord (>= 3.2)
 
 GEM
@@ -24,6 +24,7 @@ GEM
     i18n (0.6.11)
     multi_json (1.11.2)
     mysql2 (0.3.17)
+    rake (10.4.2)
     rspec (3.4.0)
       rspec-core (~> 3.4.0)
       rspec-expectations (~> 3.4.0)
@@ -47,7 +48,8 @@ DEPENDENCIES
   activerecord (= 3.2.22)
   i18n (= 0.6.11)
   mysql2 (= 0.3.17)
+  rake
   rspec (~> 3.4)
 
 BUNDLED WITH
-   1.11.2
+   1.15.4

data/gemfiles/Gemfile.3.2.sqlite3

@@ -3,6 +3,7 @@ source 'https://rubygems.org'
 gem 'activerecord', '=3.2.22'
 gem 'rspec', '~>3.4'
 gem 'sqlite3'
+gem 'rake'
 
 gem 'active_type', :path => '..'
 gem 'i18n', '=0.6.11' # 0.7 no longer builds for Ruby 1.8.7

data/gemfiles/Gemfile.3.2.sqlite3.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    active_type (0.4.5)
+    active_type (0.7.5)
       activerecord (>= 3.2)
 
 GEM
@@ -23,6 +23,7 @@ GEM
     diff-lcs (1.2.5)
     i18n (0.6.11)
     multi_json (1.11.2)
+    rake (10.4.2)
     rspec (3.4.0)
       rspec-core (~> 3.4.0)
       rspec-expectations (~> 3.4.0)
@@ -46,8 +47,9 @@ DEPENDENCIES
   active_type!
   activerecord (= 3.2.22)
   i18n (= 0.6.11)
+  rake
   rspec (~> 3.4)
   sqlite3
 
 BUNDLED WITH
-   1.11.2
+   1.15.4

data/gemfiles/Gemfile.4.0.sqlite3

@@ -3,5 +3,6 @@ source 'https://rubygems.org'
 gem 'activerecord', '~>4.0.0'
 gem 'rspec', '~>3.4'
 gem 'sqlite3'
+gem 'rake'
 
 gem 'active_type', :path => '..'

data/gemfiles/Gemfile.4.0.sqlite3.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    active_type (0.4.5)
+    active_type (0.7.5)
       activerecord (>= 3.2)
 
 GEM
@@ -28,6 +28,7 @@ GEM
     i18n (0.7.0)
     minitest (4.7.5)
     multi_json (1.11.2)
+    rake (10.4.2)
     rspec (3.4.0)
       rspec-core (~> 3.4.0)
       rspec-expectations (~> 3.4.0)
@@ -51,8 +52,9 @@ PLATFORMS
 DEPENDENCIES
   active_type!
   activerecord (~> 4.0.0)
+  rake
   rspec (~> 3.4)
   sqlite3
 
 BUNDLED WITH
-   1.11.2
+   1.15.4

data/gemfiles/Gemfile.4.1.sqlite3

@@ -3,5 +3,6 @@ source 'https://rubygems.org'
 gem 'activerecord', '~>4.1.0'
 gem 'rspec', '~>3.4'
 gem 'sqlite3'
+gem 'rake'
 
 gem 'active_type', :path => '..'

data/gemfiles/Gemfile.4.1.sqlite3.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    active_type (0.4.5)
+    active_type (0.7.5)
       activerecord (>= 3.2)
 
 GEM
@@ -26,6 +26,7 @@ GEM
     i18n (0.7.0)
     json (1.8.3)
     minitest (5.8.3)
+    rake (10.4.2)
     rspec (3.4.0)
       rspec-core (~> 3.4.0)
       rspec-expectations (~> 3.4.0)
@@ -50,8 +51,9 @@ PLATFORMS
 DEPENDENCIES
   active_type!
   activerecord (~> 4.1.0)
+  rake
   rspec (~> 3.4)
   sqlite3
 
 BUNDLED WITH
-   1.11.2
+   1.15.4

data/gemfiles/Gemfile.4.2.1.mysql2

@@ -3,5 +3,6 @@ source 'https://rubygems.org'
 gem 'activerecord', '~>4.2.1'
 gem 'rspec', '~>3.4'
 gem 'mysql2', '~> 0.3.17'
+gem 'rake'
 
 gem 'active_type', :path => '..'

data/gemfiles/Gemfile.4.2.1.mysql2.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    active_type (0.4.5)
+    active_type (0.7.5)
       activerecord (>= 3.2)
 
 GEM
@@ -27,6 +27,7 @@ GEM
     json (1.8.3)
     minitest (5.8.3)
     mysql2 (0.3.20)
+    rake (10.4.2)
     rspec (3.4.0)
       rspec-core (~> 3.4.0)
       rspec-expectations (~> 3.4.0)
@@ -51,7 +52,8 @@ DEPENDENCIES
   active_type!
   activerecord (~> 4.2.1)
   mysql2 (~> 0.3.17)
+  rake
   rspec (~> 3.4)
 
 BUNDLED WITH
-   1.11.2
+   1.15.4

data/gemfiles/Gemfile.4.2.1.pg

@@ -3,5 +3,6 @@ source 'https://rubygems.org'
 gem 'activerecord', '~>4.2.1'
 gem 'rspec', '~>3.4'
 gem 'pg'
+gem 'rake'
 
 gem 'active_type', :path => '..'

data/gemfiles/Gemfile.4.2.1.pg.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    active_type (0.4.5)
+    active_type (0.7.5)
       activerecord (>= 3.2)
 
 GEM
@@ -27,6 +27,7 @@ GEM
     json (1.8.3)
     minitest (5.8.3)
     pg (0.18.4)
+    rake (10.4.2)
     rspec (3.4.0)
       rspec-core (~> 3.4.0)
       rspec-expectations (~> 3.4.0)
@@ -51,7 +52,8 @@ DEPENDENCIES
   active_type!
   activerecord (~> 4.2.1)
   pg
+  rake
   rspec (~> 3.4)
 
 BUNDLED WITH
-   1.11.2
+   1.15.4

data/gemfiles/Gemfile.4.2.1.sqlite3

@@ -3,5 +3,6 @@ source 'https://rubygems.org'
 gem 'activerecord', '~>4.2.1'
 gem 'rspec', '~> 3.4'
 gem 'sqlite3'
+gem 'rake'
 
 gem 'active_type', :path => '..'

data/gemfiles/Gemfile.4.2.1.sqlite3.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    active_type (0.4.5)
+    active_type (0.7.5)
       activerecord (>= 3.2)
 
 GEM
@@ -26,6 +26,7 @@ GEM
     i18n (0.7.0)
     json (1.8.3)
     minitest (5.8.3)
+    rake (10.4.2)
     rspec (3.4.0)
       rspec-core (~> 3.4.0)
       rspec-expectations (~> 3.4.0)
@@ -50,8 +51,9 @@ PLATFORMS
 DEPENDENCIES
   active_type!
   activerecord (~> 4.2.1)
+  rake
   rspec (~> 3.4)
   sqlite3
 
 BUNDLED WITH
-   1.11.2
+   1.15.4

data/gemfiles/Gemfile.5.0.0.mysql2.lock

@@ -0,0 +1,56 @@
+PATH
+  remote: ..
+  specs:
+    active_type (0.7.0)
+      activerecord (>= 3.2)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (5.0.0)
+      activesupport (= 5.0.0)
+    activerecord (5.0.0)
+      activemodel (= 5.0.0)
+      activesupport (= 5.0.0)
+      arel (~> 7.0)
+    activesupport (5.0.0)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (~> 0.7)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+    arel (7.0.0)
+    concurrent-ruby (1.0.2)
+    diff-lcs (1.2.5)
+    i18n (0.7.0)
+    minitest (5.9.0)
+    mysql2 (0.3.21)
+    rake (10.4.2)
+    rspec (3.5.0)
+      rspec-core (~> 3.5.0)
+      rspec-expectations (~> 3.5.0)
+      rspec-mocks (~> 3.5.0)
+    rspec-core (3.5.0)
+      rspec-support (~> 3.5.0)
+    rspec-expectations (3.5.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.5.0)
+    rspec-mocks (3.5.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.5.0)
+    rspec-support (3.5.0)
+    thread_safe (0.3.5)
+    tzinfo (1.2.2)
+      thread_safe (~> 0.1)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  active_type!
+  activerecord (~> 5.0.0)
+  mysql2 (~> 0.3.17)
+  rake
+  rspec (~> 3.4)
+
+BUNDLED WITH
+   1.12.1