active_triples-local_name 0.1.0 → 0.5.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MTcyOTBhODdmODAzNWQ5OWJiYjFlOWY3YTA4ZDRmZTBlNDIwYzI3MA==
+    OThlYTNlODZlOGMwNTBiZGE0ZjYwOWZiNDE1Njc2NjViNjljNjgyNw==
   data.tar.gz: !binary |-
-    MTRjNzcwNWQ3NjhkMjQzOWRlZTcyMDVkNTE3ZDFmZDA0NjUzNjM1Nw==
+    MGRlMjgyMmE1ZDMxOGRmN2ZjODA2MmNlYTcwYTBlN2FjMjc3NjFmNw==
 SHA512:
   metadata.gz: !binary |-
-    ZTRmYzc4NmEyMjgyYzg2MDE5MWNkMWVlZWJjZjExMzFmMWY4YzBkYTEyZWQ0
-    NTg4MTYyZGNlYmMzZGQyYzJmYjI1MDQ5YWNiZjMzMThiNTU5MmRiMGFmMGIx
-    NTI5YTVhNWQ5NDgwMzgyY2ViZGU2YmVjMWExOGVlOTIwOGVmNTA=
+    NmY4NjEzZDZmZTM0OWRjNGEwMTZmZTc2NzQ2YTMzZDAwZjYzOWFmZDljMWMw
+    ZDAwNWM0OGQ4ODU4MWVjNmRmNzk1NTU4MmJkNTVjOWRiM2VmMDdkMjE5ODRk
+    MGI1ODAxYmE2NDE3YTQ4YTRjZjk2YTNkNzJkNjVlYzllZGY4YzE=
   data.tar.gz: !binary |-
-    NjBkNDc3NTM4MjMwODlmYTk1M2RlNDJkMmVkMTVkNmJkNjllY2M2YzYzY2Jk
-    ZTUxMWIwMTc2MzkwNmIyYTdhMTVmMTIxODJjMDhlM2I3ZDEwMmViOGVlMGJm
-    MjhiNWI2NjBmYjYwZjU2MGEwZjc1OTM5NWUxMDk2ZTFmNGNjMzQ=
+    Mjc1ZTZkZGQxYTQyZTk2ZTEyMzBmMGI1NTA2ZmRjNTM1NDZkYjIxZDIzYjIy
+    ODg2ZjgzYmYwOGEyZTRiN2UxZGVhYWI3ODg4YTFjOWFkNmY2MzBhOTllOTRl
+    MWRlYzQwNTUwMmUxOWJkNWFmZWQyZjliYmM1YWU0NGQwMWM1MGQ=

data/.coveralls.yml

@@ -0,0 +1 @@
+service_name: travis-ci

data/.gitignore

@@ -1,7 +1,27 @@
-.bundle/
 log/*.log
-pkg/
-Gemfile.lock
-tmp/*
 .sass-cache
+*.gem
+*.rbc
+.bundle
+.config
+.yardoc
+Gemfile.lock
+InstalledFiles
+_yardoc
+coverage
+doc/
+lib/bundler/man
+pkg
+rdoc
+spec/reports
+test/tmp
+test/version_tmp
+tmp
+*.bundle
+*.so
+*.o
+*.a
+mkmf.log
 .idea
+.ruby-gemset
+.ruby-version

data/.travis.yml

@@ -1,4 +1,4 @@
-anguage: ruby
+language: ruby
 bundler_args: --without debug
 script: "bundle exec rspec spec"
 rvm:

data/Gemfile

@@ -2,7 +2,3 @@ source "https://rubygems.org"
 
 gemspec
 
-# GETTING FROM GEMFILE UNTIL ActiveTriples master CODE IS RELEASED (>0.4.0), THEN MOVE THIS BACK TO *.gemspec FILE
-# Use active-triple for handling of triple persistence
-gem 'active-triples', :git => 'git@github.com:no-reply/ActiveTriples.git', :branch => 'master'
-

data/README.md

@@ -1,5 +1,8 @@
 # ActiveTriples::LocalName
 
+[![Build Status](https://travis-ci.org/ActiveTriples/active_triples-local_name.png?branch=master)](https://travis-ci.org/ActiveTriples/active_triples-local_name)
+[![Coverage Status](https://coveralls.io/repos/ActiveTriples/active_triples-local_name/badge.png?branch=master)](https://coveralls.io/r/ActiveTriples/active_triples-local_name?branch=master)
+[![Gem Version](https://badge.fury.io/rb/active_triples-local_name.svg)](http://badge.fury.io/rb/active_triples-local_name)
 
 Provides utilities for working with local names under the [ActiveTriples](https://github.com/ActiveTriples/ActiveTriples) 
 framework.  Includes a default implementation of a local name minter.

data/active_triples-local_name.gemspec

@@ -7,21 +7,21 @@ Gem::Specification.new do |s|
   s.version     = ActiveTriples::LocalName::VERSION
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["E. Lynette Rayle"]
-  s.homepage    = 'https://github.com/no-reply/active_triples-local_name'
+  s.homepage    = 'https://github.com/ActiveTriples/active_triples-local_name'
   s.email       = 'elr37@cornell.edu'
   s.summary     = %q{Local name minter for ActiveTriples based resources.}
   s.description = %q{active_triples-local_name provides a standard interface and default implementation for a minter of the local name portion of a URI.}
   s.license     = "APACHE2"
   s.required_ruby_version     = '>= 1.9.3'
 
-  # GETTING FROM GEMFILE UNTIL persistent check CODE IS RELEASED
-  # s.add_dependency('active-triples', '~> 0.4')
+  s.add_dependency('active-triples', '~> 0.5')
 
   s.add_dependency('deprecation', '~> 0.1')
   s.add_dependency('activesupport', '>= 3.0.0')
 
   s.add_development_dependency('rdoc')
   s.add_development_dependency('rspec')
+  s.add_development_dependency('coveralls')
   s.add_development_dependency('guard-rspec')
 
   s.files         = `git ls-files`.split("\n")

data/lib/active_triples/local_name/minter.rb

@@ -26,6 +26,8 @@ module ActiveTriples
       # @raise [Exception] if for_class does not have base_uri configured
       # @raise [Exception] if an available local name is not found in the maximum allowed tries.
       #
+      # @note See README for examples passing in minter block.
+      #
       # @TODO This is inefficient if max_tries is large. Could try
       #    multi-threading. When using the default_minter included
       #    in this class, it is unlikely to be a problem and should
@@ -63,6 +65,8 @@ module ActiveTriples
       #   numeric as the first character.  Pass in an alpha character as <tt>:prefix</tt> to enforce this best
       #   practice.
       #
+      # @note See README for example overriding default minter.
+      #
       # @return [String] a uuid
       def self.default_minter( *options )
         prefix = options[0][:prefix] if ! options.empty? && options[0].is_a?(Hash) && options[0].key?(:prefix)

data/lib/active_triples/local_name/version.rb

@@ -1,5 +1,5 @@
 module ActiveTriples
   module LocalName
-    VERSION = "0.1.0"
+    VERSION = "0.5.0"
   end
 end

data/spec/active_triples/local_name/minter_spec.rb

@@ -81,10 +81,55 @@ describe ActiveTriples::LocalName::Minter do
       ActiveTriples::Repositories.clear_repositories!
     end
 
-    context "when class doesn't have base_uri defined" do
-      it "should raise an Exception" do
-        expect{ ActiveTriples::LocalName::Minter.generate_local_name(DummyResource) }.to raise_error(RuntimeError, 'Requires base_uri to be defined in for_class.')
+    context "when one or more arguments are invalid" do
+#      def self.generate_local_name(for_class, max_tries=10, *minter_args, &minter_block)
+
+      context "and all arguments are missing" do
+        it "should raise error" do
+          # NOTE: ruby < 2 puts out (0 for 1); ruby >= 2 puts out (0 for 1+)
+          expect{ ActiveTriples::LocalName::Minter.generate_local_name() }.
+              to raise_error(ArgumentError, /wrong number of arguments \(0 for 1\+?\)/)
+        end
+      end
+
+      context "and max_tries is negative" do
+        it "should raise error" do
+          expect{ ActiveTriples::LocalName::Minter.generate_local_name(DummyResource,-1) }.
+              to raise_error(ArgumentError, 'Argument max_tries must be >= 1 if passed in')
+        end
+      end
+
+      context "and class doesn't inherit from ActiveTriples::Resource" do
+        before do
+          class DummyNonResource
+          end
+        end
+        after do
+          Object.send(:remove_const, "DummyNonResource") if Object
+        end
+
+        it "should raise error" do
+          expect{ ActiveTriples::LocalName::Minter.generate_local_name(DummyNonResource) }.
+              to raise_error(ArgumentError, 'Argument for_class must inherit from ActiveTriples::Resource')
+        end
+      end
+
+
+      context "and class doesn't have base_uri defined" do
+        it "should raise error" do
+          expect{ ActiveTriples::LocalName::Minter.generate_local_name(DummyResource) }.
+              to raise_error(RuntimeError, 'Requires base_uri to be defined in for_class.')
+        end
       end
+
+      ## TODO: Can't see how to test this.  The test complains if I pass anything other than a Proc instead of complaining that the passing in thing isn't callable.
+      # context "block isn't callable" do
+      #   it "should raise error" do
+      #     x = "foo"
+      #     expect{ ActiveTriples::LocalName::Minter.generate_local_name(DummyResourceWithBaseURI,10,{:prefix => 'a'},&x) }.
+      #         to raise_error(ArgumentError, 'Invalid minter_block.')
+      #   end
+      # end
     end
 
     context "when all IDs available" do
@@ -92,8 +137,8 @@ describe ActiveTriples::LocalName::Minter do
         it "should generate an ID using default minter function" do
           id = ActiveTriples::LocalName::Minter.generate_local_name(DummyResourceWithBaseURI)
           expect(id).to be_kind_of String
-          expect(id.length).to be 36
-          id.should match /[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}/
+          expect(id.length).to eq 36
+          expect(id).to match /[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}/
         end
       end
 
@@ -290,8 +335,8 @@ describe ActiveTriples::LocalName::Minter do
         it "should generate a prefixed ID" do
           id = ActiveTriples::LocalName::Minter.generate_local_name(DummyResourceWithBaseURI,10,{:prefix=>"s"})
           expect(id).to be_kind_of String
-          expect(id.length).to be 37
-          id.should match /s[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}/
+          expect(id.length).to eq 37
+          expect(id).to match /s[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}/
         end
       end
 
@@ -299,8 +344,8 @@ describe ActiveTriples::LocalName::Minter do
         it "should generate ID ignoring prefix" do
           id = ActiveTriples::LocalName::Minter.generate_local_name(DummyResourceWithBaseURI,10,1)
           expect(id).to be_kind_of String
-          expect(id.length).to be 36
-          id.should match /[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}/
+          expect(id.length).to eq 36
+          expect(id).to match /[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}/
         end
       end
 
@@ -308,8 +353,8 @@ describe ActiveTriples::LocalName::Minter do
         it "should generate ID ignoring prefix" do
           id = ActiveTriples::LocalName::Minter.generate_local_name(DummyResourceWithBaseURI,10,{:prefix=>1.5})
           expect(id).to be_kind_of String
-          expect(id.length).to be 36
-          id.should match /[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}/
+          expect(id.length).to eq 36
+          expect(id).to match /[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}/
         end
       end
 
@@ -317,8 +362,8 @@ describe ActiveTriples::LocalName::Minter do
         it "should generate ID ignoring prefix" do
           id = ActiveTriples::LocalName::Minter.generate_local_name(DummyResourceWithBaseURI,10,{:prefix=>{"a"=>"b"}})
           expect(id).to be_kind_of String
-          expect(id.length).to be 36
-          id.should match /[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}/
+          expect(id.length).to eq 36
+          expect(id).to match /[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}/
         end
       end
 
@@ -326,11 +371,69 @@ describe ActiveTriples::LocalName::Minter do
         it "should generate ID ignoring prefix" do
           id = ActiveTriples::LocalName::Minter.generate_local_name(DummyResourceWithBaseURI,10,{:prefix=>[1,2,3]})
           expect(id).to be_kind_of String
-          expect(id.length).to be 36
-          id.should match /[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}/
+          expect(id.length).to eq 36
+          expect(id).to match /[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}/
         end
       end
     end
 
   end
+
+  describe "default_minter" do
+    context "when options are empty" do
+      it "creates a uuid" do
+        id = ActiveTriples::LocalName::Minter.default_minter
+        expect(id).to be_kind_of String
+        expect(id.length).to eq 36
+        expect(id).to match /[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}/
+      end
+    end
+
+    context "when options is passed a prefix" do
+      context "and prefix is string" do
+        it "should generate a prefixed ID" do
+          id = ActiveTriples::LocalName::Minter.default_minter({:prefix=>"s"})
+          expect(id).to be_kind_of String
+          expect(id.length).to eq 37
+          expect(id).to match /s[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}/
+        end
+      end
+
+      context "and prefix is integer" do
+        it "should generate ID ignoring prefix" do
+          id = ActiveTriples::LocalName::Minter.default_minter({:prefix=>1})
+          expect(id).to be_kind_of String
+          expect(id.length).to eq 36
+          expect(id).to match /[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}/
+        end
+      end
+
+      context "and prefix is float" do
+        it "should generate ID ignoring prefix" do
+          id = ActiveTriples::LocalName::Minter.default_minter({:prefix=>1.5})
+          expect(id).to be_kind_of String
+          expect(id.length).to eq 36
+          expect(id).to match /[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}/
+        end
+      end
+
+      context "and prefix is hash" do
+        it "should generate ID ignoring prefix" do
+          id = ActiveTriples::LocalName::Minter.default_minter({:prefix=>{"a"=>"b"}})
+          expect(id).to be_kind_of String
+          expect(id.length).to eq 36
+          expect(id).to match /[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}/
+        end
+      end
+
+      context "and prefix is array" do
+        it "should generate ID ignoring prefix" do
+          id = ActiveTriples::LocalName::Minter.default_minter({:prefix=>[1,2,3]})
+          expect(id).to be_kind_of String
+          expect(id.length).to eq 36
+          expect(id).to match /[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}/
+        end
+      end
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,3 +1,6 @@
+require 'coveralls'
+Coveralls.wear!
+
 require 'bundler/setup'
 Bundler.setup
 

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: active_triples-local_name
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.5.0
 platform: ruby
 authors:
 - E. Lynette Rayle
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-25 00:00:00.000000000 Z
+date: 2015-01-09 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: active-triples
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.5'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: deprecation
   requirement: !ruby/object:Gem::Requirement
@@ -66,6 +80,20 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -89,6 +117,7 @@ extra_rdoc_files:
 - LICENSE
 - README.md
 files:
+- .coveralls.yml
 - .gitignore
 - .travis.yml
 - AUTHORS
@@ -102,8 +131,7 @@ files:
 - lib/active_triples/local_name/version.rb
 - spec/active_triples/local_name/minter_spec.rb
 - spec/spec_helper.rb
-- spec/support/active_model_lint.rb
-homepage: https://github.com/no-reply/active_triples-local_name
+homepage: https://github.com/ActiveTriples/active_triples-local_name
 licenses:
 - APACHE2
 metadata: {}

data/spec/support/active_model_lint.rb

@@ -1,81 +0,0 @@
-shared_examples_for "an ActiveModel" do
-  subject { described_class.new }
-
-  describe '#to_key' do
-    it 'should respond' do
-      expect(subject).to respond_to :to_key
-    end
-
-    it 'should return nil when #persisted? is false ' do
-      def subject.persisted?() false end
-      expect(subject.to_key).to eq nil
-    end
-  end
-
-  describe '#to_param' do
-    it 'should respond' do
-      expect(subject).to respond_to :to_param
-    end
-
-    it 'should return nil when #persisted? is false ' do
-      def subject.persisted?() false end
-      expect(subject.to_param).to eq nil
-    end
-  end
-
-  describe '#model_name' do
-    let(:model_name) { subject.class.model_name }
-
-    it 'should have a model name' do
-      expect(model_name).to respond_to :to_str
-    end
-
-    it 'should have a human name' do
-      expect(model_name.human).to respond_to :to_str
-    end
-
-    it 'should have a singular name' do
-      expect(model_name.singular).to respond_to :to_str
-    end
-
-    it 'should have a plural name' do
-      expect(model_name.plural).to respond_to :to_str
-    end
-  end
-
-  describe '#to_partial_path' do
-    it 'should return a string' do
-      expect(subject.to_partial_path).to be_a String
-    end
-  end
-
-  describe '#persisted?' do
-    it 'should return a boolean' do
-      expect(match_boolean(subject.persisted?)).to be true
-    end
-  end
-
-  describe '#valid?' do
-    it 'should return a boolean' do
-      expect(match_boolean(subject.valid?)).to be true
-    end
-  end
-
-  describe '#new_record' do
-    it 'should return a boolean' do
-      expect(match_boolean(subject.new_record?)).to be true
-    end
-  end
-
-  describe '#destroyed?' do
-    it 'should return a boolean' do
-      expect(match_boolean(subject.destroyed?)).to be true
-    end
-  end
-
-  private 
-  
-    def match_boolean(result)
-      result == true || result == false
-    end
-end