active_store_accessor 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4292ddb949e1408e098e6b011b793712fac73aab
-  data.tar.gz: be546cf4e8bfc20c9ac95b42adaff2e45de4c29e
+  metadata.gz: 21798f125f793a3a4f664dd3c005871f64228658
+  data.tar.gz: 8c0f9fabb18aa63200c14889911b86a346f3603d
 SHA512:
-  metadata.gz: 5430d75c6d0b771b4221b60356c7388881da5233b57815d1381ab170bb874a18a7eed652bbb7d730870c6056a08a5d861d81807329b765fd99e8d13f3d2e1f70
-  data.tar.gz: ee4f46f15a41cc510c488ea0cbb8a75629315bad8b1550b976e6bcfba01d16a58ace185ed205031a98f6764eb0df06eed4f95ea05e71c2e2b9c7d797fdf7bb9e
+  metadata.gz: 30bd5cc30e6d13bc183c0889d2f19ebb9163e0bdf69c163ff63481ace00f76a4e9f3b2c460fc0ec1349b72be28ada3e2a214c17d885764135ae6b75ece8684f5
+  data.tar.gz: d513515b3108bf6d697b59112e58f16f2cbcfce679d3fa9c4fadc3505f36e8ecd930ebe3b9459766b9fe80ad87e87753e01139ad16596a36ed32bf0dfd00c624

data/.travis.yml

@@ -1,8 +1,11 @@
 env:
-  - "RAILS_VERSION=3.2"
-  - "RAILS_VERSION=4.0"
-  - "RAILS_VERSION=master"
+  - "AR_VERSION=4.0"
+  - "AR_VERSION=4.1"
 rvm:
   - 1.9.3
   - 2.0.0
   - 2.1.2
+addons:
+  postgresql: "9.3"
+before_script:
+  - psql -c 'create database asa_test;' -U rails

data/Gemfile

@@ -1,14 +1,14 @@
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in active_store_accessor.gemspec
-gemspec
 
 ar_version = ENV["AR_VERSION"]
 ar_version = case ar_version
-  when "3.2" then "~> 3.2.0"
   when "4.0" then "~> 4.0.0"
   else
     "~> 4.1.0"
   end
-gem "activerecord", ar_version
-gem "sqlite3"
+gem "activerecord", ar_version, require: ["active_record", "active_support/all"]
+gem "pg"
+
+gemspec

data/README.md

@@ -4,7 +4,7 @@
 [![Gem Version](https://badge.fury.io/rb/active_store_accessor.svg)](http://badge.fury.io/rb/active_store_accessor)
 [![Code Climate](https://codeclimate.com/github/jalkoby/active_store_accessor.png)](https://codeclimate.com/github/jalkoby/active_store_accessor)
 
-With `active_store_accessor` you can have boolean, integer, float, time store attributes which would act like a regular schema columns.  
+With `active_store_accessor` you can have boolean, integer, float, time store attributes which would act like a regular schema columns.
 
 ## Usage
 
@@ -16,7 +16,7 @@ class Profile < ActiveRecord::Base
   active_store_accessor :info, age: :integer, birthday: :time
 
   # with default values
-  active_store_accessor :info, score: { type: :float, default: 0.0 }, 
+  active_store_accessor :info, score: { type: :float, default: 0.0 },
     active: { type: :boolean, default: true }
 end
 
@@ -39,10 +39,10 @@ Add this line to your application's Gemfile:
 And then execute:
 
     $ bundle
-    
+
 ## Requirements & dependencies
 
-This library has been tested on ruby 1.9.3+ and activerecord 3.2+. Any other configurations might have potential issues. `active_store_accessor` doesn't have any external dependency(expect activerecord) and contains only one file with one module.
+This library has been tested on ruby 1.9.3+ and activerecord 4.0+. Any other configurations might have potential issues. `active_store_accessor` doesn't have any external dependency(expect activerecord) and contains only one file with one module.
 
 ## Contributing
 

data/active_store_accessor.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "active_store_accessor"
-  spec.version       = "0.1.1"
+  spec.version       = "0.1.2"
   spec.authors       = ["Sergey Pchelincev"]
   spec.email         = ["mail@sergeyp.me"]
   spec.summary       = %q{Get more from ActiveRecord::Store}
@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "activerecord", ">= 3.2"
+  spec.add_dependency "activerecord", ">= 4.0"
   spec.add_development_dependency "bundler", "~> 1.6"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "minitest", ">= 4.7"

data/lib/active_store_accessor.rb

@@ -6,7 +6,12 @@ module ActiveStoreAccessor
   end
 
   def active_store_accessor(column_name, attrs)
-    store column_name, accessors: attrs.keys
+    if columns.detect { |column| column.name == column_name.to_s }.text?
+      serialize(column_name) unless serialized_attributes.include?(column_name.to_s)
+    end
+
+    store_accessor column_name, *attrs.keys
+
     attrs.each do |attr_name, options|
       options = { type: options.to_s } unless options.is_a?(Hash)
       type = options.fetch(:type) { raise ArgumentError, "please specify type of attribute" }.to_s

data/tests/lib/active_store_accessor_test.rb

@@ -20,7 +20,7 @@ describe ActiveStoreAccessor do
     assert_equal profile.score, 100
     assert_equal profile.rank, 3213.312
     assert_equal profile.birthday, Time.utc(2014, 5, 12)
-    assert_equal profile.confirmed, true
+    assert profile.confirmed
   end
 
   it "should support model inheritance" do
@@ -29,4 +29,11 @@ describe ActiveStoreAccessor do
     assert_equal admin_profile.age, 23
     assert_equal admin_profile.level, 5
   end
+
+  it "handles properly hstore" do
+    profile = Profile.create(active: true, pi: 3.14)
+
+    assert profile.active
+    assert_equal profile.pi, 3.14
+  end
 end

data/tests/test_helper.rb

@@ -2,12 +2,18 @@ require "minitest/autorun"
 require "active_record"
 require "active_store_accessor"
 
-ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')
+ActiveRecord::Base.establish_connection(adapter: 'postgresql', database: 'asa_test', user: 'rails')
 ActiveRecord::Base.logger = Logger.new(STDOUT)
+ActiveRecord::Base.connection.execute "drop schema public cascade"
+ActiveRecord::Base.connection.execute "create schema public"
+ActiveRecord::Base.connection.execute "CREATE EXTENSION IF NOT EXISTS hstore"
 
 ActiveRecord::Schema.define do
+  enable_extension "hstore"
+
   create_table :profiles do |t|
     t.text :info
+    t.hstore :keys
   end
 end
 
@@ -16,6 +22,9 @@ class Profile < ActiveRecord::Base
   active_store_accessor :info, rank: :float
   active_store_accessor :info, birthday: :time
   active_store_accessor :info, confirmed: :boolean
+
+  active_store_accessor :keys, active: :boolean
+  active_store_accessor :keys, pi: :float
 end
 
 class AdminProfile < Profile

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_store_accessor
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Sergey Pchelincev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-31 00:00:00.000000000 Z
+date: 2014-06-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement