active_storage_validations 4.0.0 → 4.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 21b87628a4e532d945c76ceca7d37444c7524f15ed11b587a4bab0a5eae7eaef
-  data.tar.gz: 90fd47c4a439b00503e8997de2e344ace1771d15206a1e147fb785b94280abd4
+  metadata.gz: 5a6bd490e0f58921da42838a5df629556c0e9f84a01c114b8772ac195afea917
+  data.tar.gz: 397f02aeea00242f94af79a422d37dbcd90c1e07946107bf08f2dccf1da0c793
 SHA512:
-  metadata.gz: b851e77dcdd882cb2bcae49dc3871c5d5d5920409cb94bba357a77ecd55ff34efd0266fe52bb0866bf31db52eb324bc0ef80749d2805dd27b97d7c89a2adcb51
-  data.tar.gz: 422c62e2832c2adf34686832ec76ecc570f093133110838234c854c2ede5485324ebf9865aeb911f590a9c003485fd2d6535cced5e74d6ec686a562157ce983a
+  metadata.gz: ffc3c1b5b9a722dbc2b33d57560fdc41a2efb5ec68095883e15d251024e073f5d34342a2c0f10515794bd1ea6aeed1de593ca0e345af9cfb130d2d424543bf9a
+  data.tar.gz: aaf819d38fd5e91de9eeb68248b9d8e4f0faf733a9b5773a682819bb19933b6e740336315842914a1962b9ef2c39f2b9637fd3c481e584dd9c4f566237f0ace5

data/README.md

@@ -31,6 +31,7 @@ This gem is doing it right for you! Just use `validates :avatar, attached: true,
   - [Total size](#total-size)
   - [Dimension](#dimension)
   - [Duration](#duration)
+  - [With audio](#with-audio)
   - [Aspect ratio](#aspect-ratio)
   - [Processable file](#processable-file)
   - [Pages](#pages)
@@ -76,7 +77,7 @@ We recommend **libvips** (`ruby-vips` + `config.active_storage.variant_processor
 
 ### Using video and audio metadata validators
 
-To use the video and audio metadata validators (`dimension`, `aspect_ratio`, `processable_file` and `duration`), you will not need to add any gems. However you will need to have the `ffmpeg` command-line tool installed on your system (once again, be sure to have it installed both on your local and in your CI / production environments).
+To use the video and audio metadata validators (`dimension`, `aspect_ratio`, `processable_file`, `duration` and `with_audio`), you will not need to add any gems. However you will need to have the `ffmpeg` command-line tool installed on your system (once again, be sure to have it installed both on your local and in your CI / production environments).
 
 ### Using pdf metadata validators
 
@@ -113,9 +114,22 @@ end
 #   event = ActiveSupport::Notifications::Event.new(*args)
 #   Rails.logger.warn("[ASV] command timeout: #{event.payload}")
 # end
+
+# Optional: monitor how long metadata / content type analysis takes
+# ActiveSupport::Notifications.subscribe("analyze.active_storage_validations") do |*args|
+#   event = ActiveSupport::Notifications::Event.new(*args)
+#   Rails.logger.info("[ASV] analyzed: #{event.payload}")
+# end
 ```
 
-`command_timeout` bounds metadata analysis used by `dimension`, `aspect_ratio`, `duration`, `pages`, `processable_file`, and `content_type` (with `spoofing_protection`). When a command times out, analysis fails closed and the validator adds its usual error (`file_not_processable` / `media_metadata_missing` / content-type errors) — there is no separate timeout error message.
+The gem emits two `ActiveSupport::Notifications` events:
+
+| Event | Payload | Emitted |
+|---|---|---|
+| `analyze.active_storage_validations` | `analyzer`, `command`, `timeout`, `timed_out`, `duration` | Every time an analyzer command runs (i.e. on a cache miss) |
+| `timeout.active_storage_validations` | `analyzer`, `command`, `timeout` | Only when a command exceeds its deadline |
+
+`command_timeout` bounds metadata analysis used by `dimension`, `aspect_ratio`, `duration`, `with_audio`, `pages`, `processable_file`, and `content_type` (with `spoofing_protection`). When a command times out, analysis fails closed and the validator adds its usual error (`file_not_processable` / `media_metadata_missing` / `audio_missing` / content-type errors) — there is no separate timeout error message.
 
 The 10s default is enough for typical uploads. Raise it (or set `nil`) if you analyze very large videos/PDFs, especially on slow or network storage — otherwise those files can start failing validation after upgrade. See [upgrade to 4.x](docs/upgrade_to_4.md#analyzer-command-timeout).
 
@@ -140,6 +154,7 @@ Notes:
 - [Total size](#total-size): validates total file size for several files
 - [Dimension](#dimension): validates image / video dimensions
 - [Duration](#duration): validates video / audio duration
+- [With audio](#with-audio): validates whether a video / audio file contains an audio track
 - [Aspect ratio](#aspect-ratio): validates image / video aspect ratio
 - [Processable file](#processable-file): validates if a file can be processed
 - [Pages](#pages): validates pdf number of pages
@@ -161,6 +176,8 @@ Some validators rely on an expensive operation (metadata analysis and content ty
 
 As stated in the Rails documentation: "Blobs are intended to be immutable in so far as their reference to a specific file goes". We based our performance optimization on the same assumption, so if you do not follow it, the gem will not work as expected.
 
+This also covers metadata the analyzer cannot extract from a given file (e.g. a `duration` validation on an image): the gem remembers that the value is unavailable, so the validation keeps failing with `media_metadata_missing` but the file is only analyzed once. Files that yield no metadata at all — missing command-line tool, [timed out](#configuration) command, unreadable file — are not remembered and get analyzed again on the next validation.
+
 ---
 
 ### Attached
@@ -317,7 +334,8 @@ ActiveStorageValidations.configure { |config| config.infer_file_field_accept = f
 
 Notes:
 - Only broad MIME-type regexes of the form `/\Aimage\/.*\z/` (or `video` / `audio` / etc.) are inferred, as `image/*`
-- Other regexes (e.g. `/\Aimage\/(png|gif)\z/`) and Proc / dynamic `content_type` options are skipped, since they cannot be reliably represented in `accept`
+- Other regexes (e.g. `/\Aimage\/(png|gif)\z/`) are skipped, since they cannot be reliably represented in `accept`
+- Proc / dynamic `content_type` options are skipped: they are not called while the form renders, because their result can depend on record state that is only set on submit, and a raising proc would break the whole view for what is merely a frontend hint. Backend validation is unchanged; pass a custom `accept:` on those fields if you want the picker filtered
 - Conditional validators (`if:` / `unless:`) are not evaluated: their content types are always included in `accept`, even when the condition would skip the validator for that record. Backend validation is unchanged; use `infer_accept: false` (or a custom `accept:`) if the picker must match the active conditions
 
 #### Content type shorthands
@@ -362,7 +380,7 @@ Spoofing protection compares the declared Active Storage content type to a type
 
 Neither backend fully parses the file. They do **not** load the whole file into RAM. For already-persisted blobs (e.g. remote storage), the analyzer still downloads the blob to a local tempfile before sniffing. That download is streamed in chunks to disk, but it can still be costly for very large files. Local path uploads are analyzed in place.
 
-Detected types are cached on the blob as `asv_content_type` + `asv_content_type_backend`. Switching backend re-analyzes. Legacy blobs that only have `asv_content_type` (no backend key) are treated as `:file` and keep using the cache — they are not re-analyzed.
+Detected types are cached on the blob as `asv_content_type` + `asv_content_type_backend`. Switching backend re-analyzes. Legacy blobs that only have `asv_content_type` (no backend key) are treated as `:file` and keep using the cache — they are not re-analyzed. New (unsaved) blobs keep `asv_*` in memory until the record is saved; already-persisted blobs write the cache immediately so it survives `reload`.
 
 Sniffers will not always return the exact same MIME as Active Storage (AS uses first ~4kb + filename + extension). Close parent types are accepted via `Marcel::TYPE_PARENTS` (e.g. `video/x-ms-wmv` vs `video/x-ms-asf`).
 
@@ -644,6 +662,49 @@ The `duration` validator error messages expose 4 values that you can use:
 
 ---
 
+### With audio
+
+Validates whether attached video / audio files contain an audio track.
+(be sure to have the right dependencies installed as mentioned in [Using video and audio metadata validators](#using-video-and-audio-metadata-validators))
+
+#### Options
+
+The `with_audio` validator supports:
+- `with`: `true` requires an audio track and `false` rejects one
+- `timeout`: overrides the global analyzer [command timeout](#configuration) for this validation
+
+#### Examples
+
+Use it like this:
+```ruby
+class User < ApplicationRecord
+  has_one_attached :video
+  has_one_attached :silent_video
+
+  validates :video, with_audio: true
+  validates :silent_video, with_audio: { with: false }
+  validates :video, with_audio: { timeout: 5.seconds }
+end
+```
+
+Rails treats a bare `with_audio: false` as a disabled validator. Use the hash form `with_audio: { with: false }` to reject files that contain audio.
+
+Files that cannot contain an audio stream at all (images, pdfs) are treated as having no audio track: they fail `with_audio: true` and pass `with_audio: { with: false }`.
+
+#### Error messages (I18n)
+
+```yml
+en:
+  errors:
+    messages:
+      audio_missing: "must have an audio track"
+      audio_present: "must not have an audio track"
+```
+
+The `with_audio` validator error message exposes the `filename` value containing the current file name.
+
+---
+
 ### Aspect ratio
 
 Validates the aspect ratio of the attached image / video files.
@@ -895,6 +956,10 @@ describe User do
   it { is_expected.to validate_duration_of(:introduction).between(100..500.seconds) }
   it { is_expected.to validate_duration_of(:avatar).equal_to(5.minutes) }
 
+  # with_audio
+  it { is_expected.to validate_with_audio_of(:video) }
+  it { is_expected.to validate_with_audio_of(:silent_video).without_audio }
+
   # pages:
   # #less_than, #less_than_or_equal_to, #greater_than, #greater_than_or_equal_to, #between, #equal_to
   it { is_expected.to validate_pages_of(:contract).less_than(50) }
@@ -911,9 +976,6 @@ All matchers can currently be customized with these options:
 
 ```ruby
 describe User do
-  # :allow_blank
-  it { is_expected.to validate_attached_of(:avatar).allow_blank }
-
   # :on
   it { is_expected.to validate_attached_of(:avatar).on(:update) }
   it { is_expected.to validate_attached_of(:avatar).on(%i[update custom]) }
@@ -927,6 +989,7 @@ describe User do
 
   # :timeout (analyzer command timeout — metadata validators + content_type with spoofing)
   it { is_expected.to validate_duration_of(:video).less_than(5.minutes).timeout(30.seconds) }
+  it { is_expected.to validate_with_audio_of(:video).timeout(5.seconds) }
   it { is_expected.to validate_processable_file_of(:avatar).timeout(5.seconds) }
 end
 ```
@@ -934,7 +997,7 @@ end
 ### Minitest
 
 #### Setup
-To use the matchers, make sure you have the [shoulda-context](https://github.com/thoughtbot/shoulda-context) gem up and running.
+To use the matchers, make sure you have the [shoulda-context](https://github.com/thoughtbot/shoulda-context) gem up and running. No extra mock library is required (`minitest-mock` is not needed on Minitest 6).
 
 You need to require the matchers:
 

data/config/locales/da.yml

@@ -55,6 +55,8 @@ da:
       aspect_ratio_not_x_y: "skal være %{authorized_aspect_ratios} (nuværende fil er %{width}x%{height}px)"
       aspect_ratio_invalid: "har et ugyldigt aspektforhold (gyldige aspektforhold er %{authorized_aspect_ratios})"
       file_not_processable: "identificeres ikke som en gyldig mediefil"
+      audio_missing: "skal have et lydspor"
+      audio_present: "må ikke have et lydspor"
       pages_not_less_than: "sideantal skal være mindre end %{max} (aktuelt sideantal er %{pages})"
       pages_not_less_than_or_equal_to: "sideantal skal være mindre end eller lig med %{max} (aktuelt sideantal er %{pages})"
       pages_not_greater_than: "sideantal skal være større end %{min} (aktuelt sideantal er %{pages})"

data/config/locales/de.yml

@@ -55,6 +55,8 @@ de:
       aspect_ratio_not_x_y: "muss %{authorized_aspect_ratios} sein (aktuelle Datei ist %{width}x%{height}px)"
       aspect_ratio_invalid: "hat ein ungültiges Seitenverhältnis (gültige Seitenverhältnisse sind %{authorized_aspect_ratios})"
       file_not_processable: "wird nicht als gültige Mediendatei identifiziert"
+      audio_missing: "muss eine Audiospur enthalten"
+      audio_present: "darf keine Audiospur enthalten"
       pages_not_less_than: "Die Seitenanzahl muss kleiner als %{max} sein (die aktuelle Seitenanzahl beträgt %{pages})."
       pages_not_less_than_or_equal_to: "Die Seitenanzahl muss kleiner oder gleich %{max} sein (die aktuelle Seitenanzahl beträgt %{pages})."
       pages_not_greater_than: "Die Seitenanzahl muss größer als %{min} sein (die aktuelle Seitenanzahl beträgt %{pages})."

data/config/locales/en-GB.yml

@@ -55,6 +55,8 @@ en-GB:
       aspect_ratio_not_x_y: "must be %{authorized_aspect_ratios} (current file is %{width}x%{height}px)"
       aspect_ratio_invalid: "has an invalid aspect ratio (valid aspect ratios are %{authorized_aspect_ratios})"
       file_not_processable: "is not identified as a valid media file"
+      audio_missing: "must have an audio track"
+      audio_present: "must not have an audio track"
       pages_not_less_than: "page count must be less than %{max} (current page count is %{pages})"
       pages_not_less_than_or_equal_to: "page count must be less than or equal to %{max} (current page count is %{pages})"
       pages_not_greater_than: "page count must be greater than %{min} (current page count is %{pages})"

data/config/locales/en.yml

@@ -55,6 +55,8 @@ en:
       aspect_ratio_not_x_y: "must be %{authorized_aspect_ratios} (current file is %{width}x%{height}px)"
       aspect_ratio_invalid: "has an invalid aspect ratio (valid aspect ratios are %{authorized_aspect_ratios})"
       file_not_processable: "is not identified as a valid media file"
+      audio_missing: "must have an audio track"
+      audio_present: "must not have an audio track"
       pages_not_less_than: "page count must be less than %{max} (current page count is %{pages})"
       pages_not_less_than_or_equal_to: "page count must be less than or equal to %{max} (current page count is %{pages})"
       pages_not_greater_than: "page count must be greater than %{min} (current page count is %{pages})"

data/config/locales/es.yml

@@ -55,6 +55,8 @@ es:
       aspect_ratio_not_x_y: "debe ser %{authorized_aspect_ratios} (el archivo actual es %{width}x%{height}px)"
       aspect_ratio_invalid: "tiene una relación de aspecto inválida (las relaciones de aspecto válidas son %{authorized_aspect_ratios})"
       file_not_processable: "no se identifica como un archivo multimedia válido"
+      audio_missing: "debe tener una pista de audio"
+      audio_present: "no debe tener una pista de audio"
       pages_not_less_than: "el número de páginas debe ser menor que %{max} (el número actual de páginas es %{pages})"
       pages_not_less_than_or_equal_to: "el número de páginas debe ser menor o igual que %{max} (el número actual de páginas es %{pages})"
       pages_not_greater_than: "el número de páginas debe ser mayor que %{min} (el número actual de páginas es %{pages})"

data/config/locales/fr.yml

@@ -55,6 +55,8 @@ fr:
       aspect_ratio_not_x_y: "doit être %{authorized_aspect_ratios} (le fichier actuel est %{width}x%{height}px)"
       aspect_ratio_invalid: "a un rapport d'aspect invalide (les rapports d'aspect valides sont %{authorized_aspect_ratios})"
       file_not_processable: "n'est pas identifié comme un fichier média valide"
+      audio_missing: "doit contenir une piste audio"
+      audio_present: "ne doit pas contenir de piste audio"
       pages_not_less_than: "le nombre de pages doit être inférieur à %{max} (le nombre actuel est de %{pages})"
       pages_not_less_than_or_equal_to: "le nombre de pages doit être inférieur ou égal à %{max} (le nombre actuel est de %{pages})"
       pages_not_greater_than: "le nombre de pages doit être supérieur à %{min} (le nombre actuel est de %{pages})"

data/config/locales/it.yml

@@ -55,6 +55,8 @@ it:
       aspect_ratio_not_x_y: "deve essere %{authorized_aspect_ratios} (il file corrente è %{width}x%{height}px)"
       aspect_ratio_invalid: "ha un formato non valido (i rapporti di aspetto validi sono %{authorized_aspect_ratios})"
       file_not_processable: "non è identificato come file multimediale valido"
+      audio_missing: "deve contenere una traccia audio"
+      audio_present: "non deve contenere una traccia audio"
       pages_not_less_than: "il numero di pagine deve essere inferiore a %{max} (il numero di pagine corrente è %{pages})"
       pages_not_less_than_or_equal_to: "il numero di pagine deve essere inferiore o uguale a %{max} (il numero di pagine corrente è %{pages})"
       pages_not_greater_than: "il numero di pagine deve essere maggiore di %{min} (il numero di pagine corrente è %{pages})"

data/config/locales/ja.yml

@@ -55,6 +55,8 @@ ja:
       aspect_ratio_not_x_y: "のアスペクト比は%{authorized_aspect_ratios}にしてください (添付されたメディアの解像度は%{width}x%{height})"
       aspect_ratio_invalid: "のアスペクト比を検出できません (許可されたアスペクト比は%{authorized_aspect_ratios})"
       file_not_processable: "のメディアを処理できません"
+      audio_missing: "には音声トラックが必要です"
+      audio_present: "に音声トラックを含めることはできません"
       pages_not_less_than: "のページ数は%{max}未満にしてください (添付されたファイルは%{pages}ページ)"
       pages_not_less_than_or_equal_to: "のページ数は%{max}以下にしてください (添付されたファイルは%{pages}ページ)"
       pages_not_greater_than: "のページ数は%{min}より大きくしてください (添付されたファイルは%{pages}ページ)"

data/config/locales/nl.yml

@@ -55,6 +55,8 @@ nl:
       aspect_ratio_not_x_y: "moet %{authorized_aspect_ratios} zijn (huidig bestand is %{width}x%{height}px)"
       aspect_ratio_invalid: "heeft een ongeldige beeldverhouding (geldige beeldverhoudingen zijn %{authorized_aspect_ratios})"
       file_not_processable: "wordt niet geïdentificeerd als een geldig mediabestand"
+      audio_missing: "moet een audiotrack bevatten"
+      audio_present: "mag geen audiotrack bevatten"
       pages_not_less_than: "het aantal pagina's moet kleiner zijn dan %{max} (het huidige aantal pagina's is %{pages})"
       pages_not_less_than_or_equal_to: "het aantal pagina's moet kleiner zijn dan of gelijk zijn aan %{max} (het huidige aantal pagina's is %{pages})"
       pages_not_greater_than: "het aantal pagina's moet groter zijn dan %{min} (het huidige aantal pagina's is %{pages})"

data/config/locales/pl.yml

@@ -55,6 +55,8 @@ pl:
       aspect_ratio_not_x_y: "musi być %{authorized_aspect_ratios} (bieżący plik to %{width}x%{height}px)"
       aspect_ratio_invalid: "ma nieprawidłowy współczynnik kształtu (ważne współczynniki kształtu wynoszą %{authorized_aspect_ratios})"
       file_not_processable: "nie jest identyfikowany jako prawidłowy plik multimedialny"
+      audio_missing: "musi zawierać ścieżkę dźwiękową"
+      audio_present: "nie może zawierać ścieżki dźwiękowej"
       pages_not_less_than: "liczba stron musi być mniejsza niż %{max} (bieżąca liczba stron to %{pages})"
       pages_not_less_than_or_equal_to: "liczba stron musi być mniejsza lub równa %{max} (bieżąca liczba stron to %{pages})"
       pages_not_greater_than: "liczba stron musi być większa niż %{min} (bieżąca liczba stron to %{pages})"

data/config/locales/pt-BR.yml

@@ -55,6 +55,8 @@ pt-BR:
       aspect_ratio_not_x_y: "deve ser %{authorized_aspect_ratios} (o arquivo atual é %{width}x%{height}px)"
       aspect_ratio_invalid: "tem uma proporção inválida (as proporções válidas são %{authorized_aspect_ratios})"
       file_not_processable: "não é identificado como um arquivo de mídia válido"
+      audio_missing: "deve ter uma faixa de áudio"
+      audio_present: "não deve ter uma faixa de áudio"
       pages_not_less_than: "a contagem de páginas deve ser menor que %{max} (a contagem atual de páginas é %{pages})"
       pages_not_less_than_or_equal_to: "a contagem de páginas deve ser menor ou igual a %{max} (a contagem atual de páginas é %{pages})"
       pages_not_greater_than: "a contagem de páginas deve ser maior que %{min} (a contagem atual de páginas é %{pages})"

data/config/locales/ru.yml

@@ -55,6 +55,8 @@ ru:
       aspect_ratio_not_x_y: "должно быть %{authorized_aspect_ratios} (текущий файл %{width}x%{height} пикселей)"
       aspect_ratio_invalid: "имеет недействительное соотношение сторон (действительные соотношения сторон %{authorized_aspect_ratios})"
       file_not_processable: "не идентифицируется как действительный медиафайл"
+      audio_missing: "должен содержать аудиодорожку"
+      audio_present: "не должен содержать аудиодорожку"
       pages_not_less_than: "количество страниц должно быть меньше %{max} (текущее количество страниц %{pages})"
       pages_not_less_than_or_equal_to: "количество страниц должно быть меньше или равно %{max} (текущее количество страниц %{pages})"
       pages_not_greater_than: "количество страниц должно быть больше %{min} (текущее количество страниц %{pages})"

data/config/locales/sv.yml

@@ -52,9 +52,11 @@ sv:
       aspect_ratio_not_square: "måste vara kvadratisk (nuvarande fil är %{width}x%{height} pixlar)"
       aspect_ratio_not_portrait: "måste vara porträtt (nuvarande fil är %{width}x%{height} pixlar)"
       aspect_ratio_not_landscape: "måste vara landskap (nuvarande fil är %{width}x%{height} pixlar)"
-      aspect_ratio_not_x_y: "måste vara% { authorized_aspect_ratios } (nuvarande fil är %{width}x%{height} pixlar)"
-      aspect_ratio_invalid: "har ett ogiltigt bildförhållande (giltiga bildförhållanden är %{förväntat_aspect_ratios})"
+      aspect_ratio_not_x_y: "måste vara %{authorized_aspect_ratios} (nuvarande fil är %{width}x%{height} pixlar)"
+      aspect_ratio_invalid: "har ett ogiltigt bildförhållande (giltiga bildförhållanden är %{authorized_aspect_ratios})"
       file_not_processable: "identifieras inte som en giltig mediefil"
+      audio_missing: "måste innehålla ett ljudspår"
+      audio_present: "får inte innehålla ett ljudspår"
       pages_not_less_than: "sidantal måste vara mindre än %{max} (nuvarande sidantal är %{pages})"
       pages_not_less_than_or_equal_to: "sidantal måste vara mindre än eller lika med %{max} (nuvarande antal sidor är %{pages})"
       pages_not_greater_than: "sidantal måste vara större än %{min} (nuvarande sidantal är %{pages})"

data/config/locales/tr.yml

@@ -55,6 +55,8 @@ tr:
       aspect_ratio_not_x_y: "%{authorized_aspect_ratios} olmalıdır (geçerli dosya %{width}x%{height}px)"
       aspect_ratio_invalid: "geçersiz bir en boy oranına sahiptir (geçerli en boy oranları %{authorized_aspect_ratios})"
       file_not_processable: "geçerli bir medya dosyası olarak tanımlanmadı"
+      audio_missing: "bir ses parçası içermelidir"
+      audio_present: "bir ses parçası içermemelidir"
       pages_not_less_than: "sayfa sayısı %{max} değerinden az olmalıdır (geçerli sayfa sayısı %{pages})"
       pages_not_less_than_or_equal_to: "sayfa sayısı %{max} değerinden az veya eşit olmalıdır (geçerli sayfa sayısı %{pages})"
       pages_not_greater_than: "sayfa sayısı %{min} değerinden fazla olmalıdır (geçerli sayfa sayısı %{pages})"

data/config/locales/uk.yml

@@ -55,6 +55,8 @@ uk:
       aspect_ratio_not_x_y: "повинен бути %{authorized_aspect_ratios} (поточний файл становить %{width}x%{height} пікселям)"
       aspect_ratio_invalid: "має недійсне співвідношення сторін (дійсні співвідношення сторін %{authorized_aspect_ratios})"
       file_not_processable: "не ідентифікується як дійсний медіа-файл"
+      audio_missing: "має містити аудіодоріжку"
+      audio_present: "не має містити аудіодоріжку"
       pages_not_less_than: "кількість сторінок має бути менше %{max} (поточна кількість сторінок %{pages})"
       pages_not_less_than_or_equal_to: "кількість сторінок має бути меншою або дорівнювати %{max} (поточна кількість сторінок становить %{pages})"
       pages_not_greater_than: "кількість сторінок має бути більшою за %{min} (поточна кількість сторінок становить %{pages})"

data/config/locales/vi.yml

@@ -55,6 +55,8 @@ vi:
       aspect_ratio_not_x_y: "phải là %{authorized_aspect_ratios} (tệp hiện tại là %{width}x%{height}px)"
       aspect_ratio_invalid: "có tỷ lệ khung hình không hợp lệ (tỷ lệ khung hình hợp lệ là %{authorized_aspect_ratios})"
       file_not_processable: "không được xác định là tệp phương tiện hợp lệ"
+      audio_missing: "phải có một bản âm thanh"
+      audio_present: "không được chứa bản âm thanh"
       pages_not_less_than: "số trang phải nhỏ hơn %{max} (số trang hiện tại là %{pages})"
       pages_not_less_than_or_equal_to: "số trang phải nhỏ hơn hoặc bằng %{max} (số trang hiện tại là %{pages})"
       pages_not_greater_than: "số trang phải lớn hơn %{min} (số trang hiện tại là %{pages})"

data/config/locales/zh-CN.yml

@@ -55,6 +55,8 @@ zh-CN:
       aspect_ratio_not_x_y: "必须为 %{authorized_aspect_ratios}（当前文件为 %{width} x%{height} 像素)"
       aspect_ratio_invalid: "具有无效的长宽比（有效长宽比为 %{authorized_aspect_ratios})"
       file_not_processable: "未标识为有效的媒体文件"
+      audio_missing: "必须包含音轨"
+      audio_present: "不得包含音轨"
       pages_not_less_than: "页数必须小于 %{max}（当前页数为 %{pages})"
       pages_not_less_than_or_equal_to: "页数必须小于或等于 %{max}（当前页数为 %{pages})"
       pages_not_greater_than: "页数必须大于 %{min}（当前页数为 %{pages})"

data/lib/active_storage_validations/analyzer/audio_analyzer.rb

@@ -10,12 +10,13 @@ module ActiveStorageValidations
   # * Duration (seconds)
   # * Bit rate (bits/s)
   # * Sample rate (hertz)
+  # * Audio (true if file has an audio channel, false if not)
   # * Tags (internal metadata)
   #
   # Example:
   #
   #   ActiveStorageValidations::Analyzer::AudioAnalyzer.new(attachable).metadata
-  #   # => { duration: 5.0, bit_rate: 320340, sample_rate: 44100, tags: { encoder: "Lavc57.64", ... } }
+  #   # => { duration: 5.0, bit_rate: 320340, sample_rate: 44100, audio: true, tags: { encoder: "Lavc57.64", ... } }
   #
   # This analyzer requires the {FFmpeg}[https://www.ffmpeg.org] system library, which is not provided by \Rails.
   class Analyzer::AudioAnalyzer < Analyzer
@@ -27,6 +28,7 @@ module ActiveStorageValidations
           duration: duration,
           bit_rate: bit_rate,
           sample_rate: sample_rate,
+          audio: audio?,
           tags: tags
         }.compact
       end
@@ -34,6 +36,10 @@ module ActiveStorageValidations
 
     private
 
+    def audio?
+      audio_stream.present?
+    end
+
     def duration
       duration = audio_stream["duration"]
       Float(duration).round(1) if duration

data/lib/active_storage_validations/analyzer/content_type_analyzer/file.rb

@@ -5,8 +5,6 @@ module ActiveStorageValidations
   #
   # Override the binary path with +ActiveStorage.paths[:file]+.
   class Analyzer::ContentTypeAnalyzer::File < Analyzer::ContentTypeAnalyzer
-    class CommandLineToolNotInstalledError < StandardError; end
-
     private
 
     def backend

data/lib/active_storage_validations/analyzer/content_type_analyzer/magika.rb

@@ -7,8 +7,6 @@ module ActiveStorageValidations
   #
   # Override the binary path with +ActiveStorage.paths[:magika]+.
   class Analyzer::ContentTypeAnalyzer::Magika < Analyzer::ContentTypeAnalyzer
-    class CommandLineToolNotInstalledError < StandardError; end
-
     private
 
     def backend

data/lib/active_storage_validations/analyzer/content_type_analyzer.rb

@@ -12,6 +12,9 @@ module ActiveStorageValidations
   #   ActiveStorageValidations::Analyzer::ContentTypeAnalyzer::Magika.new(attachable).content_type
   #   # => { content_type: "image/png", content_type_backend: "magika" }
   class Analyzer::ContentTypeAnalyzer < Analyzer
+    # Shared by File and Magika backends so consumers can rescue either missing CLI.
+    class CommandLineToolNotInstalledError < StandardError; end
+
     def content_type
       read_media do |media|
         {

data/lib/active_storage_validations/analyzer/image_analyzer.rb

@@ -12,7 +12,15 @@ module ActiveStorageValidations
   #   ActiveStorageValidations::Analyzer::ImageAnalyzer::ImageMagick.new(attachable).metadata
   #   # => { width: 4104, height: 2736 }
   class Analyzer::ImageAnalyzer < Analyzer
-    @@supported_analyzers = {}
+    class << self
+      def reset_supported_analyzers_cache!
+        @supported_analyzers = {}
+      end
+
+      def supported_analyzers
+        @supported_analyzers ||= {}
+      end
+    end
 
     def metadata
       return {} unless analyzer_supported?
@@ -28,12 +36,14 @@ module ActiveStorageValidations
 
     private
 
+    # Cache by class, not instance: a new analyzer is built per attachable, so
+    # an instance-keyed hash never hits and retains every attachable for the
+    # process lifetime.
     def analyzer_supported?
-      if @@supported_analyzers.key?(self)
-        @@supported_analyzers.fetch(self)
-      else
-        @@supported_analyzers[self] = supported?
-      end
+      cache = Analyzer::ImageAnalyzer.supported_analyzers
+      return cache[self.class] if cache.key?(self.class)
+
+      cache[self.class] = supported?
     end
 
     # Override this method in a concrete subclass. Have it return true if the image is rotated.

data/lib/active_storage_validations/analyzer/pdf_analyzer.rb

@@ -16,6 +16,11 @@ module ActiveStorageValidations
   #
   # This analyzer requires the {poppler}[https://pdf2image.readthedocs.io/en/latest/installation.html] system library, which is not provided by \Rails.
   class Analyzer::PdfAnalyzer < Analyzer
+    # pdfinfo reports e.g. "595.276 x 841.89 pts (A4)". Capture the full
+    # integer or decimal so extra fractional digits are not split into a
+    # second number (which would make height 8 for A4).
+    PAGE_SIZE_NUMBER = /\d+(?:\.\d+)?/
+
     def metadata
       read_media do |media|
         {
@@ -69,11 +74,15 @@ module ActiveStorageValidations
     end
 
     def width
-      @media["page_size"].scan(/\d+\.?\d?/)[0].to_i
+      page_size_in_points[0]
     end
 
     def height
-      @media["page_size"].scan(/\d+\.?\d?/)[1].to_i
+      page_size_in_points[1]
+    end
+
+    def page_size_in_points
+      @media["page_size"].to_s.scan(PAGE_SIZE_NUMBER).map(&:to_i)
     end
 
     def pages

data/lib/active_storage_validations/analyzer.rb

@@ -40,45 +40,12 @@ module ActiveStorageValidations
       raise NotImplementedError
     end
 
-    # rubocop:disable Metrics/MethodLength
     def media(tempfile)
-      @media ||= case @attachable
-      when ActiveStorage::Blob, String
-        blob = @attachable.is_a?(String) ? ActiveStorage::Blob.find_signed!(@attachable) : @attachable
-        media_from_tempfile_path(tempfile, blob)
-      when Hash
-        io = @attachable[:io]
-        if io.is_a?(StringIO)
-          media_from_tempfile_path(tempfile, io)
-        else
-          File.open(io) do |file|
-            media_from_path(file.path)
-        end
-        end
-      when ActionDispatch::Http::UploadedFile, Rack::Test::UploadedFile
-        media_from_path(@attachable.path)
-      when File
-        supports_file_attachment? ? media_from_path(@attachable.path) : raise_rails_like_error(@attachable)
-      when Pathname
-        supports_pathname_attachment? ? media_from_path(@attachable.to_s) : raise_rails_like_error(@attachable)
-      else
-        raise_rails_like_error(@attachable)
+      @media ||= wrap_attachable(@attachable).with_media_path(tempfile) do |path|
+        media_from_path(path)
       end
     end
 
-    def media_from_tempfile_path(tempfile, file_representation)
-      if file_representation.is_a?(ActiveStorage::Blob)
-        file_representation.download { |chunk| tempfile.write(chunk) }
-      else
-        IO.copy_stream(file_representation, tempfile)
-        file_representation.rewind
-      end
-
-      tempfile.flush
-      tempfile.rewind
-      media_from_path(tempfile.path)
-    end
-
     # Override this method in a concrete subclass. Have it return a media object.
     def media_from_path(path)
       raise NotImplementedError

data/lib/active_storage_validations/aspect_ratio_validator.rb

@@ -18,7 +18,7 @@ module ActiveStorageValidations
 
     AVAILABLE_CHECKS = %i[with in].freeze
     NAMED_ASPECT_RATIOS = %i[square portrait landscape].freeze
-    ASPECT_RATIO_REGEX = /is_([1-9]\d*)_([1-9]\d*)/.freeze
+    ASPECT_RATIO_REGEX = /is_([1-9]\d*)_([1-9]\d*)/
     ERROR_TYPES = %i[
       aspect_ratio_not_square
       aspect_ratio_not_portrait
@@ -27,7 +27,7 @@ module ActiveStorageValidations
       aspect_ratio_invalid
       media_metadata_missing
     ].freeze
-    PRECISION = 3.freeze
+    PRECISION = 3
     METADATA_KEYS = %i[width height].freeze
 
     def check_validity!
@@ -38,22 +38,28 @@ module ActiveStorageValidations
     def validate_each(record, attribute, _value)
       return if no_attachments?(record, attribute)
 
-      flat_options = set_flat_options(record)
-      @authorized_aspect_ratios = authorized_aspect_ratios_from_options(flat_options).compact
-      return if @authorized_aspect_ratios.empty?
+      return if authorized_aspect_ratios(record).empty?
 
       validate_changed_files_from_metadata(record, attribute, METADATA_KEYS)
     end
 
     private
 
+    # Recomputed for every attachable rather than memoized on the validator:
+    # Active Model reuses one validator instance across records and threads, so
+    # per-validation state cannot live in an instance variable.
+    def authorized_aspect_ratios(record)
+      authorized_aspect_ratios_from_options(set_flat_options(record)).compact
+    end
+
     def is_valid?(record, attribute, attachable, metadata)
       media_metadata_present?(record, attribute, attachable, metadata) &&
         authorized_aspect_ratio?(record, attribute, attachable, metadata)
     end
 
     def authorized_aspect_ratio?(record, attribute, attachable, metadata)
-      attachable_aspect_ratio_is_authorized = @authorized_aspect_ratios.any? do |authorized_aspect_ratio|
+      aspect_ratios = authorized_aspect_ratios(record)
+      attachable_aspect_ratio_is_authorized = aspect_ratios.any? do |authorized_aspect_ratio|
         case authorized_aspect_ratio
         when :square then valid_square_aspect_ratio?(metadata)
         when :portrait then valid_portrait_aspect_ratio?(metadata)
@@ -64,18 +70,18 @@ module ActiveStorageValidations
 
       return true if attachable_aspect_ratio_is_authorized
 
-      errors_options = initialize_and_populate_error_options(options, attachable)
+      errors_options = initialize_and_populate_error_options(options, attachable, aspect_ratios)
       errors_options[:width] = metadata[:width]
       errors_options[:height] = metadata[:height]
-      error_type = aspect_ratio_error_mapping
+      error_type = aspect_ratio_error_mapping(aspect_ratios)
       add_error(record, attribute, error_type, **errors_options)
       false
     end
 
-    def aspect_ratio_error_mapping
-      return :aspect_ratio_invalid if @authorized_aspect_ratios.many?
+    def aspect_ratio_error_mapping(aspect_ratios)
+      return :aspect_ratio_invalid if aspect_ratios.many?
 
-      aspect_ratio = @authorized_aspect_ratios.first
+      aspect_ratio = aspect_ratios.first
       NAMED_ASPECT_RATIOS.include?(aspect_ratio) ? :"aspect_ratio_not_#{aspect_ratio}" : :aspect_ratio_not_x_y
     end
 
@@ -86,9 +92,9 @@ module ActiveStorageValidations
       false
     end
 
-    def initialize_and_populate_error_options(options, attachable)
+    def initialize_and_populate_error_options(options, attachable, aspect_ratios)
       errors_options = initialize_error_options(options, attachable)
-      errors_options[:authorized_aspect_ratios] = string_aspect_ratios
+      errors_options[:authorized_aspect_ratios] = string_aspect_ratios(aspect_ratios)
       errors_options
     end
 
@@ -140,8 +146,8 @@ module ActiveStorageValidations
       (Array.wrap(flat_options[:with]) + Array.wrap(flat_options[:in]))
     end
 
-    def string_aspect_ratios
-      @authorized_aspect_ratios.map do |aspect_ratio|
+    def string_aspect_ratios(aspect_ratios)
+      aspect_ratios.map do |aspect_ratio|
         if NAMED_ASPECT_RATIOS.include?(aspect_ratio)
           aspect_ratio
         else