active_storage_validations 2.0.3 → 2.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ba7e03a6367634ed5ece53bda87d82c76b179c75e2c9b37e4055d8f47f9ab98
-  data.tar.gz: 7225e4937cab59e3209d082d9650c1077342eae7dcae46ddee0c25a9a5e93e56
+  metadata.gz: 491e16f93da96fad8b6b28ea04082b86b94720b12ba6fe1dcfc78c7896276ae7
+  data.tar.gz: fbb276c358504d03e6d6c46c02e9553e5e376141d070ee1fd155e5074cb43f8e
 SHA512:
-  metadata.gz: 9464b889ae0f8ab4167bcc612926e44c52d3541de6092fa0c82baf57a2f9edb4f541780145443966fa168c8f3f819456b000fac4a8770c1e923219a7394918da
-  data.tar.gz: 4dea3b65668a16cac757d85f4e8d8f31e98c5089bbcf5747a5f192083fb12e2b57d611091eb2e2fb468aff27c590cdad1232566f24b75415784c7fe28434013f
+  metadata.gz: 8f29a4388357d60f8d834833bb687450fa890f42462d48dc8c664a01c088f72edf3bad8eb5e6ec497119049fde1f0dfb2cdddcd8a98b0ad24a327a4a9122cb0e
+  data.tar.gz: 7ae4c7f58abb91ffec5f2bbfb6e02180667e8f47c5982137be1a2330d366c51f90eaa0a32b634a76e29b8e27d9821c07b2d4ef140fc6f40481f876d8b380f77f

data/README.md

@@ -7,6 +7,7 @@
 [![RailsJazz](https://github.com/igorkasyanchuk/rails_time_travel/blob/main/docs/my_other.svg?raw=true)](https://www.railsjazz.com)
 [![https://www.patreon.com/igorkasyanchuk](https://github.com/igorkasyanchuk/rails_time_travel/blob/main/docs/patron.svg?raw=true)](https://www.patreon.com/igorkasyanchuk)
 
+[!["Buy Me A Coffee"](https://github.com/igorkasyanchuk/get-smart/blob/main/docs/snapshot-bmc-button-small.png?raw=true)](https://buymeacoffee.com/igorkasyanchuk)
 
 Active Storage Validations is a gem that allows you to add validations for Active Storage attributes.
 
@@ -801,6 +802,7 @@ To run the gem tests, launch the following commands in the root folder of gem re
 * `BUNDLE_GEMFILE=gemfiles/rails_7_1.gemfile bundle exec rake test` to run for Rails 7.1
 * `BUNDLE_GEMFILE=gemfiles/rails_7_2.gemfile bundle exec rake test` to run for Rails 7.2
 * `BUNDLE_GEMFILE=gemfiles/rails_8_0.gemfile bundle exec rake test` to run for Rails 8.0
+* `BUNDLE_GEMFILE=gemfiles/rails_next.gemfile bundle exec rake test` to run for Rails main
 
 Snippet to run in console:
 
@@ -810,11 +812,13 @@ BUNDLE_GEMFILE=gemfiles/rails_7_0.gemfile bundle
 BUNDLE_GEMFILE=gemfiles/rails_7_1.gemfile bundle
 BUNDLE_GEMFILE=gemfiles/rails_7_2.gemfile bundle
 BUNDLE_GEMFILE=gemfiles/rails_8_0.gemfile bundle
+BUNDLE_GEMFILE=gemfiles/rails_next.gemfile bundle
 BUNDLE_GEMFILE=gemfiles/rails_6_1_4.gemfile bundle exec rake test
 BUNDLE_GEMFILE=gemfiles/rails_7_0.gemfile bundle exec rake test
 BUNDLE_GEMFILE=gemfiles/rails_7_1.gemfile bundle exec rake test
 BUNDLE_GEMFILE=gemfiles/rails_7_2.gemfile bundle exec rake test
 BUNDLE_GEMFILE=gemfiles/rails_8_0.gemfile bundle exec rake test
+BUNDLE_GEMFILE=gemfiles/rails_next.gemfile bundle exec rake test
 ```
 
 Tips:
@@ -838,3 +842,5 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 [<img src="https://github.com/igorkasyanchuk/rails_time_travel/blob/main/docs/more_gems.png?raw=true"
 />](https://www.railsjazz.com/?utm_source=github&utm_medium=bottom&utm_campaign=active_storage_validations)
+
+[!["Buy Me A Coffee"](https://github.com/igorkasyanchuk/get-smart/blob/main/docs/snapshot-bmc-button.png?raw=true)](https://buymeacoffee.com/igorkasyanchuk)

data/lib/active_storage_validations/railtie.rb

@@ -2,15 +2,18 @@
 
 module ActiveStorageValidations
   class Railtie < ::Rails::Railtie
-    initializer "active_storage_validations.configure", after: :load_config_initializers do
+    # Using after: :load_config_initializers would cause a stack level too deep error
+    # See: https://github.com/igorkasyanchuk/active_storage_validations/issues/364
+
+    initializer "active_storage_validations.configure" do
       ActiveSupport.on_load(:active_record) do
-        send :include, ActiveStorageValidations
+        include ActiveStorageValidations
       end
     end
 
     initializer "active_storage_validations.extend_active_storage_blob" do
       ActiveSupport.on_load(:active_storage_blob) do
-        include(ActiveStorageValidations::ASVBlobMetadatable)
+        include ActiveStorageValidations::ASVBlobMetadatable
       end
     end
   end

data/lib/active_storage_validations/shared/asv_errorable.rb

@@ -20,9 +20,18 @@ module ActiveStorageValidations
     def add_error(record, attribute, error_type, **errors_options)
       return if record.errors.added?(attribute, error_type)
 
+      error = record.errors.add(attribute, error_type, **errors_options)
+
+      # Rails 8.0.2 introduced a new way to mark errors as nested
+      # https://github.com/igorkasyanchuk/active_storage_validations/issues/377
+      if Rails.gem_version >= Gem::Version.new("8.0.2")
+        # Mark errors as nested when they occur in a parent/child context
+        set_nested_error(record, error) if updating_through_parent?(record)
+      end
+
       # You can read https://api.rubyonrails.org/classes/ActiveModel/Errors.html#method-i-add
       # to better understand how Rails model errors work
-      record.errors.add(attribute, error_type, **errors_options)
+      error
     end
 
     private
@@ -36,5 +45,20 @@ module ActiveStorageValidations
       when Hash then file[:filename]
       end.to_s
     end
+
+    def updating_through_parent?(record)
+      record.instance_variable_defined?(:@marked_for_destruction) ||
+        record.instance_variable_defined?(:@_destroy) ||
+        (record.respond_to?(:parent) && record.parent.present?)
+    end
+
+    def set_nested_error(record, error)
+      reflection = record.class.reflect_on_association(:parent)
+
+      if reflection
+        association = record.association(reflection.name)
+        record.errors.objects.append(ActiveRecord::Associations::NestedError.new(association, error))
+      end
+    end
   end
 end

data/lib/active_storage_validations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveStorageValidations
-  VERSION = "2.0.3"
+  VERSION = "2.0.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_storage_validations
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.0.4
 platform: ruby
 authors:
 - Igor Kasyanchuk
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-04-19 00:00:00.000000000 Z
+date: 2025-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob