active_storage_base64 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 36dfcca56fbad7ca9bb0d860b2d192d1ac6fd78b49e82e3056e271de47e52103
-  data.tar.gz: b9919fc691756b718216656cd8bf58e6a8a4b2c02f27946ba828caa854233161
+  metadata.gz: 3f06ab3b77fc8bc3dd993d1313ad0136d2ab2bdf6a776a0dc7414c5af9fd75c3
+  data.tar.gz: 5f00568a8b09f02018bb6049203d4a02ffaca06ba7769ac04b8c001e0061fa2b
 SHA512:
-  metadata.gz: fbf1cf11a8b1decc8a12c5af113a75fc5ad17b9c8fd2b2190e4252f160bcdc6dc0790ed178b4b6d5230ba18730aef279c1e7e22239feb183c090f71b48b11287
-  data.tar.gz: ce40b3239c679243468cfcd93e45ae1d8b825a123bda0dcc5989a2ec3693fc286971f02feabbaf42cfe3ae1058d00caf4182686e02b9a71bfcb650df2e8fc1af
+  metadata.gz: 74e9c1008d1f9dad166133f44014ae715d779eca9d03d1177d4923de2d54db4389840756fac7aadcd09f87beb0eae8b0603f39f520660dc380313557f245107f
+  data.tar.gz: cdc6293595a7187c91b2543bc67893ba05b605506072686002e123f02ad47d671876399d16acfa26fe1bcea7dfd17c8723db895dac9f23198de5f8d20ea1dead

data/.gitignore

@@ -1,3 +1,4 @@
 Gemfile.lock
 spec/dummy/log
 spec/dummy/db/**.sqlite3
+/coverage/

data/.travis.yml

@@ -12,6 +12,18 @@ rvm:
 
 sudo: false
 
+env:
+  global:
+    - CC_TEST_REPORTER_ID=7196b4aa257fde33f24463218af32db6a6efd23d9148204822f757fa614a093e
+
+before_script:
+  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+  - chmod +x ./cc-test-reporter
+  - ./cc-test-reporter before-build
+
 script:
   - bundle exec rake code_analysis
   - bundle exec rspec
+
+after_script:
+  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT

data/README.md

@@ -1,5 +1,6 @@
 [![Build Status](https://travis-ci.org/rootstrap/active-storage-base64.svg?branch=master)](https://travis-ci.org/rootstrap/active-storage-base64)
 [![Maintainability](https://api.codeclimate.com/v1/badges/0da0a0901cedd72aeb10/maintainability)](https://codeclimate.com/github/rootstrap/active-storage-base64/maintainability)
+[![Test Coverage](https://api.codeclimate.com/v1/badges/0da0a0901cedd72aeb10/test_coverage)](https://codeclimate.com/github/rootstrap/active-storage-base64/test_coverage)
 
 # ActiveStorageBase64
 
@@ -67,22 +68,7 @@ on your controller you could do something like this:
 class UsersController < ApplicationController
   def create
     user = User.create(user_params)
-  end
-
-  private
-
-  def user_params
-    params.require(:user).permit(:avatar[data:], :username, :email)
-  end
-end
-```
-
-Or you could also do:
-```ruby
-class UsersController < ApplicationController
-  def create
-    user = User.create(user_params)
-    user.avatar.attach(params[:avatar])
+    user.avatar.attach(data: params[:avatar])
   end
 
   private
@@ -98,7 +84,7 @@ Here's another option to achieve the same:
 class UsersController < ApplicationController
   def create
     user = User.create(user_params)
-    user.avatar = params[:avatar]
+    user.avatar = { data: params[:avatar] }
   end
 
   private
@@ -127,23 +113,6 @@ class UsersController < ApplicationController
   end
 end
 ```
-Or, in case you want to have the avatar attached as soon as the user is created you can do:
-```ruby
-class UsersController < ApplicationController
-  def create
-    user = User.create(user_params)
-  end
-
-  private
-
-  def user_params
-    params.require(:user).permit(:username, :email, avatar:[:data,
-                                                            :filename,
-                                                            :content_type,
-                                                            :identify])
-  end
-end
-```
 
 For more information on how to work with ActiveStorage, please check the [Active Storage Overview](https://edgeguides.rubyonrails.org/active_storage_overview.html) mentioned above, all points in there apply to this gem as well.
 

data/active_storage_base64.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = 'active_storage_base64'
-  s.version = '0.1.1'
+  s.version = '0.1.2'
   s.summary = 'Base64 support for ActiveStorage'
   s.description = s.summary
 
@@ -25,4 +25,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rspec-rails', '~> 3.8.0'
   s.add_development_dependency 'sqlite3', '1.3.13'
   s.add_development_dependency 'pry-rails', '~> 0.3.6'
+  s.add_development_dependency 'simplecov'
 end

data/config.reek

@@ -9,10 +9,10 @@ ClassVariable:
   exclude: []
 ControlParameter:
   enabled: true
-  exclude: []
+  exclude: ['ActiveStorageSupport::SupportForBase64#add_helper_method']
 DataClump:
   enabled: true
-  exclude: []
+  exclude: ['ActiveStorageSupport::SupportForBase64']
   max_copies: 2
   min_clump_size: 2
 DuplicateMethodCall:

data/lib/active_storage_support/base64_attach.rb

@@ -4,17 +4,17 @@ module ActiveStorageSupport
     module_function
 
     def attachment_from_data(attachment)
-      if attachment.is_a?(Hash)
-        base64_data = attachment.delete(:data)
-        if base64_data.try(:is_a?, String) && base64_data =~ /^data:(.*?);(.*?),(.*)$/
-
-          attachment[:io] = StringIO.new(Base64.decode64(Regexp.last_match(3)))
-          attachment[:content_type] = Regexp.last_match(1) unless attachment[:content_type]
-          attachment[:filename] = Time.current.to_i.to_s unless attachment[:filename]
-        end
-      end
+      fill_attachment_data(attachment, attachment.delete(:data)) if attachment.is_a?(Hash)
 
       attachment
     end
+
+    def fill_attachment_data(attachment, base64_data)
+      return unless base64_data.try(:is_a?, String) && base64_data =~ /^data:(.*?);(.*?),(.*)$/
+
+      attachment[:io] = StringIO.new(Base64.decode64(Regexp.last_match(3)))
+      attachment[:content_type] ||= Regexp.last_match(1)
+      attachment[:filename]     ||= Time.current.to_i.to_s
+    end
   end
 end

data/lib/active_storage_support/support_for_base64.rb

@@ -8,29 +8,24 @@ module ActiveStorageSupport
       def has_one_base64_attached(name, dependent: :purge_later)
         has_one_attached name, dependent: dependent
 
-        class_eval <<-CODE, __FILE__, __LINE__ + 1
-          def #{name}
-            @active_storage_attached_#{name} ||=
-              ActiveStorageSupport::Base64One.new("#{name}", self, dependent: #{dependent == :purge_later ? ':purge_later' : 'false'})
-          end
-
-          def #{name}=(data)
-            #{name}.attach(data)
-          end
-        CODE
+        add_helper_method(ActiveStorageSupport::Base64One, name, dependent: dependent)
       end
 
       def has_many_base64_attached(name, dependent: :purge_later)
         has_many_attached name, dependent: dependent
 
+        add_helper_method(ActiveStorageSupport::Base64Many, name, dependent: dependent)
+      end
+
+      def add_helper_method(type, name, dependent:)
         class_eval <<-CODE, __FILE__, __LINE__ + 1
           def #{name}
             @active_storage_attached_#{name} ||=
-              ActiveStorageSupport::Base64Many.new("#{name}", self, dependent: #{dependent == :purge_later ? ':purge_later' : 'false'})
+              #{type}.new("#{name}", self, dependent: #{dependent == :purge_later ? ':purge_later' : 'false'})
           end
 
-          def #{name}=(attachables)
-            #{name}.attach(attachables)
+          def #{name}=(data)
+            #{name}.attach(data)
           end
         CODE
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_storage_base64
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Ricardo Cortio
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-03 00:00:00.000000000 Z
+date: 2019-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -100,6 +100,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.3.6
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Base64 support for ActiveStorage
 email: ricardo@rootstrap.com
 executables: []